mirror of
https://github.com/docker/compose.git
synced 2026-10-12 02:13:08 +00:00
Guillaume Lours
bbec45855a
On top of the output-tail infrastructure from the previous commit: Stderr bias: split the combined output tail into separate stdout and stderr buffers. stdcopy.StdCopy(wOut, wErr, reader) now routes each stream to its own outputTail. The error message prefers stderr (where hooks write their actual error) and falls back to stdout when stderr is empty: db hook exited with status 1: Table 'service.sites' doesn't exist A new hookExitError helper encapsulates this preference. pre_start parity: streamPreStartLogs previously short-circuited and returned immediately when listener was nil (detached mode / compose up -d), leaving the tail buffers empty and failure errors without context. The log stream is now always opened. The demultiplexed streams fill separate tailOut / tailErr buffers. On non-zero exit the stderr-biased tail is appended to the error (same behaviour as exec hooks). Tests: - TestRunHook_StderrBias: stdout noise stays out of the error when stderr has content. - TestPreStart_DetachedModeAttachesLogs: ContainerLogs is called even with a nil listener. - TestPreStart_FailureIncludesTail: a failing pre_start hook carries its stderr output in the returned error. Signed-off-by: Guillaume Lours <[email protected]>