From 37e532322b6d7b68a64291e713271703ef57ce8e Mon Sep 17 00:00:00 2001 From: Scott Mansell Date: Thu, 27 May 2021 12:32:02 +1200 Subject: [PATCH] Port dump XFB option to Qt UI. Looks like the option was added to the Wx UI at commit 198d3b69, which was a few months after the advancedWidget was originally ported from Wx to Qt, but before anyone was actually using Qt. --- Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp | 7 +++++++ Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.h | 1 + 2 files changed, 8 insertions(+) diff --git a/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp b/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp index 16ebd14dc9..c4798943e2 100644 --- a/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp +++ b/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.cpp @@ -70,6 +70,7 @@ void AdvancedWidget::CreateWidgets() m_prefetch_custom_textures = new GraphicsBool(tr("Prefetch Custom Textures"), Config::GFX_CACHE_HIRES_TEXTURES); m_dump_efb_target = new GraphicsBool(tr("Dump EFB Target"), Config::GFX_DUMP_EFB_TARGET); + m_dump_xfb_target = new GraphicsBool(tr("Dump XFB Target"), Config::GFX_DUMP_XFB_TARGET); m_disable_vram_copies = new GraphicsBool(tr("Disable EFB VRAM Copies"), Config::GFX_HACK_DISABLE_COPY_TO_VRAM); @@ -79,6 +80,7 @@ void AdvancedWidget::CreateWidgets() utility_layout->addWidget(m_disable_vram_copies, 1, 0); utility_layout->addWidget(m_dump_efb_target, 1, 1); + utility_layout->addWidget(m_dump_xfb_target, 2, 1); // Texture dumping auto* texture_dump_box = new QGroupBox(tr("Texture Dumping")); @@ -233,6 +235,10 @@ void AdvancedWidget::AddDescriptions() QT_TR_NOOP("Dumps the contents of EFB copies to User/Dump/Textures/.

If unsure, leave this " "unchecked."); + static const char TR_DUMP_XFB_DESCRIPTION[] = + QT_TR_NOOP("Dumps the contents of XFB copies to User/Dump/Textures/.

If unsure, leave this " + "unchecked."); static const char TR_DISABLE_VRAM_COPIES_DESCRIPTION[] = QT_TR_NOOP("Disables the VRAM copy of the EFB, forcing a round-trip to RAM. Inhibits all " "upscaling.

If unsure, leave this " @@ -288,6 +294,7 @@ void AdvancedWidget::AddDescriptions() m_load_custom_textures->SetDescription(tr(TR_LOAD_CUSTOM_TEXTURE_DESCRIPTION)); m_prefetch_custom_textures->SetDescription(tr(TR_CACHE_CUSTOM_TEXTURE_DESCRIPTION)); m_dump_efb_target->SetDescription(tr(TR_DUMP_EFB_DESCRIPTION)); + m_dump_xfb_target->SetDescription(tr(TR_DUMP_XFB_DESCRIPTION)); m_disable_vram_copies->SetDescription(tr(TR_DISABLE_VRAM_COPIES_DESCRIPTION)); m_use_fullres_framedumps->SetDescription(tr(TR_INTERNAL_RESOLUTION_FRAME_DUMPING_DESCRIPTION)); #ifdef HAVE_FFMPEG diff --git a/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.h b/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.h index 180df811b0..8b8cdc5dc6 100644 --- a/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.h +++ b/Source/Core/DolphinQt/Config/Graphics/AdvancedWidget.h @@ -40,6 +40,7 @@ private: // Utility GraphicsBool* m_prefetch_custom_textures; GraphicsBool* m_dump_efb_target; + GraphicsBool* m_dump_xfb_target; GraphicsBool* m_disable_vram_copies; GraphicsBool* m_load_custom_textures;