From aa42534fed6435ef3d0c2b5d5ac3b7cccc844d9b Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 27 Mar 2018 21:55:16 -0400 Subject: [PATCH] FilesystemWidget: Pass path QString by const reference instead of by value in ExtractDirectory() Makes it consistent with the surrounding API. Also corrects a typo in ExtractFile's parameter list. --- Source/Core/DolphinQt2/Config/FilesystemWidget.cpp | 2 +- Source/Core/DolphinQt2/Config/FilesystemWidget.h | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Source/Core/DolphinQt2/Config/FilesystemWidget.cpp b/Source/Core/DolphinQt2/Config/FilesystemWidget.cpp index 73ff255fb3..950833eb72 100644 --- a/Source/Core/DolphinQt2/Config/FilesystemWidget.cpp +++ b/Source/Core/DolphinQt2/Config/FilesystemWidget.cpp @@ -238,7 +238,7 @@ void FilesystemWidget::ExtractSystemData(const DiscIO::Partition& partition, con QMessageBox::critical(nullptr, tr("Error"), tr("Failed to extract system data.")); } -void FilesystemWidget::ExtractDirectory(const DiscIO::Partition& partition, const QString path, +void FilesystemWidget::ExtractDirectory(const DiscIO::Partition& partition, const QString& path, const QString& out) { const DiscIO::FileSystem* filesystem = m_volume->GetFileSystem(partition); diff --git a/Source/Core/DolphinQt2/Config/FilesystemWidget.h b/Source/Core/DolphinQt2/Config/FilesystemWidget.h index 820168c8b5..b06892f811 100644 --- a/Source/Core/DolphinQt2/Config/FilesystemWidget.h +++ b/Source/Core/DolphinQt2/Config/FilesystemWidget.h @@ -36,8 +36,9 @@ private: void ShowContextMenu(const QPoint&); void ExtractPartition(const DiscIO::Partition& partition, const QString& out); - void ExtractDirectory(const DiscIO::Partition& partition, const QString path, const QString& out); - void ExtractFile(const DiscIO::Partition& pratition, const QString& path, const QString& out); + void ExtractDirectory(const DiscIO::Partition& partition, const QString& path, + const QString& out); + void ExtractFile(const DiscIO::Partition& partition, const QString& path, const QString& out); void ExtractSystemData(const DiscIO::Partition& partition, const QString& out); void CheckIntegrity(const DiscIO::Partition& partition);