From d4b293e969341b630340f3d3c35e1c0d3edf4152 Mon Sep 17 00:00:00 2001
From: Norbert Lange <nolange79@gmail.com>
Date: Mon, 22 Feb 2021 14:32:53 +0100
Subject: [PATCH] Simplify macro guards for HAVE_XRANDR

---
 CMakeLists.txt                           |  2 --
 Source/Core/DolphinNoGUI/PlatformX11.cpp | 10 +++++-----
 Source/Core/DolphinQt/MainWindow.cpp     |  4 ++--
 Source/Core/DolphinQt/MainWindow.h       |  2 +-
 Source/Core/UICommon/VideoUtils.cpp      |  2 +-
 Source/Core/UICommon/X11Utils.cpp        |  2 +-
 Source/Core/UICommon/X11Utils.h          |  4 ++--
 7 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 37c2ba2197..9197156e8f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -440,8 +440,6 @@ if(ENABLE_X11)
     check_lib(XRANDR xrandr Xrandr)
     if(XRANDR_FOUND)
       add_definitions(-DHAVE_XRANDR=1)
-    else()
-      add_definitions(-DHAVE_XRANDR=0)
     endif()
     pkg_check_modules(X11_INPUT REQUIRED xi>=1.5.0)
     message(STATUS "X11 support enabled")
diff --git a/Source/Core/DolphinNoGUI/PlatformX11.cpp b/Source/Core/DolphinNoGUI/PlatformX11.cpp
index c57e60bd9a..b44620a048 100644
--- a/Source/Core/DolphinNoGUI/PlatformX11.cpp
+++ b/Source/Core/DolphinNoGUI/PlatformX11.cpp
@@ -48,7 +48,7 @@ private:
   Display* m_display = nullptr;
   Window m_window = {};
   Cursor m_blank_cursor = None;
-#if defined(HAVE_XRANDR) && HAVE_XRANDR
+#ifdef HAVE_XRANDR
   X11Utils::XRRConfiguration* m_xrr_config = nullptr;
 #endif
   int m_window_x = Config::Get(Config::MAIN_RENDER_WINDOW_XPOS);
@@ -59,7 +59,7 @@ private:
 
 PlatformX11::~PlatformX11()
 {
-#if defined(HAVE_XRANDR) && HAVE_XRANDR
+#ifdef HAVE_XRANDR
   delete m_xrr_config;
 #endif
 
@@ -106,7 +106,7 @@ bool PlatformX11::Init()
   if (Config::Get(Config::MAIN_DISABLE_SCREENSAVER))
     X11Utils::InhibitScreensaver(m_window, true);
 
-#if defined(HAVE_XRANDR) && HAVE_XRANDR
+#ifdef HAVE_XRANDR
   m_xrr_config = new X11Utils::XRRConfiguration(m_display, m_window);
 #endif
 
@@ -126,7 +126,7 @@ bool PlatformX11::Init()
   if (Config::Get(Config::MAIN_FULLSCREEN))
   {
     m_window_fullscreen = X11Utils::ToggleFullscreen(m_display, m_window);
-#if defined(HAVE_XRANDR) && HAVE_XRANDR
+#ifdef HAVE_XRANDR
     m_xrr_config->ToggleDisplayMode(True);
 #endif
     ProcessEvents();
@@ -210,7 +210,7 @@ void PlatformX11::ProcessEvents()
       {
         m_window_fullscreen = !m_window_fullscreen;
         X11Utils::ToggleFullscreen(m_display, m_window);
-#if defined(HAVE_XRANDR) && HAVE_XRANDR
+#ifdef HAVE_XRANDR
         m_xrr_config->ToggleDisplayMode(m_window_fullscreen);
 #endif
         UpdateWindowPosition();
diff --git a/Source/Core/DolphinQt/MainWindow.cpp b/Source/Core/DolphinQt/MainWindow.cpp
index 5e9b9b09cb..c0235835e4 100644
--- a/Source/Core/DolphinQt/MainWindow.cpp
+++ b/Source/Core/DolphinQt/MainWindow.cpp
@@ -119,7 +119,7 @@
 #include "VideoCommon/NetPlayChatUI.h"
 #include "VideoCommon/VideoConfig.h"
 
-#if defined(HAVE_XRANDR) && HAVE_XRANDR
+#ifdef HAVE_XRANDR
 #include "UICommon/X11Utils.h"
 // This #define within X11/X.h conflicts with our WiimoteSource enum.
 #undef None
@@ -1172,7 +1172,7 @@ void MainWindow::ShowGraphicsWindow()
 {
   if (!m_graphics_window)
   {
-#if defined(HAVE_XRANDR) && HAVE_XRANDR
+#ifdef HAVE_XRANDR
     if (GetWindowSystemType() == WindowSystemType::X11)
     {
       m_xrr_config = std::make_unique<X11Utils::XRRConfiguration>(
diff --git a/Source/Core/DolphinQt/MainWindow.h b/Source/Core/DolphinQt/MainWindow.h
index bd9da7651c..60653412bb 100644
--- a/Source/Core/DolphinQt/MainWindow.h
+++ b/Source/Core/DolphinQt/MainWindow.h
@@ -191,7 +191,7 @@ private:
   void dropEvent(QDropEvent* event) override;
   QSize sizeHint() const override;
 
-#if defined(HAVE_XRANDR) && HAVE_XRANDR
+#ifdef HAVE_XRANDR
   std::unique_ptr<X11Utils::XRRConfiguration> m_xrr_config;
 #endif
 
diff --git a/Source/Core/UICommon/VideoUtils.cpp b/Source/Core/UICommon/VideoUtils.cpp
index 73c88a743a..b6cdde49bf 100644
--- a/Source/Core/UICommon/VideoUtils.cpp
+++ b/Source/Core/UICommon/VideoUtils.cpp
@@ -11,7 +11,7 @@
 #include <Windows.h>
 #endif
 
-#if defined(HAVE_XRANDR) && HAVE_XRANDR
+#ifdef HAVE_XRANDR
 #include "UICommon/X11Utils.h"
 #endif
 
diff --git a/Source/Core/UICommon/X11Utils.cpp b/Source/Core/UICommon/X11Utils.cpp
index 24317d8a04..239482f01f 100644
--- a/Source/Core/UICommon/X11Utils.cpp
+++ b/Source/Core/UICommon/X11Utils.cpp
@@ -64,7 +64,7 @@ void InhibitScreensaver(Window win, bool suspend)
   }
 }
 
-#if defined(HAVE_XRANDR) && HAVE_XRANDR
+#ifdef HAVE_XRANDR
 XRRConfiguration::XRRConfiguration(Display* _dpy, Window _win)
     : dpy(_dpy), win(_win), screenResources(nullptr), outputInfo(nullptr), crtcInfo(nullptr),
       fullMode(0), fs_fb_width(0), fs_fb_height(0), fs_fb_width_mm(0), fs_fb_height_mm(0),
diff --git a/Source/Core/UICommon/X11Utils.h b/Source/Core/UICommon/X11Utils.h
index 33b2fa2d0e..6d69d8bdd0 100644
--- a/Source/Core/UICommon/X11Utils.h
+++ b/Source/Core/UICommon/X11Utils.h
@@ -7,7 +7,7 @@
 #include <string>
 #include <vector>
 
-#if defined(HAVE_XRANDR) && HAVE_XRANDR
+#ifdef HAVE_XRANDR
 #include <X11/extensions/Xrandr.h>
 #endif
 #include <X11/Xlib.h>
@@ -26,7 +26,7 @@ Display* XDisplayFromHandle(void* Handle);
 
 void InhibitScreensaver(Window win, bool suspend);
 
-#if defined(HAVE_XRANDR) && HAVE_XRANDR
+#ifdef HAVE_XRANDR
 class XRRConfiguration
 {
 public: