dolphin-emu/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-10-06 23:33:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

JitArm64: Fix FPRF handling of denormal singles

Browse Source 
The interpreter was wrong after all. Hardware verified.
This commit is contained in:
JosJuice 2021-06-13 14:22:59 +02:00
parent aff39af5fb
commit def5666419
1 changed files with 2 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Source/Core/Core/PowerPC/JitArm64/JitAsm.cpp
View File

@ -455,25 +455,12 @@ void JitArm64::GenerateFPRF(bool single)
FixupBranch nan_or_inf = B(CCFlags::CC_EQ); FixupBranch nan_or_inf = B(CCFlags::CC_EQ);
// exp != 0 && exp != EXP_MASK // exp != 0 && exp != EXP_MASK
const u8* normal = GetCodePtr();
emit_write_fprf_and_ret(); emit_write_fprf_and_ret();
// exp == 0 // exp == 0
SetJumpTarget(zero_or_denormal); SetJumpTarget(zero_or_denormal);
TSTI2R(input_reg, INPUT_FRAC_MASK); TSTI2R(input_reg, INPUT_FRAC_MASK);
FixupBranch denormal; FixupBranch denormal = B(CCFlags::CC_NEQ);
if (single)
{
// To match the interpreter, what we output should be based on how the input would be classified
// after conversion to double. Converting a denormal single to a double always results in a
// normal double, so for denormal singles we need to output PPC_FPCLASS_PN/PPC_FPCLASS_NN.
// TODO: Hardware test that the interpreter actually is correct.
B(CCFlags::CC_NEQ, normal);
}
else
{
denormal = B(CCFlags::CC_NEQ);
}
// exp == 0 && frac == 0 // exp == 0 && frac == 0
LSR(ARM64Reg::W1, fprf_reg, 3); LSR(ARM64Reg::W1, fprf_reg, 3);
@ -483,8 +470,7 @@ void JitArm64::GenerateFPRF(bool single)
emit_write_fprf_and_ret(); emit_write_fprf_and_ret();
// exp == 0 && frac != 0 // exp == 0 && frac != 0
if (!single) SetJumpTarget(denormal);
SetJumpTarget(denormal);
ORRI2R(fprf_reg, fprf_reg, Common::PPC_FPCLASS_PD & ~OUTPUT_SIGN_MASK); ORRI2R(fprf_reg, fprf_reg, Common::PPC_FPCLASS_PD & ~OUTPUT_SIGN_MASK);
B(write_fprf_and_ret); B(write_fprf_and_ret);