dolphin-emu/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-10-08 00:03:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Qt/GameListModel: Use absolutePath for file path column

Browse Source 
canonicalPath is orders of magnitude slower as it has to perform actual
disk I/O to resolve symlinks, which makes sorting by this column
ridiculously slow for large game lists, especially if the games are on
a NAS. We probably don't need that, simply resolving relative paths
should be sufficient.
This commit is contained in:
Techjar 2020-06-06 05:22:55 -04:00
parent 4fc8674a7a
commit fa208c4acd
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/DolphinQt/GameList/GameListModel.cpp
View File

@ -146,7 +146,7 @@ QVariant GameListModel::data(const QModelIndex& index, int role) const
if (role == Qt::DisplayRole || role == Qt::InitialSortOrderRole)
{
QString file_path = QDir::toNativeSeparators(
QFileInfo(QString::fromStdString(game.GetFilePath())).canonicalPath());
QFileInfo(QString::fromStdString(game.GetFilePath())).absolutePath());
if (!file_path.endsWith(QDir::separator()))
file_path.append(QDir::separator());
return file_path;