(null);
+ const close = useCallback(() => {
+ if (menu.current?.contains(document.activeElement)) anchor.current?.focus({ preventScroll: true });
+ onClose();
+ }, [anchor, onClose]);
+ useDismiss(true, anchor, close, menu);
+ const place = useCallback(() => {
+ if (!anchor.current || !menu.current) return;
+ const rect = anchor.current.getBoundingClientRect(), box = menu.current.getBoundingClientRect();
+ pinToViewport(menu.current, rect.right - box.width, beside(rect, box.height, innerHeight, "below", 6));
+ }, [anchor]);
+ useFollow(true, place);
+ return createPortal( {
+ if (event.key === "Tab") { close(); return; }
+ if (!["ArrowDown", "ArrowUp", "Home", "End"].includes(event.key)) return;
+ event.preventDefault();
+ const items = [...event.currentTarget.querySelectorAll('[role="menuitem"]')];
+ const at = items.indexOf(document.activeElement as HTMLButtonElement);
+ const next = event.key === "Home" ? 0 : event.key === "End" ? items.length - 1
+ : (at + (event.key === "ArrowDown" ? 1 : -1) + items.length) % items.length;
+ items[next]?.focus();
+ }}>
+ {actions.map((action, index) => )}
+
, document.body);
+}
diff --git a/desktop/frontend-next/src/ui/document/DocumentPreview.tsx b/desktop/frontend-next/src/ui/document/DocumentPreview.tsx
new file mode 100644
index 0000000000..f58a7249a8
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/DocumentPreview.tsx
@@ -0,0 +1,67 @@
+import { lazy, Suspense, useEffect, useState } from "react";
+import type { AgentPort } from "../../port/port";
+import { t } from "../../i18n";
+import { useDocument } from "./useDocument";
+import { Boundary } from "../Boundary";
+import "./document.css";
+import type { DocumentViewState } from "./viewState";
+
+const PdfPreview = lazy(() => import("./PdfPreview"));
+const DelimitedPreview = lazy(() => import("./DelimitedPreview"));
+const StaticHtmlPreview = lazy(() => import("./StaticHtmlPreview"));
+
+function Picture({ data, path, view }: { data: ArrayBuffer; path: string; view: DocumentViewState }) {
+ const [url, setURL] = useState("");
+ const [zoom, updateZoom] = useState(view.zoom ?? 1);
+ const setZoom = (value: number) => { view.zoom = value; updateZoom(value); };
+ const [failed, setFailed] = useState(false);
+ useEffect(() => {
+ const type = /\.svg$/i.test(path) ? "image/svg+xml" : undefined;
+ const url = URL.createObjectURL(new Blob([data], { type }));
+ setURL(url); setFailed(false);
+ return () => URL.revokeObjectURL(url);
+ }, [data, path]);
+ return <>
+
+
+
+
+
+ {failed ? {t("图片不可用")}
:
+ {url &&
setFailed(true)} />}
+
{t("此文件暂不支持预览")}
;
+ let body = {t("正在读取…")}
;
+ if (error) body = {error}
;
+ else if (info?.kind === "unsupported") body = fallback;
+ else if (info && info.size > info.limit) body = {t("文件超过预览大小限制")}
;
+ else if (data && info) {
+ const text = () => new TextDecoder("utf-8", { fatal: true }).decode(data);
+ switch (info.kind) {
+ case "pdf": body = ; break;
+ case "table": body = ; break;
+ case "html": body = ; break;
+ case "image": body = ; break;
+ default: body = fallback;
+ }
+ }
+ return
+
+ {info && {info.size.toLocaleString()} B}
+
+ {onOpenExternal && }
+
+
+ {t("正在读取…")}}>{body}
+
+
+
+
+ {page} / {doc?.numPages ?? "—"}
+
+
+
+ {error &&
{t("PDF 无法显示，文件可能损坏或需要密码")}
}
+ {!doc && !error &&
{t("正在读取…")}
}
+
+
{t("静态预览，脚本和外部资源未加载")}
+
+ ;
+}
diff --git a/desktop/frontend-next/src/ui/document/active-file.interaction.test.tsx b/desktop/frontend-next/src/ui/document/active-file.interaction.test.tsx
new file mode 100644
index 0000000000..095180db37
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/active-file.interaction.test.tsx
@@ -0,0 +1,29 @@
+// @vitest-environment jsdom
+import { cleanup, fireEvent, render, screen, waitFor } from "@testing-library/react";
+import { afterEach, expect, it, vi } from "vitest";
+import { MockPort } from "../../port/mock";
+import { WorkbenchPanel } from "../WorkbenchPanel";
+import "../testkit";
+
+afterEach(cleanup);
+
+it("reports actual tab selection and clears it when the canvas is hidden or its file closes", async () => {
+ const port = new MockPort(), onActiveFile = vi.fn();
+ const props = { port, tabs: [], manual: false, shown: true, scheme: "light" as const, changes: [],
+ workspaceRoot: "/project", onSurfaces: vi.fn(), onCloseManual: vi.fn(), onExternal: vi.fn(), onActiveFile };
+ const view = render();
+ await waitFor(() => expect(onActiveFile).toHaveBeenLastCalledWith("docs/one.md"));
+ view.rerender();
+ await waitFor(() => expect(onActiveFile).toHaveBeenLastCalledWith("other/one.md"));
+ view.rerender();
+ fireEvent.click(screen.getAllByRole("button", { name: "one.md" })[0]);
+ await waitFor(() => expect(onActiveFile).toHaveBeenLastCalledWith("docs/one.md"));
+ fireEvent.click(screen.getByRole("button", { name: "文件" }));
+ await waitFor(() => expect(onActiveFile).toHaveBeenLastCalledWith(undefined));
+ fireEvent.click(screen.getByRole("button", { name: "文件" }));
+ await waitFor(() => expect(onActiveFile).toHaveBeenLastCalledWith("docs/one.md"));
+ fireEvent.click(screen.getAllByRole("button", { name: "关闭 one.md" })[0]);
+ await waitFor(() => expect(onActiveFile).toHaveBeenLastCalledWith("other/one.md"));
+ view.rerender();
+ await waitFor(() => expect(onActiveFile).toHaveBeenLastCalledWith(undefined));
+});
diff --git a/desktop/frontend-next/src/ui/document/delimited.worker.ts b/desktop/frontend-next/src/ui/document/delimited.worker.ts
new file mode 100644
index 0000000000..043ca3678b
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/delimited.worker.ts
@@ -0,0 +1,9 @@
+import { parseDelimited } from "./parseDelimited";
+
+self.onmessage = (event: MessageEvent<{ text: string; delimiter: string }>) => {
+ try {
+ self.postMessage({ rows: parseDelimited(event.data.text, event.data.delimiter) });
+ } catch {
+ self.postMessage({ error: true });
+ }
+};
diff --git a/desktop/frontend-next/src/ui/document/deliveries.test.ts b/desktop/frontend-next/src/ui/document/deliveries.test.ts
new file mode 100644
index 0000000000..900294b4ac
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/deliveries.test.ts
@@ -0,0 +1,38 @@
+import { expect, it } from "vitest";
+import type { Item } from "../../state/session";
+import { deliveriesByReply } from "./deliveries";
+import { fromHistory, initialState, reduce } from "../../state/session";
+
+it("keeps the latest declaration per file within a turn and preserves previous turns", () => {
+ const tool = (id: string, description: string): Item => ({ t: "tool", id, running: false, children: [], tool: {
+ name: "present_files", readOnly: true, deliveries: [{ path: "report.md", description }],
+ } });
+ const items: Item[] = [
+ { t: "user", id: "u1", text: "one" },
+ tool("t1", "old"), tool("t2", "new"),
+ { t: "say", id: "s1", text: "done", done: true },
+ { t: "user", id: "u2", text: "two" },
+ tool("t3", "second"),
+ { t: "say", id: "s2", text: "done", done: true },
+ ];
+ const map = deliveriesByReply(items);
+ expect(map.get("s1")?.map((f) => f.description)).toEqual(["new"]);
+ expect(map.get("s2")?.map((f) => f.description)).toEqual(["second"]);
+});
+
+it("preserves structured deliveries through live folding and history restoration", () => {
+ const files = [{ root: "/granted", path: "report 100%.md", description: "Report" }];
+ const tool = { id: "present", name: "present_files", readOnly: true, output: "done", deliveries: files };
+ const live = reduce(reduce(initialState, { kind: "tool_dispatch", tool: { id: tool.id, name: tool.name, readOnly: true } }), { kind: "tool_result", tool });
+ const restored = fromHistory([
+ { role: "assistant", content: "", toolCalls: [{ id: tool.id, name: tool.name }] },
+ { role: "tool", content: "done", toolCallId: tool.id, toolName: tool.name, deliveries: files },
+ ]);
+ expect([...deliveriesByReply(live.items).values()]).toEqual([files]);
+ expect([...deliveriesByReply(restored.items).values()]).toEqual([files]);
+ const failed = fromHistory([
+ { role: "assistant", content: "", toolCalls: [{ id: tool.id, name: tool.name }] },
+ { role: "tool", content: "failed", toolCallId: tool.id, toolName: tool.name, toolFailed: true, deliveries: files },
+ ]);
+ expect(deliveriesByReply(failed.items).size).toBe(0);
+});
diff --git a/desktop/frontend-next/src/ui/document/deliveries.ts b/desktop/frontend-next/src/ui/document/deliveries.ts
new file mode 100644
index 0000000000..e872d17e7a
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/deliveries.ts
@@ -0,0 +1,23 @@
+import type { Item } from "../../state/session";
+import type { DeliveredFile } from "../../port/workspace";
+import { opensTurn } from "../blocks";
+
+export function deliveriesByReply(items: Item[]): Map {
+ const out = new Map();
+ let files = new Map();
+ let anchor = "", call = "";
+ const flush = () => {
+ if (files.size && (anchor || call)) out.set(anchor || call, [...files.values()]);
+ files = new Map(); anchor = ""; call = "";
+ };
+ for (const item of items) {
+ if (opensTurn(item)) flush();
+ if (item.t === "say" && item.text) anchor = item.id;
+ if (item.t === "tool" && !item.running && !item.tool.err && item.tool.deliveries?.length) {
+ call = item.id;
+ for (const file of item.tool.deliveries) files.set(JSON.stringify([file.root ?? "", file.path]), file);
+ }
+ }
+ flush();
+ return out;
+}
diff --git a/desktop/frontend-next/src/ui/document/delivery.css b/desktop/frontend-next/src/ui/document/delivery.css
new file mode 100644
index 0000000000..019f057a02
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/delivery.css
@@ -0,0 +1,181 @@
+.delivery-files {
+ container-type: inline-size;
+ min-width: 0;
+ margin: 12px 0;
+}
+.delivery-grid {
+ display: grid;
+ grid-template-columns: minmax(0, 1fr);
+ gap: 8px;
+}
+@container (min-width: 720px) {
+ .delivery-grid:not([data-single]) {
+ grid-template-columns: repeat(2, minmax(0, 1fr));
+ }
+}
+.delivery-file {
+ display: grid;
+ grid-template-columns: minmax(0, 1fr) auto;
+ align-items: center;
+ min-width: 0;
+ min-height: 72px;
+ border: 1px solid var(--border);
+ border-radius: var(--r-md, 8px);
+ background: var(--raised);
+ color: var(--text);
+}
+.delivery-file:hover {
+ background: var(--float-hi);
+}
+.delivery-file[data-current] {
+ border-color: color-mix(in srgb, var(--accent) 45%, var(--border));
+ background: color-mix(in srgb, var(--accent) 5%, var(--raised));
+}
+.delivery-open {
+ display: flex;
+ align-items: center;
+ align-self: stretch;
+ gap: 10px;
+ min-width: 0;
+ padding: 12px;
+ border: 0;
+ border-radius: inherit;
+ background: transparent;
+ color: inherit;
+ text-align: start;
+ font: inherit;
+ cursor: pointer;
+}
+.delivery-open:focus-visible, .delivery-more:focus-visible {
+ outline: 2px solid var(--focus);
+ outline-offset: -3px;
+}
+.delivery-icon {
+ display: flex;
+ flex-direction: column;
+ align-items: center;
+ justify-content: center;
+ flex: 0 0 32px;
+ width: 32px;
+ height: 36px;
+ color: var(--muted);
+}
+.delivery-icon-badge {
+ font: 600 8px/1.2 var(--mono);
+ letter-spacing: .2px;
+}
+.delivery-icon svg {
+ width: 22px;
+ height: 22px;
+}
+.delivery-details {
+ display: flex;
+ flex-direction: column;
+ gap: 4px;
+ min-width: 0;
+ flex: 1;
+}
+.delivery-heading, .delivery-name {
+ display: flex;
+ align-items: baseline;
+ min-width: 0;
+}
+.delivery-heading {
+ gap: 8px;
+}
+.delivery-name {
+ font-size: var(--fs-ui);
+ font-weight: var(--w-med);
+ line-height: 1.45;
+}
+.delivery-name > span:first-child, .delivery-description, .delivery-location {
+ overflow: hidden;
+ text-overflow: ellipsis;
+ white-space: nowrap;
+}
+.delivery-extension {
+ flex: none;
+ color: var(--muted);
+}
+.delivery-description, .delivery-location {
+ display: block;
+ font-size: var(--fs-meta);
+ line-height: 1.5;
+ color: var(--muted);
+}
+.delivery-current {
+ flex: none;
+ color: var(--accent-ink);
+ font-size: var(--fs-micro);
+ white-space: nowrap;
+}
+.delivery-more {
+ display: inline-flex;
+ align-items: center;
+ justify-content: center;
+ gap: 4px;
+ min-width: 60px;
+ height: 32px;
+ margin: 0 8px 0 0;
+ padding: 6px 8px;
+ border: 1px solid var(--border);
+ border-radius: var(--r-sm);
+ background: var(--surface);
+ color: var(--text);
+ font: var(--w-med) var(--fs-meta) var(--ui);
+ cursor: pointer;
+}
+.delivery-more:hover, .delivery-more[aria-expanded="true"] {
+ background: var(--float-hi);
+ color: var(--text);
+}
+.delivery-more svg {
+ width: 14px;
+ height: 14px;
+}
+.delivery-menu {
+ position: fixed;
+ z-index: 60;
+ min-width: 200px;
+ max-width: calc(100vw / var(--zoom, 1) - 12px);
+ padding: 5px;
+ border: 1px solid var(--border);
+ border-radius: var(--r-md, 8px);
+ background: var(--float);
+ color: var(--text);
+ box-shadow: var(--shadow-float);
+}
+.delivery-menu button {
+ display: flex;
+ align-items: center;
+ gap: 10px;
+ width: 100%;
+ padding: 8px 10px;
+ border: 0;
+ border-radius: var(--r-sm);
+ background: transparent;
+ color: inherit;
+ font: var(--fs-ui) var(--ui);
+ text-align: start;
+ cursor: pointer;
+}
+.delivery-menu button:hover, .delivery-menu button:focus-visible {
+ background: var(--float-hi);
+ outline: none;
+}
+.delivery-menu svg {
+ width: 16px;
+ height: 16px;
+ flex: none;
+ color: var(--muted);
+}
+.delivery-feedback {
+ grid-column: 1 / -1;
+ padding: 0 12px 10px 54px;
+ font-size: var(--fs-meta);
+ color: var(--muted);
+ overflow-wrap: anywhere;
+}
+.delivery-feedback[data-kind="error"] {
+ color: var(--err-ink);
+}
diff --git a/desktop/frontend-next/src/ui/document/document.css b/desktop/frontend-next/src/ui/document/document.css
new file mode 100644
index 0000000000..7df8fef350
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/document.css
@@ -0,0 +1,77 @@
+.document-preview, .document-pdf {
+ display: flex;
+ flex: 1;
+ flex-direction: column;
+ min-height: 0;
+ min-width: 0;
+ overflow: hidden;
+}
+.document-controls {
+ display: flex;
+ align-items: center;
+ gap: 8px;
+ padding: 8px 12px;
+ flex-wrap: wrap;
+}
+.document-controls button, .document-controls select {
+ color: var(--text);
+ background: var(--bg);
+ border: 1px solid var(--border);
+ padding: 4px 8px;
+ border-radius: 6px;
+}
+.document-notice, .document-preview > p {
+ padding: 8px 12px;
+}
+.document-html {
+ flex: 1;
+ width: 100%;
+ min-height: 240px;
+ background: white;
+ border: 0;
+}
+.document-table, .document-pdf-scroll, .document-picture {
+ flex: 1;
+ min-height: 0;
+ overflow: auto;
+}
+.document-table table {
+ border-collapse: collapse;
+ font-size: 13px;
+}
+.document-table td, .document-table th {
+ padding: 0 8px;
+ border: 1px solid var(--border);
+ max-width: 400px;
+ overflow: hidden;
+ white-space: nowrap;
+ text-overflow: ellipsis;
+ line-height: 29px;
+}
+.document-table th {
+ position: sticky;
+ left: 0;
+ background: var(--bg);
+}
+.document-table tr[aria-hidden] td {
+ padding: 0;
+ border: 0;
+}
+.document-pdf-scroll {
+ padding: 12px;
+}
+.document-pdf-page {
+ position: relative;
+ width: fit-content;
+ margin: auto;
+}
+.document-pdf-page canvas {
+ display: block;
+}
+.document-pdf-page .textLayer {
+ position: absolute;
+ inset: 0;
+}
+.document-picture img {
+ display: block;
+}
diff --git a/desktop/frontend-next/src/ui/document/document.test.ts b/desktop/frontend-next/src/ui/document/document.test.ts
new file mode 100644
index 0000000000..b2a15999f4
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/document.test.ts
@@ -0,0 +1,24 @@
+// @vitest-environment jsdom
+import { expect, it } from "vitest";
+import { staticDocument } from "./staticDocument";
+import { parseDelimited } from "./parseDelimited";
+
+it("keeps CSV values literal including multiline quoted cells and leading zeros", () => {
+ expect(parseDelimited('id,value\n001,"hello\nworld"\n002,"=SUM(A1:A2)"', ",")).toEqual([
+ ["id", "value"], ["001", "hello\nworld"], ["002", "=SUM(A1:A2)"],
+ ]);
+ expect(parseDelimited('a\t"b\tc"\n1\t2', "\t")).toEqual([["a", "b\tc"], ["1", "2"]]);
+ expect(() => parseDelimited('"unterminated', ",")).toThrow();
+ expect(() => parseDelimited("a,b,c", ",", 2)).toThrow();
+});
+
+it("static HTML cannot execute or load remote resources", () => {
+ const html = staticDocument('hello
link');
+ const doc = new DOMParser().parseFromString(html, "text/html");
+ expect(doc.querySelector("script,iframe,form,input,[onclick],[href]")).toBeNull();
+ expect(doc.querySelector('meta[http-equiv="refresh"]')).toBeNull();
+ expect(doc.querySelector("img")?.getAttribute("src")).toBeNull();
+ expect(doc.querySelector("p")?.textContent).toBe("hello");
+ expect(doc.querySelector("style")?.textContent).toContain("color:red");
+ expect(doc.querySelector('meta[http-equiv="Content-Security-Policy"]')?.getAttribute("content")).toContain("default-src 'none'");
+});
diff --git a/desktop/frontend-next/src/ui/document/draft-observation.test.tsx b/desktop/frontend-next/src/ui/document/draft-observation.test.tsx
new file mode 100644
index 0000000000..615210b830
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/draft-observation.test.tsx
@@ -0,0 +1,25 @@
+// @vitest-environment jsdom
+import { act, cleanup, renderHook, waitFor } from "@testing-library/react";
+import { afterEach, expect, it, vi } from "vitest";
+import { MockPort } from "../../port/mock";
+import { useWorkbenchFiles } from "../useWorkbenchFiles";
+
+afterEach(cleanup);
+
+it("warns about disk changes using metadata without reloading an unsaved draft", async () => {
+ const port = new MockPort();
+ const read = vi.spyOn(port, "workspaceFile").mockResolvedValue({ path: "notes.md", content: "# Saved", revision: "hash", observedVersion: "disk-1" });
+ const stat = vi.spyOn(port, "workspacePreviewInfo").mockResolvedValue({
+ ref: { path: "notes.md" }, kind: "markdown", version: "disk-2", size: 9, limit: 2 << 20, readOnly: false,
+ });
+ const paths = ["notes.md"];
+ const { result } = renderHook(() => useWorkbenchFiles({
+ port, workspaceRoot: "/fixture", path: "notes.md", openPaths: paths, shown: true, refresh: "", poll: false,
+ }));
+ await waitFor(() => expect(result.current.file).toBeTruthy());
+ act(() => result.current.setDraft("# My unsaved changes"));
+ await waitFor(() => expect(result.current.error).toContain("未保存的编辑已保留"));
+ expect(result.current.draft).toBe("# My unsaved changes");
+ expect(stat).toHaveBeenCalled();
+ expect(read).toHaveBeenCalledOnce();
+});
diff --git a/desktop/frontend-next/src/ui/document/parseDelimited.ts b/desktop/frontend-next/src/ui/document/parseDelimited.ts
new file mode 100644
index 0000000000..bee2846ef3
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/parseDelimited.ts
@@ -0,0 +1,19 @@
+import Papa from "papaparse";
+
+export function parseDelimited(text: string, delimiter: string, maxCells = 100_000): string[][] {
+ const rows: string[][] = [];
+ let cells = 0;
+ let failure = "";
+ Papa.parse(text.replace(/^\uFEFF/, ""), {
+ delimiter, dynamicTyping: false, skipEmptyLines: false,
+ step(result, parser) {
+ if (result.errors.length) failure = "invalid";
+ cells += result.data.length;
+ if (cells > maxCells) failure = "limit";
+ if (failure) parser.abort();
+ else rows.push(result.data);
+ },
+ });
+ if (failure) throw new Error(failure);
+ return rows;
+}
diff --git a/desktop/frontend-next/src/ui/document/registry.ts b/desktop/frontend-next/src/ui/document/registry.ts
new file mode 100644
index 0000000000..21614fd11d
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/registry.ts
@@ -0,0 +1,18 @@
+import type { PreviewInfo } from "../../port/workspace";
+
+type Kind = PreviewInfo["kind"];
+export const renderers: ReadonlyArray<{ kind: Kind; extensions: RegExp; source: boolean }> = [
+ { kind: "markdown", extensions: /\.(md|markdown|mdx)$/i, source: true },
+ { kind: "image", extensions: /\.(png|jpe?g|gif|webp|avif|bmp|ico|svg)$/i, source: false },
+ { kind: "pdf", extensions: /\.pdf$/i, source: false },
+ { kind: "table", extensions: /\.(csv|tsv)$/i, source: true },
+ { kind: "html", extensions: /\.html?$/i, source: true },
+ { kind: "unsupported", extensions: /\.(docx?|xlsx?|pptx?|zip|gz|7z|rar|exe|dll|bin)$/i, source: false },
+];
+
+export function previewKind(path: string): Kind {
+ return renderers.find((r) => r.extensions.test(path))?.kind ?? "text";
+}
+
+export const documentView = (path: string) => !["markdown", "text"].includes(previewKind(path));
+export const sourceView = (path: string) => renderers.find((r) => r.extensions.test(path))?.source ?? true;
diff --git a/desktop/frontend-next/src/ui/document/staticDocument.ts b/desktop/frontend-next/src/ui/document/staticDocument.ts
new file mode 100644
index 0000000000..bc5645a351
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/staticDocument.ts
@@ -0,0 +1,20 @@
+import DOMPurify from "dompurify";
+
+export function staticDocument(source: string): string {
+ const clean = DOMPurify.sanitize(source, {
+ WHOLE_DOCUMENT: true,
+ ADD_TAGS: ["style"],
+ FORBID_TAGS: ["script", "iframe", "object", "embed", "form", "input", "button", "textarea", "select", "link", "base", "meta"],
+ FORBID_ATTR: ["srcdoc", "srcset", "action", "formaction", "href", "xlink:href", "ping", "target"],
+ });
+ const doc = new DOMParser().parseFromString(clean, "text/html");
+ for (const el of doc.querySelectorAll("[src]")) {
+ const src = el.getAttribute("src") ?? "";
+ if (el.tagName !== "IMG" || !/^data:image\/(png|jpeg|gif|webp|avif|bmp|x-icon);base64,/i.test(src)) el.removeAttribute("src");
+ }
+ const policy = doc.createElement("meta");
+ policy.httpEquiv = "Content-Security-Policy";
+ policy.content = "default-src 'none'; script-src 'none'; style-src 'unsafe-inline'; img-src data:; connect-src 'none'; form-action 'none'; base-uri 'none'";
+ doc.head.prepend(policy);
+ return "" + doc.documentElement.outerHTML;
+}
diff --git a/desktop/frontend-next/src/ui/document/text-refresh.test.tsx b/desktop/frontend-next/src/ui/document/text-refresh.test.tsx
new file mode 100644
index 0000000000..dc3229574c
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/text-refresh.test.tsx
@@ -0,0 +1,43 @@
+// @vitest-environment jsdom
+import { act, cleanup, renderHook } from "@testing-library/react";
+import { afterEach, expect, it, vi } from "vitest";
+import { MockPort } from "../../port/mock";
+import { HttpError } from "../../port/port";
+import { useWorkbenchFiles } from "../useWorkbenchFiles";
+
+afterEach(() => { cleanup(); vi.useRealTimers(); });
+
+it.each([[404, "workspace.file_missing"], [403, "workspace.preview_denied"]])("surfaces a %s poll failure and removes stale saved text", async (status, code) => {
+ vi.useFakeTimers();
+ const port = new MockPort();
+ const read = vi.spyOn(port, "workspaceFile").mockResolvedValue({ path: "a.md", content: "saved", revision: "r1" });
+ const paths = ["a.md"];
+ const { result } = renderHook(() => useWorkbenchFiles({ port, workspaceRoot: "/work", path: "a.md", openPaths: paths, shown: true, refresh: "", poll: true }));
+ await act(async () => {});
+ expect(result.current.draft).toBe("saved");
+ read.mockRejectedValue(new HttpError(status, "unavailable", { code }));
+ await act(async () => { await vi.advanceTimersByTimeAsync(3000); });
+ expect(result.current.errorCode).toBe(code);
+ expect(result.current.file).toBeNull();
+ expect(result.current.draft).toBe("");
+ read.mockResolvedValue({ path: "a.md", content: "recreated", revision: "r2" });
+ await act(async () => { await vi.advanceTimersByTimeAsync(3000); });
+ expect(result.current.draft).toBe("recreated");
+ expect(result.current.error).toBe("");
+});
+
+it("does not poll metadata for every keystroke and preserves a draft after deletion", async () => {
+ vi.useFakeTimers();
+ const port = new MockPort();
+ vi.spyOn(port, "workspaceFile").mockResolvedValue({ path: "a.md", content: "saved", revision: "r1", observedVersion: "v1" });
+ const stat = vi.spyOn(port, "workspacePreviewInfo").mockResolvedValue({ ref: { path: "a.md" }, kind: "markdown", version: "v1", size: 5, limit: 2 << 20, readOnly: false });
+ const paths = ["a.md"];
+ const { result } = renderHook(() => useWorkbenchFiles({ port, workspaceRoot: "/work", path: "a.md", openPaths: paths, shown: true, refresh: "", poll: true }));
+ await act(async () => {});
+ for (const text of ["a", "ab", "abc"]) await act(async () => result.current.setDraft(text));
+ expect(stat).toHaveBeenCalledOnce();
+ stat.mockRejectedValue(new HttpError(404, "gone", { code: "workspace.file_missing" }));
+ await act(async () => { await vi.advanceTimersByTimeAsync(3000); });
+ expect(result.current.draft).toBe("abc");
+ expect(result.current.error).toContain("找不到");
+});
diff --git a/desktop/frontend-next/src/ui/document/useDocument.test.tsx b/desktop/frontend-next/src/ui/document/useDocument.test.tsx
new file mode 100644
index 0000000000..1d2b6844f6
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/useDocument.test.tsx
@@ -0,0 +1,49 @@
+// @vitest-environment jsdom
+import { act, cleanup, renderHook, waitFor } from "@testing-library/react";
+import { afterEach, expect, it, vi } from "vitest";
+import { MockPort } from "../../port/mock";
+import { HttpError } from "../../port/port";
+import { useDocument } from "./useDocument";
+
+afterEach(() => { cleanup(); vi.restoreAllMocks(); });
+
+it("discards a previous file's late response and aborts on close", async () => {
+ const port = new MockPort();
+ let done!: (value: { data: ArrayBuffer; version: string }) => void;
+ let signal: AbortSignal | undefined;
+ vi.spyOn(port, "workspacePreviewContent").mockImplementationOnce((_ref, s?: AbortSignal) => {
+ signal = s;
+ return new Promise((resolve) => { done = resolve; });
+ });
+ const { result, rerender, unmount } = renderHook(({ path }) => useDocument(port, path, true, ""), { initialProps: { path: "one.csv" } });
+ await waitFor(() => expect(done).toBeDefined());
+ rerender({ path: "two.csv" });
+ await waitFor(() => expect(result.current.value?.info.ref.path).toBe("two.csv"));
+ expect(signal?.aborted).toBe(true);
+ await act(async () => done({ data: new ArrayBuffer(0), version: "old" }));
+ expect(result.current.value?.info.ref.path).toBe("two.csv");
+ unmount();
+});
+
+it("removes stale bytes when access is revoked and reload fails", async () => {
+ const port = new MockPort();
+ const { result } = renderHook(() => useDocument(port, "report.csv", true, ""));
+ await waitFor(() => expect(result.current.value?.data).toBeTruthy());
+ vi.spyOn(port, "workspacePreviewInfo").mockRejectedValue(new HttpError(403, "denied", { code: "workspace.preview_denied" }));
+ act(() => result.current.reload());
+ await waitFor(() => expect(result.current.value?.error).toBeTruthy());
+ expect(result.current.value?.data).toBeUndefined();
+});
+
+it("checks metadata on invalidation and only forces unchanged bytes for manual refresh", async () => {
+ const port = new MockPort();
+ const content = vi.spyOn(port, "workspacePreviewContent");
+ const info = vi.spyOn(port, "workspacePreviewInfo");
+ const { result, rerender } = renderHook(({ refresh }) => useDocument(port, "report.csv", true, refresh), { initialProps: { refresh: "first" } });
+ await waitFor(() => expect(result.current.value?.data).toBeTruthy());
+ rerender({ refresh: "tool finished" });
+ await waitFor(() => expect(info).toHaveBeenCalledTimes(2));
+ expect(content).toHaveBeenCalledTimes(1);
+ act(() => result.current.reload());
+ await waitFor(() => expect(content).toHaveBeenCalledTimes(2));
+});
diff --git a/desktop/frontend-next/src/ui/document/useDocument.ts b/desktop/frontend-next/src/ui/document/useDocument.ts
new file mode 100644
index 0000000000..be8f073565
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/useDocument.ts
@@ -0,0 +1,55 @@
+import { useCallback, useEffect, useMemo, useRef, useState } from "react";
+import type { AgentPort } from "../../port/port";
+import type { PreviewInfo } from "../../port/workspace";
+import { parseGrantedFile } from "../grantedfiles";
+import { reason } from "../../i18n/kernel";
+
+type Loaded = { info: PreviewInfo; data?: ArrayBuffer; error?: string };
+
+export function useDocument(port: AgentPort, path: string, shown: boolean, refresh: string) {
+ const held = useMemo(() => parseGrantedFile(path), [path]);
+ const ref = useMemo(() => ({ path: held?.rel ?? path, ...(held ? { root: held.root } : {}) }), [held, path]);
+ const [state, setState] = useState<{ ref: typeof ref; port: AgentPort; value: Loaded }>();
+ const [reload, setReload] = useState(0);
+ const cache = useRef(undefined);
+ const lastReload = useRef(0);
+ const request = useCallback(() => setReload((n) => n + 1), []);
+ useEffect(() => {
+ cache.current = undefined;
+ setState(undefined);
+ }, [ref, port]);
+ useEffect(() => {
+ if (!shown) return;
+ const controller = new AbortController();
+ let busy = false;
+ const read = async (force: boolean) => {
+ if (busy || controller.signal.aborted) return;
+ busy = true;
+ let observed: PreviewInfo | undefined;
+ try {
+ const info = await port.workspacePreviewInfo(ref, controller.signal);
+ observed = info;
+ if (controller.signal.aborted) return;
+ let value: Loaded;
+ if (info.kind === "unsupported" || info.size > info.limit) value = { info };
+ else if (!force && cache.current?.data && cache.current.info.version === info.version) value = { ...cache.current, info, error: undefined };
+ else {
+ const loaded = await port.workspacePreviewContent(ref, controller.signal);
+ value = { info: { ...info, version: loaded.version || info.version }, data: loaded.data };
+ }
+ if (!controller.signal.aborted) { cache.current = value; setState({ ref, port, value }); }
+ } catch (e) {
+ if (!controller.signal.aborted) {
+ cache.current = undefined;
+ setState({ ref, port, value: { info: observed ?? { ref, kind: "unsupported", size: 0, limit: 0, version: "", readOnly: true }, error: reason(e) } });
+ }
+ } finally { busy = false; }
+ };
+ const force = lastReload.current !== reload;
+ lastReload.current = reload;
+ void read(force);
+ const timer = window.setInterval(() => void read(false), 3000);
+ return () => { controller.abort(); window.clearInterval(timer); };
+ }, [port, ref, shown, refresh, reload]);
+ return { value: state?.ref === ref && state.port === port ? state.value : undefined, reload: request };
+}
diff --git a/desktop/frontend-next/src/ui/document/viewState.ts b/desktop/frontend-next/src/ui/document/viewState.ts
new file mode 100644
index 0000000000..aed887f789
--- /dev/null
+++ b/desktop/frontend-next/src/ui/document/viewState.ts
@@ -0,0 +1,12 @@
+export interface DocumentViewState {
+ top?: number;
+ left?: number;
+ page?: number;
+ zoom?: number;
+}
+
+export function documentState(states: Map, path: string): DocumentViewState {
+ let state = states.get(path);
+ if (!state) { state = {}; states.set(path, state); }
+ return state;
+}
diff --git a/desktop/frontend-next/src/ui/html-preview.interaction.test.tsx b/desktop/frontend-next/src/ui/html-preview.interaction.test.tsx
index 18ef96a3fc..36425ff9f5 100644
--- a/desktop/frontend-next/src/ui/html-preview.interaction.test.tsx
+++ b/desktop/frontend-next/src/ui/html-preview.interaction.test.tsx
@@ -58,6 +58,7 @@ it.each([["before", false], ["before", true], ["after", false], ["after", true]]
const fresh = page({ id: "fresh", target: "tf", url: "https://example.com/fresh", title: "Fresh" });
const { container, rerender } = render(panel(port, { tabs: [agent] }));
await user.click(await screen.findByRole("button", { name: "index.html" }));
+ await user.click(await screen.findByRole("button", { name: "交互运行" }));
await waitFor(() => expect(open).toHaveBeenCalledTimes(1));
await user.click(container.querySelector('[data-action="workbench.files"]')!);
expect(container.querySelector(".workbench-body")?.hasAttribute("data-files")).toBe(true);
@@ -86,6 +87,7 @@ it("keeps a superseded successful user tab owned while a separate preview claim
const userTab = page({ id: "user", target: "tu", url: "https://example.com", title: "User page" });
const { container, rerender } = render(panel(port));
await user.click(await screen.findByRole("button", { name: "index.html" }));
+ await user.click(await screen.findByRole("button", { name: "交互运行" }));
await waitFor(() => expect(open).toHaveBeenCalledTimes(1));
const pending = openPage(port, userTab.url);
await user.click(container.querySelector('[data-action="workbench.files"]')!);
@@ -106,6 +108,7 @@ describe("opening an HTML file from the explorer", () => {
vi.spyOn(port, "workspaceFile").mockReturnValue(new Promise((resolve) => { read = resolve; }));
const { container } = render(panel(port));
await user.click(await screen.findByRole("button", { name: "index.html" }));
+ await user.click(await screen.findByRole("button", { name: "交互运行" }));
await waitFor(() => expect(port.workspaceFile).toHaveBeenCalled());
if (choice === "Files") await user.click(container.querySelector('[data-action="workbench.files"]')!);
else await user.click(screen.getByRole("button", { name: "新建标签" }));
@@ -129,6 +132,7 @@ describe("opening an HTML file from the explorer", () => {
const fresh = page({ id: "fresh", target: "tf", url: "https://example.com/fresh", title: "Fresh" });
const { container, rerender } = render(panel(port, { tabs: [agent] }));
await user.click(await screen.findByRole("button", { name: "index.html" }));
+ await user.click(await screen.findByRole("button", { name: "交互运行" }));
await waitFor(() => expect(open).toHaveBeenCalledTimes(1));
await user.click(container.querySelector('[data-action="workbench.files"]')!);
const reject = () => act(async () => reply(new Response(JSON.stringify({ code: "browser.open_failed", params: { tab: page().id } }), { status: 400 })));
@@ -151,13 +155,14 @@ describe("opening an HTML file from the explorer", () => {
const { port, open } = setup();
const { rerender } = render(panel(port));
await user.click(await screen.findByRole("button", { name: "index.html" }));
+ await user.click(await screen.findByRole("button", { name: "交互运行" }));
await waitFor(() => expect(open).toHaveBeenCalledTimes(1));
expect(open).toHaveBeenCalledWith(`${ROOT}/index.html`, true);
expect(unseenPageOpenings(port)).toHaveLength(1);
rerender(panel(port, { tabs: [page()] }));
expect(unseenPageOpenings(port)).toHaveLength(0);
await waitFor(() => expect(document.querySelector(".workbench-canvas .bpanel")).toBeTruthy());
- expect(screen.getByRole("button", { name: "预览" }).getAttribute("aria-pressed")).toBe("true");
+ expect(screen.getByRole("button", { name: "交互运行" }).getAttribute("aria-pressed")).toBe("true");
expect(document.querySelector(".cm-content")).toBeNull();
expect(unseenPageOpenings(port)).toHaveLength(0);
});
@@ -170,6 +175,7 @@ describe("opening an HTML file from the explorer", () => {
open.mockReturnValue(new Promise((resolve) => (answer = resolve)));
const { rerender } = render(panel(port));
await user.click(await screen.findByRole("button", { name: "index.html" }));
+ await user.click(await screen.findByRole("button", { name: "交互运行" }));
await waitFor(() => expect(open).toHaveBeenCalled());
rerender(panel(port, { tabs: [page()] }));
expect(screen.queryByRole("tab", { name: "Landing" })).toBeNull();
@@ -187,6 +193,8 @@ describe("opening an HTML file from the explorer", () => {
render(panel(port));
(await screen.findByRole("button", { name: "about.htm" })).focus();
await user.keyboard("{Enter}");
+ screen.getByRole("button", { name: "交互运行" }).focus();
+ await user.keyboard("{Enter}");
await waitFor(() => expect(open).toHaveBeenCalledWith(`${ROOT}/about.htm`, true));
});
@@ -195,11 +203,12 @@ describe("opening an HTML file from the explorer", () => {
const { port, open } = setup();
const { rerender } = render(panel(port));
await user.click(await screen.findByRole("button", { name: "index.html" }));
+ await user.click(await screen.findByRole("button", { name: "交互运行" }));
await waitFor(() => expect(open).toHaveBeenCalledTimes(1));
rerender(panel(port, { tabs: [page()] }));
await user.click(await screen.findByRole("button", { name: "编辑" }));
await waitFor(() => expect(document.querySelector(".cm-content")).toBeTruthy());
- await user.click(screen.getByRole("button", { name: "预览" }));
+ await user.click(screen.getByRole("button", { name: "交互运行" }));
await user.click(screen.getAllByRole("button", { name: "index.html" }).find((b) => b.classList.contains("workbench-tree-row"))!);
expect(open).toHaveBeenCalledTimes(1);
expect(document.querySelector(".workbench-canvas .bpanel")).toBeTruthy();
@@ -211,6 +220,7 @@ describe("opening an HTML file from the explorer", () => {
const { port, open, control } = setup({ revision: () => revision });
const { rerender } = render(panel(port));
await user.click(await screen.findByRole("button", { name: "index.html" }));
+ await user.click(await screen.findByRole("button", { name: "交互运行" }));
await waitFor(() => expect(open).toHaveBeenCalled());
rerender(panel(port, { tabs: [page()], wrote: 0 }));
await waitFor(() => expect(document.querySelector(".bpanel")).toBeTruthy());
@@ -229,6 +239,7 @@ describe("opening an HTML file from the explorer", () => {
render(panel(port, { tabs: [page()] }));
expect(screen.getByRole("tab", { name: "Landing" })).toBeTruthy();
await user.click(await screen.findByRole("button", { name: "index.html" }));
+ await user.click(await screen.findByRole("button", { name: "交互运行" }));
await waitFor(() => expect(screen.queryByRole("tab", { name: "Landing" })).toBeNull());
expect(open).not.toHaveBeenCalled();
expect(document.querySelector(".workbench-canvas .bpanel")).toBeTruthy();
@@ -240,6 +251,7 @@ describe("opening an HTML file from the explorer", () => {
vi.spyOn(port, "workspaces").mockResolvedValue({ current: "D:\\proj\\site\\", canSwitch: true, canIsolate: true, recents: [] });
const { rerender } = render(panel(port));
await user.click(await screen.findByRole("button", { name: "index.html" }));
+ await user.click(await screen.findByRole("button", { name: "交互运行" }));
await waitFor(() => expect(open).toHaveBeenCalledWith("D:\\proj\\site/index.html", true));
open.mockClear();
rerender(panel(port, { tabs: [page({ url: "file:///D:/proj/site/index.html" })] }));
@@ -260,6 +272,7 @@ describe("opening an HTML file from the explorer", () => {
refusedLikeTheKernel(port, "browser.open_failed", "browser.url_refused: outside the workspace");
render(panel(port));
await user.click(await screen.findByRole("button", { name: "index.html" }));
+ await user.click(await screen.findByRole("button", { name: "交互运行" }));
const alert = await screen.findByRole("alert");
expect(alert.textContent).toBe("打不开这个网页：browser.url_refused: outside the workspace");
await waitFor(() => expect(document.querySelector(".cm-content")).toBeTruthy());
@@ -272,6 +285,7 @@ describe("opening an HTML file from the explorer", () => {
refusedLikeTheKernel(port, "browser.network_path", "a network path");
render(panel(port));
await user.click(await screen.findByRole("button", { name: "index.html" }));
+ await user.click(await screen.findByRole("button", { name: "交互运行" }));
const alert = await screen.findByRole("alert");
expect(alert.textContent).toContain("网络上另一台机器");
expect(alert.textContent).not.toContain("{");
@@ -300,22 +314,24 @@ describe("opening an HTML file from the explorer", () => {
expect(open).not.toHaveBeenCalled();
});
- it("opens an HTML file in the editor where the window draws no pages", async () => {
+ it("opens static HTML where the window draws no browser pages", async () => {
const user = userEvent.setup();
const { port, open } = setup({ views: false });
render(panel(port));
await user.click(await screen.findByRole("button", { name: "index.html" }));
- await waitFor(() => expect(document.querySelector(".cm-content")).toBeTruthy());
- expect(screen.queryByRole("button", { name: "预览" })).toBeNull();
+ await screen.findByTitle("HTML 静态预览");
+ expect(screen.queryByRole("button", { name: "交互运行" })).toBeNull();
+ expect(screen.getByRole("button", { name: "预览" })).toBeTruthy();
expect(open).not.toHaveBeenCalled();
});
- it("opens an HTML file in the editor when the workspace is on another machine", async () => {
+ it("opens static HTML when the workspace is on another machine", async () => {
const user = userEvent.setup();
const { port, open } = setup();
render(panel(port, { remote: true }));
await user.click(await screen.findByRole("button", { name: "index.html" }));
- await waitFor(() => expect(document.querySelector(".cm-content")).toBeTruthy());
+ await screen.findByTitle("HTML 静态预览");
+ expect(screen.queryByRole("button", { name: "交互运行" })).toBeNull();
expect(open).not.toHaveBeenCalled();
});
diff --git a/desktop/frontend-next/src/ui/tooltip.css b/desktop/frontend-next/src/ui/tooltip.css
new file mode 100644
index 0000000000..c04314ee59
--- /dev/null
+++ b/desktop/frontend-next/src/ui/tooltip.css
@@ -0,0 +1,22 @@
+.icon-tooltip {
+ position: fixed;
+ z-index: 70;
+ display: flex;
+ align-items: center;
+ gap: 8px;
+ max-width: min(340px, calc(100vw / var(--zoom, 1) - 12px));
+ padding: 6px 9px;
+ border: 1px solid var(--border);
+ border-radius: var(--r-sm);
+ background: var(--float);
+ color: var(--text);
+ box-shadow: var(--shadow-float);
+ font: var(--w-med) var(--fs-ui) var(--ui);
+ overflow-wrap: anywhere;
+ pointer-events: none;
+}
+.icon-tooltip kbd {
+ color: var(--muted);
+ font: inherit;
+ white-space: nowrap;
+}
diff --git a/desktop/frontend-next/src/ui/useConversationFiles.tsx b/desktop/frontend-next/src/ui/useConversationFiles.tsx
index 0bf294300d..89ee830ea6 100644
--- a/desktop/frontend-next/src/ui/useConversationFiles.tsx
+++ b/desktop/frontend-next/src/ui/useConversationFiles.tsx
@@ -3,7 +3,7 @@ import type { AgentPort } from "../port/port";
import { host } from "../port/host";
import type { LocalRefs } from "./Markdown";
import { GRANTED, conversationFile, isLocalPathShape } from "./filelinks";
-import { GRANTED_FILE, grantedFileKey } from "./grantedfiles";
+import { GRANTED_FILE, grantedFileKey, grantedFilePath } from "./grantedfiles";
import { WorkbenchFileMenu, absoluteWorkspacePath, type FileMenu } from "./WorkbenchFileMenu";
export function useConversationFiles(port: AgentPort, root: string, remote: boolean, shown: boolean, reveal: () => void, fail: (e: unknown) => void) {
@@ -65,6 +65,7 @@ export function useConversationFiles(port: AgentPort, root: string, remote: bool
// A path in text may become a link when it is in the workspace or in a granted folder.
const linkable = (href: string) => path(href) ?? (isLocalPathShape(href) ? grantedFileKey(granted, href) : null);
return {
+ file: (ref) => () => ask(ref.root ? grantedFilePath(ref.root, ref.path) : ref.path),
path,
linkable,
title: (href) => { const file = path(href); return file ? absoluteWorkspacePath(root, file) : ""; },
diff --git a/desktop/frontend-next/src/ui/useWorkbenchFiles.ts b/desktop/frontend-next/src/ui/useWorkbenchFiles.ts
index 3d58f65a6a..3adb31026a 100644
--- a/desktop/frontend-next/src/ui/useWorkbenchFiles.ts
+++ b/desktop/frontend-next/src/ui/useWorkbenchFiles.ts
@@ -5,12 +5,14 @@ import { locate } from "../state/gittree";
import { WORKSPACE_FILE_MISSING, reason } from "../i18n/kernel";
import { HttpError } from "../port/port";
import { parseGrantedFile } from "./grantedfiles";
+import { t } from "../i18n";
type Entry = {
file: WorkspaceFile | null; draft: string; diff: string; error: string; missing: boolean;
+ errorCode: string;
pending: "" | "read" | "save"; issued: number;
};
-const blank = (): Entry => ({ file: null, draft: "", diff: "", error: "", missing: false, pending: "", issued: 0 });
+const blank = (): Entry => ({ file: null, draft: "", diff: "", error: "", errorCode: "", missing: false, pending: "", issued: 0 });
const dirty = (entry: Entry) => !!entry.file && entry.draft !== entry.file.content;
export function useWorkbenchFiles({ port, workspaceRoot, repos = [], path, openPaths, shown, refresh, poll }: {
@@ -59,12 +61,19 @@ export function useWorkbenchFiles({ port, workspaceRoot, repos = [], path, openP
entry.file = file;
entry.draft = file.content;
entry.error = "";
+ entry.errorCode = "";
entry.missing = false;
if (!quiet) entry.diff = patch?.diff ?? "";
} catch (e) {
- if (valid() && !quiet) {
+ const code = e instanceof HttpError ? e.reason?.code ?? "" : "";
+ const unavailable = [WORKSPACE_FILE_MISSING, "workspace.root_not_granted", "workspace.preview_denied", "workspace.file_unreadable"].includes(code);
+ if (valid() && !dirty(entry) && (!quiet || unavailable)) {
+ changed = true;
entry.error = reason(e);
+ entry.errorCode = code;
entry.missing = e instanceof HttpError && e.reason?.code === WORKSPACE_FILE_MISSING;
+ entry.file = null;
+ entry.draft = "";
}
} finally {
if (valid()) { entry.pending = ""; if (changed) notify(); }
@@ -82,6 +91,32 @@ export function useWorkbenchFiles({ port, workspaceRoot, repos = [], path, openP
const timer = window.setInterval(() => { cancel = read(true) ?? cancel; }, 3000);
return () => { cancel?.(); window.clearInterval(timer); };
}, [read, poll, shown]);
+ const isDirty = dirty(entry), observedVersion = entry.file?.observedVersion, saving = entry.pending === "save";
+ useEffect(() => {
+ if (!shown || !isDirty || !observedVersion || saving) return;
+ const controller = new AbortController();
+ let busy = false;
+ const inspect = async () => {
+ if (busy) return;
+ busy = true;
+ try {
+ const held = parseGrantedFile(path);
+ const info = await port.workspacePreviewInfo({ path: held?.rel ?? path, root: held?.root }, controller.signal);
+ if (!controller.signal.aborted && info.version !== entry.file?.observedVersion) {
+ const error = t("磁盘内容已变化，未保存的编辑已保留");
+ if (entry.error !== error) { entry.error = error; notify(); }
+ }
+ } catch (e) {
+ if (!controller.signal.aborted) {
+ const error = reason(e);
+ if (entry.error !== error) { entry.error = error; notify(); }
+ }
+ } finally { busy = false; }
+ };
+ void inspect();
+ const timer = window.setInterval(() => void inspect(), 3000);
+ return () => { controller.abort(); window.clearInterval(timer); };
+ }, [port, entry, path, shown, refresh, isDirty, observedVersion, saving, notify]);
const setDraft = (draft: string) => {
if (current.current !== entries || !entry.file || entry.file.readOnly) return;
diff --git a/desktop/frontend-next/src/ui/view-switch.interaction.test.tsx b/desktop/frontend-next/src/ui/view-switch.interaction.test.tsx
index 09c3c7bbb6..4e944111dd 100644
--- a/desktop/frontend-next/src/ui/view-switch.interaction.test.tsx
+++ b/desktop/frontend-next/src/ui/view-switch.interaction.test.tsx
@@ -1,6 +1,6 @@
// @vitest-environment jsdom
import { afterEach, describe, expect, it, vi } from "vitest";
-import { cleanup, render, screen, waitFor } from "@testing-library/react";
+import { cleanup, fireEvent, render, screen, waitFor } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import "./testkit";
import { App } from "./App";
@@ -53,7 +53,10 @@ describe("the window bar's view switch", () => {
it("names its buttons by label and shortcut, not by icon alone", async () => {
render();
const button = await screen.findByRole("button", { name: "工作台" });
- expect(button.getAttribute("title")).toMatch(/工作台\s+(Ctrl 3|⌘3)/);
+ fireEvent.focus(button);
+ const tip = document.querySelector(".icon-tooltip");
+ expect(tip?.textContent).toContain("工作台");
+ expect(tip?.querySelector("kbd")?.textContent).toMatch(/Ctrl 3|⌘3/);
expect(button.getAttribute("aria-keyshortcuts")).toBeTruthy();
});
});
diff --git a/desktop/frontend-next/src/ui/workbench-missing-file.interaction.test.tsx b/desktop/frontend-next/src/ui/workbench-missing-file.interaction.test.tsx
index df788ac8d6..792d1e96f0 100644
--- a/desktop/frontend-next/src/ui/workbench-missing-file.interaction.test.tsx
+++ b/desktop/frontend-next/src/ui/workbench-missing-file.interaction.test.tsx
@@ -1,5 +1,5 @@
// @vitest-environment jsdom
-import { cleanup, render, screen, waitFor } from "@testing-library/react";
+import { cleanup, fireEvent, render, screen, waitFor } from "@testing-library/react";
import { afterEach, expect, it, vi } from "vitest";
import { MockPort } from "../port/mock";
import { WorkbenchPanel } from "./WorkbenchPanel";
@@ -40,7 +40,7 @@ it("does not open a preview page for an HTML file that cannot be read", async ()
expect(open).not.toHaveBeenCalled();
});
-it("still previews an HTML file the editor cannot read, such as one over the size limit", async () => {
+it("allows explicit interactive opening when static HTML exceeds its limit", async () => {
const port = new MockPort();
vi.spyOn(port, "workspaceFiles").mockResolvedValue({ files: ["big.html"], directories: [] });
vi.spyOn(port, "workspaceFile").mockRejectedValue(new HttpError(400, "unreadable", { code: "workspace.file_unreadable" }));
@@ -51,5 +51,21 @@ it("still previews an HTML file the editor cannot read, such as one over the siz
const open = vi.spyOn(port, "browserOpen").mockResolvedValue({ id: "p", target: "t", url: "file:///one/big.html", title: "", active: false });
const view = render();
view.rerender();
+ fireEvent.click(await screen.findByRole("button", { name: "交互运行" }));
await waitFor(() => expect(open).toHaveBeenCalled());
});
+
+it("shows metadata and a typed error for an unknown binary instead of an editor", async () => {
+ const port = new MockPort();
+ vi.spyOn(port, "workspaceFiles").mockResolvedValue({ files: ["opaque.data"], directories: [] });
+ vi.spyOn(port, "workspaceFile").mockRejectedValue(new HttpError(400, "unreadable", { code: "workspace.file_unreadable" }));
+ vi.spyOn(port, "workspacePreviewInfo").mockResolvedValue({
+ ref: { path: "opaque.data" }, kind: "text", size: 128, limit: 2 << 20, version: "v1", readOnly: false,
+ });
+ vi.spyOn(port, "workspacePreviewContent").mockRejectedValue(new HttpError(415, "binary", { code: "workspace.preview_not_text" }));
+ const view = render();
+ view.rerender();
+ await waitFor(() => expect(document.querySelector(".document-preview [role=alert]")?.textContent).toContain("文本"));
+ expect(screen.getByText("128 B")).toBeTruthy();
+ expect(document.querySelector(".cm-content")).toBeNull();
+});
diff --git a/desktop/frontend-next/src/ui/workbench-opening-lifetime.interaction.test.tsx b/desktop/frontend-next/src/ui/workbench-opening-lifetime.interaction.test.tsx
index d04bcbb8d4..918dfd4d1f 100644
--- a/desktop/frontend-next/src/ui/workbench-opening-lifetime.interaction.test.tsx
+++ b/desktop/frontend-next/src/ui/workbench-opening-lifetime.interaction.test.tsx
@@ -23,6 +23,7 @@ it.each(['event-first', 'reply-first'])('preserves newer Files when preview work
const open = vi.spyOn(port,'browserOpen').mockReturnValue(new Promise((_,reject)=>{fail=reject;}));
const {rerender} = render();
fireEvent.click(await screen.findByRole('button',{name:'index.html'}));
+ fireEvent.click(await screen.findByRole('button',{name:'交互运行'}));
await waitFor(()=>expect(workspaces).toHaveBeenCalled());
expect(open).not.toHaveBeenCalled();
fireEvent.click(document.querySelector('[data-action="workbench.files"]')!);
@@ -57,6 +58,7 @@ it('does not start a preview after its file read finishes behind a newer Files s
const open = vi.spyOn(port, 'browserOpen').mockResolvedValue(page);
render();
fireEvent.click(await screen.findByRole('button',{name:'index.html'}));
+ fireEvent.click(await screen.findByRole('button',{name:'交互运行'}));
await waitFor(()=>expect(reading).toHaveBeenCalled());
fireEvent.click(document.querySelector('[data-action="workbench.files"]')!);
await act(async()=>read({path:'index.html',content:'hello',revision:'r1'}));
@@ -76,6 +78,7 @@ it('follows a genuine agent tab while an older preview is still preparing its wo
const open = vi.spyOn(port, 'browserOpen').mockResolvedValue(page);
const {rerender} = render();
fireEvent.click(await screen.findByRole('button',{name:'index.html'}));
+ fireEvent.click(await screen.findByRole('button',{name:'交互运行'}));
await waitFor(()=>expect(lookup).toHaveBeenCalled());
fireEvent.click(document.querySelector('[data-action="workbench.files"]')!);
const fresh = {...agent,id:'fresh',target:'tf',title:'Fresh',active:false};
diff --git a/desktop/frontend-next/src/ui/workbench_tree.ts b/desktop/frontend-next/src/ui/workbench_tree.ts
new file mode 100644
index 0000000000..4e709f995e
--- /dev/null
+++ b/desktop/frontend-next/src/ui/workbench_tree.ts
@@ -0,0 +1,62 @@
+type TreeRow = {
+ kind: "folder" | "file";
+ path: string;
+ name: string;
+ depth: number;
+};
+
+/** Folders first at every level, with the tree still reading as a tree. Sorting
+ * flat paths as text interleaves `bin/` with `boot.test.exe`, because text is
+ * the only thing it compares. Segment by segment, whichever row is a directory
+ * where the two paths part wins there, and its children stay under it. */
+function before(a: TreeRow, b: TreeRow): number {
+ const x = a.path.split("/"), y = b.path.split("/");
+ for (let i = 0; i < Math.min(x.length, y.length); i++) {
+ if (x[i] === y[i]) continue;
+ const dirs = [i < x.length - 1 || a.kind === "folder", i < y.length - 1 || b.kind === "folder"];
+ return dirs[0] === dirs[1] ? x[i].localeCompare(y[i]) : dirs[0] ? -1 : 1;
+ }
+ return x.length - y.length;
+}
+
+export function treeRows(
+ files: string[],
+ directories: string[],
+ query: string,
+ closed: Set,
+): TreeRow[] {
+ const matches = query
+ ? files.filter((path) =>
+ path.toLocaleLowerCase().includes(query.toLocaleLowerCase()),
+ )
+ : files;
+ const folders = new Set(directories);
+ for (const path of matches)
+ for (let i = 1, bits = path.split("/"); i < bits.length; i++)
+ folders.add(bits.slice(0, i).join("/"));
+ const hidden = (path: string) =>
+ [...closed].some(
+ (folder) => path === folder || path.startsWith(`${folder}/`),
+ );
+ const rows: TreeRow[] = [...folders]
+ .filter(
+ (path) => ![...closed].some((parent) => path.startsWith(`${parent}/`)),
+ )
+ .map((path) => ({
+ kind: "folder",
+ path,
+ name: path.split("/").at(-1)!,
+ depth: path.split("/").length - 1,
+ }));
+ rows.push(
+ ...matches
+ .filter((path) => !hidden(path.split("/").slice(0, -1).join("/")))
+ .map((path) => ({
+ kind: "file" as const,
+ path,
+ name: path.split("/").at(-1)!,
+ depth: path.split("/").length - 1,
+ })),
+ );
+ return rows.sort(before);
+}
diff --git a/desktop/frontend-next/tools/pdf-assets.ts b/desktop/frontend-next/tools/pdf-assets.ts
new file mode 100644
index 0000000000..694f85019e
--- /dev/null
+++ b/desktop/frontend-next/tools/pdf-assets.ts
@@ -0,0 +1,33 @@
+import { readFileSync, readdirSync } from "node:fs";
+import { dirname, join } from "node:path";
+import { createRequire } from "node:module";
+import type { Plugin } from "vite";
+
+export function pdfAssets(): Plugin {
+ const require = createRequire(import.meta.url);
+ const root = dirname(require.resolve("pdfjs-dist/package.json"));
+ const files = new Map();
+ for (const dir of ["cmaps", "standard_fonts", "wasm"]) {
+ for (const name of readdirSync(join(root, dir))) files.set(`pdfjs/${dir}/${name}`, join(root, dir, name));
+ }
+ files.set("pdfjs/LICENSE", join(root, "LICENSE"));
+ files.set("licenses/papaparse.txt", join(dirname(require.resolve("papaparse")), "LICENSE"));
+ const purify = dirname(dirname(require.resolve("dompurify")));
+ files.set("licenses/dompurify.txt", join(purify, "LICENSE"));
+ files.set("licenses/dompurify-mpl.txt", join(purify, "LICENSE-MPL"));
+ files.set("licenses/lucide-react.txt", join(dirname(require.resolve("lucide-react/package.json")), "LICENSE"));
+ return {
+ name: "pdf-local-assets",
+ generateBundle() {
+ for (const [fileName, path] of files) this.emitFile({ type: "asset", fileName, source: readFileSync(path) });
+ },
+ configureServer(server) {
+ server.middlewares.use((req, res, next) => {
+ const path = files.get((req.url ?? "").split("?")[0].replace(/^\//, ""));
+ if (!path) return next();
+ res.setHeader("Content-Type", path.endsWith(".wasm") ? "application/wasm" : "application/octet-stream");
+ res.end(readFileSync(path));
+ });
+ },
+ };
+}
diff --git a/desktop/frontend-next/vite.config.ts b/desktop/frontend-next/vite.config.ts
index 92d045cd7d..e7b91d95c5 100644
--- a/desktop/frontend-next/vite.config.ts
+++ b/desktop/frontend-next/vite.config.ts
@@ -1,5 +1,6 @@
import { defineConfig, loadEnv } from "vite";
import react from "@vitejs/plugin-react";
+import { pdfAssets } from "./tools/pdf-assets.ts";
interface ProxyEvents {
on(event: "proxyReq", cb: (req: { setHeader(k: string, v: string): void }) => void): void;
@@ -36,7 +37,7 @@ export default defineConfig(({ mode }) => {
const serve = loadEnv(mode, ".", "REASONIX").REASONIX_SERVE;
return {
base: "./",
- plugins: [react()],
+ plugins: [react(), pdfAssets()],
// Stylesheets are stubbed for tests by default, `?raw` included, so a
// guard that reads app.css to check a rule gets an empty string and passes
// on nothing. Processing it is what makes that guard able to fail.
diff --git a/docs/FILE_PREVIEW.md b/docs/FILE_PREVIEW.md
new file mode 100644
index 0000000000..b6c37035fd
--- /dev/null
+++ b/docs/FILE_PREVIEW.md
@@ -0,0 +1,67 @@
+---
+owner: @SivanCola
+backup: @esengine
+status: active
+reviewed: 2026-10-21
+---
+
+# File delivery and preview / 文件交付与预览
+
+`present_files` declares one to four existing files. The host validates every
+file before returning a versioned result; failure publishes no delivery cards.
+The declaration identifies deliverables, not verified completion.
+
+`present_files` 每次声明一到四个现有文件。宿主全部校验成功后才产生交付卡片；
+声明交付文件不等于验证内容正确，也不替代任务完成判定。
+
+## Reading / 阅读
+
+| Format / 格式 | View / 展示 | Limit / 限额 |
+| --- | --- | --- |
+| Markdown, MDX | Rendered Markdown; JSX is not executed / Markdown 正文，不执行 JSX | 2 MiB |
+| Text, code / 文本、代码 | Existing source editor / 原有源码编辑器 | 2 MiB |
+| CSV, TSV | Worker parsing, virtual rows and columns / Worker 解析、虚拟表格 | 2 MiB, 100,000 cells / 单元格 |
+| HTML | Sanitized, sandboxed static iframe / 清理后的静态沙箱预览 | 2 MiB |
+| PDF | Local PDF.js worker, page controls, zoom, selectable text / 本地阅读器、分页、缩放、文字选择 | 32 MiB |
+| Images / 图片 | Image element with zoom / 图片缩放 | 10 MiB |
+| Office, archives, binaries / Office、压缩包、二进制 | Information and available actions / 文件信息与可用操作 | No inline preview / 无内联预览 |
+
+The workspace tree, message links and cards share workbench tabs. Full references
+include the authorized root and relative path; display names do not identify files.
+Open records read the source file's current content, without version snapshots.
+
+文件树、消息链接和卡片复用工作台标签。文件身份包含授权根目录和相对路径，
+不能以显示名称去重。历史交付记录读取源文件当前内容，不保存版本快照。
+
+Cards use two columns at a container width of 720 CSS pixels, otherwise one.
+The More menu contains copy, attachment and supported native actions. The current
+marker follows the actual visible workbench file. Type icons do not imply support.
+
+卡片容器达到 720 CSS 像素时显示两列，否则显示一列。“更多”菜单提供复制路径、
+添加到对话及宿主支持的原生操作。“查看中”跟随实际可见文件；图标不代表预览能力。
+
+## Boundaries / 边界
+
+- Controller preview APIs use the shared bounded, root-confined file service.
+ 内容采用原始字节读取，不通过 JSON/base64 传输 PDF。
+- Root confinement remains enforced on the opened descriptor. Missing, denied,
+ non-regular, oversized and non-text files have typed errors.
+ 文件缺失、拒绝访问、非普通文件、超限和非文本均有独立错误码。
+- HTML scripts, submission, redirects and external resources are blocked.
+ 本地桌面可显式选择已有的“交互运行”；远程页面不能调用本机系统打开。
+- Only host-confirmed successful presenter results project to cards. Live and
+ restored projections use the original tool history, including full raw results.
+ 普通工具输出相同 JSON 不会产生交付卡片，失败和拒绝调用也不会产生成功卡片。
+- Visible binary previews inspect metadata every three seconds and reload bytes
+ only on change. Obsolete requests are aborted or discarded.
+ 可见二进制预览约每三秒检查元数据，变化后才读取正文；旧请求会取消或丢弃。
+- Saved text disappears after a typed missing/denied response. Dirty drafts stay
+ intact and show the observation failure; saving still checks revisions.
+ 文件删除或撤权后清除旧的已保存正文，未保存草稿仍保留，并继续使用保存冲突检查。
+
+New `deliveries` and `observedVersion` fields are optional. Old histories remain
+readable; older clients keep the ordinary tool result. Tool schemas stay stable
+within a run, while adding the capability changes the upgrade-time catalog.
+
+新增字段均可缺省；旧会话仍可读取，旧客户端仍显示普通工具结果。
+运行期间工具定义不变；升级时新增能力会改变工具目录，可能造成一次缓存失效。
diff --git a/docs/STUDIO_PARITY.md b/docs/STUDIO_PARITY.md
index 7ba12a4cdf..70640763d4 100644
--- a/docs/STUDIO_PARITY.md
+++ b/docs/STUDIO_PARITY.md
@@ -90,7 +90,8 @@ Checked against `studio` at `d779d89bc` on 2026-10-08.
| Worktree merge dialog | Unverified | Worktree handling exists in `ui/Workspaces.tsx`; the merge flow was not checked |
| Scheduled tasks (heartbeat) | Missing | #11384 |
| Keyboard shortcuts cheat sheet | Unverified | Key handling is in `ui/keys.ts`, `ui/windowkeys.ts`; no cheat sheet found by name; no issue yet |
-| CSV and media preview in the workspace panel | Unverified | `ui/WorkbenchPanel.tsx` and `ui/CodeEditor.tsx` exist; file kinds not checked |
+| CSV and media preview in the workspace panel | Have differently | `ui/document`: CSV/TSV, PDF and still images render in the workbench; audio/video remain unsupported. CSV/TSV、PDF 和图片可直接阅读，音视频仍不支持内联预览。 |
+| File delivery cards / 文件交付卡片 | Have | `present_files` and `ui/document/DeliveryCard.tsx`: validated file references reopen in the shared workbench; auxiliary actions live in More. 已验证文件引用复用工作台标签，辅助操作位于“更多”。 |
| IM gateway (WeChat, Feishu, QQ) | Removed on purpose | Commit `f352dfbec` "remove the IM bot gateway"; `docs/MIGRATING.md` keeps the `[bot]` section untouched; #11952 asks for it back |
## Rows added by Studio
diff --git a/docs/TOOL_CONTRACT.md b/docs/TOOL_CONTRACT.md
index 638cd70253..402900576b 100644
--- a/docs/TOOL_CONTRACT.md
+++ b/docs/TOOL_CONTRACT.md
@@ -9,6 +9,25 @@ reviewed: 2026-09-29
This document records the provider-visible contract for Reasonix compile-time built-in tools. It is generated from the same canonical schema path used by the runtime registry.
+`present_files` declares up to four existing files in the workspace or authorized folders.
+Its versioned result remains in the canonical tool history; live and restored cards use
+the host-confirmed capability identity and the complete result, even when model context
+is shortened.
+
+Opening a card reads the current source file, not an immutable snapshot.
+It does not certify task completion and is not admitted by the Observe posture.
+
+`present_files` 每次声明最多四个工作区或已授权目录中的现有文件。有版本的结果保存在原始工具历史中；
+实时与恢复后的卡片使用宿主确认的能力身份和完整结果，不依赖模型上下文是否被压缩。
+点击卡片读取源文件当前内容，不保存版本快照，不构成任务完成证明，也不进入 Observe 模式。
+
+The complete builtin schema inventory grows from 7,185 to 7,328 measured tokens
+for this new capability. Boot effect tests cover direct and capability-proxy calls
+and verify that tool schemas remain unchanged within a turn.
+
+新增能力使完整内置工具 schema 的实测预算从 7,185 增至 7,328 tokens；
+Boot 效果测试覆盖直接调用和能力代理调用，并验证同一轮内工具 schema 不变。
+
| Tool | Read-only | Description |
| --- | --- | --- |
| `bash` | false | Execute a command in the shell and return combined stdout/stderr. Use for builds, tests, git, package managers, etc. To read or modify a file use read_file / edit_file / write_file — never Get-Content, cat, sed, head/tail or a shell redirect. read_file returns up to 2000 lines per call, each prefixed with its line number, and those numbers are what edit_file targets; paging a file through the shell instead costs one round trip per chunk and yields no line anchors. |
@@ -33,6 +52,7 @@ This document records the provider-visible contract for Reasonix compile-time bu
| `move_file` | false | Move or rename a file from source_path to destination_path. Creates the destination parent directory as needed. Use instead of shell mv, Move-Item, or ren for file moves so workspace confinement and file-edit permissions apply. |
| `multi_edit` | false | Apply a list of edits to a single file atomically: each edit runs against the result of the previous one, all in memory; the file is rewritten only if every edit succeeds. Cheaper and safer than chaining edit_file calls — a failure in step 3 leaves the file untouched instead of half-edited. |
| `notebook_edit` | false | Edit one cell of a Jupyter notebook (.ipynb). Target a cell by 0-based cell_number (or cell_id). edit_mode: "replace" (default) swaps the cell's source; "insert" adds a new cell after cell_number (use -1 to prepend at the top), taking cell_type and new_source; "delete" removes the cell. cell_type is "code" or "markdown" (required for insert). Editing a code cell clears its outputs. Prefer this over edit_file for notebooks — it keeps the JSON valid. |
+| `present_files` | true | Present existing final files as clickable cards, including shell-created documents. Paths must be in the workspace or authorized folders. Opens current files, not snapshots; does not certify correctness. |
| `read_file` | true | Read a text file with optional line offset/limit. Output prefixes each line with its 1-based number (e.g. ` 42→...`) so subsequent edit_file calls can target exact lines. Use `offset` and `limit` to page through large files; the tool reports total length and pagination hints in a trailer. |
| `read_video` | true | Look at a video: native if the model watches video, else ffmpeg frames. |
| `recall` | true | Bring folded conversation back: read the #n positions listed under "Folded work index" in a compaction summary, or search the whole folded region by query when no index line names what you need. Prefer re-reading a file over recalling it — a current copy beats a folded one. One budget per compaction covers both, and a request past it is refused whole, not truncated. |
diff --git a/docs/assets/file-delivery/dark.jpg b/docs/assets/file-delivery/dark.jpg
new file mode 100644
index 0000000000..fdd615eaf7
Binary files /dev/null and b/docs/assets/file-delivery/dark.jpg differ
diff --git a/docs/assets/file-delivery/light.jpg b/docs/assets/file-delivery/light.jpg
new file mode 100644
index 0000000000..8b3052a033
Binary files /dev/null and b/docs/assets/file-delivery/light.jpg differ
diff --git a/docs/assets/file-delivery/phone.jpg b/docs/assets/file-delivery/phone.jpg
new file mode 100644
index 0000000000..0414e03f84
Binary files /dev/null and b/docs/assets/file-delivery/phone.jpg differ
diff --git a/internal/assembly/boot/effect_present_files_test.go b/internal/assembly/boot/effect_present_files_test.go
new file mode 100644
index 0000000000..60a397ab82
--- /dev/null
+++ b/internal/assembly/boot/effect_present_files_test.go
@@ -0,0 +1,89 @@
+package boot
+
+import (
+ "context"
+ "reflect"
+ "testing"
+ "time"
+
+ "reasonix/internal/contract/event"
+ "reasonix/internal/contract/eventwire"
+ "reasonix/internal/contract/provider"
+ "reasonix/internal/runtime/agent/testutil"
+ "reasonix/internal/session/control"
+)
+
+func TestEffectPresentFilesSurvivesTheRealToolPipeline(t *testing.T) {
+ for _, proxy := range []bool{false, true} {
+ name := "direct"
+ if proxy {
+ name = "capability"
+ }
+ t.Run(name, func(t *testing.T) { presentFilesEffect(t, proxy) })
+ }
+}
+
+func presentFilesEffect(t *testing.T, proxy bool) {
+ t.Helper()
+ isolateConfigHome(t)
+ dir := robustTempDir(t)
+ t.Chdir(dir)
+ registerBootTokenProfileTestProvider()
+ call := provider.ToolCall{ID: "present", Name: "present_files", Arguments: `{"files":[{"path":"report.md","description":"Report"}]}`}
+ if proxy {
+ call.Name = "use_capability"
+ call.Arguments = `{"action":"call","capability_id":"tool:present_files","arguments":{"files":[{"path":"report.md","description":"Report"}]}}`
+ }
+ prov := testutil.NewMock("present-files",
+ testutil.Turn{ToolCalls: []provider.ToolCall{call}},
+ testutil.Turn{Text: "Done."},
+ )
+ setBootTokenProfileTestProvider(t, prov)
+ writeFile(t, dir, "reasonix.toml", "default_model = \"test-model\"\n[[providers]]\nname = \"test-model\"\nkind = \"boot-token-profile-test\"\nmodel = \"x\"\n")
+ writeFile(t, dir, "report.md", "# Report")
+ approveWorkspace(t, dir)
+ events := make(chan event.Event, 1000)
+ ctrl, err := Build(context.Background(), Options{WorkspaceRoot: dir, Sink: event.FuncSink(func(e event.Event) { events <- e })})
+ if err != nil {
+ t.Fatal(err)
+ }
+ t.Cleanup(ctrl.Close)
+ if err := ctrl.NewSession(); err != nil {
+ t.Fatal(err)
+ }
+ ctrl.SetToolApprovalMode(control.ToolApprovalYolo)
+ ctx, cancel := context.WithTimeout(context.Background(), 20*time.Second)
+ defer cancel()
+ if err := ctrl.Run(ctx, "Present the existing report.md file."); err != nil {
+ t.Fatal(err)
+ }
+ found := false
+ for len(events) > 0 {
+ e := <-events
+ if e.Kind == event.ToolResult && e.Tool.ID == "present" {
+ wire := eventwire.ToWire(e)
+ if wire.Tool == nil || len(wire.Tool.Deliveries) != 1 {
+ t.Fatalf("delivery did not reach UI: %+v, output %q", e.Tool, e.Tool.Output)
+ }
+ found = true
+ }
+ }
+ if !found {
+ t.Fatal("present tool result missing")
+ }
+ found = false
+ for _, message := range ctrl.History() {
+ for _, call := range message.ToolCalls {
+ if call.ID == "present" && call.CapabilityID == "tool:present_files" {
+ found = true
+ }
+ }
+ }
+ if !found {
+ t.Fatal("host-confirmed identity was not persisted")
+ }
+ requests := prov.Requests()
+ if len(requests) < 2 || !reflect.DeepEqual(requests[0].Tools, requests[1].Tools) {
+ t.Fatal("delivery changed the tool schema within the turn")
+ }
+}
diff --git a/internal/base/workspacefile/file.go b/internal/base/workspacefile/file.go
new file mode 100644
index 0000000000..12cf1063cb
--- /dev/null
+++ b/internal/base/workspacefile/file.go
@@ -0,0 +1,234 @@
+// Package workspacefile provides bounded, root-confined document reads.
+package workspacefile
+
+import (
+ "context"
+ "errors"
+ "fmt"
+ "io"
+ "io/fs"
+ "os"
+ "path/filepath"
+ "strconv"
+ "strings"
+ "unicode/utf8"
+)
+
+const (
+ TextLimit = 2 << 20
+ ImageLimit = 10 << 20
+ PDFLimit = 32 << 20
+)
+
+var (
+ ErrDenied = errors.New("file is outside authorized roots")
+ ErrMissing = errors.New("file does not exist")
+ ErrNotFile = errors.New("not a regular file")
+ ErrTooLarge = errors.New("file exceeds preview limit")
+ ErrNotText = errors.New("file is not UTF-8 text")
+ ErrUnsupported = errors.New("file format has no preview")
+ ErrChanged = errors.New("file changed during preview read")
+)
+
+type Ref struct {
+ Path string `json:"path"`
+ Root string `json:"root,omitempty"`
+}
+
+type Info struct {
+ Ref Ref `json:"ref"`
+ Kind string `json:"kind"`
+ Size int64 `json:"size"`
+ Version string `json:"version"`
+ Limit int64 `json:"limit"`
+ ReadOnly bool `json:"readOnly"`
+}
+
+// Service receives roots already authorized by its host.
+type Service struct {
+ Primary string
+ Extra []string
+}
+
+func (s Service) Resolve(path string) (Ref, error) {
+ if !filepath.IsAbs(path) {
+ if !filepath.IsLocal(path) {
+ return Ref{}, ErrDenied
+ }
+ return Ref{Path: filepath.ToSlash(filepath.Clean(path))}, nil
+ }
+ for _, root := range append([]string{s.Primary}, s.Extra...) {
+ rel, err := filepath.Rel(root, path)
+ if err == nil && filepath.IsLocal(rel) {
+ ref := Ref{Path: filepath.ToSlash(rel)}
+ if filepath.Clean(root) != filepath.Clean(s.Primary) {
+ ref.Root = root
+ }
+ return ref, nil
+ }
+ }
+ return Ref{}, ErrDenied
+}
+
+func (s Service) open(ref Ref) (*os.File, error) {
+ path := filepath.FromSlash(ref.Path)
+ if !filepath.IsLocal(path) || path == "." {
+ return nil, ErrDenied
+ }
+ base := s.Primary
+ if ref.Root != "" && filepath.Clean(ref.Root) != filepath.Clean(base) {
+ found := false
+ for _, extra := range s.Extra {
+ if filepath.Clean(extra) == filepath.Clean(ref.Root) {
+ base, found = extra, true
+ break
+ }
+ }
+ if !found {
+ return nil, ErrDenied
+ }
+ }
+ root, err := os.OpenRoot(base)
+ if err != nil {
+ return nil, classify(err)
+ }
+ defer root.Close()
+ resolvedBase, err := filepath.EvalSymlinks(base)
+ if err != nil {
+ return nil, classify(err)
+ }
+ target, err := filepath.EvalSymlinks(filepath.Join(base, path))
+ if err != nil {
+ return nil, classify(err)
+ }
+ relative, err := filepath.Rel(resolvedBase, target)
+ if err != nil || !filepath.IsLocal(relative) {
+ return nil, ErrDenied
+ }
+ // Stat before opening excludes FIFOs and devices, which may block on open.
+ info, err := root.Stat(path)
+ if err != nil {
+ return nil, classify(err)
+ }
+ if !info.Mode().IsRegular() {
+ return nil, ErrNotFile
+ }
+ file, err := root.OpenFile(path, os.O_RDONLY|nonblock, 0)
+ if err != nil {
+ return nil, classify(err)
+ }
+ info, err = file.Stat()
+ if err != nil || !info.Mode().IsRegular() {
+ file.Close()
+ if err != nil {
+ return nil, classify(err)
+ }
+ return nil, ErrNotFile
+ }
+ return file, nil
+}
+
+func classify(err error) error {
+ if errors.Is(err, fs.ErrNotExist) {
+ return fmt.Errorf("%w: %w", ErrMissing, err)
+ }
+ if errors.Is(err, fs.ErrPermission) {
+ return fmt.Errorf("%w: %w", ErrDenied, err)
+ }
+ return err
+}
+
+func metadata(ref Ref, info fs.FileInfo) Info {
+ kind, limit := Format(ref.Path)
+ return Info{Ref: ref, Kind: kind, Size: info.Size(), Limit: limit, ReadOnly: ref.Root != "",
+ Version: strconv.FormatInt(info.ModTime().UnixNano(), 10) + ":" + strconv.FormatInt(info.Size(), 10)}
+}
+
+func (s Service) Info(ctx context.Context, ref Ref) (Info, error) {
+ if err := ctx.Err(); err != nil {
+ return Info{}, err
+ }
+ f, err := s.open(ref)
+ if err != nil {
+ return Info{}, err
+ }
+ defer f.Close()
+ info, err := f.Stat()
+ if err != nil {
+ return Info{}, err
+ }
+ return metadata(ref, info), nil
+}
+
+func (s Service) Content(ctx context.Context, ref Ref) ([]byte, Info, error) {
+ return s.content(ctx, ref, false)
+}
+
+func (s Service) Text(ctx context.Context, ref Ref) ([]byte, Info, error) {
+ return s.content(ctx, ref, true)
+}
+
+func (s Service) content(ctx context.Context, ref Ref, textOnly bool) ([]byte, Info, error) {
+ if err := ctx.Err(); err != nil {
+ return nil, Info{}, err
+ }
+ f, err := s.open(ref)
+ if err != nil {
+ return nil, Info{}, err
+ }
+ defer f.Close()
+ before, err := f.Stat()
+ if err != nil {
+ return nil, Info{}, err
+ }
+ info := metadata(ref, before)
+ if textOnly {
+ info.Kind, info.Limit = "text", TextLimit
+ }
+ if info.Kind == "unsupported" {
+ return nil, info, ErrUnsupported
+ }
+ if info.Size > info.Limit {
+ return nil, info, ErrTooLarge
+ }
+ data, err := io.ReadAll(io.LimitReader(f, info.Limit+1))
+ if err != nil {
+ return nil, info, err
+ }
+ if err := ctx.Err(); err != nil {
+ return nil, info, err
+ }
+ if int64(len(data)) > info.Limit {
+ return nil, info, ErrTooLarge
+ }
+ after, err := f.Stat()
+ if err != nil {
+ return nil, info, err
+ }
+ if metadata(ref, after).Version != info.Version {
+ return nil, info, ErrChanged
+ }
+ if info.Kind != "pdf" && info.Kind != "image" && (!utf8.Valid(data) || strings.IndexByte(string(data), 0) >= 0) {
+ return nil, info, ErrNotText
+ }
+ return data, info, nil
+}
+
+func Format(path string) (string, int64) {
+ switch strings.ToLower(filepath.Ext(path)) {
+ case ".md", ".markdown", ".mdx":
+ return "markdown", TextLimit
+ case ".html", ".htm":
+ return "html", TextLimit
+ case ".csv", ".tsv":
+ return "table", TextLimit
+ case ".pdf":
+ return "pdf", PDFLimit
+ case ".png", ".jpg", ".jpeg", ".gif", ".webp", ".avif", ".bmp", ".ico", ".svg":
+ return "image", ImageLimit
+ case ".doc", ".docx", ".xls", ".xlsx", ".ppt", ".pptx", ".zip", ".gz", ".7z", ".rar", ".exe", ".dll", ".bin":
+ return "unsupported", 0
+ default:
+ return "text", TextLimit
+ }
+}
diff --git a/internal/base/workspacefile/file_test.go b/internal/base/workspacefile/file_test.go
new file mode 100644
index 0000000000..662c24cd63
--- /dev/null
+++ b/internal/base/workspacefile/file_test.go
@@ -0,0 +1,89 @@
+package workspacefile
+
+import (
+ "context"
+ "errors"
+ "os"
+ "path/filepath"
+ "testing"
+)
+
+func TestPreviewReadsBytesAndRefusesEscape(t *testing.T) {
+ root := t.TempDir()
+ data := []byte("%PDF-1.7\n\x00binary")
+ if err := os.WriteFile(filepath.Join(root, "报告.pdf"), data, 0o600); err != nil {
+ t.Fatal(err)
+ }
+ s := Service{Primary: root}
+ info, err := s.Info(context.Background(), Ref{Path: "报告.pdf"})
+ if err != nil || info.Kind != "pdf" || info.Size != int64(len(data)) {
+ t.Fatalf("info = %+v, %v", info, err)
+ }
+ got, _, err := s.Content(context.Background(), info.Ref)
+ if err != nil || string(got) != string(data) {
+ t.Fatalf("read = %q, %v", got, err)
+ }
+ for _, ref := range []Ref{{Path: "../secret"}, {Root: t.TempDir(), Path: "x"}} {
+ if _, err := s.Info(context.Background(), ref); !errors.Is(err, ErrDenied) {
+ t.Fatalf("escape = %v", err)
+ }
+ }
+ outside := t.TempDir()
+ if err := os.WriteFile(filepath.Join(outside, "secret.txt"), []byte("secret"), 0o600); err != nil {
+ t.Fatal(err)
+ }
+ if err := os.Symlink(outside, filepath.Join(root, "link")); err == nil {
+ if _, err := s.Info(context.Background(), Ref{Path: "link/secret.txt"}); err == nil {
+ t.Fatal("symlink escaped root")
+ }
+ }
+}
+
+func TestPreviewLimitsAndUnknownBinary(t *testing.T) {
+ root := t.TempDir()
+ s := Service{Primary: root}
+ for _, tc := range []struct {
+ name string
+ data []byte
+ want error
+ }{
+ {"big.txt", make([]byte, TextLimit+1), ErrTooLarge},
+ {"unknown.bin", []byte{0, 1, 2}, ErrUnsupported},
+ {"bad.txt", []byte{0xff, 0xfe}, ErrNotText},
+ } {
+ if err := os.WriteFile(filepath.Join(root, tc.name), tc.data, 0o600); err != nil {
+ t.Fatal(err)
+ }
+ if _, _, err := s.Content(context.Background(), Ref{Path: tc.name}); !errors.Is(err, tc.want) {
+ t.Errorf("%s: %v, want %v", tc.name, err, tc.want)
+ }
+ }
+ if _, err := s.Info(context.Background(), Ref{Path: "absent"}); !errors.Is(err, ErrMissing) {
+ t.Fatal(err)
+ }
+}
+
+func TestGrantedRootAndCancellation(t *testing.T) {
+ extra := t.TempDir()
+ if err := os.WriteFile(filepath.Join(extra, "notes.md"), []byte("# Notes"), 0o600); err != nil {
+ t.Fatal(err)
+ }
+ s := Service{Primary: t.TempDir(), Extra: []string{extra}}
+ ref, err := s.Resolve(filepath.Join(extra, "notes.md"))
+ if err != nil || ref.Root != extra || ref.Path != "notes.md" {
+ t.Fatalf("resolve = %+v, %v", ref, err)
+ }
+ info, err := s.Info(t.Context(), ref)
+ if err != nil || !info.ReadOnly {
+ t.Fatalf("grant = %+v, %v", info, err)
+ }
+ s.Extra = nil
+ if _, err := s.Info(t.Context(), ref); !errors.Is(err, ErrDenied) {
+ t.Fatalf("revoked grant = %v", err)
+ }
+ ctx, cancel := context.WithCancel(t.Context())
+ cancel()
+ if _, _, err := s.Content(ctx, ref); !errors.Is(err, context.Canceled) {
+ t.Fatalf("canceled read = %v", err)
+ }
+}
diff --git a/internal/base/workspacefile/open_unix.go b/internal/base/workspacefile/open_unix.go
new file mode 100644
index 0000000000..18da03f1b8
--- /dev/null
+++ b/internal/base/workspacefile/open_unix.go
@@ -0,0 +1,7 @@
+//go:build !windows
+
+package workspacefile
+
+import "syscall"
+
+const nonblock = syscall.O_NONBLOCK
diff --git a/internal/base/workspacefile/open_windows.go b/internal/base/workspacefile/open_windows.go
new file mode 100644
index 0000000000..5a1512bc17
--- /dev/null
+++ b/internal/base/workspacefile/open_windows.go
@@ -0,0 +1,3 @@
+package workspacefile
+
+const nonblock = 0
diff --git a/internal/contract/delivery/delivery.go b/internal/contract/delivery/delivery.go
new file mode 100644
index 0000000000..7fb58260d1
--- /dev/null
+++ b/internal/contract/delivery/delivery.go
@@ -0,0 +1,41 @@
+// Package delivery defines persisted file declarations and their UI projection.
+package delivery
+
+import (
+ "encoding/json"
+ "path/filepath"
+)
+
+const (
+ ToolName = "present_files"
+ Identity = "tool:present_files"
+ MaxFiles = 4
+)
+
+type File struct {
+ Path string `json:"path"`
+ Root string `json:"root,omitempty"`
+ Description string `json:"description,omitempty"`
+}
+
+type Result struct {
+ Version int `json:"version"`
+ Files []File `json:"files"`
+}
+
+// Decode requires the host's resolved builtin identity and a successful result.
+func Decode(name, identity string, failed bool, output string) []File {
+ if failed || name != ToolName || identity != Identity || len(output) > 32<<10 {
+ return nil
+ }
+ var result Result
+ if json.Unmarshal([]byte(output), &result) != nil || result.Version != 1 || len(result.Files) == 0 || len(result.Files) > MaxFiles {
+ return nil
+ }
+ for _, file := range result.Files {
+ if !filepath.IsLocal(filepath.FromSlash(file.Path)) || file.Path == "." || len(file.Description) > 1024 {
+ return nil
+ }
+ }
+ return result.Files
+}
diff --git a/internal/contract/delivery/delivery_test.go b/internal/contract/delivery/delivery_test.go
new file mode 100644
index 0000000000..b2bd3e4349
--- /dev/null
+++ b/internal/contract/delivery/delivery_test.go
@@ -0,0 +1,25 @@
+package delivery
+
+import "testing"
+
+func TestOnlyConfirmedPresenterResultsBecomeDeliveries(t *testing.T) {
+ body := `{"version":1,"files":[{"path":"docs/report.md","description":"Report"}]}`
+ if len(Decode("present_files", "tool:present_files", false, body)) != 1 {
+ t.Fatal("successful builtin delivery not decoded")
+ }
+ for _, tc := range []struct {
+ name, identity, output string
+ failed bool
+ }{
+ {"bash", "tool:bash", body, false},
+ {"present_files", "mcp-tool:server/present_files", body, false},
+ {"present_files", "", body, false},
+ {"present_files", "tool:present_files", body, true},
+ {"present_files", "tool:present_files", `{"version":2,"files":[{"path":"x"}]}`, false},
+ {"present_files", "tool:present_files", `{"version":1,"files":[{"path":"../secret"}]}`, false},
+ } {
+ if got := Decode(tc.name, tc.identity, tc.failed, tc.output); len(got) != 0 {
+ t.Fatalf("accepted %+v: %+v", tc, got)
+ }
+ }
+}
diff --git a/internal/contract/event/event.go b/internal/contract/event/event.go
index 141ea09e3a..2be3412097 100644
--- a/internal/contract/event/event.go
+++ b/internal/contract/event/event.go
@@ -13,6 +13,7 @@ package event
import (
"encoding/json"
+ "reasonix/internal/contract/delivery"
"reasonix/internal/contract/hostaudit"
"reasonix/internal/contract/pricing"
@@ -255,9 +256,10 @@ type Profile struct {
// Output/Err/Bound are filled in. Args is the raw JSON arguments — a sink
// compacts it for display.
type Tool struct {
- ID string
- Name string
- Args string
+ Deliveries []delivery.File
+ ID string
+ Name string
+ Args string
// ResolvedName/CapabilityID describe the real target behind a stable proxy
// while Name/Args remain the provider-visible call. They are optional local
// display metadata and never enter provider requests.
diff --git a/internal/contract/eventwire/wire.go b/internal/contract/eventwire/wire.go
index 73dbb01c92..1d2c3c1175 100644
--- a/internal/contract/eventwire/wire.go
+++ b/internal/contract/eventwire/wire.go
@@ -4,6 +4,7 @@ package eventwire
import (
"reasonix/internal/base/externalurl"
"reasonix/internal/contract/agentgraph"
+ "reasonix/internal/contract/delivery"
"reasonix/internal/contract/event"
"reasonix/internal/contract/pricing"
"reasonix/internal/contract/provider"
@@ -456,7 +457,8 @@ func toWireTool(t event.Tool) *Tool {
wt := &Tool{
ID: t.ID, Name: t.Name, Args: SurfaceArgs(t.Name, t.ResolvedName, t.Args),
ResolvedName: t.ResolvedName, CapabilityID: t.CapabilityID,
- Output: t.Output, Images: t.Images, Videos: toWireVideos(t.Videos), Err: t.Err, RefusalCode: t.RefusalCode,
+ Deliveries: t.Deliveries,
+ Output: t.Output, Images: t.Images, Videos: toWireVideos(t.Videos), Err: t.Err, RefusalCode: t.RefusalCode,
WorkspaceLease: toWireWorkspaceLease(t.WorkspaceLease),
OutputDiff: t.OutputDiff,
ReadOnly: t.ReadOnly, Truncated: t.Bound.Lossy(),
@@ -500,12 +502,13 @@ func toWireWorkspace(ws *event.WorkspaceChangedPayload) *WorkspaceChanged {
// Tool is the JSON form of an event.Tool.
type Tool struct {
- ID string `json:"id,omitempty"`
- Name string `json:"name"`
- Args string `json:"args,omitempty" externalizable:"true"`
- ResolvedName string `json:"resolvedName,omitempty"`
- CapabilityID string `json:"capabilityId,omitempty"`
- Output string `json:"output,omitempty" externalizable:"true"`
+ Deliveries []delivery.File `json:"deliveries,omitempty"`
+ ID string `json:"id,omitempty"`
+ Name string `json:"name"`
+ Args string `json:"args,omitempty" externalizable:"true"`
+ ResolvedName string `json:"resolvedName,omitempty"`
+ CapabilityID string `json:"capabilityId,omitempty"`
+ Output string `json:"output,omitempty" externalizable:"true"`
// Images the call showed the model, as data URLs.
Images []string `json:"images,omitempty"`
// Videos the call handed to the model to watch natively; the file's name and
diff --git a/internal/contract/tool/tool.go b/internal/contract/tool/tool.go
index f8c56c83ce..11cf9ff61c 100644
--- a/internal/contract/tool/tool.go
+++ b/internal/contract/tool/tool.go
@@ -34,6 +34,11 @@ type Tool interface {
ReadOnly() bool
}
+// FilePresenter marks the host implementation that validates file declarations.
+type FilePresenter interface {
+ FilePresentation()
+}
+
// ContextualTool is an execution-time availability contract for tools whose
// ownership depends on the active workflow context. Provider schemas remain
// static for cache stability; the host must still consult this contract before
diff --git a/internal/frontend/serve/history.go b/internal/frontend/serve/history.go
index efba150ab9..423901d33d 100644
--- a/internal/frontend/serve/history.go
+++ b/internal/frontend/serve/history.go
@@ -7,6 +7,7 @@ import (
"unicode/utf8"
"reasonix/internal/base/diff"
+ "reasonix/internal/contract/delivery"
"reasonix/internal/contract/event"
"reasonix/internal/contract/eventwire"
"reasonix/internal/contract/provider"
@@ -26,9 +27,10 @@ type historyToolCall struct {
}
type historyMessage struct {
- Role string `json:"role"`
- Content string `json:"content"`
- Reasoning string `json:"reasoning,omitempty"`
+ Deliveries []delivery.File `json:"deliveries,omitempty"`
+ Role string `json:"role"`
+ Content string `json:"content"`
+ Reasoning string `json:"reasoning,omitempty"`
// Images is how many attachments the turn carried, not the attachments
// themselves: a turn that was only an image has no text to rebuild from,
// and a reader that sees zero of both drops it as host chrome.
@@ -87,6 +89,7 @@ func historyMessagesWith(msgs []provider.Message, attachments func(string) []eve
return eventwire.ToWireAttachments(attachments(text))
}
out := make([]historyMessage, 0, len(msgs))
+ calls := make(map[string]provider.ToolCall)
worked := sessionstore.TurnWorkMs(msgs)
for i, m := range msgs {
if m.LocalOnly && m.Name == surfacespec.ActionMessageName {
@@ -130,6 +133,7 @@ func historyMessagesWith(msgs []provider.Message, attachments func(string) []eve
if len(m.ToolCalls) > 0 {
hm.ToolCalls = make([]historyToolCall, len(m.ToolCalls))
for i, tc := range m.ToolCalls {
+ calls[tc.ID] = tc
hm.ToolCalls[i] = historyToolCall{
ID: tc.ID, Name: tc.Name, Arguments: eventwire.SurfaceArgs(tc.Name, tc.ResolvedName, tc.Arguments),
ResolvedName: tc.ResolvedName, CapabilityID: tc.CapabilityID,
@@ -138,6 +142,12 @@ func historyMessagesWith(msgs []provider.Message, attachments func(string) []eve
}
}
if m.Role == provider.RoleTool {
+ call := calls[m.ToolCallID]
+ manifest := m.Content
+ if m.RawContent != "" {
+ manifest = m.RawContent
+ }
+ hm.Deliveries = delivery.Decode(call.ResolvedName, call.CapabilityID, m.ToolFailure != nil, manifest)
hm.ToolCallID = m.ToolCallID
hm.ToolName = m.Name
if m.ToolFailure != nil {
diff --git a/internal/frontend/serve/open_document.go b/internal/frontend/serve/open_document.go
index 8fb37b8486..ee39722def 100644
--- a/internal/frontend/serve/open_document.go
+++ b/internal/frontend/serve/open_document.go
@@ -25,7 +25,11 @@ var launchDocument = opendoc.Open
// openableDocument lists the types the system opener may be handed. Each is a
// document its default program renders, never something that runs as a program.
-var openableDocument = map[string]bool{".html": true, ".htm": true, ".xhtml": true, ".svg": true, ".pdf": true}
+var openableDocument = map[string]bool{
+ ".html": true, ".htm": true, ".xhtml": true, ".svg": true, ".pdf": true,
+ ".doc": true, ".docx": true, ".xls": true, ".xlsx": true, ".ppt": true, ".pptx": true,
+ ".md": true, ".markdown": true, ".txt": true, ".csv": true, ".tsv": true,
+}
// openDocument hands one file to the machine's default program. The file must
// lie in the workspace or a granted folder and, once links are followed, be a
diff --git a/internal/frontend/serve/open_document_test.go b/internal/frontend/serve/open_document_test.go
index 59875acbe2..b47bc5504f 100644
--- a/internal/frontend/serve/open_document_test.go
+++ b/internal/frontend/serve/open_document_test.go
@@ -133,7 +133,7 @@ func TestOpenDocumentRefusesWhatIsOutsideTheRoots(t *testing.T) {
func TestOpenDocumentRefusesTypesOffTheListAndWhatIsNotAFile(t *testing.T) {
f := newDocumentFixture(t, true)
- for _, name := range []string{"site/app.js", "site/run.exe", "site/note.txt"} {
+ for _, name := range []string{"site/app.js", "site/run.exe"} {
if code, why := f.open(t, filepath.Join(f.work, filepath.FromSlash(name))); code != http.StatusBadRequest || why != codeDocumentType {
t.Errorf("%s: status %d code %q, want 400 %s", name, code, why, codeDocumentType)
}
diff --git a/internal/frontend/serve/routes.go b/internal/frontend/serve/routes.go
index 08fd5b1f22..bb8397d1de 100644
--- a/internal/frontend/serve/routes.go
+++ b/internal/frontend/serve/routes.go
@@ -116,6 +116,7 @@ func (s *Server) routes() http.Handler {
mux.HandleFunc("GET /todos", s.todos)
mux.HandleFunc("GET /workspace/files", s.workspaceFiles)
mux.HandleFunc("GET /workspace/file", s.workspaceFileRead)
+ s.workspacePreviewRoutes(mux)
mux.HandleFunc("GET /workspace/image", s.workspaceImage)
mux.HandleFunc("PUT /workspace/file", s.workspaceFileWrite)
mux.HandleFunc("POST /workspace/editor", s.openInEditor)
diff --git a/internal/frontend/serve/workspace_files.go b/internal/frontend/serve/workspace_files.go
index d43b6f6ef7..771c08220e 100644
--- a/internal/frontend/serve/workspace_files.go
+++ b/internal/frontend/serve/workspace_files.go
@@ -10,14 +10,17 @@ import (
"os"
"path/filepath"
"strings"
+
+ "reasonix/internal/base/workspacefile"
)
const maxWorkspaceFile = 2 << 20
type workspaceFile struct {
- Path string `json:"path"`
- Content string `json:"content"`
- Revision string `json:"revision"`
+ Path string `json:"path"`
+ Content string `json:"content"`
+ Revision string `json:"revision"`
+ ObservedVersion string `json:"observedVersion,omitempty"`
// Root is the granted folder the file was read from; empty for the workspace
// itself. A file read from a granted folder is ReadOnly: only the workspace
// may be written through this route.
@@ -47,6 +50,10 @@ func refuseOpen(w http.ResponseWriter, err error) {
refuse(w, http.StatusNotFound, "workspace.file_missing", err.Error(), nil)
return
}
+ if errors.Is(err, workspacefile.ErrDenied) || errors.Is(err, fs.ErrPermission) {
+ refuse(w, http.StatusForbidden, "workspace.preview_denied", err.Error(), nil)
+ return
+ }
refuse(w, http.StatusInternalServerError, "workspace.file_failed", err.Error(), nil)
}
@@ -97,34 +104,17 @@ func (s *Server) workspaceFileRead(w http.ResponseWriter, r *http.Request) {
if !ok {
return
}
- root, err := os.OpenRoot(base)
+ data, info, err := (workspacefile.Service{Primary: base}).Text(r.Context(), workspacefile.Ref{Path: filepath.ToSlash(path)})
if err != nil {
- refuse(w, http.StatusInternalServerError, "workspace.file_failed", err.Error(), nil)
- return
- }
- defer root.Close()
- file, err := root.Open(path)
- if err != nil {
- refuseOpen(w, err)
- return
- }
- defer file.Close()
- info, err := file.Stat()
- if err != nil || info.IsDir() || info.Size() > maxWorkspaceFile {
- refuse(w, http.StatusBadRequest, "workspace.file_unreadable", "file is not editable text or exceeds 2 MiB", nil)
- return
- }
- data := make([]byte, info.Size())
- if _, err = file.ReadAt(data, 0); err != nil && len(data) > 0 {
- refuse(w, http.StatusInternalServerError, "workspace.file_failed", err.Error(), nil)
- return
- }
- if strings.IndexByte(string(data), 0) >= 0 {
- refuse(w, http.StatusBadRequest, "workspace.file_unreadable", "binary files cannot be edited here", nil)
+ if errors.Is(err, workspacefile.ErrTooLarge) || errors.Is(err, workspacefile.ErrNotFile) || errors.Is(err, workspacefile.ErrNotText) {
+ refuse(w, http.StatusBadRequest, "workspace.file_unreadable", err.Error(), nil)
+ } else {
+ refuseOpen(w, err)
+ }
return
}
w.Header().Set("content-type", "application/json")
- out := workspaceFile{Path: filepath.ToSlash(path), Content: string(data), Revision: fileRevision(data)}
+ out := workspaceFile{Path: filepath.ToSlash(path), Content: string(data), Revision: fileRevision(data), ObservedVersion: info.Version}
if base != s.ctl().WorkspaceRoot() {
out.Root, out.ReadOnly = base, true
}
@@ -170,6 +160,7 @@ func (s *Server) workspaceFileWrite(w http.ResponseWriter, r *http.Request) {
return
}
data := []byte(in.Content)
+ info, _ := (workspacefile.Service{Primary: s.ctl().WorkspaceRoot()}).Info(r.Context(), workspacefile.Ref{Path: filepath.ToSlash(path)})
w.Header().Set("content-type", "application/json")
- _ = json.NewEncoder(w).Encode(workspaceFile{Path: filepath.ToSlash(path), Content: in.Content, Revision: fileRevision(data)})
+ _ = json.NewEncoder(w).Encode(workspaceFile{Path: filepath.ToSlash(path), Content: in.Content, Revision: fileRevision(data), ObservedVersion: info.Version})
}
diff --git a/internal/frontend/serve/workspace_files_test.go b/internal/frontend/serve/workspace_files_test.go
index 868906e304..92304860f1 100644
--- a/internal/frontend/serve/workspace_files_test.go
+++ b/internal/frontend/serve/workspace_files_test.go
@@ -86,22 +86,25 @@ func TestWorkspaceFileSaysMissingOnlyForAFileThatIsNotThere(t *testing.T) {
ctrl := control.New(control.Options{Runner: fakeRunner{}, Sink: bc, WorkspaceRoot: dir})
srv := httptest.NewServer(operatorHandler(New(ctrl, bc, config.ServeConfig{})))
defer srv.Close()
- code := func(path string) string {
+ code := func(path string, status int) string {
resp, err := http.Get(srv.URL + "/workspace/file?path=" + path)
if err != nil {
t.Fatal(err)
}
defer resp.Body.Close()
+ if resp.StatusCode != status {
+ t.Fatalf("%s: status %d, want %d", path, resp.StatusCode, status)
+ }
var body struct {
Code string `json:"code"`
}
_ = json.NewDecoder(resp.Body).Decode(&body)
return body.Code
}
- if got := code("absent.txt"); got != "workspace.file_missing" {
+ if got := code("absent.txt", http.StatusNotFound); got != "workspace.file_missing" {
t.Fatalf("absent file: code %q, want workspace.file_missing", got)
}
- if got := code("link/secret.txt"); got != "workspace.file_failed" {
- t.Fatalf("file behind a link the root refuses: code %q, want workspace.file_failed", got)
+ if got := code("link/secret.txt", http.StatusForbidden); got != "workspace.preview_denied" {
+ t.Fatalf("file behind a link the root refuses: code %q, want workspace.preview_denied", got)
}
}
diff --git a/internal/frontend/serve/workspace_image.go b/internal/frontend/serve/workspace_image.go
index 647b341eab..c761390603 100644
--- a/internal/frontend/serve/workspace_image.go
+++ b/internal/frontend/serve/workspace_image.go
@@ -1,14 +1,13 @@
package serve
import (
- "io"
+ "errors"
"net/http"
- "os"
"path/filepath"
"strings"
-)
-const maxWorkspaceImage = 10 << 20
+ "reasonix/internal/base/workspacefile"
+)
// imageTypes are what a document in the workspace may show inline. The type is
// decided by extension here, never sniffed, so a file cannot choose to be HTML.
@@ -42,28 +41,20 @@ func (s *Server) workspaceImage(w http.ResponseWriter, r *http.Request) {
if !ok {
return
}
- root, err := os.OpenRoot(base)
+ data, _, err := (workspacefile.Service{Primary: base}).Content(r.Context(), workspacefile.Ref{Path: filepath.ToSlash(path)})
if err != nil {
- refuse(w, http.StatusInternalServerError, "workspace.file_failed", err.Error(), nil)
- return
- }
- defer root.Close()
- file, err := root.Open(path)
- if err != nil {
- refuseOpen(w, err)
- return
- }
- defer file.Close()
- info, err := file.Stat()
- if err != nil || info.IsDir() || info.Size() > maxWorkspaceImage {
- refuse(w, http.StatusBadRequest, "workspace.file_unreadable", "not a file, or larger than 10 MiB", nil)
+ if errors.Is(err, workspacefile.ErrTooLarge) || errors.Is(err, workspacefile.ErrNotFile) {
+ refuse(w, http.StatusBadRequest, "workspace.file_unreadable", err.Error(), nil)
+ } else {
+ refuseOpen(w, err)
+ }
return
}
w.Header().Set("Content-Type", contentType)
w.Header().Set("Content-Security-Policy", "default-src 'none'; style-src 'unsafe-inline'; sandbox")
w.Header().Set("X-Content-Type-Options", "nosniff")
w.Header().Set("Cache-Control", "no-cache")
- _, _ = io.Copy(w, io.LimitReader(file, maxWorkspaceImage))
+ _, _ = w.Write(data)
}
// readRoot is the folder a read comes from: the workspace, or a folder the user
diff --git a/internal/frontend/serve/workspace_preview.go b/internal/frontend/serve/workspace_preview.go
new file mode 100644
index 0000000000..81b4cb648c
--- /dev/null
+++ b/internal/frontend/serve/workspace_preview.go
@@ -0,0 +1,65 @@
+package serve
+
+import (
+ "errors"
+ "net/http"
+
+ "reasonix/internal/base/workspacefile"
+)
+
+func previewRef(r *http.Request) workspacefile.Ref {
+ return workspacefile.Ref{Path: r.URL.Query().Get("path"), Root: r.URL.Query().Get("root")}
+}
+
+func (s *Server) workspacePreviewRoutes(mux *http.ServeMux) {
+ mux.HandleFunc("GET /workspace/preview/info", s.workspacePreviewInfo)
+ mux.HandleFunc("GET /workspace/preview/content", s.workspacePreviewContent)
+}
+
+func refusePreview(w http.ResponseWriter, err error) {
+ code, status := "workspace.preview_failed", http.StatusInternalServerError
+ for _, candidate := range []struct {
+ err error
+ code string
+ status int
+ }{
+ {workspacefile.ErrMissing, "workspace.file_missing", http.StatusNotFound},
+ {workspacefile.ErrDenied, "workspace.preview_denied", http.StatusForbidden},
+ {workspacefile.ErrNotFile, "workspace.preview_not_file", http.StatusBadRequest},
+ {workspacefile.ErrTooLarge, "workspace.preview_too_large", http.StatusRequestEntityTooLarge},
+ {workspacefile.ErrNotText, "workspace.preview_not_text", http.StatusUnsupportedMediaType},
+ {workspacefile.ErrUnsupported, "workspace.preview_unsupported", http.StatusUnsupportedMediaType},
+ {workspacefile.ErrChanged, "workspace.preview_changed", http.StatusConflict},
+ } {
+ if errors.Is(err, candidate.err) {
+ code, status = candidate.code, candidate.status
+ break
+ }
+ }
+ refuse(w, status, code, err.Error(), nil)
+}
+
+func (s *Server) workspacePreviewInfo(w http.ResponseWriter, r *http.Request) {
+ info, err := s.ctl().WorkspacePreviewInfo(r.Context(), previewRef(r))
+ if err != nil {
+ refusePreview(w, err)
+ return
+ }
+ w.Header().Set("Cache-Control", "no-store")
+ writeJSON(w, info)
+}
+
+func (s *Server) workspacePreviewContent(w http.ResponseWriter, r *http.Request) {
+ data, info, err := s.ctl().WorkspacePreviewContent(r.Context(), previewRef(r))
+ if err != nil {
+ refusePreview(w, err)
+ return
+ }
+ w.Header().Set("Content-Type", "application/octet-stream")
+ w.Header().Set("Content-Disposition", "attachment")
+ w.Header().Set("X-Content-Type-Options", "nosniff")
+ w.Header().Set("Content-Security-Policy", "default-src 'none'; sandbox")
+ w.Header().Set("Cache-Control", "no-store")
+ w.Header().Set("X-Preview-Version", info.Version)
+ _, _ = w.Write(data)
+}
diff --git a/internal/frontend/serve/workspace_preview_test.go b/internal/frontend/serve/workspace_preview_test.go
new file mode 100644
index 0000000000..0e5b92d57e
--- /dev/null
+++ b/internal/frontend/serve/workspace_preview_test.go
@@ -0,0 +1,91 @@
+package serve
+
+import (
+ "encoding/json"
+ "net/http"
+ "net/http/httptest"
+ "os"
+ "path/filepath"
+ "testing"
+
+ "reasonix/internal/base/testenv"
+ "reasonix/internal/base/workspacefile"
+ "reasonix/internal/contract/config"
+ "reasonix/internal/contract/provider"
+ "reasonix/internal/session/control"
+)
+
+func TestWorkspacePreviewRoutesKeepBinaryOutOfJSON(t *testing.T) {
+ dir := testenv.TempDir(t)
+ data := []byte("%PDF-1.7\n\x00binary")
+ if err := os.WriteFile(filepath.Join(dir, "report.pdf"), data, 0o600); err != nil {
+ t.Fatal(err)
+ }
+ bc := NewBroadcaster()
+ ctrl := control.New(control.Options{Runner: fakeRunner{}, Sink: bc, WorkspaceRoot: dir})
+ t.Cleanup(ctrl.Close)
+ handler := operatorHandler(New(ctrl, bc, config.ServeConfig{}))
+ for _, tc := range []struct {
+ path string
+ code int
+ }{
+ {"/workspace/preview/info?path=report.pdf", 200},
+ {"/workspace/preview/content?path=report.pdf", 200},
+ {"/workspace/preview/info?path=../secret", 403},
+ {"/workspace/preview/info?path=missing", 404},
+ } {
+ rec := httptest.NewRecorder()
+ handler.ServeHTTP(rec, httptest.NewRequest(http.MethodGet, tc.path, nil))
+ if rec.Code != tc.code {
+ t.Fatalf("%s: %d %s", tc.path, rec.Code, rec.Body.String())
+ }
+ if tc.path == "/workspace/preview/info?path=report.pdf" {
+ var info workspacefile.Info
+ if err := json.Unmarshal(rec.Body.Bytes(), &info); err != nil || info.Kind != "pdf" {
+ t.Fatalf("info %+v, %v", info, err)
+ }
+ }
+ if tc.path == "/workspace/preview/content?path=report.pdf" {
+ if rec.Body.String() != string(data) || rec.Header().Get("X-Content-Type-Options") != "nosniff" {
+ t.Fatalf("binary response: %s", rec.Body.String())
+ }
+ }
+ }
+}
+
+func TestHistoryReconstructsOnlyConfirmedDeliveryResults(t *testing.T) {
+ body := `{"version":1,"files":[{"path":"docs/report.md","description":"Report"}]}`
+ msgs := []provider.Message{
+ {Role: provider.RoleAssistant, ToolCalls: []provider.ToolCall{
+ {ID: "real", Name: "use_capability", ResolvedName: "present_files", CapabilityID: "tool:present_files"},
+ {ID: "fake", Name: "bash", ResolvedName: "bash", CapabilityID: "tool:bash"},
+ }},
+ {Role: provider.RoleTool, ToolCallID: "real", Content: body},
+ {Role: provider.RoleTool, ToolCallID: "fake", Content: body},
+ }
+ history := historyMessages(msgs)
+ if len(history[1].Deliveries) != 1 || len(history[2].Deliveries) != 0 {
+ t.Fatalf("history = %+v", history)
+ }
+ msgs[1].Content, msgs[1].RawContent = "[result truncated]", body
+ if len(historyMessages(msgs)[1].Deliveries) != 1 {
+ t.Fatal("context truncation erased a persisted delivery")
+ }
+ msgs[1].ToolFailure = &provider.ToolFailure{}
+ if len(historyMessages(msgs)[1].Deliveries) != 0 {
+ t.Fatal("failed declaration became delivery")
+ }
+}
+
+func TestOpenOfficeAndTextDocuments(t *testing.T) {
+ f := newDocumentFixture(t, true)
+ for _, name := range []string{"report.docx", "budget.xlsx", "slides.pptx", "notes.md", "table.csv"} {
+ path := filepath.Join(f.work, name)
+ if err := os.WriteFile(path, []byte("fixture"), 0o600); err != nil {
+ t.Fatal(err)
+ }
+ if code, why := f.open(t, path); code != http.StatusOK {
+ t.Fatalf("%s: %d %s", name, code, why)
+ }
+ }
+}
diff --git a/internal/runtime/agent/execute_batch.go b/internal/runtime/agent/execute_batch.go
index ef136dc1da..dde02044d4 100644
--- a/internal/runtime/agent/execute_batch.go
+++ b/internal/runtime/agent/execute_batch.go
@@ -7,6 +7,7 @@ import (
"sync"
"time"
+ "reasonix/internal/contract/delivery"
"reasonix/internal/contract/event"
"reasonix/internal/contract/provider"
"reasonix/internal/contract/tool"
@@ -328,6 +329,11 @@ func (a *Agent) executeBatch(ctx context.Context, turn *turnRuntime, calls []pro
Execution: toEventShellExecution(o.execution, durations[i]),
Issuer: event.IssuedByModel, Executed: o.executed,
}
+ manifest := o.output
+ if o.rawOutput != "" {
+ manifest = o.rawOutput
+ }
+ tr.Deliveries = delivery.Decode(c.ResolvedName, c.CapabilityID, o.errMsg != "" || !o.executed || o.blocked, manifest)
if startedAt[i] > 0 {
tr.StartedAt = startedAt[i]
tr.EndedAt = startedAt[i] + durations[i]
diff --git a/internal/runtime/agent/execute_one.go b/internal/runtime/agent/execute_one.go
index 842b9e939c..723747fef9 100644
--- a/internal/runtime/agent/execute_one.go
+++ b/internal/runtime/agent/execute_one.go
@@ -15,7 +15,6 @@ import (
"reasonix/internal/contract/tool"
"reasonix/internal/safety/evidence"
"reasonix/internal/safety/permission"
- "reasonix/internal/tools/shellrun"
)
// CodeMCPToolDisabled identifies a call refused by an explicit disabled_tools
@@ -648,6 +647,9 @@ func (a *Agent) finishToolExecution(ctx context.Context, plan *toolCallPlan) too
a.announceDelegation(plan)
cctx := plan.cctx
runTool := plan.runTool
+ if _, ok := runTool.(tool.FilePresenter); ok {
+ plan.resolvedMeta = &tool.ResolvedCall{TargetName: runTool.Name(), CapabilityID: "tool:present_files", ReadOnly: true, Target: runTool, Args: plan.runArgs}
+ }
runArgs := plan.runArgs
call := plan.call
t := plan.tool
@@ -738,21 +740,6 @@ func (a *Agent) finishToolExecution(ctx context.Context, plan *toolCallPlan) too
return out
}
-// annotateShellSubject records the part of the command that names what it runs,
-// when an assignment prefix stands in front of it.
-func annotateShellSubject(execution *tool.ShellExecution, args json.RawMessage) {
- if execution == nil || execution.Subject != "" {
- return
- }
- cmd := bashCommandFromArgs(args)
- if cmd == "" {
- return
- }
- if subject, cut := shellrun.OperativeCommand(cmd); cut {
- execution.Subject = subject
- }
-}
-
// executeStoppable runs the call under a context CancelToolCall can end alone.
func (a *Agent) executeStoppable(turn, cctx context.Context, plan *toolCallPlan) (result string, media toolMedia, execution *tool.ShellExecution, err error) {
runTool, runArgs := plan.runTool, plan.runArgs
diff --git a/internal/runtime/agent/shell_subject.go b/internal/runtime/agent/shell_subject.go
new file mode 100644
index 0000000000..5dee15c168
--- /dev/null
+++ b/internal/runtime/agent/shell_subject.go
@@ -0,0 +1,22 @@
+package agent
+
+import (
+ "encoding/json"
+ "reasonix/internal/contract/tool"
+ "reasonix/internal/tools/shellrun"
+)
+
+// annotateShellSubject records the part of the command that names what it runs,
+// when an assignment prefix stands in front of it.
+func annotateShellSubject(execution *tool.ShellExecution, args json.RawMessage) {
+ if execution == nil || execution.Subject != "" {
+ return
+ }
+ cmd := bashCommandFromArgs(args)
+ if cmd == "" {
+ return
+ }
+ if subject, cut := shellrun.OperativeCommand(cmd); cut {
+ execution.Subject = subject
+ }
+}
diff --git a/internal/session/control/port.go b/internal/session/control/port.go
index 6bfb67e331..3e8341a159 100644
--- a/internal/session/control/port.go
+++ b/internal/session/control/port.go
@@ -2,6 +2,7 @@ package control
import (
"context"
+ "reasonix/internal/base/workspacefile"
"reasonix/internal/state/sessionstore"
"reasonix/internal/contract/agentcomposition"
@@ -292,6 +293,8 @@ type RuntimeSettings interface {
RevokeRememberedProjectRule(rule string) error
WorkspaceRoots() (WorkspaceRoots, error)
ReadableExtraRoots() ([]string, error)
+ WorkspacePreviewInfo(context.Context, workspacefile.Ref) (workspacefile.Info, error)
+ WorkspacePreviewContent(context.Context, workspacefile.Ref) ([]byte, workspacefile.Info, error)
AddWorkspaceRoot(dir string) (string, error)
RemoveWorkspaceRoot(dir string) error
SandboxSettings() SandboxSettings
diff --git a/internal/session/control/workspace_preview.go b/internal/session/control/workspace_preview.go
new file mode 100644
index 0000000000..a69f4afc7a
--- /dev/null
+++ b/internal/session/control/workspace_preview.go
@@ -0,0 +1,28 @@
+package control
+
+import (
+ "context"
+
+ "reasonix/internal/base/workspacefile"
+)
+
+func (c *Controller) previewFiles() (workspacefile.Service, error) {
+ extra, err := c.ReadableExtraRoots()
+ return workspacefile.Service{Primary: c.WorkspaceRoot(), Extra: extra}, err
+}
+
+func (c *Controller) WorkspacePreviewInfo(ctx context.Context, ref workspacefile.Ref) (workspacefile.Info, error) {
+ files, err := c.previewFiles()
+ if err != nil {
+ return workspacefile.Info{}, err
+ }
+ return files.Info(ctx, ref)
+}
+
+func (c *Controller) WorkspacePreviewContent(ctx context.Context, ref workspacefile.Ref) ([]byte, workspacefile.Info, error) {
+ files, err := c.previewFiles()
+ if err != nil {
+ return nil, workspacefile.Info{}, err
+ }
+ return files.Content(ctx, ref)
+}
diff --git a/internal/tools/builtin/present_files.go b/internal/tools/builtin/present_files.go
new file mode 100644
index 0000000000..e12a49e2e1
--- /dev/null
+++ b/internal/tools/builtin/present_files.go
@@ -0,0 +1,104 @@
+package builtin
+
+import (
+ "context"
+ "encoding/json"
+ "fmt"
+ "path/filepath"
+
+ "reasonix/internal/base/workspacefile"
+ "reasonix/internal/contract/delivery"
+ "reasonix/internal/contract/tool"
+)
+
+func init() { tool.RegisterBuiltin(presentFiles{}) }
+
+type presentFiles struct {
+ workDir string
+ roots []string
+ readRoots []string
+ forbidRoots []string
+}
+
+func (presentFiles) Name() string { return delivery.ToolName }
+func (presentFiles) Description() string {
+ return "Present existing final files as clickable cards, including shell-created documents. Paths must be in the workspace or authorized folders. Opens current files, not snapshots; does not certify correctness."
+}
+func (presentFiles) Schema() json.RawMessage {
+ return json.RawMessage(`{"type":"object","properties":{"files":{"type":"array","minItems":1,"maxItems":4,"items":{"type":"object","properties":{"path":{"type":"string","maxLength":4096},"description":{"type":"string","maxLength":256}},"required":["path"],"additionalProperties":false}}},"required":["files"],"additionalProperties":false}`)
+}
+func (presentFiles) ReadOnly() bool { return true }
+func (presentFiles) FilePresentation() {}
+func (presentFiles) SnipHint() tool.SnipHint {
+ return tool.SnipHint{Head: 1, Tail: 1, HeadChars: 32 << 10, TailChars: 1}
+}
+
+func (p presentFiles) ReadPaths(_ context.Context, args json.RawMessage) ([]string, error) {
+ var in struct {
+ Files []struct {
+ Path string `json:"path"`
+ } `json:"files"`
+ }
+ if err := json.Unmarshal(args, &in); err != nil {
+ return nil, err
+ }
+ var paths []string
+ for _, file := range in.Files {
+ path := file.Path
+ if !filepath.IsAbs(path) {
+ path = filepath.Join(p.workDir, path)
+ }
+ paths = append(paths, path)
+ }
+ return paths, nil
+}
+
+func (p presentFiles) Execute(ctx context.Context, args json.RawMessage) (string, error) {
+ var in struct {
+ Files []struct {
+ Path string `json:"path"`
+ Description string `json:"description"`
+ } `json:"files"`
+ }
+ if err := json.Unmarshal(args, &in); err != nil {
+ return "", err
+ }
+ if len(in.Files) == 0 || len(in.Files) > delivery.MaxFiles {
+ return "", fmt.Errorf("present_files requires 1 to 4 files")
+ }
+ root, err := filepath.Abs(p.workDir)
+ if err != nil {
+ return "", err
+ }
+ service := workspacefile.Service{Primary: root, Extra: p.roots}
+ result := delivery.Result{Version: 1, Files: make([]delivery.File, 0, len(in.Files))}
+ for _, file := range in.Files {
+ if len(file.Path) > 4096 || len(file.Description) > 1024 {
+ return "", fmt.Errorf("file path or description is too long")
+ }
+ ref, err := service.Resolve(file.Path)
+ if err != nil {
+ return "", err
+ }
+ base := root
+ if ref.Root != "" {
+ base = ref.Root
+ }
+ target, err := filepath.EvalSymlinks(filepath.Join(base, filepath.FromSlash(ref.Path)))
+ if err != nil {
+ return "", err
+ }
+ if err := checkReadTargetAccess(p.readRoots, p.forbidRoots, target); err != nil {
+ return "", err
+ }
+ if _, err := service.Info(ctx, ref); err != nil {
+ return "", err
+ }
+ result.Files = append(result.Files, delivery.File{Path: ref.Path, Root: ref.Root, Description: file.Description})
+ }
+ data, err := json.Marshal(result)
+ if len(data) > 32<<10 {
+ return "", fmt.Errorf("file declaration exceeds 32 KiB")
+ }
+ return string(data), err
+}
diff --git a/internal/tools/builtin/present_files_test.go b/internal/tools/builtin/present_files_test.go
new file mode 100644
index 0000000000..6116397113
--- /dev/null
+++ b/internal/tools/builtin/present_files_test.go
@@ -0,0 +1,63 @@
+package builtin
+
+import (
+ "encoding/json"
+ "os"
+ "path/filepath"
+ "testing"
+
+ "reasonix/internal/contract/delivery"
+)
+
+func TestPresentFilesValidatesEveryFileBeforeReturning(t *testing.T) {
+ root := t.TempDir()
+ if err := os.WriteFile(filepath.Join(root, "report.md"), []byte("# Report"), 0o600); err != nil {
+ t.Fatal(err)
+ }
+ p := presentFiles{workDir: root}
+ out, err := p.Execute(t.Context(), json.RawMessage(`{"files":[{"path":"report.md","description":"Report"}]}`))
+ if err != nil || !json.Valid([]byte(out)) {
+ t.Fatalf("present = %q, %v", out, err)
+ }
+ for _, args := range []string{
+ `{"files":[]}`,
+ `{"files":[{"path":"report.md"},{"path":"missing.md"}]}`,
+ `{"files":[{"path":"../secret"}]}`,
+ `{"files":[{"path":"."}]}`,
+ } {
+ if out, err := p.Execute(t.Context(), json.RawMessage(args)); err == nil || out != "" {
+ t.Fatalf("invalid declaration returned %q, %v", out, err)
+ }
+ }
+}
+
+func TestPresentFilesHonorsReadPolicyAndGrantedRoots(t *testing.T) {
+ roots := realRoots([]string{t.TempDir(), t.TempDir()})
+ root, extra := roots[0], roots[1]
+ path := filepath.Join(extra, "report 100%.md")
+ if err := os.WriteFile(path, []byte("# Report"), 0o600); err != nil {
+ t.Fatal(err)
+ }
+ args, err := json.Marshal(map[string]any{"files": []map[string]string{{"path": path}}})
+ if err != nil {
+ t.Fatal(err)
+ }
+ for _, presenter := range []presentFiles{
+ {workDir: root},
+ {workDir: root, roots: []string{extra}, forbidRoots: []string{extra}},
+ {workDir: root, roots: []string{extra}, readRoots: []string{root}},
+ } {
+ if out, err := presenter.Execute(t.Context(), args); err == nil || out != "" {
+ t.Fatalf("restricted declaration = %q, %v", out, err)
+ }
+ }
+ presenter := presentFiles{workDir: root, roots: []string{extra}, readRoots: []string{extra}}
+ out, err := presenter.Execute(t.Context(), args)
+ if err != nil {
+ t.Fatal(err)
+ }
+ files := delivery.Decode(delivery.ToolName, delivery.Identity, false, out)
+ if len(files) != 1 || files[0].Root != extra || files[0].Path != "report 100%.md" {
+ t.Fatalf("normalized files = %+v", files)
+ }
+}
diff --git a/internal/tools/builtin/schema_budget.json b/internal/tools/builtin/schema_budget.json
index d98e6f72e2..d9199d3d69 100644
--- a/internal/tools/builtin/schema_budget.json
+++ b/internal/tools/builtin/schema_budget.json
@@ -1,3 +1,3 @@
{
- "totalTokens": 7185
+ "totalTokens": 7328
}
diff --git a/internal/tools/builtin/workspace.go b/internal/tools/builtin/workspace.go
index 5d06a5323c..227630e059 100644
--- a/internal/tools/builtin/workspace.go
+++ b/internal/tools/builtin/workspace.go
@@ -81,6 +81,7 @@ func (w Workspace) Tools(enabled ...string) []tool.Tool {
}
overrides := map[string]tool.Tool{
+ "present_files": presentFiles{workDir: w.Dir, roots: writeRoots, readRoots: readRoots, forbidRoots: forbidRoots},
"read_file": readFile{workDir: w.Dir, netRoots: netRoots, readRoots: readRoots, paths: w.ReadPaths, forbidRoots: forbidRoots, overlay: w.FileOverlay},
"write_file": writeFile{workDir: w.Dir, roots: roots, readRoots: readRoots, forbidRoots: forbidRoots, guard: w.SessionGuard, managed: w.ManagedConfig, sessionTemp: w.SessionTemp, overlay: w.FileOverlay, receipt: w.FileWriteReceipt},
"edit_file": editFile{readPolicy: editReadPolicy{readRoots: readRoots, forbidRoots: forbidRoots}, workDir: w.Dir, roots: roots, guard: w.SessionGuard, managed: w.ManagedConfig, sessionTemp: w.SessionTemp, overlay: w.FileOverlay},
diff --git a/tools/repolint/layers.go b/tools/repolint/layers.go
index 1d217819c5..f8f4a8428f 100644
--- a/tools/repolint/layers.go
+++ b/tools/repolint/layers.go
@@ -25,6 +25,8 @@ var frontends = []string{
// One may reach another: the layer is closed, so that drags nothing in, and
// refusing it is what leaves the same judgement copied into several of them.
var leaves = []string{
+ "internal/base/workspacefile",
+ "internal/contract/delivery",
"internal/contract/ablation",
"internal/contract/agentgraph",
"internal/contract/agentpreset",
diff --git a/tools/repolint/wireparity.go b/tools/repolint/wireparity.go
index 6e4c3b94de..831c989713 100644
--- a/tools/repolint/wireparity.go
+++ b/tools/repolint/wireparity.go
@@ -44,6 +44,10 @@ const (
// wrong. Declared and not inferred, for the reason the sensitive paths are: no
// spelling tells a mirrored contract from a struct with json tags.
var mirroredWireTypes = []wireMirror{
+ {"internal/frontend/serve/workspace_files.go", "workspaceFile", tsWorkspaceFile, "WorkspaceFile"},
+ {"internal/base/workspacefile/file.go", "Ref", tsWorkspaceFile, "FileRef"},
+ {"internal/base/workspacefile/file.go", "Info", tsWorkspaceFile, "PreviewInfo"},
+ {"internal/contract/delivery/delivery.go", "File", tsWorkspaceFile, "DeliveredFile"},
{"internal/platform/worktree/source.go", "Source", tsWorkspaceFile, "WorktreeSource"},
{"internal/frontend/serve/workspace_source.go", "worktreeSourcesView", tsWorkspaceFile, "WorktreeSources"},
{"internal/frontend/serve/workspace_source.go", "worktreeSelection", tsWorkspaceFile, "WorktreeSelection"},