2 Commits

Include renames

Author	SHA1	Message	Date
SivanCola	7539047ba2	chore(eval): make capability replay optional ... Problem: The use_capability paired replay required a live_paired dataset and fixed performance thresholds before Stable publication. Root cause: The optional performance benchmark was promoted into a release-blocking command and policy even though its median helper remains useful independently. Fix: Remove the release-only CLI, dataset types, thresholds, and gate tests. Keep the synthetic median fixture and document paired replay as an optional diagnostic in English and Chinese. Verification: - go test ./internal/eval/replay/ -count=1 - go test ./... -count=1 - go vet ./... - go run ./tools/repolint - git diff --check	2026-08-30 11:26:26 +08:00
SivanCola	22291d4e78	feat(agent): land cache-stable use_capability speed and quality controls / 落地缓存稳定的能力代理速度与质量治理 (#9569) ... * feat(agent): land cache-stable use_capability speed and quality controls Problem: MCP discovery and review loops inflate tools/list traffic, schema bytes, and automatic architecture review. The 1.33.0 speed-and-quality plan keeps a fixed use_capability proxy, but host validation, parallel read-only dispatch, stop-loss, child review budgets, and observability were incomplete. Root cause: The proxy schema was cache-stable, yet argument validation, scheduling class, review triggers, child sampling caps, facts packs, and list-layer metrics were not wired through. Architecture review fired too broadly, and the review 2048-token cap never reached child provider sampling. Fix: - Validate arguments against the real target schema before MCP tools/call. - Classify list/search/inspect and connected read-only MCP as parallel. - Fail closed when schema generation or safety class changes after scheduling. - Narrow auto independent review to architecture-worthy writes and cap at one first review plus one re-review. - Stamp review children with 8 steps / 2048 output tokens and a parent facts pack, without copying the parent transcript. - Record tool/phase/MCP list metrics and export three-layer list sources. - Keep first-party Tool Search preview plumbing default-off. Verification: - go test ./internal/agent/ ./internal/plugin/ ./internal/taskcontract/ ./internal/cli/ ./internal/tool/ ./internal/boot/ ./internal/eval/replay/ - go test -race on parallel MCP and listChanged tests - go vet ./internal/agent/ ./internal/plugin/ ./internal/cli/ - go run ./tools/repolint * fix(agent): harden capability speed controls Problem - Capability retries, proxy classification, and loop guards could duplicate canceled work, serialize safe reads, or repeat failed decisions. - MCP attribution, review context, native tool search, output validation, and desktop export wiring had correctness and CI gaps. Root cause - Wrapper layers dropped resolved metadata, per-turn state used cumulative or non-atomic accounting, and process-only metrics could not explain session behavior. - Provider support was inferred from names, while two same-stem export modules made TypeScript resolve the wrong implementation. Fix - Fail closed on cancellation and dynamic classification, bound reviews and repeated failures, validate output schemas, index discovery once, and emit session-scoped MCP list observations. - Gate native tool search by concrete first-party Responses capability, preserve host validation, and split lightweight export data from raster renderers. - Add deterministic concurrency, decision, dedupe, Windows path, frontend contract, and wire-format coverage. Verification - go test ./... -count=1 - go test -race ./internal/agent ./internal/plugin -count=1 - golangci-lint run ./... (darwin, linux, windows) - pnpm build - node scripts/run-tests.mjs (236 suites) * refactor(boot): preserve repository lint budgets Problem - The capability review wiring increased line and complexity counts in two already-baselined large files, so the repository lint gate rejected the otherwise clean change. Root cause - Review context preparation and observer binding were inlined at high-complexity call sites. Fix - Move review option preparation into the focused boot helper module and combine capability observer setup behind one call. - Preserve behavior while returning agent.go and boot.go to their prior lint budgets. Verification - go run ./tools/repolint - go test ./internal/agent ./internal/boot -count=1 - golangci-lint run ./... * fix(boot): remove ineffectual review budget result Problem Linux CI reports two ineffectual assignments when review subagent options are prepared. Root cause The extracted helper returned the adjusted step count after it had already embedded that value in agent.Options, while callers never read the returned count again. Fix Narrow the helper contract to return only the rewritten task and completed options, and update both call sites. Verification go test ./internal/boot -count=1 go run ./tools/repolint golangci-lint run --timeout=5m ./... * fix(agent): close speed and quality review gaps Problem: PR #9569 still allowed invalid proxy arguments to reach hooks or remote tools, attributed MCP list activity imprecisely, repeated equivalent decisions and outputs, and used a synthetic performance fixture as release evidence.\n\nRoot cause: Validation, dispatch telemetry, retry semantics, discovery attribution, loop guards, and release qualification were implemented at separate abstraction layers without a single resolved-tool contract.\n\nFix: Validate resolved tools before hooks and dispatch, preserve exact remote-dispatch telemetry, reject MCP application errors from transport retries, deduplicate decisions and outputs, bound inspect responses, attribute live MCP list changes to active sessions, enforce rolling soft budgets, and add a live paired-run release gate.\n\nVerification: go test ./...; targeted Go race tests; go vet ./...; golangci-lint; repolint; desktop and SDK Go tests; frontend build; all 239 frontend suites. * test(desktop): follow composer measurement mirror Problem: The latest main-v2 composer autosize change made the full frontend suite fail seven run-strip height assertions. Root cause: The regression test still mocked scrollHeight on the live textarea even though production now measures an out-of-flow mirror. Fix: Mock the measurement mirror while continuing to assert the live textarea and card geometry. Verification: The focused composer tests and all 239 frontend suites pass; the production build and bundle budgets also pass. * test(desktop): stabilize native tail fixture Problem: The Windows WebView2 smoke failed before its composer assertions when the initial history already exceeded the target row count. Root cause: The prepared multiline draft could shrink the native viewport one paint late while logical ownership remained tail-follow, leaving no jump-bottom control for fixture setup. Fix: Normalize only the logical tail-follow setup to the physical tail, continue requiring the product control in manual-reader mode, and verify the loaded tail after recovery. Verification: node syntax check; desktop Go tests; repolint; local native fixture passed the modified setup and reached native-event sampling. * fix(desktop): preserve tail during hydration resize WebView2 could keep logical tail-follow while a restored multiline draft shrank the transcript during history hydration, leaving the physical viewport 37-74px above the tail. Route those viewport resize events through the existing tail controller only while tail-follow ownership is active. Manual readers remain untouched, and the native smoke now verifies product behavior without a fixture-owned scroll write. Verified with the frontend build, all 239 frontend suites, transcript and composer suites, desktop Go tests, native contract syntax, repolint, and diff checks. * fix(desktop): repair hydrating footer tail gaps The Windows matrix confirmed the restored multiline draft changes the App footer while transcript hydration is active. The footer-height effect discarded that event, and the ResizeObserver could be recreated after the height change, leaving logical tail-follow 37px above the physical tail. Allow footer resize repairs whenever the transcript still owns tail-follow, including during hydration, while continuing to block manual readers. Use the canonical scroll mode for the viewport fallback as well. Verified with transcript and composer suites, frontend build, desktop Go tests, native contract syntax, repolint, and diff checks. * test(boot): isolate provider prefix effects * fix(desktop): pin composer footer tail before paint * fix(desktop): settle staged native footer growth * test(boot): fence history index cleanup * fix(desktop): make transcript tail physically reachable * fix(desktop): use painted WebView2 viewport extent * fix(desktop): learn reachable WebView2 transcript tail * fix(desktop): retain asynchronous WebView2 tail evidence * fix(agent): preserve MCP concurrency policy at runtime Problem: Configured MCP serial/parallel policy disappeared when the session runtime copied plugin entries, allowing explicitly serial stateful servers to be classified and executed concurrently. Root cause: runtimePluginEntry retained only name, source, and auto-start metadata, while both batch classification and the execution gate read Concurrency from that reduced entry. Fix: Normalize and retain Concurrency in the runtime entry. Add regression coverage through both ConfigureServers and UpsertServer so initial assembly and hot updates preserve explicit serial and parallel behavior. Verification: - go test ./internal/agent -run MCP concurrency tests -count=1 - go test -race ./internal/agent -run MCP concurrency tests -count=1 - go test ./... -count=1 - go vet ./... - go run ./tools/repolint	2026-08-29 23:52:41 +08:00