mirror of
https://github.com/esengine/DeepSeek-Reasonix.git
synced 2026-11-07 02:36:01 -10:00
Two things cost a full CI round trip each, both avoidable. REASONIX.md told contributors golangci-lint was "not locally available", so nobody ran it. It always was: lint-cross already shells out to it. What was missing is a pinned version and one command. `.golangci-version` is now the single pin the Makefile and the lint job both read, `make lint-install` installs it (with CGO_ENABLED=0, so a stray clang on PATH cannot break the install), and `make lint` runs the same two gates CI runs, in the same order. Replaying a recent PR's diff through it reproduces the exact `modernize` finding CI took ten minutes to report. The Windows smoke step then failed on a run whose only change was two test fixtures. Across four consecutive runs of near-identical code, internal/boot measured 133s, 146s, 162s and 180s, and internal/agent 82s, 92s, 144s and 180s: a 2.2x spread from runner variance, four heavy packages sharing four vCPUs. A 3 minute per-package timeout sat inside that spread, so the step was one slow runner away from failing at any time. It is 8m now, still well inside the step's own 15 minute budget, which is what actually catches a hang. Neither change touches what is tested.
2 lines
8 B
Plaintext
2 lines
8 B
Plaintext
v2.12.2
|