Files
YHH 23f0a011c4 fix(config): workspace configuration only narrows the user's settings (#11208)
A workspace's reasonix.toml and .reasonix/settings.json are read as
untrusted input.

- [sandbox]: bash may only move to enforce and network only to false;
  forbid_read and denied_domains add to the user's; allow_write entries
  and workspace_root apply only when they resolve inside the workspace.
  ${VAR} in sandbox and proxy paths expands from the process environment
  only.
- [permissions] mode, allow and allow_dynamic_bash, [network] proxy
  settings and [desktop] default_tool_approval_mode are read from the
  user config only; deny and ask add to the user's. An "always allow"
  given in a workspace is stored under the Reasonix home
  (project-grants.json) rather than in the checkout.
- Programs a workspace declares (hooks, language servers, providers,
  tools.search.rg_path, tools.shell.path, [browser], tools.system_one
  endpoints and the local Laya runtime) run only once approved for that
  folder. An approval records the declaration and a digest of the files
  it names, is kept under the Reasonix home, and is checked again before
  each start; a change refuses the start with ErrProjectProgramChanged.
  `reasonix trust` lists and approves them, and saving hooks from the
  hooks page approves the block written. Model settings that named only
  a held-back provider fall back to the user's choice.
- Single program paths may not point into the workspace, a temporary
  directory, an allow_write root or a toolchain cache.
- Sandbox write roots and host write directories keep the identity they
  had when first granted; a root whose identity changed is dropped with
  sandbox.write_root_redirected or sandbox.write_root_changed. The
  host-writable directory list lives in internal/base/hostwrite.
- Every ignored value is reported as a load warning with a typed reason
  (Config.IgnoredProjectSettings); held-back programs raise the
  project_programs_awaiting_approval notice.
2026-09-28 18:21:34 -07:00

61 lines
1.5 KiB
Go

package boot
import (
"slices"
"strings"
"testing"
"reasonix/internal/tools/builtin"
)
// A steered name missing from the provider schema cannot be called, so the whole
// recommendation reads as unreliable and the model falls back to shell reads.
// Asserted against the real boot surface, not the declared allowlist, so a tool
// dropped during registration fails here too.
func TestBashSteerNamesReachTheProviderSurface(t *testing.T) {
isolateConfigHome(t)
dir := robustTempDir(t)
t.Chdir(dir)
writeFile(t, dir, "reasonix.toml", `
default_model = "test-model"
[agent]
system_prompt = "BASE"
[[providers]]
name = "test-model"
kind = "boot-token-profile-test"
model = "x"
`)
approveWorkspace(t, dir)
req, _ := captureTokenProfileSurface(t, "")
visible := toolSchemaNames(req.Tools)
steered := builtin.BashSteerTools()
if len(steered) == 0 {
t.Fatal("bash steer recommends no tools; the shell recipes in the description go uncountered")
}
for _, name := range steered {
if !slices.Contains(visible, name) {
t.Fatalf("bash description recommends %q but it is not provider-visible\nvisible=%v", name, visible)
}
}
var bashDesc string
for _, s := range req.Tools {
if s.Name == "bash" {
bashDesc = s.Description
break
}
}
if bashDesc == "" {
t.Fatalf("bash missing from provider surface; visible=%v", visible)
}
for _, name := range steered {
if !strings.Contains(bashDesc, name) {
t.Fatalf("bash description does not mention steered tool %q\ndescription=%q", name, bashDesc)
}
}
}