Files
DeepSeek-Reasonix/internal/assembly/boot/deepseek_protocol_migration_test.go
yhh 394da0a313 refactor: the kernel's packages live in the layer they belong to
internal/ was 141 packages side by side, so nothing but a reader's memory
said which were foundations and which assembled the rest. Each now sits in a
layer directory, and the directory is the declaration:

  base      L0  foundation with no domain in it
  contract  L1  types and interfaces the layers above agree on
  model, tools, safety, ext, state, platform
            L2  subsystems, peers of one another
  runtime   L3  the turn engine
  session   L4  the controller
  assembly  L5  the composition root
  frontend  L6  cli, serve, acp and the host adapters

Only paths change: package names, code and behaviour do not. Imports,
repolint and coverage baselines, sensitive paths, CI package lists and docs
follow the new paths; release notes keep the paths they were written with,
and sample paths inside tests and fixtures keep theirs.

repolint gains layer-order: a package may import its own layer and those
below it, read from where it lives. The 47 imports that point upward today
are recorded as that rule's opening debt (-allow-widen, a new rule's first
baseline) and can only go down. Most of it is config, which still reaches
into eight subsystems and is the next thing to take apart; the rest is
event, history and a few tools reaching into runtime for types that belong
in contract.
2026-09-23 18:28:21 -07:00

183 lines
5.6 KiB
Go

package boot
import (
"bytes"
"context"
"os"
"path/filepath"
"strings"
"testing"
"reasonix/internal/contract/config"
"reasonix/internal/contract/event"
"reasonix/internal/contract/surface"
)
func TestBuildScopesMalformedConfigDeepSeekMigrationWarningToNonDesktopFrontends(t *testing.T) {
tests := []struct {
name string
statsSource surface.Surface
handleWarnings bool
wantNotice bool
}{
{name: "desktop accepts persistent config warning", statsSource: surface.Desktop, handleWarnings: true},
{name: "desktop without warning handler keeps boot warning", statsSource: surface.Desktop, wantNotice: true},
{name: "CLI keeps boot warning", statsSource: surface.CLI, wantNotice: true},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
home := isolateConfigHome(t)
t.Setenv("REASONIX_HOME", filepath.Join(home, "reasonix-home"))
userPath := config.UserConfigPath()
if err := os.MkdirAll(filepath.Dir(userPath), 0o700); err != nil {
t.Fatal(err)
}
raw := `[[providers]]
name = "deepseek-flash"
kind = "openai"
base_url = "https://api.deepseek.com"
model = "deepseek-v4-flash"
api_key_env = "DEEPSEEK_API_KEY"
[[plugins]]
name = "windows-mcp"
command = "C:\Users\reasonix\mcp.exe"
`
if err := os.WriteFile(userPath, []byte(raw), 0o600); err != nil {
t.Fatal(err)
}
var notices []event.Event
sink := event.FuncSink(func(e event.Event) {
if e.Kind == event.Notice {
notices = append(notices, e)
}
})
var handledWarnings []string
opts := Options{Sink: sink, WorkspaceRoot: robustTempDir(t), StatsSource: tt.statsSource}
if tt.handleWarnings {
opts.OnConfigLoadWarnings = func(warnings []string) bool {
handledWarnings = append([]string(nil), warnings...)
return true
}
}
ctrl, err := Build(context.Background(), opts)
if err != nil {
t.Fatalf("Build: %v", err)
}
ctrl.Close()
var migrationNotice *event.Event
for i := range notices {
if notices[i].Text == "DeepSeek protocol migration did not complete." {
migrationNotice = &notices[i]
break
}
}
if got := migrationNotice != nil; got != tt.wantNotice {
t.Fatalf("migration notice present = %v, want %v; notices=%+v", got, tt.wantNotice, notices)
}
if got := len(handledWarnings) > 0; got != tt.handleWarnings {
t.Fatalf("config warnings handled = %v, want %v; warnings=%v", got, tt.handleWarnings, handledWarnings)
}
if migrationNotice != nil &&
(migrationNotice.Level != event.LevelWarn || !strings.Contains(migrationNotice.Detail, "toml:")) {
t.Fatalf("migration notice lost parse diagnostics: %+v", *migrationNotice)
}
next, err := os.ReadFile(userPath)
if err != nil {
t.Fatal(err)
}
if string(next) != raw {
t.Fatalf("build rewrote malformed config:\n%s", next)
}
})
}
}
func TestBuildDeliversProjectConfigWarningsWithoutDeepSeekMigrationError(t *testing.T) {
home := isolateConfigHome(t)
t.Setenv("REASONIX_HOME", filepath.Join(home, "reasonix-home"))
workspace := robustTempDir(t)
projectPath := filepath.Join(workspace, "reasonix.toml")
raw := `[[plugins]]
name = "windows-mcp"
command = "C:\Users\reasonix\mcp.exe"
`
if err := os.WriteFile(projectPath, []byte(raw), 0o600); err != nil {
t.Fatal(err)
}
var handledWarnings []string
var notices []event.Event
ctrl, err := Build(context.Background(), Options{
WorkspaceRoot: workspace,
StatsSource: surface.Desktop,
Sink: event.FuncSink(func(e event.Event) {
if e.Kind == event.Notice {
notices = append(notices, e)
}
}),
OnConfigLoadWarnings: func(warnings []string) bool {
handledWarnings = append([]string(nil), warnings...)
return true
},
})
if err != nil {
t.Fatalf("Build: %v", err)
}
ctrl.Close()
if len(handledWarnings) == 0 || !strings.Contains(strings.Join(handledWarnings, "\n"), "project config") {
t.Fatalf("project config warnings were not delivered: %v", handledWarnings)
}
for _, notice := range notices {
if notice.Text == "DeepSeek protocol migration did not complete." {
t.Fatalf("project config damage produced an unrelated migration notice: %+v", notice)
}
}
next, err := os.ReadFile(projectPath)
if err != nil {
t.Fatal(err)
}
if string(next) != raw {
t.Fatalf("build rewrote malformed project config:\n%s", next)
}
}
// TestABrokenConfigSaysSoWithNoFrontendListening pins the other half: a host
// that registered no handler still tells whoever started the session. The
// loader keeps going on built-in defaults — another model, and none of the
// person's permission rules — so silence there is a session running as someone
// else with nothing on screen to say it.
func TestABrokenConfigSaysSoWithNoFrontendListening(t *testing.T) {
isolateConfigHome(t)
workspace := robustTempDir(t)
broken := "default_model = \"x/y\"\n\n[browser]\nenabled = true\n\n[browser]\nheadless = true\n"
userConfig := config.UserConfigPath()
if err := os.MkdirAll(filepath.Dir(userConfig), 0o700); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(userConfig, []byte(broken), 0o600); err != nil {
t.Fatal(err)
}
var said bytes.Buffer
ctrl, err := Build(context.Background(), Options{
WorkspaceRoot: workspace,
StatsSource: surface.CLI,
Sink: event.Discard,
Stderr: &said,
})
if err != nil {
t.Fatalf("Build: %v", err)
}
ctrl.Close()
// The words that carry the consequence: which file, that it was not read,
// and what the session is running on instead.
for _, want := range []string{userConfig, "invalid", "built-in defaults"} {
if !strings.Contains(said.String(), want) {
t.Fatalf("the broken config was not reported (%q missing):\n%s", want, said.String())
}
}
}