Files
YHH 23f0a011c4 fix(config): workspace configuration only narrows the user's settings (#11208)
A workspace's reasonix.toml and .reasonix/settings.json are read as
untrusted input.

- [sandbox]: bash may only move to enforce and network only to false;
  forbid_read and denied_domains add to the user's; allow_write entries
  and workspace_root apply only when they resolve inside the workspace.
  ${VAR} in sandbox and proxy paths expands from the process environment
  only.
- [permissions] mode, allow and allow_dynamic_bash, [network] proxy
  settings and [desktop] default_tool_approval_mode are read from the
  user config only; deny and ask add to the user's. An "always allow"
  given in a workspace is stored under the Reasonix home
  (project-grants.json) rather than in the checkout.
- Programs a workspace declares (hooks, language servers, providers,
  tools.search.rg_path, tools.shell.path, [browser], tools.system_one
  endpoints and the local Laya runtime) run only once approved for that
  folder. An approval records the declaration and a digest of the files
  it names, is kept under the Reasonix home, and is checked again before
  each start; a change refuses the start with ErrProjectProgramChanged.
  `reasonix trust` lists and approves them, and saving hooks from the
  hooks page approves the block written. Model settings that named only
  a held-back provider fall back to the user's choice.
- Single program paths may not point into the workspace, a temporary
  directory, an allow_write root or a toolchain cache.
- Sandbox write roots and host write directories keep the identity they
  had when first granted; a root whose identity changed is dropped with
  sandbox.write_root_redirected or sandbox.write_root_changed. The
  host-writable directory list lives in internal/base/hostwrite.
- Every ignored value is reported as a load warning with a typed reason
  (Config.IgnoredProjectSettings); held-back programs raise the
  project_programs_awaiting_approval notice.
2026-09-28 18:21:34 -07:00

97 lines
2.7 KiB
Go

package boot
import (
"context"
"strings"
"testing"
"reasonix/internal/contract/config"
)
func TestBuildAppendsWorkPracticePolicyToCustomSystemPrompt(t *testing.T) {
dir := robustTempDir(t)
t.Chdir(dir)
writeFile(t, dir, "reasonix.toml", `
default_model = "test-model"
[agent]
system_prompt = "BASE"
[[providers]]
name = "test-model"
kind = "openai"
base_url = "https://example.invalid"
model = "x"
api_key_env = "REASONIX_TEST_KEY_UNSET"
`)
approveWorkspace(t, dir)
ctrl, err := Build(context.Background(), Options{})
if err != nil {
t.Fatalf("Build: %v", err)
}
defer ctrl.Close()
sys := systemMessage(ctrl.History())
for _, want := range []string{"Work practices:", "implement exactly that", "review the final diff"} {
if !strings.Contains(sys, want) {
t.Fatalf("work practice policy missing %q from custom system prompt:\n%s", want, sys)
}
}
if strings.Index(sys, config.UserDecisionPolicy) >= strings.Index(sys, config.WorkPracticePolicy) ||
strings.Index(sys, config.WorkPracticePolicy) >= strings.Index(sys, config.LanguagePolicy) {
t.Fatal("policy order must be user-decision < work-practice < language")
}
}
func TestWorkPracticePolicyCarriesNoEnvironmentSpecificClaims(t *testing.T) {
for _, unwanted := range []string{"offline", "proxy", "stop retrying", "avoid repeated full-suite runs", "pre-exist"} {
if strings.Contains(strings.ToLower(config.WorkPracticePolicy), unwanted) {
t.Errorf("work practice policy must not assert %q", unwanted)
}
}
}
func TestBuildInjectsOfflineNoteOnlyWhenEnvironmentDeclaresIt(t *testing.T) {
build := func(t *testing.T, environmentSection string) string {
t.Helper()
dir := robustTempDir(t)
t.Chdir(dir)
writeFile(t, dir, "reasonix.toml", `
default_model = "test-model"
[agent]
system_prompt = "BASE"
[[providers]]
name = "test-model"
kind = "openai"
base_url = "https://example.invalid"
model = "x"
api_key_env = "REASONIX_TEST_KEY_UNSET"
`+environmentSection)
approveWorkspace(t, dir)
ctrl, err := Build(context.Background(), Options{})
if err != nil {
t.Fatalf("Build: %v", err)
}
defer ctrl.Close()
return systemMessage(ctrl.History())
}
if sys := build(t, ""); strings.Contains(sys, config.OfflineEnvironmentNote) {
t.Fatalf("undeclared environment includes offline note:\n%s", sys)
}
if sys := build(t, "\n[environment]\noffline = true\n"); !strings.Contains(sys, config.OfflineEnvironmentNote) {
t.Fatalf("declared offline environment missing note:\n%s", sys)
}
sys := build(t, "\n[environment]\nenabled = false\noffline = true\n")
if !strings.Contains(sys, config.OfflineEnvironmentNote) {
t.Fatal("offline declaration must survive disabled probing")
}
if strings.Contains(sys, "## Environment") {
t.Fatal("disabled probing must suppress the environment section")
}
}