Files
yhh 394da0a313 refactor: the kernel's packages live in the layer they belong to
internal/ was 141 packages side by side, so nothing but a reader's memory
said which were foundations and which assembled the rest. Each now sits in a
layer directory, and the directory is the declaration:

  base      L0  foundation with no domain in it
  contract  L1  types and interfaces the layers above agree on
  model, tools, safety, ext, state, platform
            L2  subsystems, peers of one another
  runtime   L3  the turn engine
  session   L4  the controller
  assembly  L5  the composition root
  frontend  L6  cli, serve, acp and the host adapters

Only paths change: package names, code and behaviour do not. Imports,
repolint and coverage baselines, sensitive paths, CI package lists and docs
follow the new paths; release notes keep the paths they were written with,
and sample paths inside tests and fixtures keep theirs.

repolint gains layer-order: a package may import its own layer and those
below it, read from where it lives. The 47 imports that point upward today
are recorded as that rule's opening debt (-allow-widen, a new rule's first
baseline) and can only go down. Most of it is config, which still reaches
into eight subsystems and is the next thing to take apart; the rest is
event, history and a few tools reaching into runtime for types that belong
in contract.
2026-09-23 18:28:21 -07:00

59 lines
1.9 KiB
Go

package agent
import "testing"
// The escalation path may only ever widen what runs by one narrow answer, so
// everything that is not a bare READONLY has to land on the refusing side.
func TestCommandClassOnlyAcceptsABareReadonly(t *testing.T) {
accepted := []string{"READONLY", "readonly", " ReadOnly \n"}
for _, reply := range accepted {
if !parseClassVerdict(reply, "READONLY") {
t.Errorf("parseClassVerdict(%q) = false, want true", reply)
}
}
refused := []string{
"WRITES",
"",
"READONLY, but it depends on the flags",
"probably READONLY",
"READONLY WRITES",
"I think this only reads",
"READ", // truncated at the token cap
}
for _, reply := range refused {
if parseClassVerdict(reply, "READONLY") {
t.Errorf("parseClassVerdict(%q) = true, want false: only a bare verdict counts", reply)
}
}
}
// A verdict has to be stable: the same segment feeds the evidence ledger, which
// is audited, so asking twice must not be able to answer differently.
func TestCommandClassCacheAnswersOnce(t *testing.T) {
var c commandClassCache
if _, ok := c.get("jq .name pkg.json"); ok {
t.Fatal("empty cache reported a verdict")
}
c.put("jq .name pkg.json", true)
got, ok := c.get("jq .name pkg.json")
if !ok || !got {
t.Fatalf("cache returned (%v, %v), want the stored verdict", got, ok)
}
c.put("rm -rf build", false)
if got, ok := c.get("rm -rf build"); !ok || got {
t.Fatalf("cache returned (%v, %v) for a writing command", got, ok)
}
}
// Without a provider there is nothing to escalate to, and the answer must stay
// on the conservative side rather than defaulting to permissive.
func TestSegmentIsReadOnlyWithoutProviderRefuses(t *testing.T) {
var a Agent
if a.segmentIsReadOnly(t.Context(), "jq .name pkg.json") {
t.Fatal("classified read-only with no provider to ask")
}
if (&Agent{}).segmentIsReadOnly(t.Context(), "") {
t.Fatal("classified an empty segment as read-only")
}
}