mirror of
https://github.com/esengine/DeepSeek-Reasonix.git
synced 2026-11-07 10:45:59 -10:00
internal/ was 141 packages side by side, so nothing but a reader's memory
said which were foundations and which assembled the rest. Each now sits in a
layer directory, and the directory is the declaration:
base L0 foundation with no domain in it
contract L1 types and interfaces the layers above agree on
model, tools, safety, ext, state, platform
L2 subsystems, peers of one another
runtime L3 the turn engine
session L4 the controller
assembly L5 the composition root
frontend L6 cli, serve, acp and the host adapters
Only paths change: package names, code and behaviour do not. Imports,
repolint and coverage baselines, sensitive paths, CI package lists and docs
follow the new paths; release notes keep the paths they were written with,
and sample paths inside tests and fixtures keep theirs.
repolint gains layer-order: a package may import its own layer and those
below it, read from where it lives. The 47 imports that point upward today
are recorded as that rule's opening debt (-allow-widen, a new rule's first
baseline) and can only go down. Most of it is config, which still reaches
into eight subsystems and is the next thing to take apart; the rest is
event, history and a few tools reaching into runtime for types that belong
in contract.
160 lines
5.3 KiB
Go
160 lines
5.3 KiB
Go
package main
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
|
|
"reasonix/internal/base/testenv"
|
|
)
|
|
|
|
func TestPackagesForMapsGlobsOntoPackages(t *testing.T) {
|
|
got := packagesFor([]string{
|
|
"internal/safety/permission/**",
|
|
"internal/session/control/approval.go",
|
|
"internal/safety/permission/**",
|
|
})
|
|
want := []string{"./internal/safety/permission/...", "./internal/session/control/..."}
|
|
if !reflect.DeepEqual(got, want) {
|
|
t.Fatalf("packagesFor = %v, want %v", got, want)
|
|
}
|
|
// A go package pattern is slash-separated on every host. Only Windows ever
|
|
// said otherwise, and it said it twice: an unmatchable pattern, and an order
|
|
// that changed with it because a backslash outranks a slash.
|
|
for _, pkg := range got {
|
|
if strings.ContainsRune(pkg, '\\') {
|
|
t.Errorf("package pattern %q carries a host separator", pkg)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestMatchesGlobHandlesSubtreesAndExactFiles(t *testing.T) {
|
|
for _, tc := range []struct {
|
|
glob, file string
|
|
want bool
|
|
}{
|
|
{"internal/safety/permission/**", "internal/safety/permission/rule.go", true},
|
|
{"internal/safety/permission/**", "internal/permissionx/rule.go", false},
|
|
{"internal/session/control/approval.go", "internal/session/control/approval.go", true},
|
|
{"internal/session/control/approval.go", "internal/session/control/controller.go", false},
|
|
} {
|
|
if got := matchesGlob(tc.glob, tc.file); got != tc.want {
|
|
t.Errorf("matchesGlob(%q, %q) = %v, want %v", tc.glob, tc.file, got, tc.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
// A file-level declaration must be measured as that file, not as its package:
|
|
// approval.go sits in a package the project did not call sensitive.
|
|
func TestFromProfileAggregatesPerDeclaredPath(t *testing.T) {
|
|
dir := testenv.TempDir(t)
|
|
profile := filepath.Join(dir, "c.out")
|
|
body := "mode: set\n" +
|
|
"reasonix/internal/session/control/approval.go:1.1,2.2 4 1\n" +
|
|
"reasonix/internal/session/control/approval.go:3.1,4.2 4 0\n" +
|
|
"reasonix/internal/session/control/controller.go:1.1,2.2 100 0\n" +
|
|
"reasonix/internal/safety/permission/rule.go:1.1,2.2 3 1\n"
|
|
if err := os.WriteFile(profile, []byte(body), 0o600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
got, _, err := fromProfile(profile, []string{"internal/session/control/approval.go", "internal/safety/permission/**"})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if got["internal/session/control/approval.go"] != 50.0 {
|
|
t.Errorf("approval.go = %v, want 50 (the file, not its package)", got["internal/session/control/approval.go"])
|
|
}
|
|
if got["internal/safety/permission/**"] != 100.0 {
|
|
t.Errorf("permission = %v, want 100", got["internal/safety/permission/**"])
|
|
}
|
|
}
|
|
|
|
// The recorded floor and the value compared against it must be the same number,
|
|
// or a freshly written baseline fails against itself.
|
|
func TestMeasuredValuesAreRoundedOnce(t *testing.T) {
|
|
dir := testenv.TempDir(t)
|
|
profile := filepath.Join(dir, "c.out")
|
|
if err := os.WriteFile(profile, []byte("mode: set\nreasonix/internal/x/a.go:1.1,2.2 3 1\n"), 0o600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
got, _, err := fromProfile(profile, []string{"internal/x/**"})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
path := filepath.Join(dir, "baseline.json")
|
|
if err := write(path, got); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
loaded, err := load(path)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if loaded["internal/x/**"] != got["internal/x/**"] {
|
|
t.Fatalf("round trip changed the floor: %v -> %v", got["internal/x/**"], loaded["internal/x/**"])
|
|
}
|
|
if d := drops(loaded, got); len(d) != 0 {
|
|
t.Fatalf("a freshly written baseline reports a drop against itself: %v", d)
|
|
}
|
|
}
|
|
|
|
func TestDropsReportsOnlyLoweredFloors(t *testing.T) {
|
|
prev := map[string]float64{"a": 80, "b": 50}
|
|
next := map[string]float64{"a": 79.9, "b": 60}
|
|
got := drops(prev, next)
|
|
if len(got) != 1 || got[0] != "a: 80.0% -> 79.9%" {
|
|
t.Fatalf("drops = %v, want only the lowered floor", got)
|
|
}
|
|
}
|
|
|
|
// The gate reads the same `sensitive:` bullets the runtime reads, so declaring
|
|
// a path once both hardens its review and holds its coverage.
|
|
func TestSensitiveGlobsComeFromTheProjectHostChecks(t *testing.T) {
|
|
globs, err := sensitiveGlobs("../..")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(globs) == 0 {
|
|
t.Fatal("no sensitive paths read from the project's host checks")
|
|
}
|
|
found := false
|
|
for _, g := range globs {
|
|
if g == "internal/safety/shellsafe/**" {
|
|
found = true
|
|
}
|
|
}
|
|
if !found {
|
|
t.Fatalf("declared sensitive paths not read: %v", globs)
|
|
}
|
|
}
|
|
|
|
// A floor that has slipped names the lines, largest first. A percentage alone
|
|
// leaves the reader measuring a package by hand on a platform they may not be
|
|
// on, which is how a shortfall on one GOOS goes unfixed.
|
|
func TestUncoveredBlocksAreReportedLargestFirst(t *testing.T) {
|
|
dir := t.TempDir()
|
|
profile := filepath.Join(dir, "c.out")
|
|
body := "mode: set\n" +
|
|
"reasonix/internal/x/a.go:1.1,2.2 3 1\n" +
|
|
"reasonix/internal/x/a.go:4.1,5.2 2 0\n" +
|
|
"reasonix/internal/x/b.go:7.1,9.2 5 0\n"
|
|
if err := os.WriteFile(profile, []byte(body), 0o600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
_, gaps, err := fromProfile(profile, []string{"internal/x/**"})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
got := gaps["internal/x/**"]
|
|
if len(got) != 2 {
|
|
t.Fatalf("gaps = %+v, want the two blocks nothing executed", got)
|
|
}
|
|
if got[0].stmts != 5 || got[0].where != "internal/x/b.go:7.1,9.2" {
|
|
t.Fatalf("first gap = %+v, want the largest one", got[0])
|
|
}
|
|
if n := len(topGaps(got, 1)); n != 1 {
|
|
t.Fatalf("topGaps kept %d, want the cap honoured", n)
|
|
}
|
|
}
|