mirror of
https://github.com/esengine/DeepSeek-Reasonix.git
synced 2026-11-07 10:45:59 -10:00
* refactor(go): adopt modern stdlib idioms across kernel and desktop Mechanical sweep with golangci-lint's modernize/intrange/copyloopvar/ usestdlibvars fixers plus hand-fixes for what they could not rewrite: slices.Contains, min/max, slices.Backward, WaitGroup.Go, reflect.TypeFor, maps.Copy, strings.Cut/CutPrefix/SplitSeq, strings.Builder, range-over-int. Net -549 lines with no behavior change. Three loops in session.go stay index-based: slices.Backward yields element copies, so the fixer's rewrite silently dropped writes to DecisionReceipts and ToolCalls (caught by TestDelivery* and TestDependentSameBatch*). All 49 slices.Backward sites were audited for that shape; only these three write through the index, and they carry a nolint with the reason. CaptureAfter's scan loop had an empty body and never ran any logic, so the fixer could not express it. Drop it and the accessor it was the only caller of. omitzero is deliberately untouched: turning omitempty into omitzero changes the JSON written for nested structs, which is a wire-format change to session files and the extension protocol. * build(lint): gate the modern-idiom linters Nothing stopped the codebase from drifting back to pre-1.22 idioms. Both modules are now clean for modernize, intrange, copyloopvar, and usestdlibvars, so enable them rather than leaving the sweep as a one-off. omitzero stays disabled with the reason inline; usetesting, perfsprint, and errorlint still have residue and land separately.
129 lines
4.3 KiB
Go
129 lines
4.3 KiB
Go
package main
|
|
|
|
import (
|
|
"errors"
|
|
"strings"
|
|
"sync/atomic"
|
|
"testing"
|
|
"time"
|
|
|
|
"reasonix/internal/event"
|
|
"reasonix/internal/provider"
|
|
)
|
|
|
|
func TestDisplayTurnBufferPreservesStreamingReplacementAndTools(t *testing.T) {
|
|
var buffer displayTurnBuffer
|
|
recordHistoryDisplayEvent(&buffer, event.Event{Kind: event.Reasoning, Text: "draft reason "})
|
|
recordHistoryDisplayEvent(&buffer, event.Event{Kind: event.Reasoning, Text: "continued"})
|
|
recordHistoryDisplayEvent(&buffer, event.Event{Kind: event.Text, Text: "draft answer"})
|
|
recordHistoryDisplayEvent(&buffer, event.Event{
|
|
Kind: event.Message,
|
|
Text: "final answer",
|
|
Reasoning: "final reason",
|
|
MemoryCitations: []provider.MemoryCitation{{
|
|
ID: "memory-1", Source: "project",
|
|
}},
|
|
})
|
|
recordHistoryDisplayEvent(&buffer, event.Event{Kind: event.ToolDispatch, Tool: event.Tool{
|
|
ID: "call-1", Name: "read_file", Args: `{"path":"settings.json"}`,
|
|
}})
|
|
recordHistoryDisplayEvent(&buffer, event.Event{Kind: event.ToolResult, Tool: event.Tool{
|
|
ID: "call-1", Output: "settings contents",
|
|
}})
|
|
|
|
got := buffer.materialize()
|
|
if len(got) != 3 {
|
|
t.Fatalf("messages = %d, want 3: %+v", len(got), got)
|
|
}
|
|
if got[0].Role != "assistant" || got[0].Content != "final answer" || got[0].Reasoning != "final reason" {
|
|
t.Fatalf("stream replacement changed: %+v", got[0])
|
|
}
|
|
if len(got[0].MemoryCitations) != 1 || got[0].MemoryCitations[0].ID != "memory-1" {
|
|
t.Fatalf("memory citations changed: %+v", got[0].MemoryCitations)
|
|
}
|
|
if got[1].Role != "assistant" || len(got[1].ToolCalls) != 1 || got[1].ToolCalls[0].ID != "call-1" || got[1].ToolCalls[0].Summary == "" {
|
|
t.Fatalf("tool call changed: %+v", got[1])
|
|
}
|
|
if got[2].Role != "tool" || got[2].ToolCallID != "call-1" || got[2].ToolName != "read_file" {
|
|
t.Fatalf("tool result changed: %+v", got[2])
|
|
}
|
|
}
|
|
|
|
func TestDisplayTurnBufferStreamingAllocationsStayNearLinear(t *testing.T) {
|
|
const (
|
|
chunks = 2_000
|
|
chunkSize = 32
|
|
)
|
|
chunk := strings.Repeat("x", chunkSize)
|
|
result := testing.Benchmark(func(b *testing.B) {
|
|
b.ReportAllocs()
|
|
for range b.N {
|
|
var buffer displayTurnBuffer
|
|
for range chunks {
|
|
recordHistoryDisplayEvent(&buffer, event.Event{Kind: event.Text, Text: chunk})
|
|
}
|
|
messages := buffer.materialize()
|
|
if len(messages) != 1 || len(messages[0].Content) != chunks*chunkSize {
|
|
b.Fatalf("materialized display length changed")
|
|
}
|
|
}
|
|
})
|
|
|
|
// Repeated string concatenation allocated roughly one full growing prefix
|
|
// per chunk (>69 MiB for this 64 KiB stream). Keep a generous ceiling for
|
|
// platform/runtime variance while pinning the intended near-linear shape.
|
|
if got, max := result.AllocedBytesPerOp(), int64(chunks*chunkSize*16); got > max {
|
|
t.Fatalf("stream allocated %d bytes/op, want <= %d (%s)", got, max, result.String())
|
|
}
|
|
if got := result.AllocsPerOp(); got > 100 {
|
|
t.Fatalf("stream allocated %d objects/op, want <= 100 (%s)", got, result.String())
|
|
}
|
|
t.Logf("64 KiB stream: %d bytes/op, %d allocs/op", result.AllocedBytesPerOp(), result.AllocsPerOp())
|
|
}
|
|
|
|
func TestPendingDisplayWriteRetriesWithoutDroppingTurn(t *testing.T) {
|
|
state := &tabDisplayState{}
|
|
var attempts atomic.Int32
|
|
persisted := make(chan struct{})
|
|
write := &pendingDisplayWrite{
|
|
dir: "sessions",
|
|
sessionPath: "sessions/session.jsonl",
|
|
userContent: "prompt",
|
|
messages: []HistoryMessage{{Role: "assistant", Content: "partial answer"}},
|
|
persist: func(_, _, _ string, messages []HistoryMessage) error {
|
|
attempt := attempts.Add(1)
|
|
if len(messages) != 1 || messages[0].Content != "partial answer" {
|
|
return errors.New("queued turn changed")
|
|
}
|
|
if attempt < 3 {
|
|
return errors.New("temporary lock contention")
|
|
}
|
|
close(persisted)
|
|
return nil
|
|
},
|
|
}
|
|
persistOrEnqueueDisplayWrite(state, write)
|
|
select {
|
|
case <-persisted:
|
|
case <-time.After(3 * time.Second):
|
|
t.Fatal("pending display write was not retried")
|
|
}
|
|
deadline := time.Now().Add(time.Second)
|
|
for {
|
|
state.mu.Lock()
|
|
pending := len(state.pendingWrites)
|
|
running := state.persistRunning
|
|
state.mu.Unlock()
|
|
if pending == 0 && !running {
|
|
break
|
|
}
|
|
if time.Now().After(deadline) {
|
|
t.Fatalf("retry worker did not drain: pending=%d running=%v", pending, running)
|
|
}
|
|
time.Sleep(5 * time.Millisecond)
|
|
}
|
|
if got := attempts.Load(); got != 3 {
|
|
t.Fatalf("persist attempts = %d, want 3", got)
|
|
}
|
|
}
|