mirror of
https://github.com/esengine/DeepSeek-Reasonix.git
synced 2026-11-07 10:45:59 -10:00
* refactor(go): adopt modern stdlib idioms across kernel and desktop Mechanical sweep with golangci-lint's modernize/intrange/copyloopvar/ usestdlibvars fixers plus hand-fixes for what they could not rewrite: slices.Contains, min/max, slices.Backward, WaitGroup.Go, reflect.TypeFor, maps.Copy, strings.Cut/CutPrefix/SplitSeq, strings.Builder, range-over-int. Net -549 lines with no behavior change. Three loops in session.go stay index-based: slices.Backward yields element copies, so the fixer's rewrite silently dropped writes to DecisionReceipts and ToolCalls (caught by TestDelivery* and TestDependentSameBatch*). All 49 slices.Backward sites were audited for that shape; only these three write through the index, and they carry a nolint with the reason. CaptureAfter's scan loop had an empty body and never ran any logic, so the fixer could not express it. Drop it and the accessor it was the only caller of. omitzero is deliberately untouched: turning omitempty into omitzero changes the JSON written for nested structs, which is a wire-format change to session files and the extension protocol. * build(lint): gate the modern-idiom linters Nothing stopped the codebase from drifting back to pre-1.22 idioms. Both modules are now clean for modernize, intrange, copyloopvar, and usestdlibvars, so enable them rather than leaving the sweep as a one-off. omitzero stays disabled with the reason inline; usetesting, perfsprint, and errorlint still have residue and land separately.
47 lines
1.3 KiB
Go
47 lines
1.3 KiB
Go
package main
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
"testing"
|
|
|
|
"reasonix/internal/event"
|
|
)
|
|
|
|
// All tabEventSink context mutations go through the locked setContext /
|
|
// clearContext accessors (no bare s.ctx = ... writes that data-race the
|
|
// s.context() reads in emitRuntimeEvent). After clearContext the sink stops
|
|
// emitting — emitRuntimeEvent sees a nil ctx and no-ops — and the queued
|
|
// emitter is drained, so a detached/backgrounded session can't flush stale
|
|
// events onto the now-rebound tab (#5352: stale "AI 不断输出" on the visible
|
|
// session after rapid session switching).
|
|
func TestTabEventSinkClearContextStopsEmission(t *testing.T) {
|
|
var mu sync.Mutex
|
|
var emitted int
|
|
s := &tabEventSink{tabID: "t"}
|
|
s.runtimeEvents.emit = func(context.Context, string, ...any) {
|
|
mu.Lock()
|
|
emitted++
|
|
mu.Unlock()
|
|
}
|
|
|
|
s.setContext(context.Background())
|
|
if s.context() == nil {
|
|
t.Fatal("setContext did not install the context")
|
|
}
|
|
|
|
s.clearContext()
|
|
if s.context() != nil {
|
|
t.Fatal("clearContext did not clear the context")
|
|
}
|
|
|
|
// An emit after clearContext must not reach the runtime bridge.
|
|
s.emitRuntimeEvent(eventChannel, toWireTab(event.Event{}, s.tabID))
|
|
|
|
mu.Lock()
|
|
defer mu.Unlock()
|
|
if emitted != 0 {
|
|
t.Fatalf("sink emitted %d events after clearContext, want 0", emitted)
|
|
}
|
|
}
|