mirror of
https://github.com/esengine/DeepSeek-Reasonix.git
synced 2026-11-07 02:36:01 -10:00
YHH
4fbbca6a99
* refactor(go): adopt modern stdlib idioms across kernel and desktop Mechanical sweep with golangci-lint's modernize/intrange/copyloopvar/ usestdlibvars fixers plus hand-fixes for what they could not rewrite: slices.Contains, min/max, slices.Backward, WaitGroup.Go, reflect.TypeFor, maps.Copy, strings.Cut/CutPrefix/SplitSeq, strings.Builder, range-over-int. Net -549 lines with no behavior change. Three loops in session.go stay index-based: slices.Backward yields element copies, so the fixer's rewrite silently dropped writes to DecisionReceipts and ToolCalls (caught by TestDelivery* and TestDependentSameBatch*). All 49 slices.Backward sites were audited for that shape; only these three write through the index, and they carry a nolint with the reason. CaptureAfter's scan loop had an empty body and never ran any logic, so the fixer could not express it. Drop it and the accessor it was the only caller of. omitzero is deliberately untouched: turning omitempty into omitzero changes the JSON written for nested structs, which is a wire-format change to session files and the extension protocol. * build(lint): gate the modern-idiom linters Nothing stopped the codebase from drifting back to pre-1.22 idioms. Both modules are now clean for modernize, intrange, copyloopvar, and usestdlibvars, so enable them rather than leaving the sweep as a one-off. omitzero stays disabled with the reason inline; usetesting, perfsprint, and errorlint still have residue and land separately.
36 lines
1.1 KiB
Go
36 lines
1.1 KiB
Go
package main
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// robustTempDir is a drop-in for t.TempDir whose cleanup retries RemoveAll for a
|
|
// short window. The Capabilities/history tests wire a Controller and isolate the
|
|
// user-config tree under a temp dir; at teardown a background resource can still
|
|
// hold a file under it for a few milliseconds after Close returns. On Windows
|
|
// that surfaces as "being used by another process"; on Linux a write racing
|
|
// RemoveAll surfaces as "directory not empty". Plain t.TempDir turns that
|
|
// teardown race into a red test even though every assertion passed (the
|
|
// recurring main-v2 CI flake). Retrying absorbs the race; a dir that never frees
|
|
// is logged, not fatal, so a genuine leak stays visible without the flake.
|
|
func robustTempDir(t *testing.T) string {
|
|
t.Helper()
|
|
dir, err := os.MkdirTemp("", "reasonix-test-*")
|
|
if err != nil {
|
|
t.Fatalf("robustTempDir: %v", err)
|
|
}
|
|
t.Cleanup(func() {
|
|
var rmErr error
|
|
for range 100 {
|
|
if rmErr = os.RemoveAll(dir); rmErr == nil {
|
|
return
|
|
}
|
|
time.Sleep(20 * time.Millisecond)
|
|
}
|
|
t.Logf("robustTempDir: cleanup did not converge for %s: %v", dir, rmErr)
|
|
})
|
|
return dir
|
|
}
|