Files
DeepSeek-Reasonix/desktop/updater_install_linux.go
T
YHH 4fbbca6a99 refactor(go): adopt modern stdlib idioms and gate them (#7831)
* refactor(go): adopt modern stdlib idioms across kernel and desktop

Mechanical sweep with golangci-lint's modernize/intrange/copyloopvar/
usestdlibvars fixers plus hand-fixes for what they could not rewrite:
slices.Contains, min/max, slices.Backward, WaitGroup.Go, reflect.TypeFor,
maps.Copy, strings.Cut/CutPrefix/SplitSeq, strings.Builder, range-over-int.
Net -549 lines with no behavior change.

Three loops in session.go stay index-based: slices.Backward yields element
copies, so the fixer's rewrite silently dropped writes to DecisionReceipts
and ToolCalls (caught by TestDelivery* and TestDependentSameBatch*). All 49
slices.Backward sites were audited for that shape; only these three write
through the index, and they carry a nolint with the reason.

CaptureAfter's scan loop had an empty body and never ran any logic, so the
fixer could not express it. Drop it and the accessor it was the only caller
of. omitzero is deliberately untouched: turning omitempty into omitzero
changes the JSON written for nested structs, which is a wire-format change
to session files and the extension protocol.

* build(lint): gate the modern-idiom linters

Nothing stopped the codebase from drifting back to pre-1.22 idioms. Both
modules are now clean for modernize, intrange, copyloopvar, and
usestdlibvars, so enable them rather than leaving the sweep as a one-off.

omitzero stays disabled with the reason inline; usetesting, perfsprint, and
errorlint still have residue and land separately.
2026-08-07 15:30:33 +08:00

136 lines
3.4 KiB
Go

//go:build linux
package main
import (
"bytes"
"os"
"os/exec"
"path/filepath"
"strings"
)
// dirIsWritable reports whether the process can create a temporary file in dir.
func dirIsWritable(dir string) bool {
if dir == "" {
return false
}
info, err := os.Stat(dir)
if err != nil || !info.IsDir() {
return false
}
f, err := os.CreateTemp(dir, ".reasonix-write-test-*")
if err != nil {
return false
}
name := f.Name()
_ = f.Close()
_ = os.Remove(name)
return true
}
// resolveExecutablePath returns the real path of the running binary.
func resolveExecutablePath() string {
exe, err := os.Executable()
if err != nil {
return ""
}
if resolved, err := filepath.EvalSymlinks(exe); err == nil {
exe = resolved
}
return exe
}
// detectLinuxInstallProfile classifies the running Linux install.
//
// deb — dpkg owns the absolute executable path as reasonix-desktop, and the
// Polkit helper + pkexec are present for authorized upgrades.
// portable — not dpkg-managed, install directory is writable (tarball flow).
// manual — system directory not writable, package ownership unclear, or
// authorization components missing.
func detectLinuxInstallProfile() installProfile {
exe := resolveExecutablePath()
if exe == "" {
return installProfile{
Mode: installModeManual,
CanSelfUpdate: false,
ManualReason: "cannot resolve the running executable path",
}
}
if isDpkgOwnedReasonix(exe) {
if linuxDebHelperReady() {
return installProfile{
Mode: installModeDeb,
CanSelfUpdate: true,
RequiresElev: true,
ArtifactKind: artifactKindDeb,
}
}
return installProfile{
Mode: installModeManual,
CanSelfUpdate: false,
ManualReason: manualDebInstallHint() + " (Polkit helper or pkexec is missing)",
}
}
dir := filepath.Dir(exe)
if dirIsWritable(dir) {
return installProfile{
Mode: installModePortable,
CanSelfUpdate: true,
ArtifactKind: artifactKindTarball,
}
}
return installProfile{
Mode: installModeManual,
CanSelfUpdate: false,
ManualReason: "this install is not writable and is not managed by the reasonix-desktop package; download the package from the download page",
}
}
// isDpkgOwnedReasonix reports whether absolute path belongs to the reasonix-desktop
// package. Uses absolute dpkg-query and requires both package name and path match.
func isDpkgOwnedReasonix(absPath string) bool {
if absPath == "" || !filepath.IsAbs(absPath) {
return false
}
if _, err := os.Stat("/usr/bin/dpkg-query"); err != nil {
return false
}
cmd := exec.Command("/usr/bin/dpkg-query", "-S", absPath)
var stdout, stderr bytes.Buffer
cmd.Stdout = &stdout
cmd.Stderr = &stderr
if err := cmd.Run(); err != nil {
return false
}
// Output shape: "reasonix-desktop: /usr/bin/reasonix-desktop"
line := strings.TrimSpace(stdout.String())
if line == "" {
return false
}
// dpkg-query may return multiple lines for diversions; require an exact package hit.
for raw := range strings.SplitSeq(line, "\n") {
raw = strings.TrimSpace(raw)
pkg, path, ok := strings.Cut(raw, ":")
if !ok {
continue
}
pkg = strings.TrimSpace(pkg)
path = strings.TrimSpace(path)
if pkg != linuxDebPackageName {
continue
}
if path == absPath {
return true
}
// Some dpkg versions report the path relative or with //; compare cleaned.
if filepath.Clean(path) == filepath.Clean(absPath) {
return true
}
}
return false
}