Files
DeepSeek-Reasonix/internal/agent/fleet.go
T
YHH 4fbbca6a99 refactor(go): adopt modern stdlib idioms and gate them (#7831)
* refactor(go): adopt modern stdlib idioms across kernel and desktop

Mechanical sweep with golangci-lint's modernize/intrange/copyloopvar/
usestdlibvars fixers plus hand-fixes for what they could not rewrite:
slices.Contains, min/max, slices.Backward, WaitGroup.Go, reflect.TypeFor,
maps.Copy, strings.Cut/CutPrefix/SplitSeq, strings.Builder, range-over-int.
Net -549 lines with no behavior change.

Three loops in session.go stay index-based: slices.Backward yields element
copies, so the fixer's rewrite silently dropped writes to DecisionReceipts
and ToolCalls (caught by TestDelivery* and TestDependentSameBatch*). All 49
slices.Backward sites were audited for that shape; only these three write
through the index, and they carry a nolint with the reason.

CaptureAfter's scan loop had an empty body and never ran any logic, so the
fixer could not express it. Drop it and the accessor it was the only caller
of. omitzero is deliberately untouched: turning omitempty into omitzero
changes the JSON written for nested structs, which is a wire-format change
to session files and the extension protocol.

* build(lint): gate the modern-idiom linters

Nothing stopped the codebase from drifting back to pre-1.22 idioms. Both
modules are now clean for modernize, intrange, copyloopvar, and
usestdlibvars, so enable them rather than leaving the sweep as a one-off.

omitzero stays disabled with the reason inline; usetesting, perfsprint, and
errorlint still have residue and land separately.
2026-08-07 15:30:33 +08:00

455 lines
16 KiB
Go
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
package agent
import (
"bytes"
"context"
"encoding/json"
"errors"
"fmt"
"io"
"strings"
"sync"
"time"
"reasonix/internal/event"
"reasonix/internal/evidence"
"reasonix/internal/jobs"
)
const (
fleetMinTasks = 2
fleetMaxTasks = 64
)
// FleetTool dispatches multiple profile-aware sub-agent tasks in parallel
// under the session scheduler. Write tasks must predeclare non-overlapping
// write_paths; preflight failure starts nothing.
type FleetTool struct {
taskTool *TaskTool
}
// NewFleetTool creates a fleet dispatcher that reuses TaskTool infrastructure.
func NewFleetTool(taskTool *TaskTool) *FleetTool {
return &FleetTool{taskTool: taskTool}
}
func (*FleetTool) Name() string { return "fleet" }
func (*FleetTool) Description() string {
return "Dispatch 2–64 sub-agent tasks in parallel and return bounded previews plus stable Subagent references for full-result retrieval from completed persisted children with read_subagent_result. Each item may select a profile, model, effort, tools, write_paths, or read_only. Multiple writers must declare non-overlapping write_paths; omitted write_paths claim the whole workspace, so two or more writers without paths fail preflight before any task starts. Independent failure is the default: one failure does not cancel others. Background mode returns a fleet job id collectable with wait."
}
func (*FleetTool) Schema() json.RawMessage {
return json.RawMessage(`{
"type":"object",
"properties":{
"tasks":{
"type":"array",
"description":"Array of 2–64 sub-tasks to run under the session scheduler.",
"minItems":2,
"maxItems":64,
"items":{
"type":"object",
"properties":{
"prompt":{"type":"string","description":"Task prompt for the sub-agent."},
"description":{"type":"string","description":"Optional short label shown in the job list."},
"profile":{"type":"string","description":"Optional runAs=subagent profile name."},
"write_paths":{"type":"array","items":{"type":"string"},"description":"Write targets for this item. Parallel writers must declare non-overlapping paths. Omitting write_paths claims the whole workspace; multiple whole-workspace claims (or any path overlap) fail preflight and start nothing."},
"read_only":{"type":"boolean","description":"Force the read-only registry even if the profile is writable."},
"tools":{"type":"array","items":{"type":"string"},"description":"Optional tool whitelist (intersected with profile allowed-tools)."},
"max_steps":{"type":"integer","description":"Optional max tool-call rounds.","minimum":1},
"model":{"type":"string","description":"Optional model override."},
"effort":{"type":"string","description":"Optional reasoning effort override."}
},
"required":["prompt"]
}
},
"run_in_background":{"type":"boolean","description":"Run the whole fleet asynchronously and return a job id collectable with wait. Items queue for concurrency/write slots inside the job."}
},
"required":["tasks"]
}`)
}
func (*FleetTool) ReadOnly() bool { return false }
type fleetTaskItem struct {
Prompt string `json:"prompt"`
Description string `json:"description"`
Profile string `json:"profile"`
WritePaths []string `json:"write_paths"`
ReadOnly bool `json:"read_only"`
Tools []string `json:"tools"`
MaxSteps int `json:"max_steps"`
Model string `json:"model"`
Effort string `json:"effort"`
}
type fleetItemStatus string
const (
fleetItemPending fleetItemStatus = "pending"
fleetItemCompleted fleetItemStatus = "completed"
fleetItemFailed fleetItemStatus = "failed"
fleetItemCancelled fleetItemStatus = "cancelled"
fleetItemSkipped fleetItemStatus = "skipped"
)
type fleetItemResult struct {
index int
status fleetItemStatus
profile string
output string
err error
ref string
}
// fleetGroupTerminalPhase classifies a fleet group's single terminal status:
// cancellation/deadline wins, then any failed child, then any error
// (including validation failures), then completed.
func fleetGroupTerminalPhase(ctx context.Context, err error, results []fleetItemResult) subagentProgressPhase {
if ctx.Err() != nil {
return subagentPhaseCancelled
}
for _, r := range results {
if r.status == fleetItemFailed {
return subagentPhaseFailed
}
}
if err != nil {
return subagentPhaseFailed
}
return subagentPhaseCompleted
}
func (f *FleetTool) Execute(ctx context.Context, args json.RawMessage) (result string, err error) {
if f == nil || f.taskTool == nil {
return "", fmt.Errorf("fleet is not configured")
}
// Group lifecycle: the group card's terminal is an explicit event from
// the tool (running once children start, exactly one terminal at the
// end) so frontends never infer group completion from the children they
// happen to have observed. Validation failures emit a failed terminal;
// once runFleet starts it owns the lifecycle (the background job runs
// runFleet inside the job, after this function has returned).
groupParentID, groupSink, _, ok := CallContext(ctx)
if !ok || groupSink == nil {
groupParentID = "fleet"
groupSink = event.Discard
}
// The merger emits already-namespaced group/child IDs, so it must use the
// raw call sink. A nested subSink would prefix the group ID a second time
// (group/group), leaving the frontend unable to match its lifecycle card.
merger := newSubagentProgressMerger(realProgressClock{}, groupSink, groupParentID)
lifecycleHandoff := false
mergerCloseHandoff := false
defer func() {
if !mergerCloseHandoff {
merger.Close()
}
}()
defer func() {
if lifecycleHandoff {
return
}
merger.directStatus(groupParentID, fleetGroupTerminalPhase(ctx, err, nil))
}()
ctx = withSubagentProgressMerger(ctx, merger)
var params struct {
Tasks []fleetTaskItem `json:"tasks"`
RunInBackground bool `json:"run_in_background"`
}
dec := json.NewDecoder(bytes.NewReader(args))
dec.DisallowUnknownFields()
if err := dec.Decode(&params); err != nil {
return "", fmt.Errorf("invalid args: %w", err)
}
if n := len(params.Tasks); n < fleetMinTasks || n > fleetMaxTasks {
return "", fmt.Errorf("fleet requires between %d and %d tasks (got %d)", fleetMinTasks, fleetMaxTasks, n)
}
specs := make([]ProfileExecSpec, len(params.Tasks))
// Keep one claim slot per original task so preflight errors report the
// caller-visible task numbers even when read-only items are interleaved.
claims := make([]WritePathSet, len(params.Tasks))
for i, item := range params.Tasks {
if strings.TrimSpace(item.Prompt) == "" {
return "", fmt.Errorf("task %d: prompt is required", i+1)
}
// Fleet writers without write_paths claim the whole workspace so the
// preflight can detect multi-writer collisions before anything starts.
forceBackgroundClaim := !item.ReadOnly
spec, err := f.taskTool.buildTaskSpec(ctx, item.Prompt, item.Description, item.Profile, item.WritePaths, item.Tools, item.MaxSteps, item.Model, item.Effort, "", "", false, item.ReadOnly)
if err != nil {
return "", fmt.Errorf("task %d: %w", i+1, err)
}
if forceBackgroundClaim && !spec.ReadOnly && spec.WritePaths.Empty() {
whole, werr := WholeWorkspaceWriteClaim(f.taskTool.workspaceRoot)
if werr != nil {
return "", fmt.Errorf("task %d: %w", i+1, werr)
}
spec.WritePaths = whole
}
spec.Nested = SubagentDepth(ctx) > 0
spec.RunInBackground = false // fleet owns backgrounding
if spec.Description == "" {
spec.Description = fmt.Sprintf("fleet-%d", i+1)
}
specs[i] = spec
if !spec.ReadOnly {
claims[i] = spec.WritePaths
}
}
if err := ValidateNonOverlappingWriteClaims(claims); err != nil {
return "", fmt.Errorf("fleet preflight: %w", err)
}
if params.RunInBackground {
for i := range specs {
specs[i].BackgroundWriter = !specs[i].ReadOnly
}
jm, ok := jobs.FromContext(ctx)
if !ok {
return "", fmt.Errorf("background execution is not available in this context")
}
parentID := groupParentID
parentSession := ParentSession(ctx)
label := fmt.Sprintf("fleet(%d)", len(specs))
backgroundEvidence := evidence.NewLedger()
writerID := fmt.Sprintf("background-fleet:%s:%d", parentID, time.Now().UnixNano())
writerRegistered := false
observer := f.taskTool.mutationObserver
if observer != nil {
hasWriter := false
for i := range specs {
if specs[i].BackgroundWriter {
hasWriter = true
break
}
}
if hasWriter {
if err := observer.RegisterWriter(writerID, "background_fleet", observer.OwnershipTurn()); err != nil {
return "", err
}
writerRegistered = true
}
}
job := jm.StartForSession(jobs.SessionFromContext(ctx), "fleet", label, func(jobCtx context.Context, _ io.Writer) (string, error) {
// Execute returns as soon as the job is registered, so the job owns
// the handed-off merger until every child preview and terminal has
// flushed. Closing it in Execute would strand child cards at running.
defer merger.Close()
if writerRegistered {
defer observer.UnregisterWriter(writerID)
}
jobCtx = WithParentSession(jobCtx, parentSession)
jobCtx = evidence.WithLedger(jobCtx, backgroundEvidence)
defer func() { jobs.PublishEvidence(jobCtx, backgroundEvidence.Summary()) }()
// The job shares the Execute-level merger so the group lifecycle
// events and the child previews ride the same pacing budget.
jobCtx = withSubagentProgressMerger(jobCtx, merger)
return f.runFleet(jobCtx, groupSink, specs, parentID)
})
// runFleet (inside the job) owns the terminal and merger close from
// here on. Foreground runFleet hands off only the terminal; Execute
// still closes the merger after the synchronous call returns.
lifecycleHandoff = true
mergerCloseHandoff = true
return fmt.Sprintf("Started background fleet %q (%s). Collect results with wait; you will be notified when it finishes.", job.ID, label), nil
}
lifecycleHandoff = true
return f.runFleet(ctx, groupSink, specs, groupParentID)
}
func (f *FleetTool) runFleet(ctx context.Context, sink event.Sink, specs []ProfileExecSpec, groupParentID string) (result string, err error) {
if sink == nil {
sink = event.Discard
}
// Child IDs are namespaced exactly once under the group call. Background
// jobs no longer carry the original call context, so groupParentID is the
// authoritative identity there; direct callers fall back to CallContext.
parentID := strings.TrimSpace(groupParentID)
if parentID == "" {
var ok bool
parentID, _, _, ok = CallContext(ctx)
if !ok || parentID == "" {
parentID = "fleet"
}
}
groupParentID = parentID
// The Execute-level merger (or a fallback for direct callers) paces the
// group; runFleet owns the lifecycle once it starts: running up front
// and exactly one terminal after every child settles.
merger := subagentProgressMergerFromContext(ctx)
ownsMerger := false
if merger == nil {
merger = newSubagentProgressMerger(realProgressClock{}, sink, groupParentID)
ownsMerger = true
ctx = withSubagentProgressMerger(ctx, merger)
}
if ownsMerger {
defer merger.Close()
}
merger.directStatus(groupParentID, subagentPhaseRunning)
var results []fleetItemResult
defer func() {
merger.directStatus(groupParentID, fleetGroupTerminalPhase(ctx, err, results))
}()
n := len(specs)
results = make([]fleetItemResult, n)
for i := range results {
results[i] = fleetItemResult{index: i, status: fleetItemPending, profile: specs[i].Profile}
}
var wg sync.WaitGroup
doneCh := make(chan fleetItemResult, n)
startOne := func(idx int) {
spec := specs[idx]
label := spec.Description
subID := fmt.Sprintf("%s/fleet-%d", parentID, idx+1)
dispatchArgs, _ := json.Marshal(map[string]any{
"prompt": spec.Prompt,
"description": label,
"profile": spec.Profile,
})
sink.Emit(event.Event{
Kind: event.ToolDispatch,
Tool: event.Tool{
ID: subID, ParentID: parentID, Name: "task",
Args: string(dispatchArgs), ReadOnly: spec.ReadOnly,
},
})
wg.Go(func() {
// Each fleet item runs as its own task-shaped execution so
// transcripts, evidence, and scheduler claims stay independent.
itemCtx := withCallContext(ctx, subID, subSinkFor(subID, sink), nil, false)
out, err := f.taskTool.RunProfileSpec(itemCtx, spec)
answer, ref := splitSubagentRunResult(out)
res := fleetItemResult{index: idx, profile: spec.Profile, output: answer, ref: ref, err: err}
if err == nil {
res.status = fleetItemCompleted
sink.Emit(event.Event{
Kind: event.ToolResult,
Tool: event.Tool{ID: subID, ParentID: parentID, Name: "task", Output: out},
})
} else {
if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) {
res.status = fleetItemCancelled
} else {
res.status = fleetItemFailed
}
sink.Emit(event.Event{
Kind: event.ToolResult,
Tool: event.Tool{ID: subID, ParentID: parentID, Name: "task", Err: err.Error()},
})
}
doneCh <- res
})
}
// Mark only genuinely unstarted items skipped. Started items always publish
// a terminal result, including after cancellation, so partial writer work is
// never misreported as a task that did not run.
started := 0
for i := range specs {
if ctx.Err() != nil {
for j := i; j < n; j++ {
results[j].status = fleetItemSkipped
results[j].err = ctx.Err()
}
break
}
startOne(i)
started++
}
completed := 0
cancelled := false
for completed < started && !cancelled {
select {
case r := <-doneCh:
results[r.index] = r
completed++
case <-ctx.Done():
cancelled = true
}
}
// doneCh is buffered for every item, so workers can always publish their
// terminal result while this goroutine waits. Once they stop, drain exactly
// the outstanding started items and preserve their real completed/cancelled
// status instead of replacing it with skipped.
wg.Wait()
for completed < started {
r := <-doneCh
results[r.index] = r
completed++
}
for _, r := range results {
if r.status == fleetItemCancelled || r.status == fleetItemSkipped {
cancelled = true
break
}
}
if cancelled {
err := ctx.Err()
if err == nil {
err = context.Canceled
}
return formatFleetAggregate(results, true), err
}
return formatFleetAggregate(results, false), nil
}
func formatFleetAggregate(results []fleetItemResult, cancelled bool) string {
n := len(results)
var prefix string
if cancelled {
completed := 0
for _, r := range results {
if r.status == fleetItemCompleted {
completed++
}
}
prefix = fmt.Sprintf("Cancelled fleet after completing %d of %d tasks:\n", completed, n)
} else {
prefix = fmt.Sprintf("Completed fleet of %d tasks:\n", n)
}
items := make([]subagentAggregateItem, 0, n)
for i, r := range results {
header := fmt.Sprintf("── task-%d", i+1)
if r.profile != "" {
header += " profile=" + boundedInline(r.profile, 80)
}
header += " ──\n"
item := subagentAggregateItem{header: header, ref: r.ref}
switch r.status {
case fleetItemCompleted:
item.status = "status: completed\n"
item.answer = strings.TrimSpace(r.output)
case fleetItemFailed:
item.status = "status: failed\n"
if r.err != nil {
item.detail = fmt.Sprintf("[FAILED] %s\n", boundedInline(r.err.Error(), 256))
}
case fleetItemCancelled:
item.status = "status: cancelled\n"
if r.err != nil {
item.detail = fmt.Sprintf("[CANCELLED] %s\n", boundedInline(r.err.Error(), 256))
}
case fleetItemSkipped:
item.status = "status: skipped\n"
if r.err != nil {
item.detail = fmt.Sprintf("[SKIPPED] %s\n", boundedInline(r.err.Error(), 256))
}
default:
item.status = "status: pending\n"
}
items = append(items, item)
}
return formatBoundedSubagentAggregate(prefix, items)
}