Merge "bspatch_fuzzer: guard againts integer overflow with bad patch" am: 10118144d0 am: ea33dbd616

am: 797bbc3120

Change-Id: Ia90db55aad75c9537c3181b69788a36627a72f94
This commit is contained in:
Amin Hassani authored and android-build-merger committed 2019-06-18 12:26:55 -07:00
commit f4c57d47ff
1 file changed
+6
+6
View File
@@ -34,6 +34,7 @@ __FBSDID("$FreeBSD: src/usr.bin/bsdiff/bspatch/bspatch.c,v 1.1 2005/08/06 01:59:
#include <fcntl.h>
#include <inttypes.h>
#include <stdio.h>
#include <stdint.h>
#include <stdlib.h>
#include <string.h>
#include <sys/stat.h>
@@ -329,6 +330,8 @@ int bspatch(const std::unique_ptr<FileInterface>& old_file,
// Adjust pointers.
newpos += control_entry.diff_size;
if (oldpos > INT64_MAX - static_cast<int64_t>(control_entry.diff_size))
return 2;
oldpos += control_entry.diff_size;
if (oldpos > static_cast<int64_t>(old_file_size)) {
@@ -358,6 +361,9 @@ int bspatch(const std::unique_ptr<FileInterface>& old_file,
// Adjust pointers.
newpos += control_entry.extra_size;
if (control_entry.offset_increment > 0 &&
oldpos > INT64_MAX - control_entry.offset_increment)
return 2;
oldpos += control_entry.offset_increment;
}