expo/config-plugins
1
0 Fork 0
mirror of https://github.com/expo/config-plugins.git synced 2026-11-13 20:28:07 -10:00
Code Issues Packages Projects Releases 1 Wiki Activity

fix(detox): use improved xml generation (#47)

Browse Source 
* fix xml generation

generate xml without space or new line in the beginning

* remove indentation

* update snapshots to no indentation

* add built file

Co-authored-by: Maurice Döpke <mauricedoepkeoutlook.de>
This commit is contained in:
Maurice DoepkeandMaurice Döpke authored and GitHub committed 2022-03-16 16:27:57 -05:00
1 parent 480ec19161
commit 6324eb041b
3 files changed
+26 -24
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

packages/detox/build/withNetworkSecurityConfig.js
Generated
+9 -6
View File
@@ -42,12 +42,15 @@ function getTemplateConfigContent(subdomains) {
}
function getTemplateFile(subdomains) {
const content = getTemplateConfigContent(subdomains);
return `
<?xml version="1.0" encoding="utf-8"?>
<network-security-config>
${content}
</network-security-config>
`;
/**
* May not have new lines or spaces in the beginning.
* Otherwise build fails with:
* "AAPT: error: XML or text declaration not at start of entity"
*/
return `<?xml version="1.0" encoding="utf-8"?>
<network-security-config>
${content}
</network-security-config>`;
}
exports.getTemplateFile = getTemplateFile;
/**
packages/detox/src/__tests__/__snapshots__/withNetworkSecurityConfig-test.ts.snap
+8 -12
View File
@@ -1,25 +1,21 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`getTemplateFile returns domain-config when subdomains is an array 1`] = `
"
<?xml version=\\"1.0\\" encoding=\\"utf-8\\"?>
<network-security-config>
"<?xml version=\\"1.0\\" encoding=\\"utf-8\\"?>
<network-security-config>
<domain-config cleartextTrafficPermitted=\\"true\\">
<domain includeSubdomains=\\"true\\">localhost</domain>
</domain-config>
</network-security-config>
"
</network-security-config>"
`;
exports[`getTemplateFile returns only base-config when subdomains is '*' 1`] = `
"
<?xml version=\\"1.0\\" encoding=\\"utf-8\\"?>
<network-security-config>
<base-config cleartextTrafficPermitted=\\"true\\" />
</network-security-config>
"
"<?xml version=\\"1.0\\" encoding=\\"utf-8\\"?>
<network-security-config>
<base-config cleartextTrafficPermitted=\\"true\\" />
</network-security-config>"
`;
exports[`withNetworkSecurityConfigManifest doesn't modify config if subdomains is an empty array 1`] = `
packages/detox/src/withNetworkSecurityConfig.ts
+9 -6
View File
@@ -29,12 +29,15 @@ function getTemplateConfigContent(subdomains: SubdomainsType) {
export function getTemplateFile(subdomains: SubdomainsType): string {
const content = getTemplateConfigContent(subdomains);
return `
<?xml version="1.0" encoding="utf-8"?>
<network-security-config>
${content}
</network-security-config>
`;
/**
* May not have new lines or spaces in the beginning.
* Otherwise build fails with:
* "AAPT: error: XML or text declaration not at start of entity"
*/
return `<?xml version="1.0" encoding="utf-8"?>
<network-security-config>
${content}
</network-security-config>`;
}
/**