Compare commits

..
Author SHA1 Message Date
semantic-release-bot e2d2b27494 chore: 2.1.0
## @config-plugins/react-native-webrtc [2.1.0](https://github.com/expo/config-plugins/compare/@config-plugins/[email protected]...@config-plugins/[email protected]) (2022-03-22)

### Features

* **react-native-webrtc:** add config mod for Android minSdkVersion 24 ([ff8b167](https://github.com/expo/config-plugins/commit/ff8b1677640a560ca98abd8a83f349b3a1ee9017))
2022-03-22 16:48:53 +00:00
Thorben Primke ff8b167764 feat(react-native-webrtc): add config mod for Android minSdkVersion 24
Summary:
react-native-webrtc requires that the Android minSdkVersion is
set to 24.
Related issue on this here and also mentioned on Daily's RN SDK
that has react-native-webrtc as a dependency.

Adds withBuildScriptExtMinimumVersion same as the ffmpeg-kit-react-native
config plugin. Maybe withBuildScriptExtMinimumVersion could be
exported in `config-plugins` package so that it could be used directly.
2022-03-22 11:44:39 -05:00
Evan Bacon eee366bebc chore(repo): add PR template (#56)
* chore(repo): add PR template

* chore: add CODEOWNERS
2022-03-18 10:28:30 -05:00
7 changed files with 47 additions and 3 deletions

No files matched your search

+1
View File
@@ -0,0 +1 @@
/* @EvanBacon
+24
View File
@@ -0,0 +1,24 @@
<!--
🚨 We use semantic release (a bot publishes everything automatically)
🚨 so please use conventional commit style for the PR title:
🚨 https://www.conventionalcommits.org/en/v1.0.0/
🚨 Example: feat(detox): add new step
-->
# Why
<!--
Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.
-->
# How
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
<!--
Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.
-->
@@ -1,3 +1,10 @@
## @config-plugins/react-native-webrtc [2.1.0](https://github.com/expo/config-plugins/compare/@config-plugins/[email protected]...@config-plugins/[email protected]) (2022-03-22)
### Features
* **react-native-webrtc:** add config mod for Android minSdkVersion 24 ([ff8b167](https://github.com/expo/config-plugins/commit/ff8b1677640a560ca98abd8a83f349b3a1ee9017))
### @config-plugins/react-native-webrtc [2.0.2](https://github.com/expo/config-plugins/compare/@config-plugins/[email protected]...@config-plugins/[email protected]) (2022-03-16) ### @config-plugins/react-native-webrtc [2.0.2](https://github.com/expo/config-plugins/compare/@config-plugins/[email protected]...@config-plugins/[email protected]) (2022-03-16)
+4 -1
View File
@@ -59,7 +59,10 @@ export default {
}; };
``` ```
This plugin will also disable desugaring in the Android `gradle.properties`: `android.enableDexingArtifactTransform.desugaring=false`, and disable iOS Bitcode for "Release" builds (required). ## Important Notes
- For iOS, this plugin disables Bitcodes for all builds (required).
- For Android, this plugin disables desugaring in `gradle.properties`: `android.enableDexingArtifactTransform.desugaring=false` and the [minimum deployment target is changed to `24`](https://github.com/react-native-webrtc/react-native-webrtc/issues/720#issuecomment-552374206) (from `21`) which may break other packages in your app!
## Manual Setup ## Manual Setup
+4
View File
@@ -21,6 +21,10 @@ const withWebRTC = (config, props = {}) => {
"android.permission.SYSTEM_ALERT_WINDOW", "android.permission.SYSTEM_ALERT_WINDOW",
"android.permission.WAKE_LOCK", "android.permission.WAKE_LOCK",
]); ]);
config = config_plugins_1.AndroidConfig.Version.withBuildScriptExtMinimumVersion(config, {
name: "minSdkVersion",
minVersion: 24,
});
config = withDesugaring_1.withDesugaring(config, true); config = withDesugaring_1.withDesugaring(config, true);
return config; return config;
}; };
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"name": "@config-plugins/react-native-webrtc", "name": "@config-plugins/react-native-webrtc",
"version": "2.0.2", "version": "2.1.0",
"description": "Config plugin to setup react-native-webrtc on prebuild", "description": "Config plugin to setup react-native-webrtc on prebuild",
"main": "build/withWebRTC.js", "main": "build/withWebRTC.js",
"types": "build/withWebRTC.d.ts", "types": "build/withWebRTC.d.ts",
@@ -31,7 +31,12 @@ const withWebRTC: ConfigPlugin<IOSPermissionsProps | void> = (
"android.permission.SYSTEM_ALERT_WINDOW", "android.permission.SYSTEM_ALERT_WINDOW",
"android.permission.WAKE_LOCK", "android.permission.WAKE_LOCK",
]); ]);
config = AndroidConfig.Version.withBuildScriptExtMinimumVersion(config,
{
name: "minSdkVersion",
minVersion: 24,
}
)
config = withDesugaring(config, true); config = withDesugaring(config, true);
return config; return config;