Compare commits

..
Author SHA1 Message Date
Dominik Sokal 9b36ae0ef8 convert to ESM 2021-10-11 16:15:21 +02:00
Dominik Sokal 1a4cb107af add clean script 2021-10-11 16:12:42 +02:00
175 changed files with 3511 additions and 5686 deletions

No files matched your search

+2 -2
View File
@@ -28,8 +28,8 @@ jobs:
echo "Invalid /changelog-entry command" echo "Invalid /changelog-entry command"
exit 1 exit 1
fi fi
CATEGORY=$( cut -d ' ' -f 1 <<< "$PARAMS" | sed -e 's/^[[:space:]]*//' ) CATEGORY=$( cut -d ' ' -f 1 <<< "$PARAMS" | xargs )
MESSAGE=$( cut -d ' ' -f 2- <<< "$PARAMS" | sed -e 's/^[[:space:]]*//' ) MESSAGE=$( cut -d ' ' -f 2- <<< "$PARAMS" | xargs )
yarn changelog-entry "$CATEGORY" "$MESSAGE" yarn changelog-entry "$CATEGORY" "$MESSAGE"
env: env:
GITHUB_PR_AUTHOR: ${{ github.event.issue.user.login }} GITHUB_PR_AUTHOR: ${{ github.event.issue.user.login }}
-91
View File
@@ -8,103 +8,12 @@ This is the log of notable changes to EAS CLI and related packages.
### 🎉 New features ### 🎉 New features
- Add ASC Api Key generation workflow. ([#718](https://github.com/expo/eas-cli/pull/718) by [@quinlanj](https://github.com/quinlanj))
- Add support for removal of ASC Api Keys. ([#721](https://github.com/expo/eas-cli/pull/721) by [@quinlanj](https://github.com/quinlanj))
- Allow users to assign an ASC Api Key to their project. ([#719](https://github.com/expo/eas-cli/pull/719) by [@quinlanj](https://github.com/quinlanj))
- Add setup support for ASC Api Keys. ([#733](https://github.com/expo/eas-cli/pull/733) by [@quinlanj](https://github.com/quinlanj))
- Show initiating user display name when selecting a build to submit. ([#730](https://github.com/expo/eas-cli/pull/730) by [@barthap](https://github.com/barthap))
- Handle Apple servers maintenance error in `eas submit`. ([#738](https://github.com/expo/eas-cli/pull/738) by [@barthap](https://github.com/barthap))
- Integrate ASC Api Key with submissions workflow. ([#737](https://github.com/expo/eas-cli/pull/737) by [@quinlanj](https://github.com/quinlanj))
### 🐛 Bug fixes
### 🧹 Chores
- Clean up credentials prompt method. ([#728](https://github.com/expo/eas-cli/pull/728) by [@quinlanj](https://github.com/quinlanj))
- Bump @expo/apple-utils to 0.0.0-alpha.26. ([#723](https://github.com/expo/eas-cli/pull/723] by [@brentvatne](https://github.com/brentvatne))
- Grammar: replace setup with set up. ([#735](https://github.com/expo/eas-cli/pull/735) by [@quinlanj](https://github.com/quinlanj))
- Improve VCS workflow migration experience. ([#732](https://github.com/expo/eas-cli/pull/732) by [@wkozyra95](https://github.com/wkozyra95))
## [0.34.1](https://github.com/expo/eas-cli/releases/tag/0.34.1) - 2021-11-02
### 🐛 Bug fixes
- Don't show commit prompt in no-commit workflow after installing `expo-dev-client`. ([#722](https://github.com/expo/eas-cli/pull/722) by [@wkozyra95](https://github.com/wkozyra95))
### 🧹 Chores
- Add App Store Connect Api Key graphql type and print support. ([#717](https://github.com/expo/eas-cli/pull/717) by [@quinlanj](https://github.com/quinlanj))
## [0.34.0](https://github.com/expo/eas-cli/releases/tag/0.34.0) - 2021-11-01
### 🛠 Breaking changes
- `[EAS BUILD API]` Use new build job format. ([#701](https://github.com/expo/eas-cli/pull/701) and [#711](https://github.com/expo/eas-cli/pull/711) by [@dsokal](https://github.com/dsokal))
- Don't print logs to `stderr`. ([#708](https://github.com/expo/eas-cli/pull/708) by [@dsokal](https://github.com/dsokal))
- Remove automatic migration for legacy `eas.json` format introduced in [v0.22.2](https://github.com/expo/eas-cli/releases/tag/v0.22.2). ([#695](https://github.com/expo/eas-cli/pull/695) by [@wkozyra95](https://github.com/wkozyra95))
- Add required `cli` field in root of `eas.json` ([#695](https://github.com/expo/eas-cli/pull/695) by [@wkozyra95](https://github.com/wkozyra95))
### 🐛 Bug fixes
- Better error message when eas.json is invalid. ([#707](https://github.com/expo/eas-cli/pull/707) by [@dsokal](https://github.com/dsokal))
- Fix credentials workflow for new users: add additionalTypenames for credentials. ([#703](https://github.com/expo/eas-cli/pull/703) by [@quinlanj](https://github.com/quinlanj))
### 🧹 Chores
- Add additionalTypenames for other queries. ([#704](https://github.com/expo/eas-cli/pull/704) by [@quinlanj](https://github.com/quinlanj))
- Fix errors after pulling down most recent graphql schema changes. ([#713](https://github.com/expo/eas-cli/pull/713) by [@quinlanj](https://github.com/quinlanj))
- Refactor credentials manager. ([#712](https://github.com/expo/eas-cli/pull/712) by [@quinlanj](https://github.com/quinlanj))
- Remove unneeded parameters. ([#710](https://github.com/expo/eas-cli/pull/710) by [@quinlanj](https://github.com/quinlanj))
- Enforce additionalTypenames for graphql queries. ([#709](https://github.com/expo/eas-cli/pull/709) by [@quinlanj](https://github.com/quinlanj))
## [0.33.1](https://github.com/expo/eas-cli/releases/tag/0.33.1) - 2021-10-22
### 🎉 New features
- Compute runtime version using config-plugins. ([#697](https://github.com/expo/eas-cli/pull/697) by [@jkhales](https://github.com/jkhales))
### 🐛 Bug fixes
- [eas-cli] Skip validating updates scripts integration, which no longer exist in SDK 43+ ([#706](https://github.com/expo/eas-cli/pull/706) by [@brentvatne](https://github.com/brentvatne))
## [0.33.0](https://github.com/expo/eas-cli/releases/tag/0.33.0) - 2021-10-20
### 🎉 New features
- Make "production" the default profile for building and submitting. ([#677](https://github.com/expo/eas-cli/pull/677)) by [@jonsamp](https://github.com/jonsamp)
- Previously, the default profile when running `eas build` or `eas submit` was "release". We're changing it to a more recognizable name that is consistent with our docs, which is now "production". You can always specify a profile manually with the `--profile` flag. For this major version, if you do not have a profile named "production", and still have a profile named "release", we will fall back to the "release" profile as the default, however you'll see a warning as we're going to remove that behavior in the next major release of EAS CLI.
- To upgrade, update **eas.json** to have a "production" profile in both the `build` and `submit` objects. If you already have a project set up, this will replace the existing "release" profile. After the change, eas.json should have the following profiles:
```json
{
"build": {
"production": { ... }
},
"submit": {
"production": { ... }
}
}
```
### 🐛 Bug fixes
- Skip the second prompt for Apple ID if the user is already signed in with Apple. ([#691](https://github.com/expo/eas-cli/pull/691) by [@dsokal](https://github.com/dsokal))
- Unify reading `app.json`. ([#692](https://github.com/expo/eas-cli/pull/692) by [@dsokal](https://github.com/dsokal))
## [0.32.0](https://github.com/expo/eas-cli/releases/tag/0.32.0) - 2021-10-15
### 🎉 New features
- Add App Store Connect Api Key support to iOS submissions. ([#678](https://github.com/expo/eas-cli/pull/678) by [@quinlanj](https://github.com/quinlanj))
- Create/list/revoke App Store Connect Api keys via Apple apis. ([#687](https://github.com/expo/eas-cli/pull/687) by [@quinlanj](https://github.com/quinlanj))
- Add ability to select a build from a list in `eas submit` interactive mode. ([#688](https://github.com/expo/eas-cli/pull/688) by [@barthap](https://github.com/barthap))
### 🐛 Bug fixes ### 🐛 Bug fixes
- Fix printing App Store Connect URL after submission. ([#683](https://github.com/expo/eas-cli/pull/683) by [@brentvatne](https://github.com/brentvatne)) - Fix printing App Store Connect URL after submission. ([#683](https://github.com/expo/eas-cli/pull/683) by [@brentvatne](https://github.com/brentvatne))
### 🧹 Chores ### 🧹 Chores
- Add App Store Connect Api Key fields to `eas.json`. ([#684](https://github.com/expo/eas-cli/pull/684) by [@quinlanj](https://github.com/quinlanj))
- Enable no-underscore-dangle eslint rule. ([#686](https://github.com/expo/eas-cli/pull/686) by [@dsokal](https://github.com/dsokal)) - Enable no-underscore-dangle eslint rule. ([#686](https://github.com/expo/eas-cli/pull/686) by [@dsokal](https://github.com/dsokal))
## [0.31.1](https://github.com/expo/eas-cli/releases/tag/0.31.1) - 2021-10-08 ## [0.31.1](https://github.com/expo/eas-cli/releases/tag/0.31.1) - 2021-10-08
+1 -1
View File
@@ -4,7 +4,7 @@
2. Wait, the `release` workflow on GitHub Actions is going to take care of the rest (including publishing packages to npm and updating the changelog). 2. Wait, the `release` workflow on GitHub Actions is going to take care of the rest (including publishing packages to npm and updating the changelog).
3. Check the changelog. If any of the entries have been tagged with `[EAS BUILD API]` 3. Check the changelog. If any of the entries have been tagged with `[EAS BUILD API]`
- Open `package.json` and note the version of `@expo/eas-build-job` used in the eas-cli. - Open `package.json` and note the version of `@expo/eas-build-job` used in the eas-cli.
- Find the `Publish` commit in [expo/eas-build](https://github.com/expo/eas-build/commits) for that version. In most cases, it will be the latest `Publish` commit. - Find the `Publish` commit in [expo/eas-build](https://github.com/expo/eas-build/commit/) for that version. In most cases, it will be the latest `Publish` commit.
- Find the `eas-cli-local-build-plugin` version published in that commit. - Find the `eas-cli-local-build-plugin` version published in that commit.
![example publish commit](./.gh-assets/eas-build-publish-commit.png) ![example publish commit](./.gh-assets/eas-build-publish-commit.png)
- Run `npm dist-tags add eas-cli-local-build-plugin@VERSION latest` with the version from the previous step. - Run `npm dist-tags add eas-cli-local-build-plugin@VERSION latest` with the version from the previous step.
+1 -1
View File
@@ -1,5 +1,5 @@
{ {
"npmClient": "yarn", "npmClient": "yarn",
"useWorkspaces": true, "useWorkspaces": true,
"version": "0.34.1" "version": "0.31.1"
} }
+1 -1
View File
@@ -11,7 +11,7 @@
"lint": "eslint . --ext .ts --ext .js", "lint": "eslint . --ext .ts --ext .js",
"release": "lerna version", "release": "lerna version",
"test": "jest", "test": "jest",
"clean": "lerna run clean && rm -rf node_modules coverage" "clean": "lerna run clean"
}, },
"devDependencies": { "devDependencies": {
"@expo/oclif-dev-cli": "1.24.0-expo", "@expo/oclif-dev-cli": "1.24.0-expo",
+30 -32
View File
@@ -73,7 +73,7 @@ ALIASES
$ eas login $ eas login
``` ```
_See code: [src/commands/account/login.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/account/login.js)_ _See code: [src/commands/account/login.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/account/login.js)_
## `eas account:logout` ## `eas account:logout`
@@ -87,7 +87,7 @@ ALIASES
$ eas logout $ eas logout
``` ```
_See code: [src/commands/account/logout.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/account/logout.js)_ _See code: [src/commands/account/logout.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/account/logout.js)_
## `eas account:view` ## `eas account:view`
@@ -101,7 +101,7 @@ ALIASES
$ eas whoami $ eas whoami
``` ```
_See code: [src/commands/account/view.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/account/view.js)_ _See code: [src/commands/account/view.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/account/view.js)_
## `eas analytics [STATUS]` ## `eas analytics [STATUS]`
@@ -112,7 +112,7 @@ USAGE
$ eas analytics [STATUS] $ eas analytics [STATUS]
``` ```
_See code: [src/commands/analytics.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/analytics.js)_ _See code: [src/commands/analytics.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/analytics.js)_
## `eas build` ## `eas build`
@@ -138,15 +138,14 @@ OPTIONS
--non-interactive Run command in non-interactive mode --non-interactive Run command in non-interactive mode
--profile=PROFILE_NAME Name of the build profile from eas.json. Defaults to "production" if defined --profile=PROFILE_NAME [default: release] Name of the build profile from eas.json
in eas.json.
--skip-project-configuration Skip project configuration --skip-project-configuration Skip project configuration
--[no-]wait Wait for build(s) to complete --[no-]wait Wait for build(s) to complete
``` ```
_See code: [src/commands/build/index.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/build/index.js)_ _See code: [src/commands/build/index.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/build/index.js)_
## `eas build:cancel [BUILD_ID]` ## `eas build:cancel [BUILD_ID]`
@@ -157,7 +156,7 @@ USAGE
$ eas build:cancel [BUILD_ID] $ eas build:cancel [BUILD_ID]
``` ```
_See code: [src/commands/build/cancel.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/build/cancel.js)_ _See code: [src/commands/build/cancel.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/build/cancel.js)_
## `eas build:configure` ## `eas build:configure`
@@ -171,7 +170,7 @@ OPTIONS
-p, --platform=(android|ios|all) Platform to configure -p, --platform=(android|ios|all) Platform to configure
``` ```
_See code: [src/commands/build/configure.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/build/configure.js)_ _See code: [src/commands/build/configure.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/build/configure.js)_
## `eas build:list` ## `eas build:list`
@@ -204,7 +203,7 @@ OPTIONS
--status=(new|in-queue|in-progress|errored|finished|canceled) --status=(new|in-queue|in-progress|errored|finished|canceled)
``` ```
_See code: [src/commands/build/list.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/build/list.js)_ _See code: [src/commands/build/list.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/build/list.js)_
## `eas build:view [BUILD_ID]` ## `eas build:view [BUILD_ID]`
@@ -218,7 +217,7 @@ OPTIONS
--json Enable JSON output, non-JSON messages will be printed to stderr --json Enable JSON output, non-JSON messages will be printed to stderr
``` ```
_See code: [src/commands/build/view.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/build/view.js)_ _See code: [src/commands/build/view.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/build/view.js)_
## `eas config` ## `eas config`
@@ -233,7 +232,7 @@ OPTIONS
--profile=profile --profile=profile
``` ```
_See code: [src/commands/config.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/config.js)_ _See code: [src/commands/config.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/config.js)_
## `eas credentials` ## `eas credentials`
@@ -244,7 +243,7 @@ USAGE
$ eas credentials $ eas credentials
``` ```
_See code: [src/commands/credentials.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/credentials.js)_ _See code: [src/commands/credentials.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/credentials.js)_
## `eas device:create` ## `eas device:create`
@@ -255,7 +254,7 @@ USAGE
$ eas device:create $ eas device:create
``` ```
_See code: [src/commands/device/create.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/device/create.js)_ _See code: [src/commands/device/create.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/device/create.js)_
## `eas device:list` ## `eas device:list`
@@ -269,7 +268,7 @@ OPTIONS
--apple-team-id=apple-team-id --apple-team-id=apple-team-id
``` ```
_See code: [src/commands/device/list.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/device/list.js)_ _See code: [src/commands/device/list.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/device/list.js)_
## `eas device:view [UDID]` ## `eas device:view [UDID]`
@@ -280,7 +279,7 @@ USAGE
$ eas device:view [UDID] $ eas device:view [UDID]
``` ```
_See code: [src/commands/device/view.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/device/view.js)_ _See code: [src/commands/device/view.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/device/view.js)_
## `eas diagnostics` ## `eas diagnostics`
@@ -291,7 +290,7 @@ USAGE
$ eas diagnostics $ eas diagnostics
``` ```
_See code: [src/commands/diagnostics.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/diagnostics.js)_ _See code: [src/commands/diagnostics.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/diagnostics.js)_
## `eas help [COMMAND]` ## `eas help [COMMAND]`
@@ -319,7 +318,7 @@ USAGE
$ eas project:info $ eas project:info
``` ```
_See code: [src/commands/project/info.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/project/info.js)_ _See code: [src/commands/project/info.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/project/info.js)_
## `eas project:init` ## `eas project:init`
@@ -333,7 +332,7 @@ ALIASES
$ eas init $ eas init
``` ```
_See code: [src/commands/project/init.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/project/init.js)_ _See code: [src/commands/project/init.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/project/init.js)_
## `eas secret:create` ## `eas secret:create`
@@ -350,7 +349,7 @@ OPTIONS
--value=value Value of the secret --value=value Value of the secret
``` ```
_See code: [src/commands/secret/create.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/secret/create.js)_ _See code: [src/commands/secret/create.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/secret/create.js)_
## `eas secret:delete` ## `eas secret:delete`
@@ -364,10 +363,10 @@ OPTIONS
--id=id ID of the secret to delete --id=id ID of the secret to delete
DESCRIPTION DESCRIPTION
Unsure where to find the secret's ID? Run eas secret:list Unsure where to find the secret's ID? Run eas secrets:list
``` ```
_See code: [src/commands/secret/delete.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/secret/delete.js)_ _See code: [src/commands/secret/delete.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/secret/delete.js)_
## `eas secret:list` ## `eas secret:list`
@@ -378,7 +377,7 @@ USAGE
$ eas secret:list $ eas secret:list
``` ```
_See code: [src/commands/secret/list.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/secret/list.js)_ _See code: [src/commands/secret/list.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/secret/list.js)_
## `eas submit` ## `eas submit`
@@ -395,7 +394,7 @@ OPTIONS
--non-interactive Run command in non-interactive mode --non-interactive Run command in non-interactive mode
--path=path Path to the .apk/.aab/.ipa file --path=path Path to the .apk/.aab/.ipa file
--profile=profile Name of the submit profile from eas.json. Defaults to "production" if defined in --profile=profile Name of the submit profile from eas.json. Defaults to "release" if defined in
eas.json. eas.json.
--url=url App archive url --url=url App archive url
@@ -405,14 +404,13 @@ OPTIONS
--[no-]wait Wait for submission to complete --[no-]wait Wait for submission to complete
DESCRIPTION DESCRIPTION
See how to configure submits with eas.json: See how to configure submits with eas.json: https://docs.expo.dev/submit/eas-json/
https://docs.expo.dev/submit/eas-json/
ALIASES ALIASES
$ eas build:submit $ eas build:submit
``` ```
_See code: [src/commands/submit.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/submit.js)_ _See code: [src/commands/submit.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/submit.js)_
## `eas webhook:create` ## `eas webhook:create`
@@ -431,7 +429,7 @@ OPTIONS
--url=url Webhook URL --url=url Webhook URL
``` ```
_See code: [src/commands/webhook/create.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/webhook/create.js)_ _See code: [src/commands/webhook/create.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/webhook/create.js)_
## `eas webhook:delete [ID]` ## `eas webhook:delete [ID]`
@@ -445,7 +443,7 @@ ARGUMENTS
ID ID of the webhook to delete ID ID of the webhook to delete
``` ```
_See code: [src/commands/webhook/delete.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/webhook/delete.js)_ _See code: [src/commands/webhook/delete.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/webhook/delete.js)_
## `eas webhook:list` ## `eas webhook:list`
@@ -459,7 +457,7 @@ OPTIONS
--event=(BUILD) Event type that triggers the webhook --event=(BUILD) Event type that triggers the webhook
``` ```
_See code: [src/commands/webhook/list.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/webhook/list.js)_ _See code: [src/commands/webhook/list.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/webhook/list.js)_
## `eas webhook:update` ## `eas webhook:update`
@@ -479,7 +477,7 @@ OPTIONS
--url=url Webhook URL --url=url Webhook URL
``` ```
_See code: [src/commands/webhook/update.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/webhook/update.js)_ _See code: [src/commands/webhook/update.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/webhook/update.js)_
## `eas webhook:view ID` ## `eas webhook:view ID`
@@ -493,5 +491,5 @@ ARGUMENTS
ID ID of the webhook to view ID ID of the webhook to view
``` ```
_See code: [src/commands/webhook/view.js](https://github.com/expo/eas-cli/blob/v0.34.1/packages/eas-cli/src/commands/webhook/view.js)_ _See code: [src/commands/webhook/view.js](https://github.com/expo/eas-cli/blob/v0.31.1/packages/eas-cli/src/commands/webhook/view.js)_
<!-- commandsstop --> <!-- commandsstop -->
+1155 -1089
View File
File diff suppressed because it is too large. Load diff
+9 -8
View File
@@ -1,23 +1,24 @@
{ {
"name": "eas-cli", "name": "eas-cli",
"type": "module",
"description": "EAS command line tool", "description": "EAS command line tool",
"version": "0.34.1", "version": "0.31.1",
"author": "Expo <[email protected]>", "author": "Expo <[email protected]>",
"bin": { "bin": {
"eas": "./bin/run" "eas": "./bin/run"
}, },
"bugs": "https://github.com/expo/eas-cli/issues", "bugs": "https://github.com/expo/eas-cli/issues",
"dependencies": { "dependencies": {
"@expo/apple-utils": "0.0.0-alpha.26", "@expo/apple-utils": "0.0.0-alpha.25",
"@expo/config": "6.0.3", "@expo/config": "6.0.2",
"@expo/config-plugins": "4.0.3", "@expo/config-plugins": "4.0.2",
"@expo/eas-build-job": "0.2.57", "@expo/eas-build-job": "0.2.52",
"@expo/eas-json": "^0.34.1", "@expo/eas-json": "^0.31.0",
"@expo/json-file": "8.2.33", "@expo/json-file": "8.2.33",
"@expo/pkcs12": "0.0.4", "@expo/pkcs12": "0.0.4",
"@expo/plist": "0.0.14", "@expo/plist": "0.0.14",
"@expo/plugin-warn-if-update-available": "1.7.0", "@expo/plugin-warn-if-update-available": "1.7.0",
"@expo/prebuild-config": "3.0.3", "@expo/prebuild-config": "3.0.2",
"@expo/results": "1.0.0", "@expo/results": "1.0.0",
"@expo/rudder-sdk-node": "1.1.0", "@expo/rudder-sdk-node": "1.1.0",
"@expo/sdk-runtime-versions": "1.0.0", "@expo/sdk-runtime-versions": "1.0.0",
@@ -177,6 +178,6 @@
"test": "jest", "test": "jest",
"version": "yarn oclif-dev readme && node patch-readme && git add README.md", "version": "yarn oclif-dev readme && node patch-readme && git add README.md",
"generate-graphql-code": "graphql-codegen --config graphql-codegen.yml", "generate-graphql-code": "graphql-codegen --config graphql-codegen.yml",
"clean": "rm -rf dist build node_modules yarn-error.log" "clean": "rm -rf build node_modules"
} }
} }
+9 -3
View File
@@ -4,7 +4,13 @@ import { URL } from 'url';
import { v4 as uuidv4 } from 'uuid'; import { v4 as uuidv4 } from 'uuid';
import UserSettings from './user/UserSettings'; import UserSettings from './user/UserSettings';
import { easCliVersion } from './utils/easCli';
/**
* We use require() to exclude package.json from TypeScript's analysis since it lives outside
* the src directory and would change the directory structure of the emitted files
* under the build directory
*/
const packageJSON = require('../package.json');
const PLATFORM_TO_ANALYTICS_PLATFORM: { [platform: string]: string } = { const PLATFORM_TO_ANALYTICS_PLATFORM: { [platform: string]: string } = {
darwin: 'Mac', darwin: 'Mac',
@@ -91,7 +97,7 @@ export function logEvent(name: string, properties: Record<string, any> = {}): vo
ensureUserIdentified(); ensureUserIdentified();
const { userId, deviceId } = identifyData ?? {}; const { userId, deviceId } = identifyData ?? {};
const commonEventProperties = { source_version: easCliVersion, source: 'eas cli' }; const commonEventProperties = { source_version: packageJSON?.version, source: 'eas cli' };
const identity = { userId: userId ?? undefined, anonymousId: deviceId ?? uuidv4() }; const identity = { userId: userId ?? undefined, anonymousId: deviceId ?? uuidv4() };
rudderstackClient.track({ rudderstackClient.track({
@@ -120,7 +126,7 @@ function getRudderStackContext(): Record<string, any> {
return { return {
os: { name: platform, version: os.release() }, os: { name: platform, version: os.release() },
device: { type: platform, model: platform }, device: { type: platform, model: platform },
app: { name: 'eas cli', version: easCliVersion ?? undefined }, app: { name: 'eas cli', version: packageJSON?.version ?? undefined },
}; };
} }
@@ -1,5 +1,6 @@
import { ExpoConfig } from '@expo/config'; import { ExpoConfig } from '@expo/config';
import { AndroidConfig, AndroidManifest } from '@expo/config-plugins'; import { AndroidConfig, AndroidManifest } from '@expo/config-plugins';
import fs from 'fs-extra';
import Log from '../../log'; import Log from '../../log';
import { getProjectAccountName } from '../../project/projectUtils'; import { getProjectAccountName } from '../../project/projectUtils';
@@ -9,6 +10,17 @@ import { ensureValidVersions } from '../utils/updates';
export async function configureUpdatesAsync(projectDir: string, exp: ExpoConfig): Promise<void> { export async function configureUpdatesAsync(projectDir: string, exp: ExpoConfig): Promise<void> {
ensureValidVersions(exp); ensureValidVersions(exp);
const accountName = getProjectAccountName(exp, await ensureLoggedInAsync()); const accountName = getProjectAccountName(exp, await ensureLoggedInAsync());
const buildGradlePath = AndroidConfig.Paths.getAppBuildGradleFilePath(projectDir);
const buildGradleContents = await fs.readFile(buildGradlePath, 'utf8');
if (!AndroidConfig.Updates.isBuildGradleConfigured(projectDir, buildGradleContents)) {
const updatedBuildGradleContents =
AndroidConfig.Updates.ensureBuildGradleContainsConfigurationScript(
projectDir,
buildGradleContents
);
await fs.writeFile(buildGradlePath, updatedBuildGradleContents);
}
const androidManifestPath = await AndroidConfig.Paths.getAndroidManifestAsync(projectDir); const androidManifestPath = await AndroidConfig.Paths.getAndroidManifestAsync(projectDir);
const androidManifest = await getAndroidManifestAsync(projectDir); const androidManifest = await getAndroidManifestAsync(projectDir);
@@ -27,7 +39,7 @@ export async function syncUpdatesConfigurationAsync(
ensureValidVersions(exp); ensureValidVersions(exp);
const accountName = getProjectAccountName(exp, await ensureLoggedInAsync()); const accountName = getProjectAccountName(exp, await ensureLoggedInAsync());
try { try {
await ensureUpdatesConfiguredAsync(projectDir); await ensureUpdatesConfiguredAsync(projectDir, exp);
} catch (error) { } catch (error) {
Log.error( Log.error(
'expo-updates module is not configured. Please run "eas build:configure" first to configure the project' 'expo-updates module is not configured. Please run "eas build:configure" first to configure the project'
@@ -50,9 +62,15 @@ export async function syncUpdatesConfigurationAsync(
} }
} }
// Note: we assume here that Expo modules are properly configured in the project. Aside from that, async function ensureUpdatesConfiguredAsync(projectDir: string, exp: ExpoConfig): Promise<void> {
// all that is needed on Expo SDK 43+ to configure expo-updates configuration in AndroidManifest.xml const buildGradlePath = AndroidConfig.Paths.getAppBuildGradleFilePath(projectDir);
async function ensureUpdatesConfiguredAsync(projectDir: string): Promise<void> { const buildGradleContents = await fs.readFile(buildGradlePath, 'utf8');
if (!AndroidConfig.Updates.isBuildGradleConfigured(projectDir, buildGradleContents)) {
const gradleScriptApply = AndroidConfig.Updates.formatApplyLineForBuildGradle(projectDir);
throw new Error(`Missing ${gradleScriptApply} in ${buildGradlePath}`);
}
const androidManifest = await getAndroidManifestAsync(projectDir); const androidManifest = await getAndroidManifestAsync(projectDir);
if (!AndroidConfig.Updates.isMainApplicationMetaDataSet(androidManifest)) { if (!AndroidConfig.Updates.isMainApplicationMetaDataSet(androidManifest)) {
@@ -31,7 +31,7 @@ beforeEach(async () => {
await fs.mkdirp(os.tmpdir()); await fs.mkdirp(os.tmpdir());
}); });
// bare workflow // generic workflow
describe(bumpVersionAsync, () => { describe(bumpVersionAsync, () => {
it('throws an informative error when multiple flavors are detected in the android project', async () => { it('throws an informative error when multiple flavors are detected in the android project', async () => {
await initProjectWithGradleFileAsync( await initProjectWithGradleFileAsync(
@@ -69,7 +69,7 @@ describe(bumpVersionAsync, () => {
}); });
it('bumps expo.android.versionCode and buildGradle versionCode when strategy = BumpStrategy.VERSION_CODE', async () => { it('bumps expo.android.versionCode and buildGradle versionCode when strategy = BumpStrategy.VERSION_CODE', async () => {
const nativeVersionCode = 100; // this should be overwritten by bumpVersionAsync const nativeVersionCode = 100; // this should be overwritten by bumpVersionAsync
const fakeExp = initBareWorkflowProject({ versionCode: nativeVersionCode }); const fakeExp = initGenericProject({ versionCode: nativeVersionCode });
await bumpVersionAsync({ await bumpVersionAsync({
bumpStrategy: BumpStrategy.VERSION_CODE, bumpStrategy: BumpStrategy.VERSION_CODE,
@@ -91,7 +91,7 @@ describe(bumpVersionAsync, () => {
it('bumps expo.version and gradle versionCode when strategy = BumpStrategy.SHORT_VERSION', async () => { it('bumps expo.version and gradle versionCode when strategy = BumpStrategy.SHORT_VERSION', async () => {
const nativeVersionName = '1.0.0'; // this should be overwritten by bumpVersionAsync const nativeVersionName = '1.0.0'; // this should be overwritten by bumpVersionAsync
const fakeExp = initBareWorkflowProject({ versionName: nativeVersionName }); const fakeExp = initGenericProject({ versionName: nativeVersionName });
await bumpVersionAsync({ await bumpVersionAsync({
bumpStrategy: BumpStrategy.APP_VERSION, bumpStrategy: BumpStrategy.APP_VERSION,
@@ -112,7 +112,7 @@ describe(bumpVersionAsync, () => {
}); });
it('does not bump any version when strategy = BumpStrategy.NOOP', async () => { it('does not bump any version when strategy = BumpStrategy.NOOP', async () => {
const fakeExp = initBareWorkflowProject(); const fakeExp = initGenericProject();
await bumpVersionAsync({ await bumpVersionAsync({
bumpStrategy: BumpStrategy.NOOP, bumpStrategy: BumpStrategy.NOOP,
@@ -185,9 +185,9 @@ describe(bumpVersionInAppJsonAsync, () => {
}); });
describe(maybeResolveVersionsAsync, () => { describe(maybeResolveVersionsAsync, () => {
describe('bare project', () => { describe('generic project', () => {
it('reads the versions from native code', async () => { it('reads the versions from native code', async () => {
const exp = initBareWorkflowProject(); const exp = initGenericProject();
const { appVersion, appBuildVersion } = await maybeResolveVersionsAsync( const { appVersion, appBuildVersion } = await maybeResolveVersionsAsync(
'/repo', '/repo',
exp, exp,
@@ -211,7 +211,7 @@ describe(maybeResolveVersionsAsync, () => {
}); });
}); });
function initBareWorkflowProject({ function initGenericProject({
versionCode = 123, versionCode = 123,
versionName = '3.0.0', versionName = '3.0.0',
}: { }: {
@@ -6,10 +6,10 @@ import { AndroidBuildProfile, AndroidVersionAutoIncrement } from '@expo/eas-json
import Log from '../../log'; import Log from '../../log';
import { import {
ensureApplicationIdIsDefinedForManagedProjectAsync, ensureApplicationIdIsDefinedForManagedProjectAsync,
warnIfAndroidPackageDefinedInAppConfigForBareWorkflowProject, warnIfAndroidPackageDefinedInAppConfigForGenericProject,
} from '../../project/android/applicationId'; } from '../../project/android/applicationId';
import { resolveWorkflowAsync } from '../../project/workflow'; import { resolveWorkflowAsync } from '../../project/workflow';
import { getVcsClient } from '../../vcs'; import vcs from '../../vcs';
import { ConfigureContext } from '../context'; import { ConfigureContext } from '../context';
import { isExpoUpdatesInstalled } from '../utils/updates'; import { isExpoUpdatesInstalled } from '../utils/updates';
import { configureUpdatesAsync, syncUpdatesConfigurationAsync } from './UpdatesModule'; import { configureUpdatesAsync, syncUpdatesConfigurationAsync } from './UpdatesModule';
@@ -21,12 +21,12 @@ export async function configureAndroidAsync(ctx: ConfigureContext): Promise<void
return; return;
} }
warnIfAndroidPackageDefinedInAppConfigForBareWorkflowProject(ctx.projectDir, ctx.exp); warnIfAndroidPackageDefinedInAppConfigForGenericProject(ctx.projectDir, ctx.exp);
await AndroidConfig.EasBuild.configureEasBuildAsync(ctx.projectDir); await AndroidConfig.EasBuild.configureEasBuildAsync(ctx.projectDir);
const easGradlePath = AndroidConfig.EasBuild.getEasBuildGradlePath(ctx.projectDir); const easGradlePath = AndroidConfig.EasBuild.getEasBuildGradlePath(ctx.projectDir);
await getVcsClient().trackFileAsync(easGradlePath); await vcs.trackFileAsync(easGradlePath);
if (isExpoUpdatesInstalled(ctx.projectDir)) { if (isExpoUpdatesInstalled(ctx.projectDir)) {
await configureUpdatesAsync(ctx.projectDir, ctx.exp); await configureUpdatesAsync(ctx.projectDir, ctx.exp);
@@ -17,14 +17,15 @@ export function transformJob(job: Android.Job): AndroidJobInput {
artifactPath: job.artifactPath, artifactPath: job.artifactPath,
username: job.username, username: job.username,
buildType: job.buildType && transformBuildType(job.buildType), buildType: job.buildType && transformBuildType(job.buildType),
developmentClient: job.developmentClient,
}; };
} }
function transformBuildType(buildType: Android.BuildType): AndroidBuildType { function transformBuildType(buildType: Android.BuildType): AndroidBuildType {
if (buildType === Android.BuildType.APK) { if (buildType === Android.BuildType.APK) {
return AndroidBuildType.Apk; return AndroidBuildType.Apk;
} else { } else if (buildType === Android.BuildType.APP_BUNDLE) {
return AndroidBuildType.AppBundle; return AndroidBuildType.AppBundle;
} else {
return AndroidBuildType.DevelopmentClient;
} }
} }
@@ -6,7 +6,7 @@ import slash from 'slash';
import { AndroidCredentials } from '../../credentials/android/AndroidCredentialsProvider'; import { AndroidCredentials } from '../../credentials/android/AndroidCredentialsProvider';
import { getUsername } from '../../project/projectUtils'; import { getUsername } from '../../project/projectUtils';
import { ensureLoggedInAsync } from '../../user/actions'; import { ensureLoggedInAsync } from '../../user/actions';
import { getVcsClient } from '../../vcs'; import vcs from '../../vcs';
import { BuildContext } from '../context'; import { BuildContext } from '../context';
interface JobData { interface JobData {
@@ -27,7 +27,7 @@ export async function prepareJobAsync(
const username = getUsername(ctx.exp, await ensureLoggedInAsync()); const username = getUsername(ctx.exp, await ensureLoggedInAsync());
const buildProfile: AndroidBuildProfile = ctx.buildProfile; const buildProfile: AndroidBuildProfile = ctx.buildProfile;
const projectRootDirectory = const projectRootDirectory =
slash(path.relative(await getVcsClient().getRootPathAsync(), ctx.projectDir)) || '.'; slash(path.relative(await vcs.getRootPathAsync(), ctx.projectDir)) || '.';
const { credentials } = jobData; const { credentials } = jobData;
const buildCredentials = credentials const buildCredentials = credentials
? { ? {
@@ -70,11 +70,12 @@ export async function prepareJobAsync(
}, },
releaseChannel: ctx.buildProfile.releaseChannel, releaseChannel: ctx.buildProfile.releaseChannel,
updates: { channel: ctx.buildProfile.channel }, updates: { channel: ctx.buildProfile.channel },
developmentClient: buildProfile.developmentClient,
gradleCommand: buildProfile.gradleCommand, gradleCommand: buildProfile.gradleCommand,
artifactPath: buildProfile.artifactPath, artifactPath: buildProfile.artifactPath,
buildType,
username, username,
buildType: buildProfile.developmentClient ? Android.BuildType.DEVELOPMENT_CLIENT : buildType,
}; };
return sanitizeJob(job); return sanitizeJob(job);
+2 -2
View File
@@ -13,7 +13,7 @@ import { uploadAsync } from '../uploads';
import { formatBytes } from '../utils/files'; import { formatBytes } from '../utils/files';
import { createProgressTracker } from '../utils/progress'; import { createProgressTracker } from '../utils/progress';
import { sleepAsync } from '../utils/promise'; import { sleepAsync } from '../utils/promise';
import { getVcsClient } from '../vcs'; import vcs from '../vcs';
import { BuildContext } from './context'; import { BuildContext } from './context';
import { runLocalBuildAsync } from './local'; import { runLocalBuildAsync } from './local';
import { MetadataContext, collectMetadataAsync } from './metadata'; import { MetadataContext, collectMetadataAsync } from './metadata';
@@ -68,7 +68,7 @@ export async function prepareBuildRequestForPlatformAsync<
}); });
} }
if (await getVcsClient().isCommitRequiredAsync()) { if (await vcs.hasUncommittedChangesAsync()) {
Log.addNewLineIfNone(); Log.addNewLineIfNone();
await reviewAndCommitChangesAsync( await reviewAndCommitChangesAsync(
`[EAS Build] Run EAS Build for ${requestedPlatformDisplayNames[ctx.platform as Platform]}`, `[EAS Build] Run EAS Build for ${requestedPlatformDisplayNames[ctx.platform as Platform]}`,
+13 -26
View File
@@ -10,8 +10,7 @@ import { RequestedPlatform } from '../platform';
import { resolveWorkflowAsync } from '../project/workflow'; import { resolveWorkflowAsync } from '../project/workflow';
import { confirmAsync, promptAsync } from '../prompts'; import { confirmAsync, promptAsync } from '../prompts';
import { ensureLoggedInAsync } from '../user/actions'; import { ensureLoggedInAsync } from '../user/actions';
import { easCliVersion } from '../utils/easCli'; import vcs from '../vcs';
import { getVcsClient } from '../vcs';
import { configureAndroidAsync } from './android/configure'; import { configureAndroidAsync } from './android/configure';
import { ConfigureContext } from './context'; import { ConfigureContext } from './context';
import { configureIosAsync } from './ios/configure'; import { configureIosAsync } from './ios/configure';
@@ -38,7 +37,7 @@ export async function ensureProjectConfiguredAsync(
projectDir, projectDir,
platform: requestedPlatform, platform: requestedPlatform,
}); });
if (await getVcsClient().isCommitRequiredAsync()) { if (await vcs.hasUncommittedChangesAsync()) {
error( error(
'Build process requires clean working tree, please commit all your changes and run `eas build` again', 'Build process requires clean working tree, please commit all your changes and run `eas build` again',
{ exit: 1 } { exit: 1 }
@@ -58,7 +57,7 @@ export async function configureAsync(options: {
platform: RequestedPlatform; platform: RequestedPlatform;
projectDir: string; projectDir: string;
}): Promise<void> { }): Promise<void> {
await getVcsClient().ensureRepoExistsAsync(); await vcs.ensureRepoExistsAsync();
await maybeBailOnRepoStatusAsync(); await maybeBailOnRepoStatusAsync();
const { exp } = getConfig(options.projectDir, { skipSDKVersionRequirement: true }); const { exp } = getConfig(options.projectDir, { skipSDKVersionRequirement: true });
@@ -87,39 +86,31 @@ export async function configureAsync(options: {
await configureIosAsync(ctx); await configureIosAsync(ctx);
} }
if (await getVcsClient().isCommitRequiredAsync()) { if (await vcs.hasUncommittedChangesAsync()) {
Log.newLine(); Log.newLine();
await reviewAndCommitChangesAsync(configureCommitMessage[options.platform]); await reviewAndCommitChangesAsync(configureCommitMessage[options.platform]);
} else if (!(await getVcsClient().hasUncommittedChangesAsync())) { } else {
Log.newLine(); Log.newLine();
Log.withTick('No changes were necessary, the project is already configured correctly.'); Log.withTick('No changes were necessary, the project is already configured correctly.');
} }
} }
const EAS_JSON_MANAGED_DEFAULT: EasJson = { const EAS_JSON_MANAGED_DEFAULT: EasJson = {
cli: {
version: `>= ${easCliVersion}`,
},
build: { build: {
release: {},
development: { development: {
developmentClient: true, developmentClient: true,
distribution: 'internal', distribution: 'internal',
}, },
preview: {
distribution: 'internal',
},
production: {},
}, },
submit: { submit: {
production: {}, release: {},
}, },
}; };
const EAS_JSON_BARE_DEFAULT: EasJson = { const EAS_JSON_GENERIC_DEFAULT: EasJson = {
cli: {
version: `>= ${easCliVersion}`,
},
build: { build: {
release: {},
development: { development: {
distribution: 'internal', distribution: 'internal',
android: { android: {
@@ -129,13 +120,9 @@ const EAS_JSON_BARE_DEFAULT: EasJson = {
buildConfiguration: 'Debug', buildConfiguration: 'Debug',
}, },
}, },
preview: {
distribution: 'internal',
},
production: {},
}, },
submit: { submit: {
production: {}, release: {},
}, },
}; };
@@ -152,11 +139,11 @@ export async function ensureEasJsonExistsAsync(ctx: ConfigureContext): Promise<v
const easJson = const easJson =
ctx.hasAndroidNativeProject && ctx.hasIosNativeProject ctx.hasAndroidNativeProject && ctx.hasIosNativeProject
? EAS_JSON_BARE_DEFAULT ? EAS_JSON_GENERIC_DEFAULT
: EAS_JSON_MANAGED_DEFAULT; : EAS_JSON_MANAGED_DEFAULT;
await fs.writeFile(easJsonPath, `${JSON.stringify(easJson, null, 2)}\n`); await fs.writeFile(easJsonPath, `${JSON.stringify(easJson, null, 2)}\n`);
await getVcsClient().trackFileAsync(easJsonPath); await vcs.trackFileAsync(easJsonPath);
Log.withTick('Generated eas.json'); Log.withTick('Generated eas.json');
} }
@@ -190,7 +177,7 @@ async function reviewAndCommitChangesAsync(
await commitPromptAsync({ initialCommitMessage }); await commitPromptAsync({ initialCommitMessage });
Log.withTick('Committed changes'); Log.withTick('Committed changes');
} else if (selected === ShouldCommitChanges.ShowDiffFirst) { } else if (selected === ShouldCommitChanges.ShowDiffFirst) {
await getVcsClient().showDiffAsync(); await vcs.showDiffAsync();
await reviewAndCommitChangesAsync(initialCommitMessage, false); await reviewAndCommitChangesAsync(initialCommitMessage, false);
} }
} }
@@ -1,16 +1,30 @@
import { ExpoConfig } from '@expo/config'; import { ExpoConfig } from '@expo/config';
import { IOSConfig } from '@expo/config-plugins'; import { IOSConfig } from '@expo/config-plugins';
import fs from 'fs-extra';
import Log from '../../log'; import Log from '../../log';
import { getProjectAccountName } from '../../project/projectUtils'; import { getProjectAccountName } from '../../project/projectUtils';
import { ensureLoggedInAsync } from '../../user/actions'; import { ensureLoggedInAsync } from '../../user/actions';
import { getVcsClient } from '../../vcs'; import vcs from '../../vcs';
import { ensureValidVersions } from '../utils/updates'; import { ensureValidVersions } from '../utils/updates';
import { readPlistAsync, writePlistAsync } from './plist'; import { readPlistAsync, writePlistAsync } from './plist';
export async function configureUpdatesAsync(projectDir: string, exp: ExpoConfig): Promise<void> { export async function configureUpdatesAsync(projectDir: string, exp: ExpoConfig): Promise<void> {
ensureValidVersions(exp); ensureValidVersions(exp);
const accountName = getProjectAccountName(exp, await ensureLoggedInAsync()); const accountName = getProjectAccountName(exp, await ensureLoggedInAsync());
let xcodeProject = IOSConfig.XcodeUtils.getPbxproj(projectDir);
if (!IOSConfig.Updates.isShellScriptBuildPhaseConfigured(projectDir, xcodeProject)) {
xcodeProject = IOSConfig.Updates.ensureBundleReactNativePhaseContainsConfigurationScript(
projectDir,
xcodeProject
);
await fs.writeFile(
IOSConfig.Paths.getPBXProjectPath(projectDir),
// eslint-disable-next-line node/no-sync
xcodeProject.writeSync()
);
}
let expoPlist = await readExpoPlistAsync(projectDir); let expoPlist = await readExpoPlistAsync(projectDir);
if (!IOSConfig.Updates.isPlistConfigurationSynced(exp, expoPlist, accountName)) { if (!IOSConfig.Updates.isPlistConfigurationSynced(exp, expoPlist, accountName)) {
@@ -27,7 +41,7 @@ export async function syncUpdatesConfigurationAsync(
ensureValidVersions(exp); ensureValidVersions(exp);
const accountName = getProjectAccountName(exp, await ensureLoggedInAsync()); const accountName = getProjectAccountName(exp, await ensureLoggedInAsync());
try { try {
await ensureUpdatesConfiguredAsync(projectDir); await ensureUpdatesConfiguredAsync(projectDir, exp);
} catch (error) { } catch (error) {
Log.error( Log.error(
'expo-updates module is not configured. Please run "eas build:configure" first to configure the project' 'expo-updates module is not configured. Please run "eas build:configure" first to configure the project'
@@ -48,9 +62,15 @@ export async function syncUpdatesConfigurationAsync(
} }
} }
// Note: we assume here that Expo modules are properly configured in the project. Aside from that, async function ensureUpdatesConfiguredAsync(projectDir: string, exp: ExpoConfig): Promise<void> {
// all that is needed on Expo SDK 43+ to configure expo-updates configuration in Expo.plist const xcodeProject = IOSConfig.XcodeUtils.getPbxproj(projectDir);
async function ensureUpdatesConfiguredAsync(projectDir: string): Promise<void> {
if (!IOSConfig.Updates.isShellScriptBuildPhaseConfigured(projectDir, xcodeProject)) {
const script = 'expo-updates/scripts/create-manifest-ios.sh';
const buildPhase = '"Bundle React Native code and images"';
throw new Error(`Path to ${script} is missing in a ${buildPhase} build phase.`);
}
const expoPlist = await readExpoPlistAsync(projectDir); const expoPlist = await readExpoPlistAsync(projectDir);
if (!IOSConfig.Updates.isPlistConfigurationSet(expoPlist)) { if (!IOSConfig.Updates.isPlistConfigurationSet(expoPlist)) {
throw new Error('Missing values in Expo.plist'); throw new Error('Missing values in Expo.plist');
@@ -68,7 +88,7 @@ async function writeExpoPlistAsync(
): Promise<void> { ): Promise<void> {
const expoPlistPath = IOSConfig.Paths.getExpoPlistPath(projectDir); const expoPlistPath = IOSConfig.Paths.getExpoPlistPath(projectDir);
await writePlistAsync(expoPlistPath, expoPlist); await writePlistAsync(expoPlistPath, expoPlist);
await getVcsClient().trackFileAsync(expoPlistPath); await vcs.trackFileAsync(expoPlistPath);
} }
export async function readReleaseChannelSafelyAsync(projectDir: string): Promise<string | null> { export async function readReleaseChannelSafelyAsync(projectDir: string): Promise<string | null> {
@@ -49,10 +49,10 @@ describe(evaluateTemplateString, () => {
}); });
}); });
// bare workflow // generic workflow
describe(bumpVersionAsync, () => { describe(bumpVersionAsync, () => {
it('bumps expo.ios.buildNumber and CFBundleVersion when strategy = BumpStrategy.BUILD_NUMBER', async () => { it('bumps expo.ios.buildNumber and CFBundleVersion when strategy = BumpStrategy.BUILD_NUMBER', async () => {
const fakeExp = initBareWorkflowProject(); const fakeExp = initGenericProject();
await bumpVersionAsync({ await bumpVersionAsync({
bumpStrategy: BumpStrategy.BUILD_NUMBER, bumpStrategy: BumpStrategy.BUILD_NUMBER,
@@ -74,7 +74,7 @@ describe(bumpVersionAsync, () => {
}); });
it('bumps expo.ios.buildNumber and CFBundleVersion for non default Info.plist location', async () => { it('bumps expo.ios.buildNumber and CFBundleVersion for non default Info.plist location', async () => {
const fakeExp = initBareWorkflowProject({ infoPlistName: 'Info2.plist' }); const fakeExp = initGenericProject({ infoPlistName: 'Info2.plist' });
await bumpVersionAsync({ await bumpVersionAsync({
bumpStrategy: BumpStrategy.BUILD_NUMBER, bumpStrategy: BumpStrategy.BUILD_NUMBER,
@@ -98,7 +98,7 @@ describe(bumpVersionAsync, () => {
}); });
it('bumps expo.version and CFBundleShortVersionString when strategy = BumpStrategy.SHORT_VERSION', async () => { it('bumps expo.version and CFBundleShortVersionString when strategy = BumpStrategy.SHORT_VERSION', async () => {
const fakeExp = initBareWorkflowProject(); const fakeExp = initGenericProject();
await bumpVersionAsync({ await bumpVersionAsync({
bumpStrategy: BumpStrategy.APP_VERSION, bumpStrategy: BumpStrategy.APP_VERSION,
@@ -120,7 +120,7 @@ describe(bumpVersionAsync, () => {
}); });
it('does not bump any version when strategy = BumpStrategy.NOOP', async () => { it('does not bump any version when strategy = BumpStrategy.NOOP', async () => {
const fakeExp = initBareWorkflowProject(); const fakeExp = initGenericProject();
await bumpVersionAsync({ await bumpVersionAsync({
bumpStrategy: BumpStrategy.NOOP, bumpStrategy: BumpStrategy.NOOP,
@@ -194,9 +194,9 @@ describe(bumpVersionInAppJsonAsync, () => {
}); });
describe(readBuildNumberAsync, () => { describe(readBuildNumberAsync, () => {
describe('bare project', () => { describe('generic project', () => {
it('reads the build number from native code', async () => { it('reads the build number from native code', async () => {
const exp = initBareWorkflowProject(); const exp = initGenericProject();
const buildNumber = await readBuildNumberAsync('/repo', exp, {}); const buildNumber = await readBuildNumberAsync('/repo', exp, {});
expect(buildNumber).toBe('1'); expect(buildNumber).toBe('1');
}); });
@@ -212,14 +212,14 @@ describe(readBuildNumberAsync, () => {
}); });
describe(readShortVersionAsync, () => { describe(readShortVersionAsync, () => {
describe('bare project', () => { describe('generic project', () => {
it('reads the short version from native code', async () => { it('reads the short version from native code', async () => {
const exp = initBareWorkflowProject(); const exp = initGenericProject();
const appVersion = await readShortVersionAsync('/repo', exp, {}); const appVersion = await readShortVersionAsync('/repo', exp, {});
expect(appVersion).toBe('1.0.0'); expect(appVersion).toBe('1.0.0');
}); });
it('evaluates interpolated build number', async () => { it('evaluates interpolated build number', async () => {
const exp = initBareWorkflowProject({ const exp = initGenericProject({
appVersion: '$(CURRENT_PROJECT_VERSION)', appVersion: '$(CURRENT_PROJECT_VERSION)',
}); });
const buildNumber = await readShortVersionAsync('/repo', exp, { const buildNumber = await readShortVersionAsync('/repo', exp, {
@@ -231,7 +231,7 @@ describe(readShortVersionAsync, () => {
describe('managed project', () => { describe('managed project', () => {
it('reads the version from app config', async () => { it('reads the version from app config', async () => {
const exp = initBareWorkflowProject(); const exp = initGenericProject();
const appVersion = await readShortVersionAsync('/repo', exp, {}); const appVersion = await readShortVersionAsync('/repo', exp, {});
expect(appVersion).toBe('1.0.0'); expect(appVersion).toBe('1.0.0');
}); });
@@ -286,7 +286,7 @@ describe(getInfoPlistPath, () => {
}); });
}); });
function initBareWorkflowProject({ function initGenericProject({
appVersion = '1.0.0', appVersion = '1.0.0',
version = '1', version = '1',
infoPlistName = 'Info.plist', infoPlistName = 'Info.plist',
+2 -2
View File
@@ -6,7 +6,7 @@ import type { XCBuildConfiguration } from 'xcode';
import Log from '../../log'; import Log from '../../log';
import { import {
ensureBundleIdentifierIsDefinedForManagedProjectAsync, ensureBundleIdentifierIsDefinedForManagedProjectAsync,
warnIfBundleIdentifierDefinedInAppConfigForBareWorkflowProject, warnIfBundleIdentifierDefinedInAppConfigForGenericProject,
} from '../../project/ios/bundleIdentifier'; } from '../../project/ios/bundleIdentifier';
import { resolveWorkflowAsync } from '../../project/workflow'; import { resolveWorkflowAsync } from '../../project/workflow';
import { ConfigureContext } from '../context'; import { ConfigureContext } from '../context';
@@ -20,7 +20,7 @@ export async function configureIosAsync(ctx: ConfigureContext): Promise<void> {
return; return;
} }
warnIfBundleIdentifierDefinedInAppConfigForBareWorkflowProject(ctx.projectDir, ctx.exp); warnIfBundleIdentifierDefinedInAppConfigForGenericProject(ctx.projectDir, ctx.exp);
if (isExpoUpdatesInstalled(ctx.projectDir)) { if (isExpoUpdatesInstalled(ctx.projectDir)) {
await configureUpdatesAsync(ctx.projectDir, ctx.exp); await configureUpdatesAsync(ctx.projectDir, ctx.exp);
+28 -3
View File
@@ -1,7 +1,12 @@
import { Env, Ios } from '@expo/eas-build-job'; import { Env, Ios } from '@expo/eas-build-job';
import nullthrows from 'nullthrows'; import nullthrows from 'nullthrows';
import { IosJobInput, IosJobSecretsInput } from '../../graphql/generated'; import {
DistributionType,
IosBuildType,
IosJobInput,
IosJobSecretsInput,
} from '../../graphql/generated';
import { transformProjectArchive, transformWorkflow } from '../graphql'; import { transformProjectArchive, transformWorkflow } from '../graphql';
export function transformJob(job: Ios.Job): IosJobInput { export function transformJob(job: Ios.Job): IosJobInput {
@@ -11,18 +16,30 @@ export function transformJob(job: Ios.Job): IosJobInput {
projectRootDirectory: job.projectRootDirectory, projectRootDirectory: job.projectRootDirectory,
releaseChannel: job.releaseChannel, releaseChannel: job.releaseChannel,
updates: job.updates, updates: job.updates,
distribution: job.distribution && transformDistributionType(job.distribution),
secrets: transformIosSecrets(job.secrets), secrets: transformIosSecrets(job.secrets),
builderEnvironment: job.builderEnvironment, builderEnvironment: job.builderEnvironment,
cache: job.cache, cache: job.cache,
scheme: job.scheme, scheme: job.scheme,
buildConfiguration: job.buildConfiguration, buildConfiguration: job.buildConfiguration,
artifactPath: job.artifactPath, artifactPath: job.artifactPath,
buildType: job.buildType && transformBuildType(job.buildType),
username: job.username, username: job.username,
developmentClient: job.developmentClient,
simulator: job.simulator,
}; };
} }
function transformDistributionType(distributionType: Ios.DistributionType): DistributionType {
if (distributionType === 'store') {
return DistributionType.Store;
} else if (distributionType === 'internal') {
return DistributionType.Internal;
} else {
return DistributionType.Simulator;
}
}
function transformIosSecrets(secrets: { function transformIosSecrets(secrets: {
buildCredentials?: Ios.BuildCredentials; buildCredentials?: Ios.BuildCredentials;
env?: Env; env?: Env;
@@ -44,3 +61,11 @@ function transformIosSecrets(secrets: {
environmentSecrets: secrets.env, environmentSecrets: secrets.env,
}; };
} }
function transformBuildType(buildType: Ios.BuildType): IosBuildType {
if (buildType === Ios.BuildType.DEVELOPMENT_CLIENT) {
return IosBuildType.DevelopmentClient;
} else {
return IosBuildType.Release;
}
}
+8 -4
View File
@@ -5,7 +5,7 @@ import slash from 'slash';
import { IosCredentials, TargetCredentials } from '../../credentials/ios/types'; import { IosCredentials, TargetCredentials } from '../../credentials/ios/types';
import { getUsername } from '../../project/projectUtils'; import { getUsername } from '../../project/projectUtils';
import { ensureLoggedInAsync } from '../../user/actions'; import { ensureLoggedInAsync } from '../../user/actions';
import { getVcsClient } from '../../vcs'; import vcs from '../../vcs';
import { BuildContext } from '../context'; import { BuildContext } from '../context';
interface JobData { interface JobData {
@@ -25,7 +25,7 @@ export async function prepareJobAsync(
jobData: JobData jobData: JobData
): Promise<Job> { ): Promise<Job> {
const projectRootDirectory = const projectRootDirectory =
slash(path.relative(await getVcsClient().getRootPathAsync(), ctx.projectDir)) || '.'; slash(path.relative(await vcs.getRootPathAsync(), ctx.projectDir)) || '.';
const username = getUsername(ctx.exp, await ensureLoggedInAsync()); const username = getUsername(ctx.exp, await ensureLoggedInAsync());
const buildCredentials: Ios.Job['secrets']['buildCredentials'] = {}; const buildCredentials: Ios.Job['secrets']['buildCredentials'] = {};
if (jobData.credentials) { if (jobData.credentials) {
@@ -40,6 +40,7 @@ export async function prepareJobAsync(
platform: Platform.IOS, platform: Platform.IOS,
projectArchive: jobData.projectArchive, projectArchive: jobData.projectArchive,
projectRootDirectory, projectRootDirectory,
distribution: ctx.buildProfile.simulator ? 'simulator' : ctx.buildProfile.distribution,
builderEnvironment: { builderEnvironment: {
image: ctx.buildProfile.image, image: ctx.buildProfile.image,
node: ctx.buildProfile.node, node: ctx.buildProfile.node,
@@ -60,11 +61,14 @@ export async function prepareJobAsync(
}, },
releaseChannel: ctx.buildProfile.releaseChannel, releaseChannel: ctx.buildProfile.releaseChannel,
updates: { channel: ctx.buildProfile.channel }, updates: { channel: ctx.buildProfile.channel },
developmentClient: ctx.buildProfile.developmentClient,
simulator: ctx.buildProfile.simulator,
scheme: jobData.buildScheme, scheme: jobData.buildScheme,
buildConfiguration: ctx.buildProfile.buildConfiguration, buildConfiguration: ctx.buildProfile.buildConfiguration,
artifactPath: ctx.buildProfile.artifactPath, artifactPath: ctx.buildProfile.artifactPath,
buildType: ctx.buildProfile.developmentClient
? Ios.BuildType.DEVELOPMENT_CLIENT
: Ios.BuildType.RELEASE,
username, username,
}; };
return sanitizeJob(job); return sanitizeJob(job);
+10 -5
View File
@@ -7,8 +7,7 @@ import { GradleBuildContext } from '../project/android/gradle';
import { getBundleIdentifierAsync } from '../project/ios/bundleIdentifier'; import { getBundleIdentifierAsync } from '../project/ios/bundleIdentifier';
import { getUsername } from '../project/projectUtils'; import { getUsername } from '../project/projectUtils';
import { ensureLoggedInAsync } from '../user/actions'; import { ensureLoggedInAsync } from '../user/actions';
import { easCliVersion } from '../utils/easCli'; import vcs from '../vcs';
import { getVcsClient } from '../vcs';
import { import {
readChannelSafelyAsync as readAndroidChannelSafelyAsync, readChannelSafelyAsync as readAndroidChannelSafelyAsync,
readReleaseChannelSafelyAsync as readAndroidReleaseChannelSafelyAsync, readReleaseChannelSafelyAsync as readAndroidReleaseChannelSafelyAsync,
@@ -22,6 +21,13 @@ import {
import { maybeResolveVersionsAsync as maybeResolveIosVersionsAsync } from './ios/version'; import { maybeResolveVersionsAsync as maybeResolveIosVersionsAsync } from './ios/version';
import { isExpoUpdatesInstalled } from './utils/updates'; import { isExpoUpdatesInstalled } from './utils/updates';
/**
* We use require() to exclude package.json from TypeScript's analysis since it lives outside
* the src directory and would change the directory structure of the emitted files
* under the build directory
*/
const packageJSON = require('../../package.json');
export type MetadataContext<T extends Platform> = T extends Platform.ANDROID export type MetadataContext<T extends Platform> = T extends Platform.ANDROID
? AndroidMetadataContext ? AndroidMetadataContext
: IosMetadataContext; : IosMetadataContext;
@@ -47,7 +53,7 @@ export async function collectMetadataAsync<T extends Platform>(
const metadata = { const metadata = {
trackingContext: ctx.trackingCtx, trackingContext: ctx.trackingCtx,
...(await maybeResolveVersionsAsync(ctx, platformContext)), ...(await maybeResolveVersionsAsync(ctx, platformContext)),
cliVersion: easCliVersion, cliVersion: packageJSON.version,
workflow: ctx.workflow, workflow: ctx.workflow,
credentialsSource: ctx.buildProfile.credentialsSource, credentialsSource: ctx.buildProfile.credentialsSource,
sdkVersion: ctx.exp.sdkVersion, sdkVersion: ctx.exp.sdkVersion,
@@ -57,8 +63,7 @@ export async function collectMetadataAsync<T extends Platform>(
appName: ctx.exp.name, appName: ctx.exp.name,
appIdentifier: await resolveAppIdentifierAsync(ctx, platformContext), appIdentifier: await resolveAppIdentifierAsync(ctx, platformContext),
buildProfile: ctx.buildProfileName, buildProfile: ctx.buildProfileName,
gitCommitHash: await getVcsClient().getCommitHashAsync(), gitCommitHash: await vcs.getCommitHashAsync(),
isGitWorkingTreeDirty: await getVcsClient().hasUncommittedChangesAsync(),
username: getUsername(ctx.exp, await ensureLoggedInAsync()), username: getUsername(ctx.exp, await ensureLoggedInAsync()),
...(ctx.platform === Platform.IOS && { ...(ctx.platform === Platform.IOS && {
iosEnterpriseProvisioning: resolveIosEnterpriseProvisioning( iosEnterpriseProvisioning: resolveIosEnterpriseProvisioning(
+3 -12
View File
@@ -1,6 +1,6 @@
import * as ExpoConfig from '@expo/config'; import * as ExpoConfig from '@expo/config';
import JsonFile from '@expo/json-file';
import assert from 'assert'; import assert from 'assert';
import fs from 'fs-extra';
export async function updateAppJsonConfigAsync( export async function updateAppJsonConfigAsync(
{ {
@@ -15,19 +15,10 @@ export async function updateAppJsonConfigAsync(
const paths = ExpoConfig.getConfigFilePaths(projectDir); const paths = ExpoConfig.getConfigFilePaths(projectDir);
assert(paths.staticConfigPath, "can't update dynamic config"); assert(paths.staticConfigPath, "can't update dynamic config");
const rawStaticConfig = readAppJson(paths.staticConfigPath); const rawStaticConfig = await fs.readJSON(paths.staticConfigPath);
rawStaticConfig.expo = rawStaticConfig.expo ?? {}; rawStaticConfig.expo = rawStaticConfig.expo ?? {};
modifyConfig(rawStaticConfig.expo); modifyConfig(rawStaticConfig.expo);
await JsonFile.writeAsync(paths.staticConfigPath, rawStaticConfig, { json5: false }); await fs.writeJson(paths.staticConfigPath, rawStaticConfig, { spaces: 2 });
modifyConfig(exp); modifyConfig(exp);
} }
// TODO: remove this once @expo/config exports getStaticConfig
export function readAppJson(appJsonPath: string): any {
const config = JsonFile.read(appJsonPath, { json5: true });
if (config) {
return config as any;
}
throw new Error(`Failed to read app.json`);
}
+24 -24
View File
@@ -1,5 +1,5 @@
import { Workflow } from '@expo/eas-build-job'; import { Platform, Workflow } from '@expo/eas-build-job';
import { BuildProfile } from '@expo/eas-json'; import { EasJsonReader } from '@expo/eas-json';
import { error } from '@oclif/errors'; import { error } from '@oclif/errors';
import chalk from 'chalk'; import chalk from 'chalk';
import resolveFrom from 'resolve-from'; import resolveFrom from 'resolve-from';
@@ -9,38 +9,40 @@ import Log, { learnMore } from '../../log';
import { appPlatformDisplayNames } from '../../platform'; import { appPlatformDisplayNames } from '../../platform';
import { resolveWorkflowAsync } from '../../project/workflow'; import { resolveWorkflowAsync } from '../../project/workflow';
import { confirmAsync } from '../../prompts'; import { confirmAsync } from '../../prompts';
import { expoCommandAsync } from '../../utils/expoCli'; import { expoCommandAsync } from '../../utils/expoCommand';
import { ProfileData } from '../../utils/profiles'; import zipObject from '../../utils/expodash/zipObject';
import { getVcsClient } from '../../vcs';
import { reviewAndCommitChangesAsync } from './repository'; import { reviewAndCommitChangesAsync } from './repository';
export async function ensureExpoDevClientInstalledForDevClientBuildsAsync({ export async function ensureExpoDevClientInstalledForDevClientBuildsAsync({
projectDir, projectDir,
platforms,
profile,
nonInteractive = false, nonInteractive = false,
buildProfiles = [],
}: { }: {
projectDir: string; projectDir: string;
platforms: Platform[];
profile: string;
nonInteractive?: boolean; nonInteractive?: boolean;
buildProfiles?: ProfileData<BuildProfile>[];
}): Promise<void> { }): Promise<void> {
if (await isExpoDevClientInstalledAsync(projectDir)) { if (await isExpoDevClientInstalledAsync(projectDir)) {
return; return;
} }
const buildProfilesWithDevelopmentClientRequired = buildProfiles.filter( const easJsonReader = new EasJsonReader(projectDir);
buildProfile => buildProfile.profile.developmentClient const devClientPerPlatformList = await Promise.all(
platforms.map(async platform => {
const buildProfile = await easJsonReader.readBuildProfileAsync(platform, profile);
return buildProfile.developmentClient ?? false;
})
); );
const isDevelopmentClientRequired = buildProfilesWithDevelopmentClientRequired.some(Boolean); const isDevClientRequired = devClientPerPlatformList.some(i => i);
if (!isDevClientRequired) {
if (!isDevelopmentClientRequired) {
return; return;
} }
const platformsToCheck = buildProfilesWithDevelopmentClientRequired.map( const devClientPerPlatform = zipObject(platforms, devClientPerPlatformList);
({ platform }) => platform const platformsToCheck = platforms.filter(platform => devClientPerPlatform[platform]);
);
const workflowPerPlatformList = await Promise.all( const workflowPerPlatformList = await Promise.all(
platformsToCheck.map(platform => resolveWorkflowAsync(projectDir, platform)) platformsToCheck.map(platform => resolveWorkflowAsync(projectDir, platform))
); );
@@ -65,15 +67,15 @@ export async function ensureExpoDevClientInstalledForDevClientBuildsAsync({
if (install) { if (install) {
await installExpoDevClientAsync(projectDir, { nonInteractive }); await installExpoDevClientAsync(projectDir, { nonInteractive });
} else { } else {
error(`Install ${chalk.bold('expo-dev-client')} manually and come back later.`, { error(`Install ${chalk.bold('expo-dev-client')} on your own and come back later.`, {
exit: 1, exit: 1,
}); });
} }
} else { } else {
Log.warn(`You'll need to install ${chalk.bold('expo-dev-client')} manually.`); Log.warn(`Unfortunately, you need to install ${chalk.bold('expo-dev-client')} on your own.`);
Log.warn( Log.warn(
learnMore('https://docs.expo.dev/clients/installation/', { learnMore('https://docs.expo.dev/clients/installation/', {
learnMoreMessage: 'See installation instructions on how to do it.', learnMoreMessage: 'See installation instructions on how to do it',
dim: false, dim: false,
}) })
); );
@@ -108,9 +110,7 @@ async function installExpoDevClientAsync(
Log.newLine(); Log.newLine();
await expoCommandAsync(projectDir, ['install', 'expo-dev-client']); await expoCommandAsync(projectDir, ['install', 'expo-dev-client']);
Log.newLine(); Log.newLine();
if (await getVcsClient().isCommitRequiredAsync()) { await reviewAndCommitChangesAsync('Install expo-dev-client', {
await reviewAndCommitChangesAsync('Install expo-dev-client', { nonInteractive,
nonInteractive, });
});
}
} }
@@ -120,5 +120,11 @@ export function formatGraphQLBuild(build: BuildFragment): string {
} }
const getActorName = (build: BuildFragment): string => { const getActorName = (build: BuildFragment): string => {
return build.initiatingActor?.displayName || 'unknown'; if (!build.initiatingActor) {
return 'unknown';
} else if (build.initiatingActor.__typename === 'User') {
return build.initiatingActor.username;
} else {
return build.initiatingActor.firstName ?? 'unknown';
}
}; };
+7 -10
View File
@@ -10,10 +10,10 @@ import { confirmAsync, promptAsync } from '../../prompts';
import { formatBytes } from '../../utils/files'; import { formatBytes } from '../../utils/files';
import { getTmpDirectory } from '../../utils/paths'; import { getTmpDirectory } from '../../utils/paths';
import { endTimer, formatMilliseconds, startTimer } from '../../utils/timer'; import { endTimer, formatMilliseconds, startTimer } from '../../utils/timer';
import { getVcsClient } from '../../vcs'; import vcs from '../../vcs';
export async function maybeBailOnRepoStatusAsync(): Promise<void> { export async function maybeBailOnRepoStatusAsync(): Promise<void> {
if (!(await getVcsClient().isCommitRequiredAsync())) { if (!(await vcs.hasUncommittedChangesAsync())) {
return; return;
} }
Log.addNewLineIfNone(); Log.addNewLineIfNone();
@@ -33,7 +33,7 @@ export async function maybeBailOnRepoStatusAsync(): Promise<void> {
} }
export async function ensureRepoIsCleanAsync(nonInteractive = false): Promise<void> { export async function ensureRepoIsCleanAsync(nonInteractive = false): Promise<void> {
if (!(await getVcsClient().isCommitRequiredAsync())) { if (!(await vcs.hasUncommittedChangesAsync())) {
return; return;
} }
Log.addNewLineIfNone(); Log.addNewLineIfNone();
@@ -70,7 +70,7 @@ export async function commitPromptAsync({
initial: initialCommitMessage, initial: initialCommitMessage,
validate: (input: string) => input !== '', validate: (input: string) => input !== '',
}); });
await getVcsClient().commitAsync({ commitAllFiles, commitMessage: message }); await vcs.commitAsync({ commitAllFiles, commitMessage: message });
} }
export async function makeProjectTarballAsync(): Promise<{ path: string; size: number }> { export async function makeProjectTarballAsync(): Promise<{ path: string; size: number }> {
@@ -95,7 +95,7 @@ export async function makeProjectTarballAsync(): Promise<{ path: string; size: n
startTimer(compressTimerLabel); startTimer(compressTimerLabel);
try { try {
await getVcsClient().makeShallowCopyAsync(shallowClonePath); await vcs.makeShallowCopyAsync(shallowClonePath);
await tar.create({ cwd: shallowClonePath, file: tarPath, prefix: 'project', gzip: true }, [ await tar.create({ cwd: shallowClonePath, file: tarPath, prefix: 'project', gzip: true }, [
'.', '.',
]); ]);
@@ -133,10 +133,7 @@ export async function reviewAndCommitChangesAsync(
{ nonInteractive, askedFirstTime = true }: { nonInteractive: boolean; askedFirstTime?: boolean } { nonInteractive, askedFirstTime = true }: { nonInteractive: boolean; askedFirstTime?: boolean }
): Promise<void> { ): Promise<void> {
if (process.env.EAS_BUILD_AUTOCOMMIT) { if (process.env.EAS_BUILD_AUTOCOMMIT) {
await getVcsClient().commitAsync({ await vcs.commitAsync({ commitMessage: initialCommitMessage, commitAllFiles: false });
commitMessage: initialCommitMessage,
commitAllFiles: false,
});
Log.withTick('Committed changes.'); Log.withTick('Committed changes.');
return; return;
} }
@@ -169,7 +166,7 @@ export async function reviewAndCommitChangesAsync(
await commitPromptAsync({ initialCommitMessage }); await commitPromptAsync({ initialCommitMessage });
Log.withTick('Committed changes.'); Log.withTick('Committed changes.');
} else if (selected === ShouldCommitChanges.ShowDiffFirst) { } else if (selected === ShouldCommitChanges.ShowDiffFirst) {
await getVcsClient().showDiffAsync(); await vcs.showDiffAsync();
await reviewAndCommitChangesAsync(initialCommitMessage, { await reviewAndCommitChangesAsync(initialCommitMessage, {
nonInteractive, nonInteractive,
askedFirstTime: false, askedFirstTime: false,
+4 -4
View File
@@ -3,7 +3,7 @@ import fs from 'fs-extra';
import path from 'path'; import path from 'path';
import Log, { learnMore } from '../log'; import Log, { learnMore } from '../log';
import { getVcsClient } from '../vcs'; import vcs from '../vcs';
import { BuildContext } from './context'; import { BuildContext } from './context';
export function checkNodeEnvVariable(ctx: BuildContext<Platform>): void { export function checkNodeEnvVariable(ctx: BuildContext<Platform>): void {
@@ -25,12 +25,12 @@ export async function checkGoogleServicesFileAsync<T extends Platform>(
if (!googleServicesFilePath) { if (!googleServicesFilePath) {
return; return;
} }
const rootDir = path.normalize(await getVcsClient().getRootPathAsync()); const rootDir = path.normalize(await vcs.getRootPathAsync());
const absGoogleServicesFilePath = path.resolve(ctx.projectDir, googleServicesFilePath); const absGoogleServicesFilePath = path.resolve(ctx.projectDir, googleServicesFilePath);
if ( if (
(await fs.pathExists(absGoogleServicesFilePath)) && (await fs.pathExists(absGoogleServicesFilePath)) &&
(!isInsideDirectory(absGoogleServicesFilePath, rootDir) || (!isInsideDirectory(absGoogleServicesFilePath, rootDir) ||
(await getVcsClient().isFileIgnoredAsync(path.relative(rootDir, absGoogleServicesFilePath)))) (await vcs.isFileIgnoredAsync(path.relative(rootDir, absGoogleServicesFilePath))))
) { ) {
Log.warn( Log.warn(
`File specified via "${ctx.platform}.googleServicesFile" field in your app.json is not checked in to your repository and won't be uploaded to the builder.` `File specified via "${ctx.platform}.googleServicesFile" field in your app.json is not checked in to your repository and won't be uploaded to the builder.`
@@ -41,7 +41,7 @@ export async function checkGoogleServicesFileAsync<T extends Platform>(
)}` )}`
); );
Log.warn( Log.warn(
`If you are using that file for compatibility with the classic build service (expo build) you can silence this warning by setting your build profile's env.GOOGLE_SERVICES_FILE in eas.json to any non-empty string.` 'If you are using that file for compatibility with the classic build service (expo build) you can silence this warning by setting GOOGLE_SERVICES_FILE in your build profile in eas.json to any non-falsy value.'
); );
Log.newLine(); Log.newLine();
} }
@@ -1,6 +1,4 @@
import { EasJsonReader } from '@expo/eas-json';
import { Command } from '@oclif/command'; import { Command } from '@oclif/command';
import semver from 'semver';
import { import {
AnalyticsEvent, AnalyticsEvent,
@@ -8,13 +6,8 @@ import {
initAsync as initAnalyticsAsync, initAsync as initAnalyticsAsync,
logEvent, logEvent,
} from '../analytics'; } from '../analytics';
import Log from '../log';
import { findProjectRootAsync } from '../project/projectUtils';
import { getUserAsync } from '../user/User'; import { getUserAsync } from '../user/User';
import { ensureLoggedInAsync } from '../user/actions'; import { ensureLoggedInAsync } from '../user/actions';
import { easCliVersion } from '../utils/easCli';
import { setVcsClient } from '../vcs';
import GitClient from '../vcs/clients/git';
export default abstract class EasCommand extends Command { export default abstract class EasCommand extends Command {
/** /**
@@ -27,10 +20,7 @@ export default abstract class EasCommand extends Command {
// eslint-disable-next-line async-protect/async-suffix // eslint-disable-next-line async-protect/async-suffix
async run(): Promise<any> { async run(): Promise<any> {
EasJsonReader.setLog(Log);
await initAnalyticsAsync(); await initAnalyticsAsync();
await this.applyCliConfigAsync();
if (this.requiresAuthentication) { if (this.requiresAuthentication) {
const { flags } = this.parse(); const { flags } = this.parse();
@@ -52,18 +42,4 @@ export default abstract class EasCommand extends Command {
await flushAnalyticsAsync(); await flushAnalyticsAsync();
return super.finally(err); return super.finally(err);
} }
private async applyCliConfigAsync(): Promise<void> {
const projectDir = await findProjectRootAsync();
const easJsonReader = new EasJsonReader(projectDir);
const config = await easJsonReader.getCliConfigAsync();
if (config?.version && !semver.satisfies(easCliVersion, config.version)) {
throw new Error(
`You are on eas-cli@${easCliVersion} which does not satisfy the CLI version constraint in eas.json (${config.version})`
);
}
if (config?.requireCommit) {
setVcsClient(new GitClient());
}
}
} }
@@ -17,7 +17,7 @@ import {
getProjectIdAsync, getProjectIdAsync,
} from '../../project/projectUtils'; } from '../../project/projectUtils';
import { promptAsync } from '../../prompts'; import { promptAsync } from '../../prompts';
import { getVcsClient } from '../../vcs'; import vcs from '../../vcs';
export async function createUpdateBranchOnAppAsync({ export async function createUpdateBranchOnAppAsync({
appId, appId,
@@ -90,8 +90,7 @@ export default class BranchCreate extends EasCommand {
name: 'name', name: 'name',
message: 'Please name the branch:', message: 'Please name the branch:',
initial: initial:
(await getVcsClient().getBranchNameAsync()) || (await vcs.getBranchNameAsync()) || `branch-${Math.random().toString(36).substr(2, 4)}`,
`branch-${Math.random().toString(36).substr(2, 4)}`,
validate: value => (value ? true : validationMessage), validate: value => (value ? true : validationMessage),
})); }));
} }
@@ -43,8 +43,7 @@ async function getBranchInfoAsync({
{ {
appId, appId,
name, name,
}, }
{ additionalTypenames: ['UpdateBranch'] }
) )
.toPromise() .toPromise()
); );
+1 -2
View File
@@ -44,8 +44,7 @@ export async function listBranchesAsync({
{ {
appId: projectId, appId: projectId,
limit: BRANCHES_LIMIT, limit: BRANCHES_LIMIT,
}, }
{ additionalTypenames: ['UpdateBranch'] }
) )
.toPromise() .toPromise()
); );
+55 -26
View File
@@ -1,6 +1,5 @@
import { ExpoConfig, getConfig } from '@expo/config'; import { ExpoConfig, getConfig, getDefaultTarget } from '@expo/config';
import { Updates } from '@expo/config-plugins'; import { getRuntimeVersionForSDKVersion } from '@expo/sdk-runtime-versions';
import { Platform, Workflow } from '@expo/eas-build-job';
import { flags } from '@oclif/command'; import { flags } from '@oclif/command';
import assert from 'assert'; import assert from 'assert';
import chalk from 'chalk'; import chalk from 'chalk';
@@ -29,12 +28,11 @@ import {
collectAssetsAsync, collectAssetsAsync,
uploadAssetsAsync, uploadAssetsAsync,
} from '../../project/publish'; } from '../../project/publish';
import { resolveWorkflowAsync } from '../../project/workflow';
import { promptAsync, selectAsync } from '../../prompts'; import { promptAsync, selectAsync } from '../../prompts';
import { formatUpdate } from '../../update/utils'; import { formatUpdate } from '../../update/utils';
import uniqBy from '../../utils/expodash/uniqBy'; import uniqBy from '../../utils/expodash/uniqBy';
import formatFields from '../../utils/formatFields'; import formatFields from '../../utils/formatFields';
import { getVcsClient } from '../../vcs'; import vcs from '../../vcs';
import { createUpdateBranchOnAppAsync } from './create'; import { createUpdateBranchOnAppAsync } from './create';
import { listBranchesAsync } from './list'; import { listBranchesAsync } from './list';
import { viewUpdateBranchAsync } from './view'; import { viewUpdateBranchAsync } from './view';
@@ -62,8 +60,7 @@ async function getUpdateGroupAsync({
`, `,
{ {
group, group,
}, }
{ additionalTypenames: ['Update'] }
) )
.toPromise() .toPromise()
); );
@@ -171,14 +168,13 @@ export default class BranchPublish extends EasCommand {
isPublicConfig: true, isPublicConfig: true,
}); });
const runtimeVersions = await getRuntimeVersionObjectAsync(exp, platformFlag, projectDir); const runtimeVersions = getRuntimeVersionObject(exp, platformFlag, projectDir);
const projectId = await getProjectIdAsync(exp); const projectId = await getProjectIdAsync(exp);
if (!branchName && autoFlag) { if (!branchName && autoFlag) {
branchName = branchName =
(await getVcsClient().getBranchNameAsync()) || (await vcs.getBranchNameAsync()) || `branch-${Math.random().toString(36).substr(2, 4)}`;
`branch-${Math.random().toString(36).substr(2, 4)}`;
} }
if (!branchName) { if (!branchName) {
@@ -301,7 +297,7 @@ export default class BranchPublish extends EasCommand {
} }
if (!message && autoFlag) { if (!message && autoFlag) {
message = (await getVcsClient().getLastCommitMessageAsync())?.trim(); message = (await vcs.getLastCommitMessageAsync())?.trim();
} }
if (!message) { if (!message) {
@@ -315,7 +311,7 @@ export default class BranchPublish extends EasCommand {
message: `Please enter a publication message.`, message: `Please enter a publication message.`,
initial: republish initial: republish
? `Republish "${oldMessage!}" - group: ${group}` ? `Republish "${oldMessage!}" - group: ${group}`
: (await getVcsClient().getLastCommitMessageAsync())?.trim(), : (await vcs.getLastCommitMessageAsync())?.trim(),
validate: value => (value ? true : validationMessage), validate: value => (value ? true : validationMessage),
})); }));
} }
@@ -392,26 +388,59 @@ export default class BranchPublish extends EasCommand {
} }
} }
async function getRuntimeVersionObjectAsync( function getRuntimeVersionObject(
exp: ExpoConfig, exp: ExpoConfig,
platformFlag: PlatformFlag, platformFlag: string,
projectDir: string projectDir: string
): Promise<Record<string, string>> { ): Record<string, string> {
const platforms = (platformFlag === 'all' ? ['android', 'ios'] : [platformFlag]) as Platform[]; let { runtimeVersion: defaultRuntimeVersion, sdkVersion } = exp;
for (const platform of platforms) { // When a SDK version is supplied instead of a runtime version and we're in the managed workflow
const isPolicy = typeof (exp[platform]?.runtimeVersion ?? exp.runtimeVersion) === 'object'; // construct the runtimeVersion with special meaning indicating that the runtime is an
if (isPolicy) { // Expo SDK preset runtime that can be launched in Expo Go.
const isManaged = (await resolveWorkflowAsync(projectDir, platform)) === Workflow.MANAGED; const isManagedProject = getDefaultTarget(projectDir) === 'managed';
if (!isManaged) { if (!defaultRuntimeVersion && sdkVersion && isManagedProject) {
throw new Error('Runtime version policies are only supported in the managed workflow.'); Log.withTick('Generating runtime version from sdk version');
} defaultRuntimeVersion = getRuntimeVersionForSDKVersion(sdkVersion);
}
const iOSRuntimeVersion = (exp as any).ios?.runtimeVersion; // TODO-JJ remove cast to any
const androidRuntimeVersion = (exp as any).android?.runtimeVersion; // TODO-JJ remove cast to any
let runtimeVersions: Record<string, string>;
switch (platformFlag) {
case 'ios': {
runtimeVersions = {
ios: iOSRuntimeVersion ?? defaultRuntimeVersion,
};
break;
} }
case 'android': {
runtimeVersions = {
android: androidRuntimeVersion ?? defaultRuntimeVersion,
};
break;
}
case 'all': {
runtimeVersions = {
ios: iOSRuntimeVersion ?? defaultRuntimeVersion,
android: androidRuntimeVersion ?? defaultRuntimeVersion,
};
break;
}
default:
throw new Error('Platform flag must be "ios", "android", or "all"');
}
if (Object.values(runtimeVersions).some(runtime => !runtime)) {
throw new Error(
"Couldn't find a 'runtimeVersion' for every platform. Please specify it under the 'expo' key in 'app.json'"
);
}
if (Object.values(runtimeVersions).some(runtime => typeof runtime !== 'string')) {
throw new Error(
`Please ensure that all of the runtime versions defined in the app.json are strings.`
);
} }
return Object.fromEntries( return runtimeVersions;
platforms.map(platform => [platform, Updates.getRuntimeVersion(exp, platform)])
);
} }
function formatUpdateTitle( function formatUpdateTitle(
+1 -2
View File
@@ -58,8 +58,7 @@ export async function viewUpdateBranchAsync({
appId, appId,
name, name,
limit: PAGE_LIMIT, limit: PAGE_LIMIT,
}, }
{ additionalTypenames: ['UpdateBranch', 'Update'] }
) )
.toPromise() .toPromise()
); );
+70 -110
View File
@@ -1,10 +1,13 @@
import { Platform, Workflow } from '@expo/eas-build-job'; import { Platform, Workflow } from '@expo/eas-build-job';
import { BuildProfile, EasJsonReader } from '@expo/eas-json'; import {
EasJsonReader,
hasMismatchedExtendsAsync,
isUsingDeprecatedFormatAsync,
migrateAsync,
} from '@expo/eas-json';
import { flags } from '@oclif/command'; import { flags } from '@oclif/command';
import { error } from '@oclif/errors'; import { error } from '@oclif/errors';
import chalk from 'chalk'; import chalk from 'chalk';
import figures from 'figures';
import fs from 'fs-extra';
import nullthrows from 'nullthrows'; import nullthrows from 'nullthrows';
import { prepareAndroidBuildAsync } from '../../build/android/build'; import { prepareAndroidBuildAsync } from '../../build/android/build';
@@ -14,7 +17,7 @@ import { BuildContext, createBuildContextAsync } from '../../build/context';
import { prepareIosBuildAsync } from '../../build/ios/build'; import { prepareIosBuildAsync } from '../../build/ios/build';
import { ensureExpoDevClientInstalledForDevClientBuildsAsync } from '../../build/utils/devClient'; import { ensureExpoDevClientInstalledForDevClientBuildsAsync } from '../../build/utils/devClient';
import { printBuildResults, printLogsUrls } from '../../build/utils/printBuildInfo'; import { printBuildResults, printLogsUrls } from '../../build/utils/printBuildInfo';
import { ensureRepoIsCleanAsync, reviewAndCommitChangesAsync } from '../../build/utils/repository'; import { ensureRepoIsCleanAsync } from '../../build/utils/repository';
import EasCommand from '../../commandUtils/EasCommand'; import EasCommand from '../../commandUtils/EasCommand';
import { CredentialsContext } from '../../credentials/context'; import { CredentialsContext } from '../../credentials/context';
import { import {
@@ -24,7 +27,7 @@ import {
SubmissionFragment, SubmissionFragment,
} from '../../graphql/generated'; } from '../../graphql/generated';
import { toAppPlatform, toPlatform } from '../../graphql/types/AppPlatform'; import { toAppPlatform, toPlatform } from '../../graphql/types/AppPlatform';
import Log, { learnMore, link } from '../../log'; import Log from '../../log';
import { import {
RequestedPlatform, RequestedPlatform,
appPlatformDisplayNames, appPlatformDisplayNames,
@@ -38,24 +41,21 @@ import {
} from '../../project/isEasEnabledForProject'; } from '../../project/isEasEnabledForProject';
import { validateMetroConfigForManagedWorkflowAsync } from '../../project/metroConfig'; import { validateMetroConfigForManagedWorkflowAsync } from '../../project/metroConfig';
import { findProjectRootAsync } from '../../project/projectUtils'; import { findProjectRootAsync } from '../../project/projectUtils';
import { selectAsync } from '../../prompts'; import { confirmAsync } from '../../prompts';
import { createSubmissionContextAsync } from '../../submit/context'; import { createSubmissionContextAsync } from '../../submit/context';
import { import {
submitAsync, submitAsync,
waitToCompleteAsync as waitForSubmissionsToCompleteAsync, waitToCompleteAsync as waitForSubmissionsToCompleteAsync,
} from '../../submit/submit'; } from '../../submit/submit';
import { printSubmissionDetailsUrls } from '../../submit/utils/urls'; import { printSubmissionDetailsUrls } from '../../submit/utils/urls';
import { easCliVersion } from '../../utils/easCli';
import { enableJsonOutput } from '../../utils/json'; import { enableJsonOutput } from '../../utils/json';
import { ProfileData, getProfilesAsync } from '../../utils/profiles'; import vcs from '../../vcs';
import { getVcsClient, setVcsClient } from '../../vcs';
import GitClient from '../../vcs/clients/git';
interface RawBuildFlags { interface RawBuildFlags {
platform?: string; platform?: string;
'skip-credentials-check': boolean; 'skip-credentials-check': boolean;
'skip-project-configuration': boolean; 'skip-project-configuration': boolean;
profile?: string; profile: string;
'non-interactive': boolean; 'non-interactive': boolean;
local: boolean; local: boolean;
wait: boolean; wait: boolean;
@@ -68,7 +68,7 @@ interface RawBuildFlags {
interface BuildFlags { interface BuildFlags {
requestedPlatform: RequestedPlatform; requestedPlatform: RequestedPlatform;
skipProjectConfiguration: boolean; skipProjectConfiguration: boolean;
profile: string | null; profile: string;
nonInteractive: boolean; nonInteractive: boolean;
local: boolean; local: boolean;
wait: boolean; wait: boolean;
@@ -99,8 +99,8 @@ export default class Build extends EasCommand {
description: 'Skip project configuration', description: 'Skip project configuration',
}), }),
profile: flags.string({ profile: flags.string({
description: default: 'release',
'Name of the build profile from eas.json. Defaults to "production" if defined in eas.json.', description: 'Name of the build profile from eas.json',
helpValue: 'PROFILE_NAME', helpValue: 'PROFILE_NAME',
}), }),
'non-interactive': flags.boolean({ 'non-interactive': flags.boolean({
@@ -146,66 +146,50 @@ export default class Build extends EasCommand {
const projectDir = await findProjectRootAsync(); const projectDir = await findProjectRootAsync();
await handleDeprecatedEasJsonAsync(projectDir, flags.nonInteractive); await handleDeprecatedEasJsonAsync(projectDir, flags.nonInteractive);
await getVcsClient().ensureRepoExistsAsync(); await vcs.ensureRepoExistsAsync();
await ensureRepoIsCleanAsync(flags.nonInteractive); await ensureRepoIsCleanAsync(flags.nonInteractive);
await ensureProjectConfiguredAsync(projectDir, requestedPlatform); await ensureProjectConfiguredAsync(projectDir, requestedPlatform);
const platforms = toPlatforms(requestedPlatform); const platforms = toPlatforms(requestedPlatform);
const easJsonReader = new EasJsonReader(projectDir);
const buildProfiles = await getProfilesAsync({
platforms,
profileName: flags.profile,
async readProfileAsync(platform, profileName) {
return await easJsonReader.readBuildProfileAsync(platform, profileName);
},
});
await ensureExpoDevClientInstalledForDevClientBuildsAsync({ await ensureExpoDevClientInstalledForDevClientBuildsAsync({
platforms,
projectDir, projectDir,
profile: flags.profile,
nonInteractive: flags.nonInteractive, nonInteractive: flags.nonInteractive,
buildProfiles,
}); });
const startedBuilds: { const startedBuilds: BuildFragment[] = [];
build: BuildFragment;
buildProfile: ProfileData<BuildProfile>;
}[] = [];
const buildCtxByPlatform: { [p in AppPlatform]?: BuildContext<Platform> } = {}; const buildCtxByPlatform: { [p in AppPlatform]?: BuildContext<Platform> } = {};
for (const platform of platforms) {
for (const buildProfile of buildProfiles) {
const { build: maybeBuild, buildCtx } = await this.prepareAndStartBuildAsync({ const { build: maybeBuild, buildCtx } = await this.prepareAndStartBuildAsync({
projectDir, projectDir,
platform,
flags, flags,
moreBuilds: platforms.length > 1, moreBuilds: platforms.length > 1,
buildProfile,
}); });
if (maybeBuild) { if (maybeBuild) {
startedBuilds.push({ build: maybeBuild, buildProfile }); startedBuilds.push(maybeBuild);
} }
buildCtxByPlatform[toAppPlatform(buildProfile.platform)] = buildCtx; buildCtxByPlatform[toAppPlatform(platform)] = buildCtx;
} }
if (flags.local) { if (flags.local) {
return; return;
} }
Log.newLine(); Log.newLine();
printLogsUrls(startedBuilds.map(startedBuild => startedBuild.build)); printLogsUrls(startedBuilds);
Log.newLine(); Log.newLine();
const submissions: SubmissionFragment[] = []; const submissions: SubmissionFragment[] = [];
if (flags.autoSubmit) { if (flags.autoSubmit) {
for (const startedBuild of startedBuilds) { for (const build of startedBuilds) {
const submission = await this.prepareAndStartSubmissionAsync({ const submission = await this.prepareAndStartSubmissionAsync({
build: startedBuild.build, build,
credentialsCtx: nullthrows( credentialsCtx: nullthrows(buildCtxByPlatform[build.platform]?.credentialsCtx),
buildCtxByPlatform[startedBuild.build.platform]?.credentialsCtx
),
flags, flags,
moreBuilds: startedBuilds.length > 1, moreBuilds: startedBuilds.length > 1,
projectDir, projectDir,
buildProfile: startedBuild.buildProfile,
}); });
submissions.push(submission); submissions.push(submission);
} }
@@ -219,7 +203,7 @@ export default class Build extends EasCommand {
return; return;
} }
const builds = await waitForBuildEndAsync(startedBuilds.map(({ build }) => build.id)); const builds = await waitForBuildEndAsync(startedBuilds.map(build => build.id));
printBuildResults(builds, flags.json); printBuildResults(builds, flags.json);
const haveAllBuildsFailedOrCanceled = builds.every( const haveAllBuildsFailedOrCanceled = builds.every(
@@ -268,7 +252,7 @@ export default class Build extends EasCommand {
return { return {
requestedPlatform, requestedPlatform,
skipProjectConfiguration: flags['skip-project-configuration'], skipProjectConfiguration: flags['skip-project-configuration'],
profile: profile ?? null, profile,
nonInteractive, nonInteractive,
local: flags['local'], local: flags['local'],
wait: flags['wait'], wait: flags['wait'],
@@ -279,31 +263,34 @@ export default class Build extends EasCommand {
}; };
} }
private async prepareAndStartBuildAsync({ private async prepareAndStartBuildAsync<T extends Platform>({
projectDir, projectDir,
platform,
flags, flags,
moreBuilds, moreBuilds,
buildProfile,
}: { }: {
projectDir: string; projectDir: string;
platform: T;
flags: BuildFlags; flags: BuildFlags;
moreBuilds: boolean; moreBuilds: boolean;
buildProfile: ProfileData<BuildProfile>; }): Promise<{ build: BuildFragment | undefined; buildCtx: BuildContext<T> }> {
}): Promise<{ build: BuildFragment | undefined; buildCtx: BuildContext<Platform> }> { const easJsonReader = new EasJsonReader(projectDir);
const buildProfile = await easJsonReader.readBuildProfileAsync(platform, flags.profile);
const buildCtx = await createBuildContextAsync({ const buildCtx = await createBuildContextAsync({
buildProfileName: buildProfile.profileName, buildProfileName: flags.profile,
clearCache: flags.clearCache, clearCache: flags.clearCache,
buildProfile: buildProfile.profile, buildProfile,
local: flags.local, local: flags.local,
nonInteractive: flags.nonInteractive, nonInteractive: flags.nonInteractive,
platform: buildProfile.platform, platform,
projectDir, projectDir,
skipProjectConfiguration: flags.skipProjectConfiguration, skipProjectConfiguration: flags.skipProjectConfiguration,
}); });
if (moreBuilds) { if (moreBuilds) {
Log.newLine(); Log.newLine();
const appPlatform = toAppPlatform(buildProfile.platform); const appPlatform = toAppPlatform(platform);
Log.log( Log.log(
`${appPlatformEmojis[appPlatform]} ${chalk.bold( `${appPlatformEmojis[appPlatform]} ${chalk.bold(
`${appPlatformDisplayNames[appPlatform]} build` `${appPlatformDisplayNames[appPlatform]} build`
@@ -343,17 +330,16 @@ export default class Build extends EasCommand {
flags, flags,
moreBuilds, moreBuilds,
projectDir, projectDir,
buildProfile,
}: { }: {
build: BuildFragment; build: BuildFragment;
credentialsCtx: CredentialsContext; credentialsCtx: CredentialsContext;
flags: BuildFlags; flags: BuildFlags;
moreBuilds: boolean; moreBuilds: boolean;
projectDir: string; projectDir: string;
buildProfile: ProfileData<BuildProfile>;
}): Promise<SubmissionFragment> { }): Promise<SubmissionFragment> {
const easJsonReader = new EasJsonReader(projectDir); const easJsonReader = new EasJsonReader(projectDir);
const platform = toPlatform(build.platform); const platform = toPlatform(build.platform);
const buildProfile = await easJsonReader.readBuildProfileAsync(platform, flags.profile);
const submitProfile = await easJsonReader.readSubmitProfileAsync(platform, flags.submitProfile); const submitProfile = await easJsonReader.readSubmitProfileAsync(platform, flags.submitProfile);
const submissionCtx = await createSubmissionContextAsync({ const submissionCtx = await createSubmissionContextAsync({
platform, platform,
@@ -362,7 +348,7 @@ export default class Build extends EasCommand {
profile: submitProfile, profile: submitProfile,
archiveFlags: { id: build.id }, archiveFlags: { id: build.id },
nonInteractive: flags.nonInteractive, nonInteractive: flags.nonInteractive,
env: buildProfile.profile.env, env: buildProfile.env,
credentialsCtx, credentialsCtx,
}); });
@@ -392,62 +378,36 @@ export async function handleDeprecatedEasJsonAsync(
projectDir: string, projectDir: string,
nonInteractive: boolean nonInteractive: boolean
): Promise<void> { ): Promise<void> {
const easJsonPath = EasJsonReader.formatEasJsonPath(projectDir); if (await isUsingDeprecatedFormatAsync(projectDir)) {
if (!(await fs.pathExists(easJsonPath))) { const hasMismatchedExtendsKeys = await hasMismatchedExtendsAsync(projectDir);
return; if (nonInteractive) {
} Log.error('We detected that your eas.json is using a deprecated format.');
const easJsonReader = new EasJsonReader(projectDir); Log.error(
const rawEasJson = await easJsonReader.readRawAsync(); 'We will convert it automatically if run this command without --non-interactive flag. Alternatively, you can update eas.json manually according to https://docs.expo.dev/build/eas-json'
if (rawEasJson?.cli) { );
return; error('Unsupported eas.json format', { exit: 1 });
} }
if (nonInteractive) { const confirm = await confirmAsync({
Log.warn( message:
`${ 'We detected that your eas.json is using a deprecated format, do you want to migrate to the new format?',
figures.warning
} Action required: the default behavior of EAS CLI has changed and your eas.json must be updated to remove ambiguity around which Git integration workflow to use. Refer to ${link(
'https://expo.fyi/eas-vcs-workflow'
)} for more information.`
);
Log.warn(
'This warning will become an error in an upcoming EAS CLI release. For now, we will proceed with the old default behavior to avoid disruption of your builds.'
);
setVcsClient(new GitClient());
return;
}
Log.log(
`${chalk.bold(
'eas-cli@>=0.34.0 no longer requires that you commit changes to Git before starting a build.'
)} ${learnMore('https://expo.fyi/eas-vcs-workflow')}`
);
Log.log(
`If you want to continue using the Git integration, you can opt in with ${chalk.bold(
'cli.requireCommit'
)} in ${chalk.bold('eas.json')} or with the following prompt.`
);
Log.newLine();
const mode = await selectAsync('Select your preferred Git integration', [
{ title: 'Require changes to be committed in Git (old default)', value: 'requireCommit' },
{ title: 'Allow builds with dirty Git working tree (new default)', value: 'noCommit' },
]);
if (mode === 'requireCommit') {
setVcsClient(new GitClient());
await ensureRepoIsCleanAsync(nonInteractive);
}
rawEasJson.cli =
mode === 'requireCommit'
? { version: `>= ${easCliVersion}`, requireCommit: true }
: { version: `>= ${easCliVersion}` };
await fs.writeJSON(easJsonPath, rawEasJson, { spaces: 2 });
Log.withTick('Updated eas.json');
if (mode === 'requireCommit') {
await getVcsClient().trackFileAsync(easJsonPath);
await reviewAndCommitChangesAsync('Set cli.requireCommit to true in eas.json', {
nonInteractive,
}); });
if (confirm) {
await migrateAsync(projectDir);
if (hasMismatchedExtendsKeys) {
Log.warn(
'"extends" keyword can only be migrated automatically to the new format if both Android and iOS profiles extend base profiles with the same names for both platforms'
);
Log.warn(
'Migration was successful, but you need to manually adjust the extend rules for your profiles'
);
error('Fix eas.json manually', { exit: 1 });
}
} else {
Log.error(
"Aborting, update your eas.json according to https://docs.expo.dev/build/eas-json and run 'eas build' again"
);
error('Unsupported eas.json format', { exit: 1 });
}
} }
} }
@@ -49,8 +49,7 @@ async function getChannelByNameForAppAsync({
} }
} }
`, `,
{ appId, channelName }, { appId, channelName }
{ additionalTypenames: ['UpdateChannel', 'UpdateBranch'] }
) )
.toPromise() .toPromise()
); );
@@ -58,8 +58,7 @@ async function getAllUpdateChannelForAppAsync({
} }
} }
`, `,
{ appId, offset: 0, limit: CHANNEL_LIMIT }, { appId, offset: 0, limit: CHANNEL_LIMIT }
{ additionalTypenames: ['UpdateChannel', 'UpdateBranch', 'Update'] }
) )
.toPromise() .toPromise()
); );
@@ -133,8 +133,7 @@ export async function getUpdateChannelByNameForAppAsync({
} }
} }
`, `,
{ appId, channelName }, { appId, channelName }
{ additionalTypenames: ['UpdateChannel', 'UpdateBranch', 'Update'] }
) )
.toPromise() .toPromise()
); );
+3 -2
View File
@@ -2,7 +2,8 @@ import envinfo from 'envinfo';
import EasCommand from '../commandUtils/EasCommand'; import EasCommand from '../commandUtils/EasCommand';
import Log from '../log'; import Log from '../log';
import { easCliVersion } from '../utils/easCli';
const packageJSON = require('../../package.json');
export default class Diagnostics extends EasCommand { export default class Diagnostics extends EasCommand {
static description = 'log environment info to the console'; static description = 'log environment info to the console';
@@ -29,7 +30,7 @@ export default class Diagnostics extends EasCommand {
npmGlobalPackages: ['eas-cli', 'expo-cli'], npmGlobalPackages: ['eas-cli', 'expo-cli'],
}, },
{ {
title: `EAS CLI ${easCliVersion} environment info`, title: `EAS CLI ${packageJSON.version} environment info`,
} }
); );
Log.log(info); Log.log(info);
@@ -22,8 +22,7 @@ async function projectInfoByIdAsync(appId: string): Promise<AppInfoQuery> {
} }
} }
`, `,
{ appId }, { appId }
{ additionalTypenames: ['App'] }
) )
.toPromise() .toPromise()
); );
@@ -23,7 +23,7 @@ import { promptAsync, toggleConfirmAsync } from '../../prompts';
export default class EnvironmentSecretDelete extends EasCommand { export default class EnvironmentSecretDelete extends EasCommand {
static description = `Delete an environment secret by ID. static description = `Delete an environment secret by ID.
Unsure where to find the secret's ID? Run ${chalk.bold('eas secret:list')}`; Unsure where to find the secret's ID? Run ${chalk.bold('eas secrets:list')}`;
static flags = { static flags = {
id: flags.string({ id: flags.string({
+8 -16
View File
@@ -20,7 +20,6 @@ import { findProjectRootAsync, getProjectIdAsync } from '../project/projectUtils
import { SubmitArchiveFlags, createSubmissionContextAsync } from '../submit/context'; import { SubmitArchiveFlags, createSubmissionContextAsync } from '../submit/context';
import { submitAsync, waitToCompleteAsync } from '../submit/submit'; import { submitAsync, waitToCompleteAsync } from '../submit/submit';
import { printSubmissionDetailsUrls } from '../submit/utils/urls'; import { printSubmissionDetailsUrls } from '../submit/utils/urls';
import { getProfilesAsync } from '../utils/profiles';
interface RawFlags { interface RawFlags {
platform?: string; platform?: string;
@@ -55,7 +54,7 @@ See how to configure submits with eas.json: ${link('https://docs.expo.dev/submit
}), }),
profile: flags.string({ profile: flags.string({
description: description:
'Name of the submit profile from eas.json. Defaults to "production" if defined in eas.json.', 'Name of the submit profile from eas.json. Defaults to "release" if defined in eas.json.',
}), }),
latest: flags.boolean({ latest: flags.boolean({
description: 'Submit the latest build for specified platform', description: 'Submit the latest build for specified platform',
@@ -102,30 +101,23 @@ See how to configure submits with eas.json: ${link('https://docs.expo.dev/submit
return; return;
} }
const platforms = toPlatforms(flags.requestedPlatform);
const easJsonReader = new EasJsonReader(projectDir); const easJsonReader = new EasJsonReader(projectDir);
const submissionProfiles = await getProfilesAsync({ const platforms = toPlatforms(flags.requestedPlatform);
platforms,
profileName: flags.profile,
async readProfileAsync(platform, profileName) {
return await easJsonReader.readSubmitProfileAsync(platform, profileName);
},
});
const submissions: SubmissionFragment[] = []; const submissions: SubmissionFragment[] = [];
for (const submissionProfile of submissionProfiles) { for (const platform of platforms) {
const profile = await easJsonReader.readSubmitProfileAsync(platform, flags.profile);
const ctx = await createSubmissionContextAsync({ const ctx = await createSubmissionContextAsync({
platform: submissionProfile.platform, platform,
projectDir, projectDir,
projectId, projectId,
profile: submissionProfile.profile, profile,
archiveFlags: flags.archiveFlags, archiveFlags: flags.archiveFlags,
nonInteractive: flags.nonInteractive, nonInteractive: flags.nonInteractive,
}); });
if (submissionProfiles.length > 1) { if (platforms.length > 1) {
Log.newLine(); Log.newLine();
const appPlatform = toAppPlatform(submissionProfile.platform); const appPlatform = toAppPlatform(platform);
Log.log( Log.log(
`${appPlatformEmojis[appPlatform]} ${chalk.bold( `${appPlatformEmojis[appPlatform]} ${chalk.bold(
`${appPlatformDisplayNames[appPlatform]} submission` `${appPlatformDisplayNames[appPlatform]} submission`
+1 -2
View File
@@ -39,8 +39,7 @@ export async function viewUpdateAsync({
`, `,
{ {
groupId, groupId,
}, }
{ additionalTypenames: ['Update'] }
) )
.toPromise() .toPromise()
); );
@@ -4,7 +4,7 @@ import { AuthCtx } from '../ios/appstore/authenticate';
export const testAuthCtx: AuthCtx = { export const testAuthCtx: AuthCtx = {
appleId: 'test-apple-id', appleId: 'test-apple-id',
appleIdPassword: 'test-apple-password', appleIdPassword: 'test-apple-password',
team: { id: 'test-apple-team-identifier', name: 'test-team-name', inHouse: false }, team: { id: 'test-team-id', name: 'test-team-name', inHouse: false },
}; };
export function getAppstoreMock(): AppStoreApi { export function getAppstoreMock(): AppStoreApi {
@@ -22,9 +22,5 @@ export function getAppstoreMock(): AppStoreApi {
createProvisioningProfileAsync: jest.fn(), createProvisioningProfileAsync: jest.fn(),
revokeProvisioningProfileAsync: jest.fn(), revokeProvisioningProfileAsync: jest.fn(),
createOrReuseAdhocProvisioningProfileAsync: jest.fn(), createOrReuseAdhocProvisioningProfileAsync: jest.fn(),
createAscApiKeyAsync: jest.fn(),
getAscApiKeyAsync: jest.fn(),
revokeAscApiKeyAsync: jest.fn(),
listAscApiKeysAsync: jest.fn(),
} as any; } as any;
} }
@@ -1,9 +1,5 @@
import { UserRole } from '@expo/apple-utils';
import { import {
AppFragment, AppFragment,
AppStoreConnectApiKeyFragment,
AppStoreConnectUserRole,
AppleAppIdentifierFragment, AppleAppIdentifierFragment,
AppleDistributionCertificateFragment, AppleDistributionCertificateFragment,
AppleProvisioningProfileFragment, AppleProvisioningProfileFragment,
@@ -14,27 +10,12 @@ import {
IosDistributionType, IosDistributionType,
} from '../../graphql/generated'; } from '../../graphql/generated';
import * as IosGraphqlClient from '../ios/api/GraphqlClient'; import * as IosGraphqlClient from '../ios/api/GraphqlClient';
import { import { DistributionCertificate, ProvisioningProfile } from '../ios/appstore/Credentials.types';
AscApiKey,
DistributionCertificate,
ProvisioningProfile,
} from '../ios/appstore/Credentials.types';
import { Target } from '../ios/types'; import { Target } from '../ios/types';
import { testProvisioningProfileBase64 } from './fixtures-base64-data'; import { testProvisioningProfileBase64 } from './fixtures-base64-data';
const now = new Date(); const now = new Date();
export const testAscApiKey: AscApiKey = {
keyId: 'test-keyIdentifier',
issuerId: 'test-issuer-id-from-apple',
teamId: 'test-team-id',
teamName: 'test-team-name',
name: 'test-name',
roles: [UserRole.ADMIN],
isRevoked: false,
keyP8: 'test-key-p8',
};
export const testProvisioningProfile: ProvisioningProfile = { export const testProvisioningProfile: ProvisioningProfile = {
provisioningProfileId: 'test-id', provisioningProfileId: 'test-id',
provisioningProfile: testProvisioningProfileBase64, provisioningProfile: testProvisioningProfileBase64,
@@ -57,17 +38,6 @@ export const testAppFragment: AppFragment = {
slug: 'testapp', slug: 'testapp',
}; };
export const testAscApiKeyFragment: AppStoreConnectApiKeyFragment = {
id: 'test-asc-api-key-id',
appleTeam: { ...testAppleTeamFragment },
issuerIdentifier: 'test-issuerIdentifier',
keyIdentifier: 'test-keyIdentifier',
name: 'test-name',
roles: [AppStoreConnectUserRole.Admin],
updatedAt: now,
createdAt: now,
};
export const testPushKey: ApplePushKeyFragment = { export const testPushKey: ApplePushKeyFragment = {
id: 'test-push-key-id', id: 'test-push-key-id',
keyIdentifier: 'test-key-identifier', keyIdentifier: 'test-key-identifier',
@@ -142,7 +112,6 @@ export const testCommonIosAppCredentialsFragment: CommonIosAppCredentialsFragmen
appleAppIdentifier: testAppleAppIdentifierFragment, appleAppIdentifier: testAppleAppIdentifierFragment,
pushKey: testPushKey, pushKey: testPushKey,
iosAppBuildCredentialsList: [testIosAppBuildCredentialsFragment], iosAppBuildCredentialsList: [testIosAppBuildCredentialsFragment],
appStoreConnectApiKeyForSubmissions: testAscApiKeyFragment,
}; };
export const testAppleTeam = { export const testAppleTeam = {
@@ -170,9 +139,6 @@ export function getNewIosApiMock(): { [key in keyof typeof IosGraphqlClient]?: a
createPushKeyAsync: jest.fn(), createPushKeyAsync: jest.fn(),
getPushKeyForAppAsync: jest.fn(), getPushKeyForAppAsync: jest.fn(),
deletePushKeyAsync: jest.fn(), deletePushKeyAsync: jest.fn(),
createAscApiKeyAsync: jest.fn(),
deleteAscApiKeyAsync: jest.fn(),
getAscApiKeysForAccountAsync: jest.fn(() => []),
}; };
} }
@@ -5,7 +5,7 @@ import nullthrows from 'nullthrows';
import { AndroidAppBuildCredentialsFragment } from '../../graphql/generated'; import { AndroidAppBuildCredentialsFragment } from '../../graphql/generated';
import { CredentialsContext } from '../context'; import { CredentialsContext } from '../context';
import * as credentialsJsonReader from '../credentialsJson/read'; import * as credentialsJsonReader from '../credentialsJson/read';
import { SetUpBuildCredentials } from './actions/SetUpBuildCredentials'; import { SetupBuildCredentials } from './actions/SetupBuildCredentials';
import { AppLookupParams } from './api/GraphqlClient'; import { AppLookupParams } from './api/GraphqlClient';
import { Keystore } from './credentials'; import { Keystore } from './credentials';
@@ -34,7 +34,7 @@ export default class AndroidCredentialsProvider {
} }
private async getRemoteAsync(): Promise<AndroidCredentials> { private async getRemoteAsync(): Promise<AndroidCredentials> {
const setupBuildCredentialsAction = new SetUpBuildCredentials({ app: this.options.app }); const setupBuildCredentialsAction = new SetupBuildCredentials({ app: this.options.app });
const buildCredentials = await setupBuildCredentialsAction.runAsync(this.ctx); const buildCredentials = await setupBuildCredentialsAction.runAsync(this.ctx);
return this.toAndroidCredentials(buildCredentials); return this.toAndroidCredentials(buildCredentials);
} }
@@ -25,7 +25,7 @@ interface Options {
* Sets up Build Credentials for Android * Sets up Build Credentials for Android
* @name: sets up build credentials for the specified configuration. If no name is specified, the default configuration is setup * @name: sets up build credentials for the specified configuration. If no name is specified, the default configuration is setup
*/ */
export class SetUpBuildCredentials { export class SetupBuildCredentials {
constructor(private options: Options) {} constructor(private options: Options) {}
async runAsync(ctx: CredentialsContext): Promise<AndroidAppBuildCredentialsFragment> { async runAsync(ctx: CredentialsContext): Promise<AndroidAppBuildCredentialsFragment> {
@@ -14,7 +14,7 @@ import { AppLookupParams } from '../api/GraphqlClient';
import { getKeystoreWithType } from '../utils/keystoreNew'; import { getKeystoreWithType } from '../utils/keystoreNew';
import { BackupKeystore } from './DownloadKeystore'; import { BackupKeystore } from './DownloadKeystore';
export class SetUpBuildCredentialsFromCredentialsJson { export class SetupBuildCredentialsFromCredentialsJson {
constructor(private app: AppLookupParams) {} constructor(private app: AppLookupParams) {}
async runAsync(ctx: CredentialsContext): Promise<AndroidAppBuildCredentialsFragment | null> { async runAsync(ctx: CredentialsContext): Promise<AndroidAppBuildCredentialsFragment | null> {
@@ -13,7 +13,7 @@ import { AssignGoogleServiceAccountKey } from './AssignGoogleServiceAccountKey';
import { CreateGoogleServiceAccountKey } from './CreateGoogleServiceAccountKey'; import { CreateGoogleServiceAccountKey } from './CreateGoogleServiceAccountKey';
import { UseExistingGoogleServiceAccountKey } from './UseExistingGoogleServiceAccountKey'; import { UseExistingGoogleServiceAccountKey } from './UseExistingGoogleServiceAccountKey';
export class SetUpGoogleServiceAccountKey { export class SetupGoogleServiceAccountKey {
constructor(private app: AppLookupParams) {} constructor(private app: AppLookupParams) {}
public async runAsync(ctx: CredentialsContext): Promise<CommonAndroidAppCredentialsFragment> { public async runAsync(ctx: CredentialsContext): Promise<CommonAndroidAppCredentialsFragment> {
@@ -9,7 +9,7 @@ import { createCtxMock } from '../../../__tests__/fixtures-context';
import { MissingCredentialsNonInteractiveError } from '../../../errors'; import { MissingCredentialsNonInteractiveError } from '../../../errors';
import { generateRandomKeystoreAsync } from '../../utils/keystore'; import { generateRandomKeystoreAsync } from '../../utils/keystore';
import { getAppLookupParamsFromContextAsync } from '../BuildCredentialsUtils'; import { getAppLookupParamsFromContextAsync } from '../BuildCredentialsUtils';
import { SetUpBuildCredentials } from '../SetUpBuildCredentials'; import { SetupBuildCredentials } from '../SetupBuildCredentials';
jest.mock('../../../../ora'); jest.mock('../../../../ora');
jest.mock('../../../../project/ensureProjectExists'); jest.mock('../../../../project/ensureProjectExists');
@@ -17,7 +17,7 @@ jest.mock('../../../../user/actions', () => ({ ensureLoggedInAsync: jest.fn(() =
jest.mock('../../../../prompts', () => ({ confirmAsync: jest.fn(() => true) })); jest.mock('../../../../prompts', () => ({ confirmAsync: jest.fn(() => true) }));
jest.mock('../../utils/keystore', () => ({ generateRandomKeystoreAsync: jest.fn() })); jest.mock('../../utils/keystore', () => ({ generateRandomKeystoreAsync: jest.fn() }));
describe('SetUpBuildCredentials', () => { describe('SetupBuildCredentials', () => {
beforeEach(() => { beforeEach(() => {
asMock(generateRandomKeystoreAsync).mockReset(); asMock(generateRandomKeystoreAsync).mockReset();
}); });
@@ -33,7 +33,7 @@ describe('SetUpBuildCredentials', () => {
}, },
}); });
const appLookupParams = await getAppLookupParamsFromContextAsync(ctx); const appLookupParams = await getAppLookupParamsFromContextAsync(ctx);
const setupBuildCredentialsAction = new SetUpBuildCredentials({ app: appLookupParams }); const setupBuildCredentialsAction = new SetupBuildCredentials({ app: appLookupParams });
await setupBuildCredentialsAction.runAsync(ctx); await setupBuildCredentialsAction.runAsync(ctx);
// expect keystore not to be created // expect keystore not to be created
@@ -48,7 +48,7 @@ describe('SetUpBuildCredentials', () => {
}, },
}); });
const appLookupParams = await getAppLookupParamsFromContextAsync(ctx); const appLookupParams = await getAppLookupParamsFromContextAsync(ctx);
const setupBuildCredentialsAction = new SetUpBuildCredentials({ app: appLookupParams }); const setupBuildCredentialsAction = new SetupBuildCredentials({ app: appLookupParams });
await setupBuildCredentialsAction.runAsync(ctx); await setupBuildCredentialsAction.runAsync(ctx);
// expect keystore to be created // expect keystore to be created
@@ -63,7 +63,7 @@ describe('SetUpBuildCredentials', () => {
}, },
}); });
const appLookupParams = await getAppLookupParamsFromContextAsync(ctx); const appLookupParams = await getAppLookupParamsFromContextAsync(ctx);
const setupBuildCredentialsAction = new SetUpBuildCredentials({ app: appLookupParams }); const setupBuildCredentialsAction = new SetupBuildCredentials({ app: appLookupParams });
await expect(setupBuildCredentialsAction.runAsync(ctx)).rejects.toThrowError( await expect(setupBuildCredentialsAction.runAsync(ctx)).rejects.toThrowError(
MissingCredentialsNonInteractiveError MissingCredentialsNonInteractiveError
); );
@@ -14,7 +14,7 @@ import {
SelectAndroidBuildCredentialsResultType, SelectAndroidBuildCredentialsResultType,
} from '../../../manager/SelectAndroidBuildCredentials'; } from '../../../manager/SelectAndroidBuildCredentials';
import { getAppLookupParamsFromContextAsync } from '../BuildCredentialsUtils'; import { getAppLookupParamsFromContextAsync } from '../BuildCredentialsUtils';
import { SetUpBuildCredentialsFromCredentialsJson } from '../SetUpBuildCredentialsFromCredentialsJson'; import { SetupBuildCredentialsFromCredentialsJson } from '../SetupBuildCredentialsFromCredentialsJson';
jest.mock('fs'); jest.mock('fs');
@@ -26,7 +26,7 @@ beforeEach(() => {
vol.reset(); vol.reset();
}); });
describe(SetUpBuildCredentialsFromCredentialsJson, () => { describe(SetupBuildCredentialsFromCredentialsJson, () => {
it('sets up a new build configuration from credentials.json upon user request', async () => { it('sets up a new build configuration from credentials.json upon user request', async () => {
asMock(SelectAndroidBuildCredentials).mockImplementation(() => { asMock(SelectAndroidBuildCredentials).mockImplementation(() => {
return { return {
@@ -59,7 +59,7 @@ describe(SetUpBuildCredentialsFromCredentialsJson, () => {
'keystore.jks': 'some-binary-content', 'keystore.jks': 'some-binary-content',
}); });
const appLookupParams = await getAppLookupParamsFromContextAsync(ctx); const appLookupParams = await getAppLookupParamsFromContextAsync(ctx);
const setupBuildCredentialsAction = new SetUpBuildCredentialsFromCredentialsJson( const setupBuildCredentialsAction = new SetupBuildCredentialsFromCredentialsJson(
appLookupParams appLookupParams
); );
await setupBuildCredentialsAction.runAsync(ctx); await setupBuildCredentialsAction.runAsync(ctx);
@@ -109,7 +109,7 @@ describe(SetUpBuildCredentialsFromCredentialsJson, () => {
'keystore.jks': 'some-binary-content', 'keystore.jks': 'some-binary-content',
}); });
const appLookupParams = await getAppLookupParamsFromContextAsync(ctx); const appLookupParams = await getAppLookupParamsFromContextAsync(ctx);
const setupBuildCredentialsAction = new SetUpBuildCredentialsFromCredentialsJson( const setupBuildCredentialsAction = new SetupBuildCredentialsFromCredentialsJson(
appLookupParams appLookupParams
); );
await setupBuildCredentialsAction.runAsync(ctx); await setupBuildCredentialsAction.runAsync(ctx);
@@ -132,7 +132,7 @@ describe(SetUpBuildCredentialsFromCredentialsJson, () => {
nonInteractive: true, nonInteractive: true,
}); });
const appLookupParams = await getAppLookupParamsFromContextAsync(ctx); const appLookupParams = await getAppLookupParamsFromContextAsync(ctx);
const setupBuildCredentialsAction = new SetUpBuildCredentialsFromCredentialsJson( const setupBuildCredentialsAction = new SetupBuildCredentialsFromCredentialsJson(
appLookupParams appLookupParams
); );
await expect(setupBuildCredentialsAction.runAsync(ctx)).rejects.toThrowError(); await expect(setupBuildCredentialsAction.runAsync(ctx)).rejects.toThrowError();
@@ -10,7 +10,7 @@ import {
import { createCtxMock } from '../../../__tests__/fixtures-context'; import { createCtxMock } from '../../../__tests__/fixtures-context';
import { MissingCredentialsNonInteractiveError } from '../../../errors'; import { MissingCredentialsNonInteractiveError } from '../../../errors';
import { getAppLookupParamsFromContextAsync } from '../BuildCredentialsUtils'; import { getAppLookupParamsFromContextAsync } from '../BuildCredentialsUtils';
import { SetUpGoogleServiceAccountKey } from '../SetUpGoogleServiceAccountKey'; import { SetupGoogleServiceAccountKey } from '../SetupGoogleServiceAccountKey';
jest.mock('../../../../prompts'); jest.mock('../../../../prompts');
jest.mock('fs'); jest.mock('fs');
@@ -22,7 +22,7 @@ beforeEach(() => {
vol.reset(); vol.reset();
}); });
describe(SetUpGoogleServiceAccountKey, () => { describe(SetupGoogleServiceAccountKey, () => {
it('skips setup when there is a Google Service Account Key already assigned to the project', async () => { it('skips setup when there is a Google Service Account Key already assigned to the project', async () => {
const ctx = createCtxMock({ const ctx = createCtxMock({
nonInteractive: false, nonInteractive: false,
@@ -34,7 +34,7 @@ describe(SetUpGoogleServiceAccountKey, () => {
}, },
}); });
const appLookupParams = await getAppLookupParamsFromContextAsync(ctx); const appLookupParams = await getAppLookupParamsFromContextAsync(ctx);
const setupGoogleServiceAccountKeyAction = new SetUpGoogleServiceAccountKey(appLookupParams); const setupGoogleServiceAccountKeyAction = new SetupGoogleServiceAccountKey(appLookupParams);
await setupGoogleServiceAccountKeyAction.runAsync(ctx); await setupGoogleServiceAccountKeyAction.runAsync(ctx);
expect(ctx.android.createGoogleServiceAccountKeyAsync).not.toHaveBeenCalled(); expect(ctx.android.createGoogleServiceAccountKeyAsync).not.toHaveBeenCalled();
@@ -57,7 +57,7 @@ describe(SetUpGoogleServiceAccountKey, () => {
}, },
}); });
const appLookupParams = await getAppLookupParamsFromContextAsync(ctx); const appLookupParams = await getAppLookupParamsFromContextAsync(ctx);
const setupGoogleServiceAccountKeyAction = new SetUpGoogleServiceAccountKey(appLookupParams); const setupGoogleServiceAccountKeyAction = new SetupGoogleServiceAccountKey(appLookupParams);
await setupGoogleServiceAccountKeyAction.runAsync(ctx); await setupGoogleServiceAccountKeyAction.runAsync(ctx);
expect(ctx.android.createGoogleServiceAccountKeyAsync).toHaveBeenCalledTimes(1); expect(ctx.android.createGoogleServiceAccountKeyAsync).toHaveBeenCalledTimes(1);
@@ -68,7 +68,7 @@ describe(SetUpGoogleServiceAccountKey, () => {
nonInteractive: true, nonInteractive: true,
}); });
const appLookupParams = await getAppLookupParamsFromContextAsync(ctx); const appLookupParams = await getAppLookupParamsFromContextAsync(ctx);
const setupGoogleServiceAccountKeyAction = new SetUpGoogleServiceAccountKey(appLookupParams); const setupGoogleServiceAccountKeyAction = new SetupGoogleServiceAccountKey(appLookupParams);
await expect(setupGoogleServiceAccountKeyAction.runAsync(ctx)).rejects.toThrowError( await expect(setupGoogleServiceAccountKeyAction.runAsync(ctx)).rejects.toThrowError(
MissingCredentialsNonInteractiveError MissingCredentialsNonInteractiveError
); );
@@ -29,9 +29,6 @@ export const GoogleServiceAccountKeyQuery = {
`, `,
{ {
accountName, accountName,
},
{
additionalTypenames: ['GoogleServiceAccountKey'],
} }
) )
.toPromise() .toPromise()
@@ -6,8 +6,8 @@ import { AndroidAppBuildCredentialsFragment, IosDistributionType } from '../../g
import Log from '../../log'; import Log from '../../log';
import { findApplicationTarget, findTargetByName } from '../../project/ios/target'; import { findApplicationTarget, findTargetByName } from '../../project/ios/target';
import zipObject from '../../utils/expodash/zipObject'; import zipObject from '../../utils/expodash/zipObject';
import { getVcsClient } from '../../vcs'; import vcs from '../../vcs';
import GitClient from '../../vcs/clients/git'; import GitClient from '../../vcs/git';
import { CredentialsContext } from '../context'; import { CredentialsContext } from '../context';
import { App, Target, TargetCredentials } from '../ios/types'; import { App, Target, TargetCredentials } from '../ios/types';
import { readRawAsync } from './read'; import { readRawAsync } from './read';
@@ -294,9 +294,8 @@ async function updateFileAsync(
} }
async function isFileUntrackedAsync(path: string): Promise<boolean> { async function isFileUntrackedAsync(path: string): Promise<boolean> {
const vcsClient = getVcsClient(); if (vcs instanceof GitClient) {
if (vcsClient instanceof GitClient) { return await vcs.isFileUntrackedAsync(path);
return await vcsClient.isFileUntrackedAsync(path);
} }
return false; return false;
} }
@@ -5,15 +5,3 @@ export class MissingCredentialsNonInteractiveError extends Error {
); );
} }
} }
export class MissingCredentialsError extends Error {
constructor(message?: string) {
super(message ?? 'Credentials are not set up.');
}
}
export class UnsupportedCredentialsChoiceError extends Error {
constructor(message: string, public choice: string) {
super(message);
}
}
@@ -9,8 +9,8 @@ import { CredentialsContext } from '../context';
import * as credentialsJsonReader from '../credentialsJson/read'; import * as credentialsJsonReader from '../credentialsJson/read';
import { ensureAllTargetsAreConfigured } from '../credentialsJson/utils'; import { ensureAllTargetsAreConfigured } from '../credentialsJson/utils';
import { getAppFromContext } from './actions/BuildCredentialsUtils'; import { getAppFromContext } from './actions/BuildCredentialsUtils';
import { SetUpBuildCredentials } from './actions/SetUpBuildCredentials'; import { SetupBuildCredentials } from './actions/SetupBuildCredentials';
import { SetUpPushKey } from './actions/SetUpPushKey'; import { SetupPushKey } from './actions/SetupPushKey';
import { IosCapabilitiesOptions } from './appstore/ensureAppExists'; import { IosCapabilitiesOptions } from './appstore/ensureAppExists';
import { App, IosCredentials, Target } from './types'; import { App, IosCredentials, Target } from './types';
import { isAdHocProfile } from './utils/provisioningProfile'; import { isAdHocProfile } from './utils/provisioningProfile';
@@ -58,7 +58,7 @@ export default class IosCredentialsProvider {
} }
private async getRemoteAsync(): Promise<IosCredentials> { private async getRemoteAsync(): Promise<IosCredentials> {
return await new SetUpBuildCredentials({ return await new SetupBuildCredentials({
app: this.options.app, app: this.options.app,
targets: this.options.targets, targets: this.options.targets,
distribution: this.options.distribution, distribution: this.options.distribution,
@@ -83,7 +83,7 @@ export default class IosCredentialsProvider {
parentBundleIdentifier: applicationTarget.parentBundleIdentifier, parentBundleIdentifier: applicationTarget.parentBundleIdentifier,
}; };
const setupPushKeyAction = new SetUpPushKey(appLookupParams); const setupPushKeyAction = new SetupPushKey(appLookupParams);
const isPushKeySetup = await setupPushKeyAction.isPushKeySetupAsync(ctx); const isPushKeySetup = await setupPushKeyAction.isPushKeySetupAsync(ctx);
if (isPushKeySetup) { if (isPushKeySetup) {
Log.succeed( Log.succeed(
@@ -93,7 +93,7 @@ export default class IosCredentialsProvider {
} }
const confirmSetup = await confirmAsync({ const confirmSetup = await confirmAsync({
message: `Would you like to set up Push Notifications for your project?`, message: `Would you like to setup Push Notifications for your project?`,
}); });
if (!confirmSetup) { if (!confirmSetup) {
return null; return null;
@@ -1,253 +0,0 @@
import chalk from 'chalk';
import fs from 'fs-extra';
import { nanoid } from 'nanoid';
import path from 'path';
import { AppStoreConnectApiKeyFragment } from '../../../graphql/generated';
import Log, { learnMore } from '../../../log';
import { confirmAsync, promptAsync } from '../../../prompts';
import { Account } from '../../../user/Account';
import { fromNow } from '../../../utils/date';
import { CredentialsContext } from '../../context';
import {
getCredentialsFromUserAsync,
shouldAutoGenerateCredentialsAsync,
} from '../../utils/promptForCredentials';
import { AscApiKey } from '../appstore/Credentials.types';
import {
AscApiKeyPath,
MinimalAscApiKey,
ascApiKeyIdSchema,
ascApiKeyIssuerIdSchema,
} from '../credentials';
import { isAscApiKeyValidAndTrackedAsync } from '../validators/validateAscApiKey';
import { formatAppleTeam } from './AppleTeamUtils';
export enum AppStoreApiKeyPurpose {
SUBMISSION_SERVICE = 'EAS Submit',
}
export async function promptForAscApiKeyPathAsync(ctx: CredentialsContext): Promise<AscApiKeyPath> {
const { keyId, keyP8Path } = await promptForKeyP8AndIdAsync();
const bestEffortIssuerId = await getBestEffortIssuerIdAsync(ctx, keyId);
if (bestEffortIssuerId) {
Log.log(`Detected Issuer ID: ${bestEffortIssuerId}`);
return { keyId, issuerId: bestEffortIssuerId, keyP8Path };
}
const issuerId = await promptForIssuerIdAsync();
return { keyId, issuerId, keyP8Path };
}
export async function promptForIssuerIdAsync(): Promise<string> {
Log.log(chalk.bold('An App Store Connect Issuer ID is required'));
Log.log(
`If you're not sure what this is or how to find yours, ${learnMore(
'https://expo.fyi/asc-issuer-id'
)}`
);
// Do not perform uuid validation - Apple's issuerIds are not RFC4122 compliant
const { issuerId } = await getCredentialsFromUserAsync(ascApiKeyIssuerIdSchema);
return issuerId;
}
export async function getMinimalAscApiKeyAsync(ascApiKey: AscApiKey): Promise<MinimalAscApiKey> {
return {
...ascApiKey,
issuerId: ascApiKey.issuerId ?? (await promptForIssuerIdAsync()),
};
}
export async function provideOrGenerateAscApiKeyAsync(
ctx: CredentialsContext,
purpose: AppStoreApiKeyPurpose
): Promise<MinimalAscApiKey> {
if (ctx.nonInteractive) {
return await generateAscApiKeyAsync(ctx, purpose);
}
const userProvided = await promptForAscApiKeyAsync(ctx);
if (!userProvided) {
return await generateAscApiKeyAsync(ctx, purpose);
}
if (!ctx.appStore.authCtx) {
Log.warn('Unable to validate App Store Connect Api Key, you are not authenticated with Apple.');
return userProvided;
}
const isValidAndTracked = await isAscApiKeyValidAndTrackedAsync(ctx, userProvided);
if (isValidAndTracked) {
return userProvided;
}
const useUserProvided = await confirmAsync({
message: `App Store Connect Api Key with ID ${userProvided.keyId} is not valid on Apple's servers. Proceed anyway?`,
});
if (useUserProvided) {
return userProvided;
}
return await provideOrGenerateAscApiKeyAsync(ctx, purpose);
}
async function generateAscApiKeyAsync(
ctx: CredentialsContext,
purpose: AppStoreApiKeyPurpose
): Promise<MinimalAscApiKey> {
await ctx.appStore.ensureAuthenticatedAsync();
const ascApiKey = await ctx.appStore.createAscApiKeyAsync({
nickname: getAscApiKeyName(purpose),
});
return await getMinimalAscApiKeyAsync(ascApiKey);
}
export function getAscApiKeyName(purpose: AppStoreApiKeyPurpose): string {
const nameParts = ['[Expo]', purpose, nanoid(10)];
return nameParts.join(' ');
}
async function promptForAscApiKeyAsync(ctx: CredentialsContext): Promise<MinimalAscApiKey | null> {
const shouldAutoGenerateCredentials = await shouldAutoGenerateCredentialsAsync(ascApiKeyIdSchema);
if (shouldAutoGenerateCredentials) {
return null;
}
const ascApiKeyPath = await promptForAscApiKeyPathAsync(ctx);
const { keyP8Path, keyId, issuerId } = ascApiKeyPath;
return { keyP8: await fs.readFile(keyP8Path, 'utf-8'), keyId, issuerId };
}
async function promptForKeyP8AndIdAsync(): Promise<Pick<AscApiKeyPath, 'keyP8Path' | 'keyId'>> {
Log.log(
chalk.bold('An App Store Connect Api key is required to upload your app to the Apple App Store')
);
Log.log(
`If you're not sure what this is or how to create one, ${learnMore(
'https://expo.fyi/creating-asc-api-key'
)}`
);
const { keyP8Path } = await promptAsync({
type: 'text',
name: 'keyP8Path',
message: 'Path to App Store Connect Api Key:',
initial: 'AuthKey_ABCD.p8',
// eslint-disable-next-line async-protect/async-suffix
validate: async (filePath: string) => {
try {
const stats = await fs.stat(filePath);
if (stats.isFile()) {
return true;
}
return 'Input is not a file.';
} catch {
return 'File does not exist.';
}
},
});
const regex = /^AuthKey_(?<keyId>\w+)\.p8$/; // Common ASC Api file name downloaded from Apple
const bestEffortKeyId = path.basename(keyP8Path).match(regex)?.groups?.keyId;
const { keyId } = await getCredentialsFromUserAsync(ascApiKeyIdSchema, {
keyId: bestEffortKeyId,
});
return { keyId, keyP8Path };
}
async function getBestEffortIssuerIdAsync(
ctx: CredentialsContext,
ascApiKeyId: string
): Promise<string | null> {
if (!ctx.appStore.authCtx) {
return null;
}
const ascApiKeyInfo = await ctx.appStore.getAscApiKeyAsync(ascApiKeyId);
return ascApiKeyInfo?.issuerId ?? null;
}
export async function getAscApiKeysFromAccountAsync(
ctx: CredentialsContext,
account: Account,
{ filterDifferentAppleTeam }: { filterDifferentAppleTeam?: boolean } = {}
): Promise<AppStoreConnectApiKeyFragment[]> {
const ascApiKeysForAccount = await ctx.ios.getAscApiKeysForAccountAsync(account);
if (!filterDifferentAppleTeam) {
return ascApiKeysForAccount;
} else {
return filterKeysFromDifferentAppleTeam(ctx, ascApiKeysForAccount);
}
}
export async function selectAscApiKeysFromAccountAsync(
ctx: CredentialsContext,
account: Account,
{ filterDifferentAppleTeam }: { filterDifferentAppleTeam?: boolean } = {}
): Promise<AppStoreConnectApiKeyFragment | null> {
const ascApiKeysForAccount = await getAscApiKeysFromAccountAsync(ctx, account, {
filterDifferentAppleTeam,
});
if (ascApiKeysForAccount.length === 0) {
if (filterDifferentAppleTeam) {
const maybeAppleTeamId = ctx.appStore.authCtx?.team.id;
Log.warn(
`There are no App Store Connect Api Keys in your EAS account${
maybeAppleTeamId ? ` matching Apple Team ID: ${maybeAppleTeamId}.` : '.'
}`
);
} else {
Log.warn(`There are no App Store Connect Api Keys available in your EAS account.`);
}
return null;
}
return selectAscApiKeysAsync(ascApiKeysForAccount);
}
async function selectAscApiKeysAsync(
ascApiKeys: AppStoreConnectApiKeyFragment[]
): Promise<AppStoreConnectApiKeyFragment | null> {
const sortedAscApiKeys = sortAscApiKeysByUpdatedAtDesc(ascApiKeys);
const { chosenAscApiKey } = await promptAsync({
type: 'select',
name: 'chosenAscApiKey',
message: 'Select an Api Key from the list:',
choices: sortedAscApiKeys.map(ascApiKey => ({
title: formatAscApiKey(ascApiKey),
value: ascApiKey,
})),
});
return chosenAscApiKey;
}
function filterKeysFromDifferentAppleTeam(
ctx: CredentialsContext,
keys: AppStoreConnectApiKeyFragment[]
): AppStoreConnectApiKeyFragment[] {
if (!ctx.appStore.authCtx) {
return keys;
}
const teamId = ctx.appStore.authCtx.team.id;
return keys.filter(key => !key.appleTeam || key.appleTeam?.appleTeamIdentifier === teamId);
}
export function sortAscApiKeysByUpdatedAtDesc(
keys: AppStoreConnectApiKeyFragment[]
): AppStoreConnectApiKeyFragment[] {
return keys.sort(
(keyA, keyB) => new Date(keyB.updatedAt).getTime() - new Date(keyA.updatedAt).getTime()
);
}
export function formatAscApiKey(ascApiKey: AppStoreConnectApiKeyFragment): string {
const { keyIdentifier, appleTeam, name, updatedAt } = ascApiKey;
let line: string = '';
line += `Key ID: ${keyIdentifier}`;
if (name) {
line += chalk.gray(`\n Name: ${name}`);
}
if (appleTeam) {
line += chalk.gray(`\n ${formatAppleTeam(appleTeam)}`);
}
line += chalk.gray(`\n Updated: ${fromNow(new Date(updatedAt))} ago`);
return line;
}
@@ -1,38 +0,0 @@
import {
AppStoreConnectApiKeyFragment,
CommonIosAppCredentialsFragment,
} from '../../../graphql/generated';
import Log from '../../../log';
import { CredentialsContext } from '../../context';
import { AppLookupParams } from '../api/GraphqlClient';
import { resolveAppleTeamIfAuthenticatedAsync } from './AppleTeamUtils';
import { AppStoreApiKeyPurpose } from './AscApiKeyUtils';
export class AssignAscApiKey {
constructor(private app: AppLookupParams) {}
public async runAsync(
ctx: CredentialsContext,
ascApiKey: AppStoreConnectApiKeyFragment,
purpose: AppStoreApiKeyPurpose
): Promise<CommonIosAppCredentialsFragment> {
const appleTeam =
(await resolveAppleTeamIfAuthenticatedAsync(ctx, this.app)) ?? ascApiKey.appleTeam ?? null;
const appCredentials = await ctx.ios.createOrGetIosAppCredentialsWithCommonFieldsAsync(
this.app,
{ appleTeam: appleTeam ?? undefined }
);
let updatedAppCredentials;
if (purpose === AppStoreApiKeyPurpose.SUBMISSION_SERVICE) {
updatedAppCredentials = await ctx.ios.updateIosAppCredentialsAsync(appCredentials, {
ascApiKeyIdForSubmissions: ascApiKey.id,
});
} else {
throw new Error(`${purpose} is not yet supported.`);
}
Log.succeed(
`App Store Connect Api Key assigned to ${this.app.projectName}: ${this.app.bundleIdentifier} for ${purpose}.`
);
return updatedAppCredentials;
}
}
@@ -1,23 +0,0 @@
import { AppStoreConnectApiKeyFragment } from '../../../graphql/generated';
import Log from '../../../log';
import { Account } from '../../../user/Account';
import { CredentialsContext } from '../../context';
import { AppStoreApiKeyPurpose, provideOrGenerateAscApiKeyAsync } from './AscApiKeyUtils';
export class CreateAscApiKey {
constructor(private account: Account) {}
public async runAsync(
ctx: CredentialsContext,
purpose: AppStoreApiKeyPurpose
): Promise<AppStoreConnectApiKeyFragment> {
if (ctx.nonInteractive) {
throw new Error(`A new App Store Connect Api Key cannot be created in non-interactive mode.`);
}
const ascApiKey = await provideOrGenerateAscApiKeyAsync(ctx, purpose);
const result = await ctx.ios.createAscApiKeyAsync(this.account, ascApiKey);
Log.succeed('Created App Store Connect Api Key');
return result;
}
}
@@ -10,7 +10,7 @@ export class CreateDistributionCertificate {
public async runAsync( public async runAsync(
ctx: CredentialsContext ctx: CredentialsContext
): Promise<AppleDistributionCertificateMutationResult> { ): Promise<AppleDistributionCertificateMutationResult> {
const distCert = await provideOrGenerateDistributionCertificateAsync(ctx); const distCert = await provideOrGenerateDistributionCertificateAsync(ctx, this.account.name);
const result = await ctx.ios.createDistributionCertificateAsync(this.account, distCert); const result = await ctx.ios.createDistributionCertificateAsync(this.account, distCert);
Log.succeed('Created distribution certificate'); Log.succeed('Created distribution certificate');
return result; return result;
@@ -12,7 +12,7 @@ export class CreatePushKey {
throw new Error(`A new push key cannot be created in non-interactive mode.`); throw new Error(`A new push key cannot be created in non-interactive mode.`);
} }
const pushKey = await provideOrGeneratePushKeyAsync(ctx); const pushKey = await provideOrGeneratePushKeyAsync(ctx, this.account.name);
const result = await ctx.ios.createPushKeyAsync(this.account, pushKey); const result = await ctx.ios.createPushKeyAsync(this.account, pushKey);
Log.succeed('Created push key'); Log.succeed('Created push key');
return result; return result;
@@ -152,14 +152,15 @@ Please remember that Apple Distribution Certificates are not application specifi
`; `;
export async function provideOrGenerateDistributionCertificateAsync( export async function provideOrGenerateDistributionCertificateAsync(
ctx: CredentialsContext ctx: CredentialsContext,
accountName: string
): Promise<DistributionCertificate> { ): Promise<DistributionCertificate> {
if (!ctx.nonInteractive) { if (!ctx.nonInteractive) {
const userProvided = await promptForDistCertAsync(ctx); const userProvided = await promptForDistCertAsync(ctx);
if (userProvided) { if (userProvided) {
if (!ctx.appStore.authCtx) { if (!ctx.appStore.authCtx) {
Log.warn( Log.warn(
'Unable to validate distribution certificate, you are not authenticated with Apple.' 'Unable to validate distribution certificate due to insufficient Apple Credentials'
); );
return userProvided; return userProvided;
} else { } else {
@@ -167,11 +168,13 @@ export async function provideOrGenerateDistributionCertificateAsync(
if (!isValid) { if (!isValid) {
Log.warn("Provided Distribution Certificate is no longer valid on Apple's server"); Log.warn("Provided Distribution Certificate is no longer valid on Apple's server");
} }
return isValid ? userProvided : await provideOrGenerateDistributionCertificateAsync(ctx); return isValid
? userProvided
: await provideOrGenerateDistributionCertificateAsync(ctx, accountName);
} }
} }
} }
return await generateDistributionCertificateAsync(ctx); return await generateDistributionCertificateAsync(ctx, accountName);
} }
async function promptForDistCertAsync( async function promptForDistCertAsync(
@@ -197,7 +200,8 @@ async function promptForDistCertAsync(
} }
async function generateDistributionCertificateAsync( async function generateDistributionCertificateAsync(
ctx: CredentialsContext ctx: CredentialsContext,
accountName: string
): Promise<DistributionCertificate> { ): Promise<DistributionCertificate> {
await ctx.appStore.ensureAuthenticatedAsync(); await ctx.appStore.ensureAuthenticatedAsync();
try { try {
@@ -242,7 +246,7 @@ async function generateDistributionCertificateAsync(
throw e; throw e;
} }
} }
return await generateDistributionCertificateAsync(ctx); return await generateDistributionCertificateAsync(ctx, accountName);
} }
function formatDistributionCertificateFromApple( function formatDistributionCertificateFromApple(
@@ -14,12 +14,15 @@ import { pushKeySchema } from '../credentials';
import { isPushKeyValidAndTrackedAsync } from '../validators/validatePushKey'; import { isPushKeyValidAndTrackedAsync } from '../validators/validatePushKey';
import { formatAppleTeam } from './AppleTeamUtils'; import { formatAppleTeam } from './AppleTeamUtils';
export async function provideOrGeneratePushKeyAsync(ctx: CredentialsContext): Promise<PushKey> { export async function provideOrGeneratePushKeyAsync(
ctx: CredentialsContext,
accountName: string
): Promise<PushKey> {
if (!ctx.nonInteractive) { if (!ctx.nonInteractive) {
const userProvided = await promptForPushKeyAsync(ctx); const userProvided = await promptForPushKeyAsync(ctx);
if (userProvided) { if (userProvided) {
if (!ctx.appStore.authCtx) { if (!ctx.appStore.authCtx) {
Log.warn('Unable to validate push key, you are not authenticated with Apple.'); Log.warn('Unable to validate push key due to insufficient Apple Credentials');
return userProvided; return userProvided;
} else { } else {
const isValidAndTracked = await isPushKeyValidAndTrackedAsync(ctx, userProvided); const isValidAndTracked = await isPushKeyValidAndTrackedAsync(ctx, userProvided);
@@ -33,11 +36,11 @@ export async function provideOrGeneratePushKeyAsync(ctx: CredentialsContext): Pr
if (useUserProvided) { if (useUserProvided) {
return userProvided; return userProvided;
} }
return await provideOrGeneratePushKeyAsync(ctx); return await provideOrGeneratePushKeyAsync(ctx, accountName);
} }
} }
} }
return await generatePushKeyAsync(ctx); return await generatePushKeyAsync(ctx, accountName);
} }
async function promptForPushKeyAsync(ctx: CredentialsContext): Promise<PushKey | null> { async function promptForPushKeyAsync(ctx: CredentialsContext): Promise<PushKey | null> {
@@ -60,7 +63,10 @@ async function promptForPushKeyAsync(ctx: CredentialsContext): Promise<PushKey |
return userProvided; return userProvided;
} }
async function generatePushKeyAsync(ctx: CredentialsContext): Promise<PushKey> { async function generatePushKeyAsync(
ctx: CredentialsContext,
accountName: string
): Promise<PushKey> {
await ctx.appStore.ensureAuthenticatedAsync(); await ctx.appStore.ensureAuthenticatedAsync();
try { try {
return await ctx.appStore.createPushKeyAsync(); return await ctx.appStore.createPushKeyAsync();
@@ -100,7 +106,7 @@ async function generatePushKeyAsync(ctx: CredentialsContext): Promise<PushKey> {
throw e; throw e;
} }
} }
return await generatePushKeyAsync(ctx); return await generatePushKeyAsync(ctx, accountName);
} }
function formatPushKeyFromApple(pushKey: PushKeyStoreInfo): string { function formatPushKeyFromApple(pushKey: PushKeyStoreInfo): string {
@@ -1,53 +0,0 @@
import { AppStoreConnectApiKeyFragment } from '../../../graphql/generated';
import Log from '../../../log';
import { confirmAsync } from '../../../prompts';
import { Account } from '../../../user/Account';
import { CredentialsContext } from '../../context';
import { selectAscApiKeysFromAccountAsync } from './AscApiKeyUtils';
export class SelectAndRemoveAscApiKey {
constructor(private account: Account) {}
async runAsync(ctx: CredentialsContext): Promise<void> {
const selected = await selectAscApiKeysFromAccountAsync(ctx, this.account);
if (selected) {
await new RemoveAscApiKey(this.account, selected).runAsync(ctx);
Log.succeed('Removed App Store Connect Api Key');
Log.newLine();
}
}
}
export class RemoveAscApiKey {
constructor(private account: Account, private ascApiKey: AppStoreConnectApiKeyFragment) {}
public async runAsync(ctx: CredentialsContext): Promise<void> {
if (ctx.nonInteractive) {
throw new Error(`Cannot remove App Store Connect Api Keys in non-interactive mode.`);
}
// TODO(quin): add an extra edge on AppStoreConnectApiKey to find the apps using it
const confirm = await confirmAsync({
message: `Deleting this Api Key may affect your projects that rely on it. Do you want to continue?`,
});
if (!confirm) {
Log.log('Aborting');
return;
}
Log.log('Removing Api Key');
await ctx.ios.deleteAscApiKeyAsync(this.ascApiKey.id);
let shouldRevoke = false;
if (!ctx.nonInteractive) {
shouldRevoke = await confirmAsync({
message: `Do you also want to revoke this Api Key on the Apple Developer Portal?`,
});
} else if (ctx.nonInteractive) {
Log.log('Skipping Api Key revocation on the Apple Developer Portal.');
}
if (shouldRevoke) {
await ctx.appStore.revokeAscApiKeyAsync(this.ascApiKey.keyIdentifier);
}
}
}
@@ -1,148 +0,0 @@
import assert from 'assert';
import nullthrows from 'nullthrows';
import {
AppStoreConnectApiKeyFragment,
CommonIosAppCredentialsFragment,
} from '../../../graphql/generated';
import Log from '../../../log';
import { confirmAsync, promptAsync } from '../../../prompts';
import { CredentialsContext } from '../../context';
import {
MissingCredentialsNonInteractiveError,
UnsupportedCredentialsChoiceError,
} from '../../errors';
import { AppLookupParams } from '../api/GraphqlClient';
import { getValidAndTrackedAscApiKeysAsync } from '../validators/validateAscApiKey';
import {
AppStoreApiKeyPurpose,
formatAscApiKey,
getAscApiKeysFromAccountAsync,
selectAscApiKeysFromAccountAsync,
sortAscApiKeysByUpdatedAtDesc,
} from './AscApiKeyUtils';
import { AssignAscApiKey } from './AssignAscApiKey';
import { CreateAscApiKey } from './CreateAscApiKey';
export enum SetupAscApiKeyChoice {
GENERATE = 'GENERATE',
USE_EXISTING = 'USE_EXISTING',
}
export class SetUpAscApiKey {
public choices: { title: string; value: string }[] = [
{
title: '[Choose an existing key]',
value: SetupAscApiKeyChoice.USE_EXISTING,
},
{ title: '[Add a new key]', value: SetupAscApiKeyChoice.GENERATE },
];
constructor(private app: AppLookupParams, private purpose: AppStoreApiKeyPurpose) {}
public async runAsync(ctx: CredentialsContext): Promise<CommonIosAppCredentialsFragment> {
const isKeySetup = await this.isAscApiKeySetupAsync(ctx, this.purpose);
if (isKeySetup) {
Log.succeed('App Store Connect Api Key already set up.');
return nullthrows(
await ctx.ios.getIosAppCredentialsWithCommonFieldsAsync(this.app),
'iosAppCredentials cannot be null if App Store Connect Api Key is already set up'
);
}
if (ctx.nonInteractive) {
throw new MissingCredentialsNonInteractiveError(
'App Store Connect Api Keys cannot be set up in --non-interactive mode.'
);
}
const keysForAccount = await getAscApiKeysFromAccountAsync(ctx, this.app.account, {
filterDifferentAppleTeam: true,
});
const maybeAutoselectedKey = await this.doBestEffortAutoselectAsync(ctx, keysForAccount);
if (maybeAutoselectedKey) {
return await new AssignAscApiKey(this.app).runAsync(ctx, maybeAutoselectedKey, this.purpose);
}
const availableChoices =
keysForAccount.length === 0
? this.choices.filter(choice => choice.value !== SetupAscApiKeyChoice.USE_EXISTING)
: this.choices;
const ascApiKey = await this.processChoicesAsync(ctx, this.purpose, availableChoices);
return await new AssignAscApiKey(this.app).runAsync(ctx, ascApiKey, this.purpose);
}
private async doBestEffortAutoselectAsync(
ctx: CredentialsContext,
keysForAccount: AppStoreConnectApiKeyFragment[]
): Promise<AppStoreConnectApiKeyFragment | null> {
if (!ctx.appStore.authCtx) {
return null;
}
if (keysForAccount.length === 0) {
return null;
}
// only provide autoselect if we can find a key that is certainly valid
const validKeys = await getValidAndTrackedAscApiKeysAsync(ctx, keysForAccount);
if (validKeys.length === 0) {
return null;
}
const [autoselectedKey] = sortAscApiKeysByUpdatedAtDesc(validKeys);
const useAutoselected = await confirmAsync({
message: `Reuse this App Store Connect Api Key?\n${formatAscApiKey(autoselectedKey)}`,
});
if (useAutoselected) {
Log.log(`Using App Store Connect Api Key with ID ${autoselectedKey.keyIdentifier}`);
return autoselectedKey;
} else {
return null;
}
}
private async isAscApiKeySetupAsync(
ctx: CredentialsContext,
purpose: AppStoreApiKeyPurpose
): Promise<boolean> {
const appCredentials = await ctx.ios.getIosAppCredentialsWithCommonFieldsAsync(this.app);
if (purpose !== AppStoreApiKeyPurpose.SUBMISSION_SERVICE) {
throw new Error(`App Store Connect Api Key setup is not yet supported for ${purpose}.`);
}
return !!appCredentials?.appStoreConnectApiKeyForSubmissions;
}
private async processChoicesAsync(
ctx: CredentialsContext,
purpose: AppStoreApiKeyPurpose,
choices: { title: string; value: string }[]
): Promise<AppStoreConnectApiKeyFragment> {
assert(choices.length > 0, 'SetupAscApiKey: There must be at least one choice');
let choice: string;
if (choices.length === 1) {
choice = choices[0].value;
} else {
const result = await promptAsync({
type: 'select',
name: 'choice',
message: 'Select the App Store Connect Api Key to use for your project:',
choices,
});
choice = result.choice;
}
if (choice === SetupAscApiKeyChoice.GENERATE) {
return await new CreateAscApiKey(this.app.account).runAsync(ctx, purpose);
} else if (choice === SetupAscApiKeyChoice.USE_EXISTING) {
const selectedAscApiKey = await selectAscApiKeysFromAccountAsync(ctx, this.app.account, {
filterDifferentAppleTeam: true,
});
if (!selectedAscApiKey) {
return await this.processChoicesAsync(ctx, purpose, choices);
}
return selectedAscApiKey;
}
throw new UnsupportedCredentialsChoiceError(
`AscApiKey Setup does not support choice:${choice}`,
choice
);
}
}
@@ -21,7 +21,7 @@ import { validateProvisioningProfileAsync } from '../validators/validateProvisio
import { resolveAppleTeamIfAuthenticatedAsync } from './AppleTeamUtils'; import { resolveAppleTeamIfAuthenticatedAsync } from './AppleTeamUtils';
import { assignBuildCredentialsAsync, getBuildCredentialsAsync } from './BuildCredentialsUtils'; import { assignBuildCredentialsAsync, getBuildCredentialsAsync } from './BuildCredentialsUtils';
import { chooseDevicesAsync, formatDeviceLabel } from './DeviceUtils'; import { chooseDevicesAsync, formatDeviceLabel } from './DeviceUtils';
import { SetUpDistributionCertificate } from './SetUpDistributionCertificate'; import { SetupDistributionCertificate } from './SetupDistributionCertificate';
enum ReuseAction { enum ReuseAction {
Yes, Yes,
@@ -29,11 +29,11 @@ enum ReuseAction {
No, No,
} }
export class SetUpAdhocProvisioningProfile { export class SetupAdhocProvisioningProfile {
constructor(private app: AppLookupParams) {} constructor(private app: AppLookupParams) {}
async runAsync(ctx: CredentialsContext): Promise<IosAppBuildCredentialsFragment> { async runAsync(ctx: CredentialsContext): Promise<IosAppBuildCredentialsFragment> {
const distCert = await new SetUpDistributionCertificate( const distCert = await new SetupDistributionCertificate(
this.app, this.app,
IosDistributionType.AdHoc IosDistributionType.AdHoc
).runAsync(ctx); ).runAsync(ctx);
@@ -7,7 +7,7 @@ import { CredentialsContext } from '../../context';
import { IosCapabilitiesOptions } from '../appstore/ensureAppExists'; import { IosCapabilitiesOptions } from '../appstore/ensureAppExists';
import { App, IosAppBuildCredentialsMap, IosCredentials, Target } from '../types'; import { App, IosAppBuildCredentialsMap, IosCredentials, Target } from '../types';
import { displayProjectCredentials } from '../utils/printCredentials'; import { displayProjectCredentials } from '../utils/printCredentials';
import { SetUpTargetBuildCredentials } from './SetUpTargetBuildCredentials'; import { SetupTargetBuildCredentials } from './SetupTargetBuildCredentials';
interface Options { interface Options {
app: App; app: App;
@@ -17,7 +17,7 @@ interface Options {
iosCapabilitiesOptions?: IosCapabilitiesOptions; iosCapabilitiesOptions?: IosCapabilitiesOptions;
} }
export class SetUpBuildCredentials { export class SetupBuildCredentials {
constructor(private options: Options) {} constructor(private options: Options) {}
async runAsync(ctx: CredentialsContext): Promise<IosCredentials> { async runAsync(ctx: CredentialsContext): Promise<IosCredentials> {
@@ -49,7 +49,7 @@ export class SetUpBuildCredentials {
} else { } else {
Log.newLine(); Log.newLine();
} }
const action = new SetUpTargetBuildCredentials({ const action = new SetupTargetBuildCredentials({
...this.options, ...this.options,
app: { app: {
...this.options.app, ...this.options.app,
@@ -8,9 +8,9 @@ import { readIosCredentialsAsync } from '../../credentialsJson/read';
import { IosCredentials } from '../../credentialsJson/types'; import { IosCredentials } from '../../credentialsJson/types';
import { ensureAllTargetsAreConfigured } from '../../credentialsJson/utils'; import { ensureAllTargetsAreConfigured } from '../../credentialsJson/utils';
import { App, Target } from '../types'; import { App, Target } from '../types';
import { SetUpTargetBuildCredentialsFromCredentialsJson } from './SetUpTargetBuildCredentialsFromCredentialsJson'; import { SetupTargetBuildCredentialsFromCredentialsJson } from './SetupTargetBuildCredentialsFromCredentialsJson';
export class SetUpBuildCredentialsFromCredentialsJson { export class SetupBuildCredentialsFromCredentialsJson {
constructor( constructor(
private app: App, private app: App,
private targets: Target[], private targets: Target[],
@@ -32,7 +32,7 @@ export class SetUpBuildCredentialsFromCredentialsJson {
); );
Log.newLine(); Log.newLine();
} }
await new SetUpTargetBuildCredentialsFromCredentialsJson( await new SetupTargetBuildCredentialsFromCredentialsJson(
{ {
account: this.app.account, account: this.app.account,
projectName: this.app.projectName, projectName: this.app.projectName,
@@ -18,7 +18,7 @@ import { resolveAppleTeamIfAuthenticatedAsync } from './AppleTeamUtils';
import { CreateDistributionCertificate } from './CreateDistributionCertificate'; import { CreateDistributionCertificate } from './CreateDistributionCertificate';
import { formatDistributionCertificate } from './DistributionCertificateUtils'; import { formatDistributionCertificate } from './DistributionCertificateUtils';
export class SetUpDistributionCertificate { export class SetupDistributionCertificate {
private validDistCerts?: AppleDistributionCertificateFragment[]; private validDistCerts?: AppleDistributionCertificateFragment[];
constructor(private app: AppLookupParams, private distributionType: IosDistributionType) {} constructor(private app: AppLookupParams, private distributionType: IosDistributionType) {}
@@ -4,8 +4,8 @@ import { promptAsync } from '../../../prompts';
import { CredentialsContext } from '../../context'; import { CredentialsContext } from '../../context';
import { AppLookupParams } from '../api/GraphqlClient'; import { AppLookupParams } from '../api/GraphqlClient';
import { getAllBuildCredentialsAsync } from './BuildCredentialsUtils'; import { getAllBuildCredentialsAsync } from './BuildCredentialsUtils';
import { SetUpAdhocProvisioningProfile } from './SetUpAdhocProvisioningProfile'; import { SetupAdhocProvisioningProfile } from './SetupAdhocProvisioningProfile';
import { SetUpProvisioningProfile } from './SetUpProvisioningProfile'; import { SetupProvisioningProfile } from './SetupProvisioningProfile';
/** /**
* It's used when setting up credentials for internal distribution but `enterpriseProvisioning` is not set. * It's used when setting up credentials for internal distribution but `enterpriseProvisioning` is not set.
@@ -14,7 +14,7 @@ import { SetUpProvisioningProfile } from './SetUpProvisioningProfile';
* to choose if they want to set up an adhoc or universal distribution provisioning profile. Otherwise, always * to choose if they want to set up an adhoc or universal distribution provisioning profile. Otherwise, always
* set up an adhoc provisioning profile. * set up an adhoc provisioning profile.
*/ */
export class SetUpInternalProvisioningProfile { export class SetupInternalProvisioningProfile {
constructor(private app: AppLookupParams) {} constructor(private app: AppLookupParams) {}
async runAsync(ctx: CredentialsContext): Promise<IosAppBuildCredentialsFragment> { async runAsync(ctx: CredentialsContext): Promise<IosAppBuildCredentialsFragment> {
@@ -82,13 +82,13 @@ export class SetUpInternalProvisioningProfile {
private async setupAdhocProvisioningProfileAsync( private async setupAdhocProvisioningProfileAsync(
ctx: CredentialsContext ctx: CredentialsContext
): Promise<IosAppBuildCredentialsFragment> { ): Promise<IosAppBuildCredentialsFragment> {
return await new SetUpAdhocProvisioningProfile(this.app).runAsync(ctx); return await new SetupAdhocProvisioningProfile(this.app).runAsync(ctx);
} }
private async setupUniversalProvisioningProfileAsync( private async setupUniversalProvisioningProfileAsync(
ctx: CredentialsContext ctx: CredentialsContext
): Promise<IosAppBuildCredentialsFragment> { ): Promise<IosAppBuildCredentialsFragment> {
return await new SetUpProvisioningProfile(this.app, IosDistributionType.Enterprise).runAsync( return await new SetupProvisioningProfile(this.app, IosDistributionType.Enterprise).runAsync(
ctx ctx
); );
} }
@@ -20,12 +20,12 @@ import {
import { ConfigureProvisioningProfile } from './ConfigureProvisioningProfile'; import { ConfigureProvisioningProfile } from './ConfigureProvisioningProfile';
import { CreateProvisioningProfile } from './CreateProvisioningProfile'; import { CreateProvisioningProfile } from './CreateProvisioningProfile';
import { formatProvisioningProfileFromApple } from './ProvisioningProfileUtils'; import { formatProvisioningProfileFromApple } from './ProvisioningProfileUtils';
import { SetUpDistributionCertificate } from './SetUpDistributionCertificate'; import { SetupDistributionCertificate } from './SetupDistributionCertificate';
/** /**
* Sets up either APP_STORE or ENTERPRISE provisioning profiles * Sets up either APP_STORE or ENTERPRISE provisioning profiles
*/ */
export class SetUpProvisioningProfile { export class SetupProvisioningProfile {
constructor(private app: AppLookupParams, private distributionType: IosDistributionType) {} constructor(private app: AppLookupParams, private distributionType: IosDistributionType) {}
async areBuildCredentialsSetupAsync(ctx: CredentialsContext): Promise<boolean> { async areBuildCredentialsSetupAsync(ctx: CredentialsContext): Promise<boolean> {
@@ -84,7 +84,7 @@ export class SetUpProvisioningProfile {
} }
async runAsync(ctx: CredentialsContext): Promise<IosAppBuildCredentialsFragment> { async runAsync(ctx: CredentialsContext): Promise<IosAppBuildCredentialsFragment> {
const distCert = await new SetUpDistributionCertificate( const distCert = await new SetupDistributionCertificate(
this.app, this.app,
this.distributionType this.distributionType
).runAsync(ctx); ).runAsync(ctx);
@@ -14,7 +14,7 @@ import {
selectPushKeyAsync, selectPushKeyAsync,
} from './PushKeyUtils'; } from './PushKeyUtils';
export class SetUpPushKey { export class SetupPushKey {
constructor(private app: AppLookupParams) {} constructor(private app: AppLookupParams) {}
async isPushKeySetupAsync(ctx: CredentialsContext): Promise<boolean> { async isPushKeySetupAsync(ctx: CredentialsContext): Promise<boolean> {
@@ -8,9 +8,9 @@ import Log from '../../../log';
import { CredentialsContext } from '../../context'; import { CredentialsContext } from '../../context';
import { AppLookupParams as GraphQLAppLookupParams } from '../api/GraphqlClient'; import { AppLookupParams as GraphQLAppLookupParams } from '../api/GraphqlClient';
import { IosCapabilitiesOptions } from '../appstore/ensureAppExists'; import { IosCapabilitiesOptions } from '../appstore/ensureAppExists';
import { SetUpAdhocProvisioningProfile } from './SetUpAdhocProvisioningProfile'; import { SetupAdhocProvisioningProfile } from './SetupAdhocProvisioningProfile';
import { SetUpInternalProvisioningProfile } from './SetUpInternalProvisioningProfile'; import { SetupInternalProvisioningProfile } from './SetupInternalProvisioningProfile';
import { SetUpProvisioningProfile } from './SetUpProvisioningProfile'; import { SetupProvisioningProfile } from './SetupProvisioningProfile';
interface Options { interface Options {
app: GraphQLAppLookupParams; app: GraphQLAppLookupParams;
@@ -18,7 +18,7 @@ interface Options {
enterpriseProvisioning?: IosEnterpriseProvisioning; enterpriseProvisioning?: IosEnterpriseProvisioning;
iosCapabilitiesOptions?: IosCapabilitiesOptions; iosCapabilitiesOptions?: IosCapabilitiesOptions;
} }
export class SetUpTargetBuildCredentials { export class SetupTargetBuildCredentials {
constructor(private options: Options) {} constructor(private options: Options) {}
async runAsync(ctx: CredentialsContext): Promise<IosAppBuildCredentialsFragment> { async runAsync(ctx: CredentialsContext): Promise<IosAppBuildCredentialsFragment> {
@@ -39,7 +39,7 @@ export class SetUpTargetBuildCredentials {
try { try {
return await this.setupBuildCredentialsAsync(ctx); return await this.setupBuildCredentialsAsync(ctx);
} catch (error) { } catch (error) {
Log.error('Failed to set up credentials.'); Log.error('Failed to setup credentials.');
throw error; throw error;
} }
} }
@@ -50,17 +50,17 @@ export class SetUpTargetBuildCredentials {
const { app, distribution, enterpriseProvisioning } = this.options; const { app, distribution, enterpriseProvisioning } = this.options;
if (distribution === 'internal') { if (distribution === 'internal') {
if (enterpriseProvisioning === 'adhoc') { if (enterpriseProvisioning === 'adhoc') {
return await new SetUpAdhocProvisioningProfile(app).runAsync(ctx); return await new SetupAdhocProvisioningProfile(app).runAsync(ctx);
} else if (enterpriseProvisioning === 'universal') { } else if (enterpriseProvisioning === 'universal') {
return await new SetUpProvisioningProfile( return await new SetupProvisioningProfile(
app, app,
GraphQLIosDistributionType.Enterprise GraphQLIosDistributionType.Enterprise
).runAsync(ctx); ).runAsync(ctx);
} else { } else {
return await new SetUpInternalProvisioningProfile(app).runAsync(ctx); return await new SetupInternalProvisioningProfile(app).runAsync(ctx);
} }
} else { } else {
return await new SetUpProvisioningProfile(app, GraphQLIosDistributionType.AppStore).runAsync( return await new SetupProvisioningProfile(app, GraphQLIosDistributionType.AppStore).runAsync(
ctx ctx
); );
} }
@@ -22,7 +22,7 @@ import {
getProvisioningProfileAsync, getProvisioningProfileAsync,
} from './BuildCredentialsUtils'; } from './BuildCredentialsUtils';
export class SetUpTargetBuildCredentialsFromCredentialsJson { export class SetupTargetBuildCredentialsFromCredentialsJson {
constructor( constructor(
private app: AppLookupParams, private app: AppLookupParams,
private distributionType: IosDistributionType, private distributionType: IosDistributionType,
@@ -5,7 +5,7 @@ import {
import { testDistCertFragmentOneDependency } from '../../../__tests__/fixtures-ios'; import { testDistCertFragmentOneDependency } from '../../../__tests__/fixtures-ios';
import { CredentialsContext } from '../../../context'; import { CredentialsContext } from '../../../context';
import { AppLookupParams } from '../../api/GraphqlClient'; import { AppLookupParams } from '../../api/GraphqlClient';
export class SetUpDistributionCertificate { export class SetupDistributionCertificate {
constructor(private app: AppLookupParams, private distributionType: IosDistributionType) {} constructor(private app: AppLookupParams, private distributionType: IosDistributionType) {}
public async runAsync(_ctx: CredentialsContext): Promise<AppleDistributionCertificateFragment> { public async runAsync(_ctx: CredentialsContext): Promise<AppleDistributionCertificateFragment> {
@@ -1,90 +0,0 @@
import { asMock } from '../../../../__tests__/utils';
import { promptAsync } from '../../../../prompts';
import { getAppstoreMock, testAuthCtx } from '../../../__tests__/fixtures-appstore';
import { createCtxMock } from '../../../__tests__/fixtures-context';
import { testAscApiKey } from '../../../__tests__/fixtures-ios';
import { getCredentialsFromUserAsync } from '../../../utils/promptForCredentials';
import {
AppStoreApiKeyPurpose,
getAscApiKeyName,
promptForAscApiKeyPathAsync,
} from '../AscApiKeyUtils';
jest.mock('../../../../prompts');
jest.mock('../../../utils/promptForCredentials');
function enumKeys<O extends object, K extends keyof O = keyof O>(obj: O): K[] {
return Object.keys(obj) as K[];
}
afterEach(() => {
asMock(promptAsync).mockClear();
asMock(getCredentialsFromUserAsync).mockClear();
});
describe(getAscApiKeyName, () => {
// Apple enforces a 30 char limit on this name
it('produces a name under 30 chars', async () => {
for (const value of enumKeys(AppStoreApiKeyPurpose)) {
const purpose = AppStoreApiKeyPurpose[value];
const name = getAscApiKeyName(purpose);
expect(name.length < 30).toBe(true);
}
});
});
describe(promptForAscApiKeyPathAsync, () => {
it('prompts for keyId, keyP8Path and issuerId when user is not authenticated to Apple', async () => {
asMock(promptAsync).mockImplementationOnce(() => ({
keyP8Path: '/asc-api-key.p8',
}));
asMock(getCredentialsFromUserAsync).mockImplementation(() => ({
keyId: 'test-key-id',
issuerId: 'test-issuer-id',
}));
const ctx = createCtxMock({
nonInteractive: false,
appStore: {
...getAppstoreMock(),
ensureAuthenticatedAsync: jest.fn(() => {
throw new Error('this should not be called');
}),
authCtx: null,
},
});
const ascApiKeyPath = await promptForAscApiKeyPathAsync(ctx);
expect(ascApiKeyPath).toEqual({
keyId: 'test-key-id',
issuerId: 'test-issuer-id',
keyP8Path: '/asc-api-key.p8',
});
expect(promptAsync).toHaveBeenCalledTimes(1); // keyP8Path
expect(getCredentialsFromUserAsync).toHaveBeenCalledTimes(2); // keyId, issuerId
});
it('prompts for keyId, keyP8Path and detects issuerId when user is authenticated to Apple', async () => {
asMock(promptAsync).mockImplementationOnce(() => ({
keyP8Path: '/asc-api-key.p8',
}));
asMock(getCredentialsFromUserAsync).mockImplementation(() => ({
keyId: 'test-key-id',
}));
const ctx = createCtxMock({
nonInteractive: false,
appStore: {
...getAppstoreMock(),
ensureAuthenticatedAsync: jest.fn(() => testAuthCtx),
authCtx: testAuthCtx,
getAscApiKeyAsync: jest.fn(() => testAscApiKey),
},
});
const ascApiKeyPath = await promptForAscApiKeyPathAsync(ctx);
expect(ascApiKeyPath).toEqual({
keyId: 'test-key-id',
issuerId: 'test-issuer-id-from-apple',
keyP8Path: '/asc-api-key.p8',
});
expect(promptAsync).toHaveBeenCalledTimes(1); // keyP8Path
expect(getCredentialsFromUserAsync).toHaveBeenCalledTimes(1); // keyId
expect(asMock(ctx.appStore.getAscApiKeyAsync).mock.calls.length).toBe(1); // issuerId
});
});
@@ -1,46 +0,0 @@
import { findApplicationTarget } from '../../../../project/ios/target';
import { createCtxMock } from '../../../__tests__/fixtures-context';
import { testAscApiKeyFragment, testTargets } from '../../../__tests__/fixtures-ios';
import { AppStoreApiKeyPurpose } from '../AscApiKeyUtils';
import { AssignAscApiKey } from '../AssignAscApiKey';
import { getAppLookupParamsFromContext } from '../BuildCredentialsUtils';
describe(AssignAscApiKey, () => {
it('assigns an App Store Connect Api Key in Interactive Mode for EAS Submit', async () => {
const ctx = createCtxMock({
nonInteractive: false,
});
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const assignAscApiKeyAction = new AssignAscApiKey(appLookupParams);
await assignAscApiKeyAction.runAsync(
ctx,
testAscApiKeyFragment,
AppStoreApiKeyPurpose.SUBMISSION_SERVICE
);
// expect app credentials to be fetched/created, then updated
expect(ctx.ios.createOrGetIosAppCredentialsWithCommonFieldsAsync).toHaveBeenCalledTimes(1);
expect(ctx.ios.updateIosAppCredentialsAsync).toHaveBeenCalledTimes(1);
});
it('works in Non-Interactive Mode', async () => {
const ctx = createCtxMock({
nonInteractive: true,
});
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const assignAscApiKeyAction = new AssignAscApiKey(appLookupParams);
await assignAscApiKeyAction.runAsync(
ctx,
testAscApiKeyFragment,
AppStoreApiKeyPurpose.SUBMISSION_SERVICE
);
// dont fail if users are running in non-interactive mode
await expect(
assignAscApiKeyAction.runAsync(
ctx,
testAscApiKeyFragment,
AppStoreApiKeyPurpose.SUBMISSION_SERVICE
)
).resolves.not.toThrowError();
});
});
@@ -1,44 +0,0 @@
import { asMock } from '../../../../__tests__/utils';
import { findApplicationTarget } from '../../../../project/ios/target';
import { confirmAsync } from '../../../../prompts';
import { getAppstoreMock, testAuthCtx } from '../../../__tests__/fixtures-appstore';
import { createCtxMock } from '../../../__tests__/fixtures-context';
import { testAscApiKey, testTargets } from '../../../__tests__/fixtures-ios';
import { AppStoreApiKeyPurpose } from '../AscApiKeyUtils';
import { getAppLookupParamsFromContext } from '../BuildCredentialsUtils';
import { CreateAscApiKey } from '../CreateAscApiKey';
jest.mock('../../../../prompts');
asMock(confirmAsync).mockImplementation(() => true);
describe(CreateAscApiKey, () => {
it('creates a App Store Api Key in Interactive Mode', async () => {
const ctx = createCtxMock({
nonInteractive: false,
appStore: {
...getAppstoreMock(),
ensureAuthenticatedAsync: jest.fn(() => testAuthCtx),
authCtx: testAuthCtx,
createAscApiKeyAsync: jest.fn(() => testAscApiKey),
},
});
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const createAscApiKeyAction = new CreateAscApiKey(appLookupParams.account);
await createAscApiKeyAction.runAsync(ctx, AppStoreApiKeyPurpose.SUBMISSION_SERVICE);
// expect api key to be created on expo servers
expect(asMock(ctx.ios.createAscApiKeyAsync).mock.calls.length).toBe(1);
// expect api key to be created on apple portal
expect(asMock(ctx.appStore.createAscApiKeyAsync).mock.calls.length).toBe(1);
});
it('errors in Non Interactive Mode', async () => {
const ctx = createCtxMock({
nonInteractive: true,
});
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const createAscApiKeyAction = new CreateAscApiKey(appLookupParams.account);
await expect(
createAscApiKeyAction.runAsync(ctx, AppStoreApiKeyPurpose.SUBMISSION_SERVICE)
).rejects.toThrowError();
});
});
@@ -1,33 +0,0 @@
import { asMock } from '../../../../__tests__/utils';
import { findApplicationTarget } from '../../../../project/ios/target';
import { confirmAsync } from '../../../../prompts';
import { createCtxMock } from '../../../__tests__/fixtures-context';
import { testAscApiKeyFragment, testTargets } from '../../../__tests__/fixtures-ios';
import { getAppLookupParamsFromContext } from '../BuildCredentialsUtils';
import { RemoveAscApiKey } from '../RemoveAscApiKey';
jest.mock('../../../../prompts');
asMock(confirmAsync).mockImplementation(() => true);
describe(RemoveAscApiKey, () => {
it('removes an Asc Api Key', async () => {
const ctx = createCtxMock({ nonInteractive: false });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const removeAscApiKeyAction = new RemoveAscApiKey(
appLookupParams.account,
testAscApiKeyFragment
);
await removeAscApiKeyAction.runAsync(ctx);
expect(ctx.ios.deleteAscApiKeyAsync).toHaveBeenCalledTimes(1);
expect(ctx.appStore.revokeAscApiKeyAsync).toHaveBeenCalledTimes(1);
});
it('errors in Non-Interactive Mode', async () => {
const ctx = createCtxMock({ nonInteractive: true });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const removeAscApiKeyAction = new RemoveAscApiKey(
appLookupParams.account,
testAscApiKeyFragment
);
await expect(removeAscApiKeyAction.runAsync(ctx)).rejects.toThrowError();
});
});
@@ -1,146 +0,0 @@
import { asMock } from '../../../../__tests__/utils';
import { findApplicationTarget } from '../../../../project/ios/target';
import { confirmAsync, promptAsync } from '../../../../prompts';
import { getAppstoreMock, testAuthCtx } from '../../../__tests__/fixtures-appstore';
import { createCtxMock } from '../../../__tests__/fixtures-context';
import {
getNewIosApiMock,
testAscApiKey,
testAscApiKeyFragment,
testCommonIosAppCredentialsFragment,
testTargets,
} from '../../../__tests__/fixtures-ios';
import { AppStoreApiKeyPurpose } from '../AscApiKeyUtils';
import { getAppLookupParamsFromContext } from '../BuildCredentialsUtils';
import { SetUpAscApiKey, SetupAscApiKeyChoice } from '../SetUpAscApiKey';
jest.mock('../../../../prompts');
asMock(confirmAsync).mockImplementation(() => true);
describe(SetUpAscApiKey, () => {
it('skips setting up a ASC Api Key if it is already configured', async () => {
const ctx = createCtxMock({
nonInteractive: false,
ios: {
...getNewIosApiMock(),
getIosAppCredentialsWithCommonFieldsAsync: jest.fn(
() => testCommonIosAppCredentialsFragment
),
},
});
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupAscApiKeyAction = new SetUpAscApiKey(
appLookupParams,
AppStoreApiKeyPurpose.SUBMISSION_SERVICE
);
await setupAscApiKeyAction.runAsync(ctx);
// expect not to create a new ASC Api Key on expo servers
expect(asMock(ctx.ios.createAscApiKeyAsync).mock.calls.length).toBe(0);
// expect configuration not to be updated with a new ASC Api Key
expect(asMock(ctx.ios.updateIosAppCredentialsAsync).mock.calls.length).toBe(0);
});
it('sets up a ASC Api Key, creating a new one if there are no existing ASC Api Keys', async () => {
const ctx = createCtxMock({
nonInteractive: false,
appStore: {
...getAppstoreMock(),
createAscApiKeyAsync: jest.fn(() => testAscApiKey),
},
ios: {
...getNewIosApiMock(),
getIosAppCredentialsWithCommonFieldsAsync: jest.fn(),
createAscApiKeyAsync: jest.fn(() => testAscApiKeyFragment),
},
});
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupAscApiKeyAction = new SetUpAscApiKey(
appLookupParams,
AppStoreApiKeyPurpose.SUBMISSION_SERVICE
);
await setupAscApiKeyAction.runAsync(ctx);
// expect to create a new ASC Api Key on expo servers
expect(asMock(ctx.ios.createAscApiKeyAsync).mock.calls.length).toBe(1);
// expect configuration to be updated with a new ASC Api Key
expect(asMock(ctx.ios.updateIosAppCredentialsAsync).mock.calls.length).toBe(1);
});
it('sets up a ASC Api Key, use autoselected ASC Api Key when there are existing keys', async () => {
const ctx = createCtxMock({
nonInteractive: false,
appStore: {
...getAppstoreMock(),
ensureAuthenticatedAsync: jest.fn(() => testAuthCtx),
authCtx: testAuthCtx,
listAscApiKeysAsync: jest.fn(() => [testAscApiKey]),
},
ios: {
...getNewIosApiMock(),
getAscApiKeysForAccountAsync: jest.fn(() => [testAscApiKeyFragment]),
},
});
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupAscApiKeyAction = new SetUpAscApiKey(
appLookupParams,
AppStoreApiKeyPurpose.SUBMISSION_SERVICE
);
await setupAscApiKeyAction.runAsync(ctx);
// expect not to create a new ASC Api Key on expo servers, we are using the existing one
expect(asMock(ctx.ios.createAscApiKeyAsync).mock.calls.length).toBe(0);
// expect configuration to be updated with a new ASC Api Key
expect(asMock(ctx.ios.updateIosAppCredentialsAsync).mock.calls.length).toBe(1);
});
it('sets up a ASC Api Key, allowing user to choose existing keys', async () => {
const ctx = createCtxMock({
nonInteractive: false,
ios: {
...getNewIosApiMock(),
getAscApiKeysForAccountAsync: jest.fn(() => [testAscApiKeyFragment]),
},
});
asMock(promptAsync).mockImplementation(() => ({
choice: SetupAscApiKeyChoice.USE_EXISTING,
chosenAscApiKey: testAscApiKeyFragment,
}));
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupAscApiKeyAction = new SetUpAscApiKey(
appLookupParams,
AppStoreApiKeyPurpose.SUBMISSION_SERVICE
);
await setupAscApiKeyAction.runAsync(ctx);
// expect not to create a new ASC Api Key on expo servers, we are using the existing one
expect(asMock(ctx.ios.createAscApiKeyAsync).mock.calls.length).toBe(0);
// expect configuration to be updated with a new ASC Api Key
expect(asMock(ctx.ios.updateIosAppCredentialsAsync).mock.calls.length).toBe(1);
});
it('works in Non Interactive Mode if ASC Key is configured', async () => {
const ctx = createCtxMock({
nonInteractive: true,
ios: {
...getNewIosApiMock(),
getIosAppCredentialsWithCommonFieldsAsync: jest.fn(
() => testCommonIosAppCredentialsFragment
),
},
});
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupAscApiKeyAction = new SetUpAscApiKey(
appLookupParams,
AppStoreApiKeyPurpose.SUBMISSION_SERVICE
);
await expect(setupAscApiKeyAction.runAsync(ctx)).resolves.not.toThrowError();
});
it('errors in Non Interactive Mode', async () => {
const ctx = createCtxMock({
nonInteractive: true,
});
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const createAscApiKeyAction = new SetUpAscApiKey(
appLookupParams,
AppStoreApiKeyPurpose.SUBMISSION_SERVICE
);
await expect(createAscApiKeyAction.runAsync(ctx)).rejects.toThrowError();
});
});
@@ -1,4 +1,4 @@
import { doUDIDsMatch } from '../SetUpAdhocProvisioningProfile'; import { doUDIDsMatch } from '../SetupAdhocProvisioningProfile';
describe(doUDIDsMatch, () => { describe(doUDIDsMatch, () => {
it('return false if UDIDs do not match', () => { it('return false if UDIDs do not match', () => {
@@ -4,13 +4,13 @@ import { promptAsync } from '../../../../prompts';
import { getAppstoreMock, testAuthCtx } from '../../../__tests__/fixtures-appstore'; import { getAppstoreMock, testAuthCtx } from '../../../__tests__/fixtures-appstore';
import { createCtxMock } from '../../../__tests__/fixtures-context'; import { createCtxMock } from '../../../__tests__/fixtures-context';
import { getAllBuildCredentialsAsync } from '../BuildCredentialsUtils'; import { getAllBuildCredentialsAsync } from '../BuildCredentialsUtils';
import { SetUpAdhocProvisioningProfile } from '../SetUpAdhocProvisioningProfile'; import { SetupAdhocProvisioningProfile } from '../SetupAdhocProvisioningProfile';
import { SetUpInternalProvisioningProfile } from '../SetUpInternalProvisioningProfile'; import { SetupInternalProvisioningProfile } from '../SetupInternalProvisioningProfile';
import { SetUpProvisioningProfile } from '../SetUpProvisioningProfile'; import { SetupProvisioningProfile } from '../SetupProvisioningProfile';
jest.mock('../../../../prompts'); jest.mock('../../../../prompts');
jest.mock('../SetUpAdhocProvisioningProfile'); jest.mock('../SetupAdhocProvisioningProfile');
jest.mock('../SetUpProvisioningProfile'); jest.mock('../SetupProvisioningProfile');
jest.mock('../BuildCredentialsUtils', () => ({ getAllBuildCredentialsAsync: jest.fn() })); jest.mock('../BuildCredentialsUtils', () => ({ getAllBuildCredentialsAsync: jest.fn() }));
beforeEach(() => { beforeEach(() => {
@@ -33,15 +33,15 @@ const testEnterpriseBuildCredentials: IosAppBuildCredentialsFragment = {
iosDistributionType: IosDistributionType.Enterprise, iosDistributionType: IosDistributionType.Enterprise,
}; };
describe(SetUpInternalProvisioningProfile, () => { describe(SetupInternalProvisioningProfile, () => {
describe('interactive mode', () => { describe('interactive mode', () => {
describe('when authenticated with apple', () => { describe('when authenticated with apple', () => {
it('runs the SetUpAdhocProvisioningProfile action for non-enterprise team', async () => { it('runs the SetupAdhocProvisioningProfile action for non-enterprise team', async () => {
asMock(getAllBuildCredentialsAsync).mockImplementationOnce(() => { asMock(getAllBuildCredentialsAsync).mockImplementationOnce(() => {
const buildCredentials: IosAppBuildCredentialsFragment[] = []; const buildCredentials: IosAppBuildCredentialsFragment[] = [];
return buildCredentials; return buildCredentials;
}); });
const action = new SetUpInternalProvisioningProfile({ const action = new SetupInternalProvisioningProfile({
account: { id: 'account-id', name: 'account-name' }, account: { id: 'account-id', name: 'account-name' },
bundleIdentifier: 'com.expo.test', bundleIdentifier: 'com.expo.test',
projectName: 'testproject', projectName: 'testproject',
@@ -56,7 +56,7 @@ describe(SetUpInternalProvisioningProfile, () => {
}); });
const runAsync = jest.fn(); const runAsync = jest.fn();
SetUpAdhocProvisioningProfile.prototype.runAsync = runAsync; SetupAdhocProvisioningProfile.prototype.runAsync = runAsync;
await action.runAsync(ctx); await action.runAsync(ctx);
@@ -72,7 +72,7 @@ describe(SetUpInternalProvisioningProfile, () => {
return buildCredentials; return buildCredentials;
}); });
const action = new SetUpInternalProvisioningProfile({ const action = new SetupInternalProvisioningProfile({
account: { id: 'account-id', name: 'account-name' }, account: { id: 'account-id', name: 'account-name' },
bundleIdentifier: 'com.expo.test', bundleIdentifier: 'com.expo.test',
projectName: 'testproject', projectName: 'testproject',
@@ -90,7 +90,7 @@ describe(SetUpInternalProvisioningProfile, () => {
}); });
const runAsync = jest.fn(); const runAsync = jest.fn();
SetUpProvisioningProfile.prototype.runAsync = runAsync; SetupProvisioningProfile.prototype.runAsync = runAsync;
await action.runAsync(ctx); await action.runAsync(ctx);
@@ -110,7 +110,7 @@ describe(SetUpInternalProvisioningProfile, () => {
return buildCredentials; return buildCredentials;
}); });
const action = new SetUpInternalProvisioningProfile({ const action = new SetupInternalProvisioningProfile({
account: { id: 'account-id', name: 'account-name' }, account: { id: 'account-id', name: 'account-name' },
bundleIdentifier: 'com.expo.test', bundleIdentifier: 'com.expo.test',
projectName: 'testproject', projectName: 'testproject',
@@ -125,14 +125,14 @@ describe(SetUpInternalProvisioningProfile, () => {
}); });
const runAsync = jest.fn(); const runAsync = jest.fn();
SetUpProvisioningProfile.prototype.runAsync = runAsync; SetupProvisioningProfile.prototype.runAsync = runAsync;
await action.runAsync(ctx); await action.runAsync(ctx);
expect(runAsync).toHaveBeenCalled(); expect(runAsync).toHaveBeenCalled();
}); });
it('runs the SetUpAdhocProvisioningProfile action when adhoc credentials exist', async () => { it('runs the SetupAdhocProvisioningProfile action when adhoc credentials exist', async () => {
asMock(promptAsync).mockImplementationOnce(() => ({ asMock(promptAsync).mockImplementationOnce(() => ({
distributionType: IosDistributionType.Enterprise, distributionType: IosDistributionType.Enterprise,
})); }));
@@ -141,7 +141,7 @@ describe(SetUpInternalProvisioningProfile, () => {
return buildCredentials; return buildCredentials;
}); });
const action = new SetUpInternalProvisioningProfile({ const action = new SetupInternalProvisioningProfile({
account: { id: 'account-id', name: 'account-name' }, account: { id: 'account-id', name: 'account-name' },
bundleIdentifier: 'com.expo.test', bundleIdentifier: 'com.expo.test',
projectName: 'testproject', projectName: 'testproject',
@@ -156,14 +156,14 @@ describe(SetUpInternalProvisioningProfile, () => {
}); });
const runAsync = jest.fn(); const runAsync = jest.fn();
SetUpAdhocProvisioningProfile.prototype.runAsync = runAsync; SetupAdhocProvisioningProfile.prototype.runAsync = runAsync;
await action.runAsync(ctx); await action.runAsync(ctx);
expect(runAsync).toHaveBeenCalled(); expect(runAsync).toHaveBeenCalled();
}); });
it('runs the SetUpProvisioningProfile action when enterprise credentials exist', async () => { it('runs the SetupProvisioningProfile action when enterprise credentials exist', async () => {
asMock(promptAsync).mockImplementationOnce(() => ({ asMock(promptAsync).mockImplementationOnce(() => ({
distributionType: IosDistributionType.Enterprise, distributionType: IosDistributionType.Enterprise,
})); }));
@@ -174,7 +174,7 @@ describe(SetUpInternalProvisioningProfile, () => {
return buildCredentials; return buildCredentials;
}); });
const action = new SetUpInternalProvisioningProfile({ const action = new SetupInternalProvisioningProfile({
account: { id: 'account-id', name: 'account-name' }, account: { id: 'account-id', name: 'account-name' },
bundleIdentifier: 'com.expo.test', bundleIdentifier: 'com.expo.test',
projectName: 'testproject', projectName: 'testproject',
@@ -189,7 +189,7 @@ describe(SetUpInternalProvisioningProfile, () => {
}); });
const runAsync = jest.fn(); const runAsync = jest.fn();
SetUpProvisioningProfile.prototype.runAsync = runAsync; SetupProvisioningProfile.prototype.runAsync = runAsync;
await action.runAsync(ctx); await action.runAsync(ctx);
@@ -205,7 +205,7 @@ describe(SetUpInternalProvisioningProfile, () => {
return buildCredentials; return buildCredentials;
}); });
const action = new SetUpInternalProvisioningProfile({ const action = new SetupInternalProvisioningProfile({
account: { id: 'account-id', name: 'account-name' }, account: { id: 'account-id', name: 'account-name' },
bundleIdentifier: 'com.expo.test', bundleIdentifier: 'com.expo.test',
projectName: 'testproject', projectName: 'testproject',
@@ -235,7 +235,7 @@ describe(SetUpInternalProvisioningProfile, () => {
]; ];
return buildCredentials; return buildCredentials;
}); });
const action = new SetUpInternalProvisioningProfile({ const action = new SetupInternalProvisioningProfile({
account: { id: 'account-id', name: 'account-name' }, account: { id: 'account-id', name: 'account-name' },
bundleIdentifier: 'com.expo.test', bundleIdentifier: 'com.expo.test',
projectName: 'testproject', projectName: 'testproject',
@@ -253,7 +253,7 @@ describe(SetUpInternalProvisioningProfile, () => {
const buildCredentials: IosAppBuildCredentialsFragment[] = []; const buildCredentials: IosAppBuildCredentialsFragment[] = [];
return buildCredentials; return buildCredentials;
}); });
const action = new SetUpInternalProvisioningProfile({ const action = new SetupInternalProvisioningProfile({
account: { id: 'account-id', name: 'account-name' }, account: { id: 'account-id', name: 'account-name' },
bundleIdentifier: 'com.expo.test', bundleIdentifier: 'com.expo.test',
projectName: 'testproject', projectName: 'testproject',
@@ -264,12 +264,12 @@ describe(SetUpInternalProvisioningProfile, () => {
await expect(action.runAsync(ctx)).rejects.toThrow(/couldn't find any credentials/); await expect(action.runAsync(ctx)).rejects.toThrow(/couldn't find any credentials/);
}); });
it('runs the SetUpAdhocProvisioningProfile action when adhoc credentials exist', async () => { it('runs the SetupAdhocProvisioningProfile action when adhoc credentials exist', async () => {
asMock(getAllBuildCredentialsAsync).mockImplementationOnce(() => { asMock(getAllBuildCredentialsAsync).mockImplementationOnce(() => {
const buildCredentials: IosAppBuildCredentialsFragment[] = [testAdhocBuildCredentials]; const buildCredentials: IosAppBuildCredentialsFragment[] = [testAdhocBuildCredentials];
return buildCredentials; return buildCredentials;
}); });
const action = new SetUpInternalProvisioningProfile({ const action = new SetupInternalProvisioningProfile({
account: { id: 'account-id', name: 'account-name' }, account: { id: 'account-id', name: 'account-name' },
bundleIdentifier: 'com.expo.test', bundleIdentifier: 'com.expo.test',
projectName: 'testproject', projectName: 'testproject',
@@ -279,19 +279,19 @@ describe(SetUpInternalProvisioningProfile, () => {
}); });
const runAsync = jest.fn(); const runAsync = jest.fn();
SetUpAdhocProvisioningProfile.prototype.runAsync = runAsync; SetupAdhocProvisioningProfile.prototype.runAsync = runAsync;
await action.runAsync(ctx); await action.runAsync(ctx);
expect(runAsync).toHaveBeenCalled(); expect(runAsync).toHaveBeenCalled();
}); });
it('runs the SetUpProvisioningProfile action when enterprise credentials exist', async () => { it('runs the SetupProvisioningProfile action when enterprise credentials exist', async () => {
asMock(getAllBuildCredentialsAsync).mockImplementationOnce(() => { asMock(getAllBuildCredentialsAsync).mockImplementationOnce(() => {
const buildCredentials: IosAppBuildCredentialsFragment[] = [testEnterpriseBuildCredentials]; const buildCredentials: IosAppBuildCredentialsFragment[] = [testEnterpriseBuildCredentials];
return buildCredentials; return buildCredentials;
}); });
const action = new SetUpInternalProvisioningProfile({ const action = new SetupInternalProvisioningProfile({
account: { id: 'account-id', name: 'account-name' }, account: { id: 'account-id', name: 'account-name' },
bundleIdentifier: 'com.expo.test', bundleIdentifier: 'com.expo.test',
projectName: 'testproject', projectName: 'testproject',
@@ -301,7 +301,7 @@ describe(SetUpInternalProvisioningProfile, () => {
}); });
const runAsync = jest.fn(); const runAsync = jest.fn();
SetUpProvisioningProfile.prototype.runAsync = runAsync; SetupProvisioningProfile.prototype.runAsync = runAsync;
await action.runAsync(ctx); await action.runAsync(ctx);
@@ -16,16 +16,16 @@ import {
import { MissingCredentialsNonInteractiveError } from '../../../errors'; import { MissingCredentialsNonInteractiveError } from '../../../errors';
import { validateProvisioningProfileAsync } from '../../validators/validateProvisioningProfile'; import { validateProvisioningProfileAsync } from '../../validators/validateProvisioningProfile';
import { getAppLookupParamsFromContext } from '../BuildCredentialsUtils'; import { getAppLookupParamsFromContext } from '../BuildCredentialsUtils';
import { SetUpProvisioningProfile } from '../SetUpProvisioningProfile'; import { SetupProvisioningProfile } from '../SetupProvisioningProfile';
jest.mock('../../../../prompts'); jest.mock('../../../../prompts');
asMock(confirmAsync).mockImplementation(() => true); asMock(confirmAsync).mockImplementation(() => true);
jest.mock('../SetUpDistributionCertificate'); jest.mock('../SetupDistributionCertificate');
jest.mock('../ConfigureProvisioningProfile'); jest.mock('../ConfigureProvisioningProfile');
jest.mock('../CreateProvisioningProfile'); jest.mock('../CreateProvisioningProfile');
jest.mock('../../validators/validateProvisioningProfile'); jest.mock('../../validators/validateProvisioningProfile');
describe('SetUpProvisioningProfile', () => { describe('SetupProvisioningProfile', () => {
it('repairs existing Provisioning Profile with bad build credentials in Interactive Mode', async () => { it('repairs existing Provisioning Profile with bad build credentials in Interactive Mode', async () => {
asMock(validateProvisioningProfileAsync).mockImplementation(() => false); asMock(validateProvisioningProfileAsync).mockImplementation(() => false);
const ctx = createCtxMock({ const ctx = createCtxMock({
@@ -54,7 +54,7 @@ describe('SetUpProvisioningProfile', () => {
}, },
}); });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets)); const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupProvisioningProfileAction = new SetUpProvisioningProfile( const setupProvisioningProfileAction = new SetupProvisioningProfile(
appLookupParams, appLookupParams,
IosDistributionType.AppStore IosDistributionType.AppStore
); );
@@ -84,7 +84,7 @@ describe('SetUpProvisioningProfile', () => {
}, },
}); });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets)); const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupProvisioningProfileAction = new SetUpProvisioningProfile( const setupProvisioningProfileAction = new SetupProvisioningProfile(
appLookupParams, appLookupParams,
IosDistributionType.AppStore IosDistributionType.AppStore
); );
@@ -114,7 +114,7 @@ describe('SetUpProvisioningProfile', () => {
}, },
}); });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets)); const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupProvisioningProfileAction = new SetUpProvisioningProfile( const setupProvisioningProfileAction = new SetupProvisioningProfile(
appLookupParams, appLookupParams,
IosDistributionType.AppStore IosDistributionType.AppStore
); );
@@ -140,7 +140,7 @@ describe('SetUpProvisioningProfile', () => {
}, },
}); });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets)); const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupProvisioningProfileAction = new SetUpProvisioningProfile( const setupProvisioningProfileAction = new SetupProvisioningProfile(
appLookupParams, appLookupParams,
IosDistributionType.AppStore IosDistributionType.AppStore
); );
@@ -157,7 +157,7 @@ describe('SetUpProvisioningProfile', () => {
nonInteractive: true, nonInteractive: true,
}); });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets)); const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupProvisioningProfileAction = new SetUpProvisioningProfile( const setupProvisioningProfileAction = new SetupProvisioningProfile(
appLookupParams, appLookupParams,
IosDistributionType.AppStore IosDistributionType.AppStore
); );
@@ -5,12 +5,12 @@ import { getAppstoreMock, testAuthCtx } from '../../../__tests__/fixtures-appsto
import { createCtxMock } from '../../../__tests__/fixtures-context'; import { createCtxMock } from '../../../__tests__/fixtures-context';
import { getNewIosApiMock, testPushKey, testTargets } from '../../../__tests__/fixtures-ios'; import { getNewIosApiMock, testPushKey, testTargets } from '../../../__tests__/fixtures-ios';
import { getAppLookupParamsFromContext } from '../BuildCredentialsUtils'; import { getAppLookupParamsFromContext } from '../BuildCredentialsUtils';
import { SetUpPushKey } from '../SetUpPushKey'; import { SetupPushKey } from '../SetupPushKey';
jest.mock('../../../../prompts'); jest.mock('../../../../prompts');
asMock(confirmAsync).mockImplementation(() => true); asMock(confirmAsync).mockImplementation(() => true);
describe(SetUpPushKey, () => { describe(SetupPushKey, () => {
it('skips setting up a Push Key if it is already configured', async () => { it('skips setting up a Push Key if it is already configured', async () => {
const ctx = createCtxMock({ const ctx = createCtxMock({
nonInteractive: false, nonInteractive: false,
@@ -20,7 +20,7 @@ describe(SetUpPushKey, () => {
}, },
}); });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets)); const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupPushKeyAction = new SetUpPushKey(appLookupParams); const setupPushKeyAction = new SetupPushKey(appLookupParams);
await setupPushKeyAction.runAsync(ctx); await setupPushKeyAction.runAsync(ctx);
// expect not to create a new push key on expo servers // expect not to create a new push key on expo servers
@@ -38,7 +38,7 @@ describe(SetUpPushKey, () => {
}, },
}); });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets)); const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupPushKeyAction = new SetUpPushKey(appLookupParams); const setupPushKeyAction = new SetupPushKey(appLookupParams);
await setupPushKeyAction.runAsync(ctx); await setupPushKeyAction.runAsync(ctx);
// expect to create a new push key on expo servers // expect to create a new push key on expo servers
@@ -62,7 +62,7 @@ describe(SetUpPushKey, () => {
}, },
}); });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets)); const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupPushKeyAction = new SetUpPushKey(appLookupParams); const setupPushKeyAction = new SetupPushKey(appLookupParams);
await setupPushKeyAction.runAsync(ctx); await setupPushKeyAction.runAsync(ctx);
// expect not to create a new push key on expo servers, we are using the existing one // expect not to create a new push key on expo servers, we are using the existing one
@@ -75,7 +75,7 @@ describe(SetUpPushKey, () => {
nonInteractive: true, nonInteractive: true,
}); });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets)); const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const createPushKeyAction = new SetUpPushKey(appLookupParams); const createPushKeyAction = new SetupPushKey(appLookupParams);
await expect(createPushKeyAction.runAsync(ctx)).rejects.toThrowError(); await expect(createPushKeyAction.runAsync(ctx)).rejects.toThrowError();
}); });
}); });
@@ -15,7 +15,7 @@ import {
} from '../../../__tests__/fixtures-ios'; } from '../../../__tests__/fixtures-ios';
import { IosTargetCredentials } from '../../../credentialsJson/types'; import { IosTargetCredentials } from '../../../credentialsJson/types';
import { getAppLookupParamsFromContext } from '../BuildCredentialsUtils'; import { getAppLookupParamsFromContext } from '../BuildCredentialsUtils';
import { SetUpTargetBuildCredentialsFromCredentialsJson } from '../SetUpTargetBuildCredentialsFromCredentialsJson'; import { SetupTargetBuildCredentialsFromCredentialsJson } from '../SetupTargetBuildCredentialsFromCredentialsJson';
jest.mock('../../../../prompts'); jest.mock('../../../../prompts');
jest.mock('../../../credentialsJson/read'); jest.mock('../../../credentialsJson/read');
@@ -25,7 +25,7 @@ beforeEach(() => {
asMock(confirmAsync).mockImplementation(() => true); asMock(confirmAsync).mockImplementation(() => true);
}); });
describe('SetUpTargetBuildCredentialsFromCredentialsJson', () => { describe('SetupTargetBuildCredentialsFromCredentialsJson', () => {
const targetCredentials: IosTargetCredentials = { const targetCredentials: IosTargetCredentials = {
distributionCertificate: { distributionCertificate: {
certificateP12: testDistCert.certP12, certificateP12: testDistCert.certP12,
@@ -53,7 +53,7 @@ describe('SetUpTargetBuildCredentialsFromCredentialsJson', () => {
}); });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets)); const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupBuildCredentialsFromCredentialsJsonAction = const setupBuildCredentialsFromCredentialsJsonAction =
new SetUpTargetBuildCredentialsFromCredentialsJson( new SetupTargetBuildCredentialsFromCredentialsJson(
appLookupParams, appLookupParams,
IosDistributionType.AppStore, IosDistributionType.AppStore,
targetCredentials targetCredentials
@@ -82,7 +82,7 @@ describe('SetUpTargetBuildCredentialsFromCredentialsJson', () => {
}); });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets)); const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupBuildCredentialsFromCredentialsJsonAction = const setupBuildCredentialsFromCredentialsJsonAction =
new SetUpTargetBuildCredentialsFromCredentialsJson( new SetupTargetBuildCredentialsFromCredentialsJson(
appLookupParams, appLookupParams,
IosDistributionType.AppStore, IosDistributionType.AppStore,
targetCredentials targetCredentials
@@ -115,7 +115,7 @@ describe('SetUpTargetBuildCredentialsFromCredentialsJson', () => {
}); });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets)); const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupBuildCredentialsFromCredentialsJsonAction = const setupBuildCredentialsFromCredentialsJsonAction =
new SetUpTargetBuildCredentialsFromCredentialsJson( new SetupTargetBuildCredentialsFromCredentialsJson(
appLookupParams, appLookupParams,
IosDistributionType.AppStore, IosDistributionType.AppStore,
targetCredentials targetCredentials
@@ -149,7 +149,7 @@ describe('SetUpTargetBuildCredentialsFromCredentialsJson', () => {
}); });
const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets)); const appLookupParams = getAppLookupParamsFromContext(ctx, findApplicationTarget(testTargets));
const setupBuildCredentialsFromCredentialsJsonAction = const setupBuildCredentialsFromCredentialsJsonAction =
new SetUpTargetBuildCredentialsFromCredentialsJson( new SetupTargetBuildCredentialsFromCredentialsJson(
appLookupParams, appLookupParams,
IosDistributionType.AppStore, IosDistributionType.AppStore,
targetCredentials targetCredentials
@@ -1,10 +1,7 @@
import { UserRole } from '@expo/apple-utils';
import nullthrows from 'nullthrows'; import nullthrows from 'nullthrows';
import { import {
AppFragment, AppFragment,
AppStoreConnectApiKeyFragment,
AppStoreConnectUserRole,
AppleAppIdentifierFragment, AppleAppIdentifierFragment,
AppleDeviceFragment, AppleDeviceFragment,
AppleDistributionCertificateFragment, AppleDistributionCertificateFragment,
@@ -17,9 +14,7 @@ import {
import { isWildcardBundleIdentifier } from '../../../project/ios/bundleIdentifier'; import { isWildcardBundleIdentifier } from '../../../project/ios/bundleIdentifier';
import { Account } from '../../../user/Account'; import { Account } from '../../../user/Account';
import { DistributionCertificate, PushKey } from '../appstore/Credentials.types'; import { DistributionCertificate, PushKey } from '../appstore/Credentials.types';
import { MinimalAscApiKey } from '../credentials';
import { AppleTeamMissingError } from '../errors'; import { AppleTeamMissingError } from '../errors';
import { AppStoreConnectApiKeyMutation } from './graphql/mutations/AppStoreConnectApiKeyMutation';
import { AppleAppIdentifierMutation } from './graphql/mutations/AppleAppIdentifierMutation'; import { AppleAppIdentifierMutation } from './graphql/mutations/AppleAppIdentifierMutation';
import { import {
AppleDistributionCertificateMutation, AppleDistributionCertificateMutation,
@@ -34,7 +29,6 @@ import { AppleTeamMutation } from './graphql/mutations/AppleTeamMutation';
import { IosAppBuildCredentialsMutation } from './graphql/mutations/IosAppBuildCredentialsMutation'; import { IosAppBuildCredentialsMutation } from './graphql/mutations/IosAppBuildCredentialsMutation';
import { IosAppCredentialsMutation } from './graphql/mutations/IosAppCredentialsMutation'; import { IosAppCredentialsMutation } from './graphql/mutations/IosAppCredentialsMutation';
import { AppQuery } from './graphql/queries/AppQuery'; import { AppQuery } from './graphql/queries/AppQuery';
import { AppStoreConnectApiKeyQuery } from './graphql/queries/AppStoreConnectApiKeyQuery';
import { AppleAppIdentifierQuery } from './graphql/queries/AppleAppIdentifierQuery'; import { AppleAppIdentifierQuery } from './graphql/queries/AppleAppIdentifierQuery';
import { AppleDeviceQuery } from './graphql/queries/AppleDeviceQuery'; import { AppleDeviceQuery } from './graphql/queries/AppleDeviceQuery';
import { AppleDistributionCertificateQuery } from './graphql/queries/AppleDistributionCertificateQuery'; import { AppleDistributionCertificateQuery } from './graphql/queries/AppleDistributionCertificateQuery';
@@ -167,10 +161,8 @@ export async function updateIosAppCredentialsAsync(
appCredentials: CommonIosAppCredentialsFragment, appCredentials: CommonIosAppCredentialsFragment,
{ {
applePushKeyId, applePushKeyId,
ascApiKeyIdForSubmissions,
}: { }: {
applePushKeyId?: string; applePushKeyId?: string;
ascApiKeyIdForSubmissions?: string;
} }
): Promise<CommonIosAppCredentialsFragment> { ): Promise<CommonIosAppCredentialsFragment> {
let updatedAppCredentials = appCredentials; let updatedAppCredentials = appCredentials;
@@ -180,13 +172,6 @@ export async function updateIosAppCredentialsAsync(
applePushKeyId applePushKeyId
); );
} }
if (ascApiKeyIdForSubmissions) {
updatedAppCredentials =
await IosAppCredentialsMutation.setAppStoreConnectApiKeyForSubmissionsAsync(
updatedAppCredentials.id,
ascApiKeyIdForSubmissions
);
}
return updatedAppCredentials; return updatedAppCredentials;
} }
@@ -428,78 +413,5 @@ export async function deletePushKeyAsync(pushKeyId: string): Promise<void> {
return await ApplePushKeyMutation.deleteApplePushKeyAsync(pushKeyId); return await ApplePushKeyMutation.deleteApplePushKeyAsync(pushKeyId);
} }
export async function createAscApiKeyAsync(
account: Account,
ascApiKey: MinimalAscApiKey
): Promise<AppStoreConnectApiKeyFragment> {
const maybeAppleTeam = ascApiKey.teamId
? await createOrGetExistingAppleTeamAsync(account, {
appleTeamIdentifier: ascApiKey.teamId,
appleTeamName: ascApiKey.teamName,
})
: null;
return await AppStoreConnectApiKeyMutation.createAppStoreConnectApiKeyAsync(
{
issuerIdentifier: ascApiKey.issuerId,
keyIdentifier: ascApiKey.keyId,
keyP8: ascApiKey.keyP8,
name: ascApiKey.name ?? null,
roles: ascApiKey.roles?.map(role => convertUserRoleToGraphqlType(role)) ?? null,
appleTeamId: maybeAppleTeam ? maybeAppleTeam.id : null,
},
account.id
);
}
export async function getAscApiKeysForAccountAsync(
account: Account
): Promise<AppStoreConnectApiKeyFragment[]> {
return await AppStoreConnectApiKeyQuery.getAllForAccountAsync(account.name);
}
export async function getAscApiKeyForAppSubmissionsAsync(
appLookupParams: AppLookupParams
): Promise<AppStoreConnectApiKeyFragment | null> {
const maybeIosAppCredentials = await getIosAppCredentialsWithCommonFieldsAsync(appLookupParams);
return maybeIosAppCredentials?.appStoreConnectApiKeyForSubmissions ?? null;
}
export async function deleteAscApiKeyAsync(ascApiKeyId: string): Promise<void> {
return await AppStoreConnectApiKeyMutation.deleteAppStoreConnectApiKeyAsync(ascApiKeyId);
}
function convertUserRoleToGraphqlType(userRole: UserRole): AppStoreConnectUserRole {
switch (userRole) {
case UserRole.ADMIN:
return AppStoreConnectUserRole.Admin;
case UserRole.ACCESS_TO_REPORTS:
return AppStoreConnectUserRole.AccessToReports;
case UserRole.ACCOUNT_HOLDER:
return AppStoreConnectUserRole.AccountHolder;
case UserRole.APP_MANAGER:
return AppStoreConnectUserRole.AppManager;
case UserRole.CLOUD_MANAGED_APP_DISTRIBUTION:
return AppStoreConnectUserRole.CloudManagedAppDistribution;
case UserRole.CLOUD_MANAGED_DEVELOPER_ID:
return AppStoreConnectUserRole.CloudManagedDeveloperId;
case UserRole.CREATE_APPS:
return AppStoreConnectUserRole.CreateApps;
case UserRole.CUSTOMER_SUPPORT:
return AppStoreConnectUserRole.CustomerSupport;
case UserRole.DEVELOPER:
return AppStoreConnectUserRole.Developer;
case UserRole.FINANCE:
return AppStoreConnectUserRole.Finance;
case UserRole.MARKETING:
return AppStoreConnectUserRole.Marketing;
case UserRole.READ_ONLY:
return AppStoreConnectUserRole.ReadOnly;
case UserRole.SALES:
return AppStoreConnectUserRole.Sales;
case UserRole.TECHNICAL:
return AppStoreConnectUserRole.Technical;
}
}
const formatProjectFullName = ({ account, projectName }: AppLookupParams): string => const formatProjectFullName = ({ account, projectName }: AppLookupParams): string =>
`@${account.name}/${projectName}`; `@${account.name}/${projectName}`;
@@ -1,75 +0,0 @@
import assert from 'assert';
import { print } from 'graphql';
import gql from 'graphql-tag';
import { graphqlClient, withErrorHandlingAsync } from '../../../../../graphql/client';
import {
AppStoreConnectApiKeyFragment,
AppStoreConnectApiKeyInput,
CreateAppStoreConnectApiKeyMutation,
DeleteAppStoreConnectApiKeyMutation,
} from '../../../../../graphql/generated';
import { AppStoreConnectApiKeyFragmentNode } from '../../../../../graphql/types/credentials/AppStoreConnectApiKey';
export const AppStoreConnectApiKeyMutation = {
async createAppStoreConnectApiKeyAsync(
appStoreConnectApiKeyInput: AppStoreConnectApiKeyInput,
accountId: string
): Promise<AppStoreConnectApiKeyFragment> {
const data = await withErrorHandlingAsync(
graphqlClient
.mutation<CreateAppStoreConnectApiKeyMutation>(
gql`
mutation CreateAppStoreConnectApiKeyMutation(
$appStoreConnectApiKeyInput: AppStoreConnectApiKeyInput!
$accountId: ID!
) {
appStoreConnectApiKey {
createAppStoreConnectApiKey(
appStoreConnectApiKeyInput: $appStoreConnectApiKeyInput
accountId: $accountId
) {
id
...AppStoreConnectApiKeyFragment
}
}
}
${print(AppStoreConnectApiKeyFragmentNode)}
`,
{
appStoreConnectApiKeyInput,
accountId,
}
)
.toPromise()
);
assert(
data.appStoreConnectApiKey.createAppStoreConnectApiKey,
'GraphQL: `createAppStoreConnectApiKey` not defined in server response'
);
return data.appStoreConnectApiKey.createAppStoreConnectApiKey;
},
async deleteAppStoreConnectApiKeyAsync(appStoreConnectApiKeyId: string): Promise<void> {
await withErrorHandlingAsync(
graphqlClient
.mutation<DeleteAppStoreConnectApiKeyMutation>(
gql`
mutation DeleteAppStoreConnectApiKeyMutation($appStoreConnectApiKeyId: ID!) {
appStoreConnectApiKey {
deleteAppStoreConnectApiKey(id: $appStoreConnectApiKeyId) {
id
}
}
}
`,
{
appStoreConnectApiKeyId,
},
{
additionalTypenames: ['AppStoreConnectApiKey', 'IosAppCredentials'],
}
)
.toPromise()
);
},
};
@@ -7,7 +7,6 @@ import {
CommonIosAppCredentialsFragment, CommonIosAppCredentialsFragment,
CreateIosAppCredentialsMutation, CreateIosAppCredentialsMutation,
IosAppCredentialsInput, IosAppCredentialsInput,
SetAppStoreConnectApiKeyForSubmissionsMutation,
SetPushKeyMutation, SetPushKeyMutation,
} from '../../../../../graphql/generated'; } from '../../../../../graphql/generated';
import { CommonIosAppCredentialsFragmentNode } from '../../../../../graphql/types/credentials/IosAppCredentials'; import { CommonIosAppCredentialsFragmentNode } from '../../../../../graphql/types/credentials/IosAppCredentials';
@@ -81,37 +80,4 @@ export const IosAppCredentialsMutation = {
); );
return data.iosAppCredentials.setPushKey; return data.iosAppCredentials.setPushKey;
}, },
async setAppStoreConnectApiKeyForSubmissionsAsync(
iosAppCredentialsId: string,
ascApiKeyId: string
): Promise<CommonIosAppCredentialsFragment> {
const data = await withErrorHandlingAsync(
graphqlClient
.mutation<SetAppStoreConnectApiKeyForSubmissionsMutation>(
gql`
mutation SetAppStoreConnectApiKeyForSubmissionsMutation(
$iosAppCredentialsId: ID!
$ascApiKeyId: ID!
) {
iosAppCredentials {
setAppStoreConnectApiKeyForSubmissions(
id: $iosAppCredentialsId
ascApiKeyId: $ascApiKeyId
) {
id
...CommonIosAppCredentialsFragment
}
}
}
${print(CommonIosAppCredentialsFragmentNode)}
`,
{
iosAppCredentialsId,
ascApiKeyId,
}
)
.toPromise()
);
return data.iosAppCredentials.setAppStoreConnectApiKeyForSubmissions;
},
}; };
@@ -22,10 +22,7 @@ export const AppQuery = {
} }
${print(AppFragmentNode)} ${print(AppFragmentNode)}
`, `,
{ fullName }, { fullName }
{
additionalTypenames: ['App'],
}
) )
.toPromise() .toPromise()
); );
@@ -1,41 +0,0 @@
import { print } from 'graphql';
import gql from 'graphql-tag';
import { graphqlClient, withErrorHandlingAsync } from '../../../../../graphql/client';
import {
AppStoreConnectApiKeyByAccountQuery,
AppStoreConnectApiKeyFragment,
} from '../../../../../graphql/generated';
import { AppStoreConnectApiKeyFragmentNode } from '../../../../../graphql/types/credentials/AppStoreConnectApiKey';
export const AppStoreConnectApiKeyQuery = {
async getAllForAccountAsync(accountName: string): Promise<AppStoreConnectApiKeyFragment[]> {
const data = await withErrorHandlingAsync(
graphqlClient
.query<AppStoreConnectApiKeyByAccountQuery>(
gql`
query AppStoreConnectApiKeyByAccountQuery($accountName: String!) {
account {
byName(accountName: $accountName) {
id
appStoreConnectApiKeys {
id
...AppStoreConnectApiKeyFragment
}
}
}
}
${print(AppStoreConnectApiKeyFragmentNode)}
`,
{
accountName,
},
{
additionalTypenames: ['AppStoreConnectApiKey'],
}
)
.toPromise()
);
return data.account.byName.appStoreConnectApiKeys;
},
};
@@ -111,10 +111,7 @@ export const AppleDeviceQuery = {
} }
} }
`, `,
{ accountName, appleTeamIdentifier }, { accountName, appleTeamIdentifier }
{
additionalTypenames: ['AppleDevice', 'AppleTeam'],
}
) )
.toPromise() .toPromise()
); );
@@ -150,10 +147,7 @@ export const AppleDeviceQuery = {
} }
} }
`, `,
{ accountName, identifier }, { accountName, identifier }
{
additionalTypenames: ['AppleDevice', 'AppleTeam'],
}
) )
.toPromise() .toPromise()
); );
@@ -60,11 +60,7 @@ export const AppleDistributionCertificateQuery = {
iosDistributionType, iosDistributionType,
}, },
{ {
additionalTypenames: [ additionalTypenames: ['IosAppCredentials', 'IosAppBuildCredentials'],
'AppleDistributionCertificate',
'IosAppCredentials',
'IosAppBuildCredentials',
],
} }
) )
.toPromise() .toPromise()
@@ -97,9 +93,6 @@ export const AppleDistributionCertificateQuery = {
`, `,
{ {
accountName, accountName,
},
{
additionalTypenames: ['AppleDistributionCertificate'],
} }
) )
.toPromise() .toPromise()
@@ -77,11 +77,7 @@ export const AppleProvisioningProfileQuery = {
iosDistributionType, iosDistributionType,
}, },
{ {
additionalTypenames: [ additionalTypenames: ['IosAppCredentials', 'IosAppBuildCredentials'],
'AppleProvisioningProfile',
'IosAppCredentials',
'IosAppBuildCredentials',
],
} }
) )
.toPromise() .toPromise()
@@ -26,9 +26,6 @@ export const ApplePushKeyQuery = {
`, `,
{ {
accountName, accountName,
},
{
additionalTypenames: ['ApplePushKey'],
} }
) )
.toPromise() .toPromise()
@@ -28,10 +28,7 @@ export const AppleTeamQuery = {
} }
} }
`, `,
{ accountName }, { accountName }
{
additionalTypenames: ['AppleTeam'],
}
) )
.toPromise() .toPromise()
); );
@@ -60,9 +57,6 @@ export const AppleTeamQuery = {
{ {
accountId, accountId,
appleTeamIdentifier, appleTeamIdentifier,
},
{
additionalTypenames: ['AppleTeam'],
} }
) )
.toPromise() .toPromise()
@@ -30,21 +30,6 @@ export const IosAppCredentialsQuery = {
}, },
__typename: 'ApplePushKey', __typename: 'ApplePushKey',
}, },
appStoreConnectApiKeyForSubmissions: {
id: 'b8fe2225-3024-4ebe-9e36-7b9022d3b13e',
appleTeam: {
id: 'ca27f9f6-c7cb-40d1-8c41-c168e8548261',
appleTeamIdentifier: '77KQ969CHE',
appleTeamName: null,
__typename: 'AppleTeam',
},
issuerIdentifier: '69a6de93-e4e4-47e3-e053-5b8c7c11a4d1',
keyIdentifier: 'NYN468XNN3',
name: 'Expo Submissions pl94k8_lnS',
roles: ['ADMIN'],
updatedAt: '2020-10-13T18:39:04.463Z',
__typename: 'AppStoreConnectApiKey',
},
iosAppBuildCredentialsList: [ iosAppBuildCredentialsList: [
{ {
id: '6f8d0175-0caf-4922-b09b-eae757b83144', id: '6f8d0175-0caf-4922-b09b-eae757b83144',
@@ -1,6 +1,4 @@
import { import {
AscApiKey,
AscApiKeyInfo,
DistributionCertificate, DistributionCertificate,
DistributionCertificateStoreInfo, DistributionCertificateStoreInfo,
ProvisioningProfile, ProvisioningProfile,
@@ -8,12 +6,6 @@ import {
PushKey, PushKey,
PushKeyStoreInfo, PushKeyStoreInfo,
} from './Credentials.types'; } from './Credentials.types';
import {
createAscApiKeyAsync,
getAscApiKeyAsync,
listAscApiKeysAsync,
revokeAscApiKeyAsync,
} from './ascApiKey';
import { AuthCtx, Options as AuthenticateOptions, authenticateAsync } from './authenticate'; import { AuthCtx, Options as AuthenticateOptions, authenticateAsync } from './authenticate';
import { import {
createDistributionCertificateAsync, createDistributionCertificateAsync,
@@ -144,24 +136,4 @@ export default class AppStoreApi {
distCertSerialNumber distCertSerialNumber
); );
} }
public async listAscApiKeysAsync(): Promise<AscApiKeyInfo[]> {
const ctx = await this.ensureAuthenticatedAsync();
return await listAscApiKeysAsync(ctx);
}
public async getAscApiKeyAsync(keyId: string): Promise<AscApiKeyInfo | null> {
const ctx = await this.ensureAuthenticatedAsync();
return await getAscApiKeyAsync(ctx, keyId);
}
public async createAscApiKeyAsync({ nickname }: { nickname: string }): Promise<AscApiKey> {
const ctx = await this.ensureAuthenticatedAsync();
return await createAscApiKeyAsync(ctx, { nickname });
}
public async revokeAscApiKeyAsync(keyId: string): Promise<AscApiKeyInfo> {
const ctx = await this.ensureAuthenticatedAsync();
return await revokeAscApiKeyAsync(ctx, keyId);
}
} }
@@ -1,5 +1,3 @@
import { UserRole } from '@expo/apple-utils';
export interface Device { export interface Device {
id: string; id: string;
teamId: string; teamId: string;
@@ -68,17 +66,3 @@ export interface PushKey {
teamId: string; teamId: string;
teamName?: string; teamName?: string;
} }
export type AscApiKeyInfo = {
keyId: string;
issuerId?: string;
teamId: string;
name: string;
teamName?: string;
roles: UserRole[];
isRevoked: boolean;
};
export type AscApiKey = AscApiKeyInfo & {
keyP8: string;
};
@@ -1,99 +0,0 @@
import { ApiKey, ApiKeyType, UserRole } from '@expo/apple-utils';
import { asMock } from '../../../../__tests__/utils';
import {
createAscApiKeyAsync,
getAscApiKeyAsync,
listAscApiKeysAsync,
revokeAscApiKeyAsync,
} from '../ascApiKey';
import { getRequestContext } from '../authenticate';
jest.mock('@expo/apple-utils');
jest.mock('../authenticate');
jest.mock('../../../../ora');
const mockTeam = {
id: 'test-id',
name: 'test-name',
};
const mockAuthCtx = {
appleId: 'test-appleId',
team: mockTeam,
};
const mockApiKey = {
type: 'apiKeys',
id: 'NL67AN9Q6Q',
attributes: {
nickname: 'ejb-apple-utils-admin',
lastUsed: '2021-06-28T12:30:41-07:00',
revokingDate: null,
isActive: true,
canDownload: false,
privateKey: null,
roles: ['ADMIN'],
allAppsVisible: true,
keyType: 'PUBLIC_API',
},
downloadAsync: jest.fn(() => 'super secret'),
revokeAsync: jest.fn(() => mockApiKey),
} as unknown as ApiKey;
const mockAscApiKeyInfo = {
issuerId: undefined,
keyId: 'NL67AN9Q6Q',
name: 'ejb-apple-utils-admin',
roles: ['ADMIN'],
teamId: 'test-id',
teamName: 'test-name',
isRevoked: false,
};
beforeEach(() => {
jest.clearAllMocks();
});
test(`listAscApiKeysAsync`, async () => {
const mockRequestContext = {};
jest.spyOn(ApiKey, 'getAsync').mockImplementation(async () => []);
asMock(getRequestContext).mockImplementation(() => mockRequestContext);
const result = await listAscApiKeysAsync(mockAuthCtx);
expect(ApiKey.getAsync).toHaveBeenLastCalledWith(mockRequestContext);
expect(result).toEqual([]);
});
test(`getAscApiKeyAsync`, async () => {
const mockRequestContext = {};
jest.spyOn(ApiKey, 'infoAsync').mockImplementation(async () => mockApiKey);
asMock(getRequestContext).mockImplementation(() => mockRequestContext);
const result = await getAscApiKeyAsync(mockAuthCtx, 'test-key-id');
expect(ApiKey.infoAsync).toHaveBeenLastCalledWith(mockRequestContext, { id: 'test-key-id' });
expect(result).toEqual(mockAscApiKeyInfo);
});
test(`createAscApiKeyAsync`, async () => {
const mockRequestContext = {};
jest.spyOn(ApiKey, 'createAsync').mockImplementation(async () => mockApiKey);
asMock(getRequestContext).mockImplementation(() => mockRequestContext);
const result = await createAscApiKeyAsync(mockAuthCtx, { nickname: 'test-name' });
expect(ApiKey.createAsync).toHaveBeenLastCalledWith(mockRequestContext, {
nickname: 'test-name',
allAppsVisible: true,
roles: [UserRole.ADMIN],
keyType: ApiKeyType.PUBLIC_API,
});
expect(result).toEqual({ ...mockAscApiKeyInfo, keyP8: 'super secret' });
});
test(`revokeAscApiKeyAsync`, async () => {
const mockRequestContext = {};
jest.spyOn(ApiKey, 'infoAsync').mockImplementation(async () => mockApiKey);
asMock(getRequestContext).mockImplementation(() => mockRequestContext);
const result = await revokeAscApiKeyAsync(mockAuthCtx, 'test-key-id');
expect(ApiKey.infoAsync).toHaveBeenLastCalledWith(mockRequestContext, {
id: 'test-key-id',
});
expect(mockApiKey.revokeAsync).toBeCalled();
expect(result).toEqual(mockAscApiKeyInfo);
});
@@ -1,116 +0,0 @@
import { ApiKey, ApiKeyProps, ApiKeyType, UserRole } from '@expo/apple-utils';
import Log from '../../../log';
import { ora } from '../../../ora';
import { AscApiKey, AscApiKeyInfo } from './Credentials.types';
import { AuthCtx, getRequestContext } from './authenticate';
export async function listAscApiKeysAsync(authCtx: AuthCtx): Promise<AscApiKeyInfo[]> {
const spinner = ora(`Fetching App Store Connect Api Keys.`).start();
try {
const context = getRequestContext(authCtx);
const keys = await ApiKey.getAsync(context);
spinner.succeed(`Fetched App Store Connect Api Keys.`);
return keys.map(key => getAscApiKeyInfo(key, authCtx));
} catch (error) {
spinner.fail(`Failed to fetch App Store Connect Api Keys.`);
throw error;
}
}
export async function getAscApiKeyAsync(
authCtx: AuthCtx,
keyId: string
): Promise<AscApiKeyInfo | null> {
const spinner = ora(`Fetching App Store Connect Api Key.`).start();
try {
const context = getRequestContext(authCtx);
const apiKey = await ApiKey.infoAsync(context, { id: keyId });
spinner.succeed(`Fetched App Store Connect Api Key (ID: ${keyId}).`);
return getAscApiKeyInfo(apiKey, authCtx);
} catch (error: any) {
const message = error?.message ?? '';
if (message.includes("There is no resource of type 'apiKeys' with id")) {
spinner.stop();
return null;
}
Log.error(error);
spinner.fail(`Failed to fetch App Store Connect Api Key.`);
throw error;
}
}
export async function createAscApiKeyAsync(
authCtx: AuthCtx,
{
nickname,
allAppsVisible,
roles,
keyType,
}: Partial<Pick<ApiKeyProps, 'nickname' | 'roles' | 'allAppsVisible' | 'keyType'>>
): Promise<AscApiKey> {
const spinner = ora(`Creating App Store Connect Api Key.`).start();
try {
const context = getRequestContext(authCtx);
const key = await ApiKey.createAsync(context, {
nickname: nickname ?? `[expo] ${new Date().getTime()}`,
allAppsVisible: allAppsVisible ?? true,
roles: roles ?? [UserRole.ADMIN],
keyType: keyType ?? ApiKeyType.PUBLIC_API,
});
const keyP8 = await key.downloadAsync();
if (!keyP8) {
const { nickname, roles } = key.attributes;
const humanReadableKey = `App Store Connect Key '${nickname}' (${
key.id
}) with roles {${roles.join(',')}}`;
if (!key.attributes.canDownload) {
// this case would be unexpected because we just created the key
throw new Error(`${humanReadableKey} is not available for download from Apple.`);
} else if (!key.attributes.isActive) {
throw new Error(`${humanReadableKey} is inactive and could not be downloaded.`);
}
throw new Error(`Failed to download .p8 file of ${humanReadableKey}.`);
}
// this object has more optional parameters populated
const fullKey = await ApiKey.infoAsync(context, { id: key.id });
spinner.succeed(`Created App Store Connect Api Key.`);
return {
...getAscApiKeyInfo(fullKey, authCtx),
keyP8,
};
} catch (err: any) {
spinner.fail('Failed to create App Store Connect Api Key.');
throw err;
}
}
export async function revokeAscApiKeyAsync(
authCtx: AuthCtx,
keyId: string
): Promise<AscApiKeyInfo> {
const spinner = ora(`Revoking App Store Connect Api Key.`).start();
try {
const context = getRequestContext(authCtx);
const apiKey = await ApiKey.infoAsync(context, { id: keyId });
const revokedKey = await apiKey.revokeAsync();
spinner.succeed(`Revoked App Store Connect Api Key.`);
return getAscApiKeyInfo(revokedKey, authCtx);
} catch (error) {
Log.error(error);
spinner.fail(`Failed to revoke App Store Connect Api Key.`);
throw error;
}
}
export function getAscApiKeyInfo(apiKey: ApiKey, authCtx: AuthCtx): AscApiKeyInfo {
return {
name: apiKey.attributes.nickname,
keyId: apiKey.id,
issuerId: apiKey.attributes.provider?.id,
teamId: authCtx.team.id,
teamName: authCtx.team.name,
roles: apiKey.attributes.roles,
isRevoked: !!apiKey.attributes.revokingDate,
};
}
@@ -1,5 +1,3 @@
import { UserRole } from '@expo/apple-utils';
import { AppleDevice } from '../../graphql/generated'; import { AppleDevice } from '../../graphql/generated';
import Log from '../../log'; import Log from '../../log';
import { CredentialSchema } from '../utils/promptForCredentials'; import { CredentialSchema } from '../utils/promptForCredentials';
@@ -102,44 +100,6 @@ export const distributionCertificateSchema: CredentialSchema<DistributionCertifi
}, },
}; };
export type MinimalAscApiKey = {
keyP8: string;
keyId: string;
issuerId: string;
teamId?: string;
teamName?: string;
roles?: UserRole[];
name?: string;
};
export interface AscApiKeyPath {
keyP8Path: string;
keyId: string;
issuerId: string;
}
export const ascApiKeyIdSchema: CredentialSchema<Pick<MinimalAscApiKey, 'keyId'>> = {
name: 'App Store Connect Api Key',
questions: [
{
field: 'keyId',
type: 'string',
question: 'Key ID:',
},
],
};
export const ascApiKeyIssuerIdSchema: CredentialSchema<Pick<MinimalAscApiKey, 'issuerId'>> = {
name: 'App Store Connect Api Key',
questions: [
{
field: 'issuerId',
type: 'string',
question: 'Issuer ID:',
},
],
};
export const pushKeySchema: CredentialSchema<PushKey> = { export const pushKeySchema: CredentialSchema<PushKey> = {
name: 'Apple Push Notifications service key', name: 'Apple Push Notifications service key',
questions: [ questions: [
Loaded 100 of 175 files, more files were not shown because too many files have changed in this diff. Show more