mirror of
https://github.com/expo/eas-cli.git
synced 2026-11-15 17:31:46 -10:00
## Why In https://github.com/expo/eas-cli/pull/3406 EAS workflow building the worker was **not** updated to Yarn v4. This breaks building worker. I tried adding `defaults.tools.yarn: 4.12.0`, but this unfortunately [is **not** the way to use Yarn v4 on EAS as I've learned](https://docs.expo.dev/more/create-expo/#yarn-2-modern). The right way is using Corepack. However, previously we explicitly did **not** use Corepack, because `pnpm --version` check the worker does in the beginning of its run was failing because it was run without `cwd`, so it was running within worker package which was configured with Yarn. Since we want to use Yarn v4, we need to figure out a way to use Corepack. ## How - Enabled Corepack. - Set up `yarn` executable like the one we have in `universe`. - Changed `pnpm --version` to **not** run inside worker (so it does not error). - Removed `setup-node` for specific Node versions in favor of a Mise override. ## Test plan - Corepack + Yarn resolution checks (local): - `mise exec [email protected].4 -- bash -lc 'corepack enable; yarn --version'` => `4.12.0` - same check from `scripts/` => `4.12.0` - Worker runtime unit test (local): - `mise exec [email protected].4 -- bash -lc 'corepack enable; yarn workspace @expo/worker test:unit -- runtimeEnvironment.test.ts'` - GitHub workflow runs: - success on Corepack worker workflow update: https://github.com/expo/eas-cli/actions/runs/22133707462 - latest run for full set of changes: https://github.com/expo/eas-cli/actions/runs/22133932635
88 lines
3.0 KiB
YAML
88 lines
3.0 KiB
YAML
name: Run tests
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
pull_request:
|
|
types: [opened, synchronize]
|
|
|
|
concurrency:
|
|
group: test-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
test:
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
matrix:
|
|
node: ['20', '22', '24']
|
|
include:
|
|
- node: '20'
|
|
coverage: true
|
|
name: Test with Node ${{ matrix.node }}
|
|
steps:
|
|
- uses: actions/checkout@v2
|
|
- name: Setup tools
|
|
uses: ./.github/actions/setup-mise
|
|
env:
|
|
MISE_NODE_VERSION: ${{ matrix.node }}
|
|
- name: Install dependencies
|
|
run: yarn install --immutable
|
|
env:
|
|
YARN_ENABLE_HARDENED_MODE: ${{ matrix.coverage == true && '1' || '0' }}
|
|
- run: yarn typecheck
|
|
- run: |
|
|
git config --global user.email "[email protected]"
|
|
git config --global user.name "Test"
|
|
- name: Fetch base commit for PR diffing
|
|
if: ${{ github.event_name == 'pull_request' }}
|
|
# Lerna needs the base commit to compute affected packages.
|
|
run: git fetch --no-tags --depth=1 origin ${{ github.event.pull_request.base.sha }}
|
|
- name: Run tests (affected)
|
|
# PRs: only run tests for changed packages + dependents.
|
|
if: ${{ !matrix.coverage && github.event_name == 'pull_request' }}
|
|
run: yarn run -T lerna run test --since ${{ github.event.pull_request.base.sha }} --include-dependents
|
|
env:
|
|
NODE_OPTIONS: --max-old-space-size=8192
|
|
- name: Run tests (all)
|
|
# Pushes to main: run all package tests.
|
|
if: ${{ !matrix.coverage && github.event_name == 'push' }}
|
|
run: yarn run -T lerna run test
|
|
env:
|
|
NODE_OPTIONS: --max-old-space-size=8192
|
|
- name: Run tests (coverage)
|
|
# Coverage on PRs and main; per-package reports are uploaded to Codecov.
|
|
if: ${{ matrix.coverage }}
|
|
run: yarn run -T lerna run test -- --coverage
|
|
env:
|
|
# Oclif seems to cause OOM errors when testing with coverage enabled.
|
|
# Remove this whenever we solved those OOM errors.
|
|
NODE_OPTIONS: --max-old-space-size=8192
|
|
- run: yarn lint
|
|
- run: yarn fmt:check
|
|
- name: Install scripts dependencies
|
|
if: ${{ matrix.coverage }}
|
|
run: yarn install --immutable
|
|
working-directory: ./scripts
|
|
env:
|
|
YARN_ENABLE_HARDENED_MODE: ${{ matrix.coverage == true && '1' || '0' }}
|
|
- uses: codecov/codecov-action@v1
|
|
if: ${{ matrix.coverage }}
|
|
with:
|
|
token: ${{ secrets.CODECOV_TOKEN }}
|
|
- if: ${{ matrix.coverage }}
|
|
run: yarn lint-changelog
|
|
|
|
notify-slack:
|
|
runs-on: ubuntu-latest
|
|
needs: [test]
|
|
name: Notify Slack
|
|
if: ${{ github.ref == 'refs/heads/main' && always() }}
|
|
steps:
|
|
- uses: actions/checkout@v2
|
|
- name: Notify Slack
|
|
uses: ./.github/internal-actions/notify-slack-on-fail-or-recover
|
|
with:
|
|
channel: eas-cli
|
|
slack_webhook: ${{ secrets.SLACK_WEBHOOK }}
|