mirror of
https://github.com/expo/eas-cli.git
synced 2026-11-15 17:31:46 -10:00
## Why In https://github.com/expo/eas-cli/pull/3406 EAS workflow building the worker was **not** updated to Yarn v4. This breaks building worker. I tried adding `defaults.tools.yarn: 4.12.0`, but this unfortunately [is **not** the way to use Yarn v4 on EAS as I've learned](https://docs.expo.dev/more/create-expo/#yarn-2-modern). The right way is using Corepack. However, previously we explicitly did **not** use Corepack, because `pnpm --version` check the worker does in the beginning of its run was failing because it was run without `cwd`, so it was running within worker package which was configured with Yarn. Since we want to use Yarn v4, we need to figure out a way to use Corepack. ## How - Enabled Corepack. - Set up `yarn` executable like the one we have in `universe`. - Changed `pnpm --version` to **not** run inside worker (so it does not error). - Removed `setup-node` for specific Node versions in favor of a Mise override. ## Test plan - Corepack + Yarn resolution checks (local): - `mise exec [email protected].4 -- bash -lc 'corepack enable; yarn --version'` => `4.12.0` - same check from `scripts/` => `4.12.0` - Worker runtime unit test (local): - `mise exec [email protected].4 -- bash -lc 'corepack enable; yarn workspace @expo/worker test:unit -- runtimeEnvironment.test.ts'` - GitHub workflow runs: - success on Corepack worker workflow update: https://github.com/expo/eas-cli/actions/runs/22133707462 - latest run for full set of changes: https://github.com/expo/eas-cli/actions/runs/22133932635
38 lines
1.1 KiB
JSON
38 lines
1.1 KiB
JSON
{
|
|
"name": "eas-cli-root",
|
|
"private": true,
|
|
"workspaces": [
|
|
"packages/*"
|
|
],
|
|
"scripts": {
|
|
"build": "lerna run build",
|
|
"typecheck": "lerna run typecheck",
|
|
"start": "lerna run watch --stream --parallel",
|
|
"start-allow-unused": "lerna run watch-allow-unused --stream --parallel",
|
|
"watch": "yarn start",
|
|
"eas": "packages/eas-cli/bin/run",
|
|
"lint": "oxlint --type-aware --import-plugin --tsconfig ./tsconfig.oxlint.json .",
|
|
"fmt": "oxfmt .",
|
|
"fmt:check": "oxfmt --check .",
|
|
"lint-changelog": "./scripts/bin/run lint-changelog",
|
|
"release": "lerna run rebuild --concurrency 1 && ./scripts/bin/run release",
|
|
"test": "lerna run test",
|
|
"clean": "lerna run clean && rm -rf node_modules coverage"
|
|
},
|
|
"devDependencies": {
|
|
"@types/jest": "29.5.11",
|
|
"@types/node": "20.14.8",
|
|
"eslint-plugin-async-protect": "3.1.0",
|
|
"jest": "29.7.0",
|
|
"jest-watch-typeahead": "2.2.2",
|
|
"lerna": "9.0.3",
|
|
"oclif": "^3.9.0",
|
|
"oxfmt": "0.28.0",
|
|
"oxlint": "1.43.0",
|
|
"oxlint-tsgolint": "0.11.1",
|
|
"ts-jest": "29.1.1",
|
|
"typescript": "5.5.4"
|
|
},
|
|
"packageManager": "[email protected]"
|
|
}
|