mirror of
https://github.com/expo/expo-cli.git
synced 2026-11-15 13:28:10 -10:00
# Why Fixes #3679 # How Upgraded ngrok at https://github.com/expo/ngrok/tree/main (no pr, just fork from [upstream v4.1.0](https://github.com/bubenshchykov/ngrok/tree/v4.1.0) and cherry-pick necessary patches). Major changes from the new version: - async/await support - ship typings in `ngrok.d.ts` - `onStatusChange` status callback to fulfill our needs # Test Plan since the our ngrok fork is not published yet, this is how i tested: ```sh cd /path/to/expo-cli/packages/xdl && yarn add -D /path/to/expo/ngrok cd /path/to/expo-cli && yarn build /path/to/packages/expo-cli/bin/expo.js init ~/ngrok_test # choose managed blank template cd ~/ngrok_test yarn add /path/to/expo/ngrok /path/to/packages/expo-cli/bin/expo.js start --tunnel # check tunnel is connected and send a manifest test http request through tunnel url ``` # Checklist - [x] Review and publish our [ngrok fork](https://github.com/expo/ngrok/tree/main), perhaps to promote main branch as default branch. - [x] Update new `@expo/ngrok` version in `packages/xdl/pacakge.json` and `packages/xdl/yarn.lock`