refactor: roll back to ncc because of swc bundling issues (#144)

* refactor: roll back to ncc because of swc bundling issues

* .

* fix: update main action entry point

* chore: fix linting issues
This commit is contained in:
Cedric van Putten authored and GitHub committed 2022-01-12 17:24:04 +01:00
1 parent 4908a48f1b
commit 3007741466
9 files changed
+69579 -381

No files matched your search

-11
View File
@@ -1,11 +0,0 @@
{
"jsc": {
"target": "es2020",
"parser": {
"syntax": "typescript"
}
},
"module": {
"type": "commonjs"
}
}
+1 -1
View File
@@ -7,7 +7,7 @@ branding:
color: gray-dark
runs:
using: node16
main: build/setup.js
main: build/setup/index.js
inputs:
expo-version:
description: The Expo CLI version to install (use any semver/dist-tag available).
-324
View File
@@ -1,324 +0,0 @@
function __swcpack_require__(mod) {
function interop(obj) {
if (obj && obj.__esModule) {
return obj;
} else {
var newObj = {};
if (obj != null) {
for(var key in obj){
if (Object.prototype.hasOwnProperty.call(obj, key)) {
var desc = Object.defineProperty && Object.getOwnPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : {};
if (desc.get || desc.set) {
Object.defineProperty(newObj, key, desc);
} else {
newObj[key] = obj[key];
}
}
}
}
newObj.default = obj;
return newObj;
}
}
var cache;
if (cache) {
return cache;
}
var module = {
exports: {}
};
mod(module, module.exports);
cache = interop(module.exports);
return cache;
}
function _interopRequireDefault(obj) {
return obj && obj.__esModule ? obj : {
default: obj
};
}
function _interopRequireWildcard(obj) {
if (obj && obj.__esModule) {
return obj;
} else {
var newObj = {};
if (obj != null) {
for(var key in obj){
if (Object.prototype.hasOwnProperty.call(obj, key)) {
var desc = Object.defineProperty && Object.getOwnPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : {};
if (desc.get || desc.set) {
Object.defineProperty(newObj, key, desc);
} else {
newObj[key] = obj[key];
}
}
}
}
newObj.default = obj;
return newObj;
}
}
var load = __swcpack_require__.bind(void 0, function(module, exports) {
"use strict";
Object.defineProperty(exports, "__esModule", {
value: true
});
exports.fromLocalCache = fromLocalCache;
exports.toLocalCache = toLocalCache;
exports.fromRemoteCache = fromRemoteCache;
exports.toRemoteCache = toRemoteCache;
var _cache = require("@actions/cache");
var core = _interopRequireWildcard(require("@actions/core"));
var toolCache = _interopRequireWildcard(require("@actions/tool-cache"));
var _path = _interopRequireDefault(require("path"));
var _os = _interopRequireDefault(require("os"));
async function fromLocalCache(config) {
return toolCache.find(config.package, config.version);
}
async function toLocalCache(root, config) {
return toolCache.cacheDir(root, config.package, config.version);
}
async function fromRemoteCache(config) {
// see: https://github.com/actions/toolkit/blob/8a4134761f09d0d97fb15f297705fd8644fef920/packages/tool-cache/src/tool-cache.ts#L401
const target = _path.default.join(process.env['RUNNER_TOOL_CACHE'] || '', config.package, config.version, _os.default.arch());
const cacheKey = config.cacheKey || getRemoteKey(config);
try {
// When running with nektos/act, or other custom environments, the cache might not be set up.
const hit = await (0, _cache).restoreCache([
target
], cacheKey);
if (hit) return target;
} catch (error) {
if (!handleRemoteCacheError(error)) throw error;
}
}
async function toRemoteCache(source, config) {
const cacheKey = config.cacheKey || getRemoteKey(config);
try {
await (0, _cache).saveCache([
source
], cacheKey);
} catch (error) {
if (!handleRemoteCacheError(error)) throw error;
}
}
/**
* Get the cache key to use when (re)storing the Expo CLI from remote cache.
*/ function getRemoteKey(config) {
return `${config.package}-${process.platform}-${_os.default.arch()}-${config.packager}-${config.version}`;
}
/**
* Handle any incoming errors from cache methods.
* This can include actual errors like `ReserveCacheErrors` or unavailability errors.
* When the error is handled, it MUST provide feedback for the developer.
*
* @returns If the error was handled properly.
*/ function handleRemoteCacheError(error) {
const isReserveCacheError = error instanceof _cache.ReserveCacheError;
const isCacheUnavailable = error.message.toLowerCase().includes('cache service url not found');
if (isReserveCacheError || isCacheUnavailable) {
core.warning('Skipping remote cache storage, encountered error:');
core.warning(error.message);
return true;
}
return false;
}
});
var load1 = __swcpack_require__.bind(void 0, function(module, exports) {
"use strict";
Object.defineProperty(exports, "__esModule", {
value: true
});
exports.install = install;
exports.fromPackager = fromPackager;
var core = _interopRequireWildcard(require("@actions/core"));
var cli = _interopRequireWildcard(require("@actions/exec"));
var io = _interopRequireWildcard(require("@actions/io"));
var path = _interopRequireWildcard(require("path"));
var _cache = load();
async function install(config) {
let root = await (0, _cache).fromLocalCache(config);
if (!root && config.cache) root = await (0, _cache).fromRemoteCache(config);
else core.info('Skipping remote cache, not enabled...');
if (!root) {
root = await fromPackager(config);
root = await (0, _cache).toLocalCache(root, config);
if (config.cache) await (0, _cache).toRemoteCache(root, config);
}
return path.join(root, 'node_modules', '.bin');
}
async function fromPackager(config) {
const root = process.env['RUNNER_TEMP'] || '';
const tool = await io.which(config.packager);
await io.mkdirP(root);
await cli.exec(tool, [
'add',
`${config.package}@${config.version}`
], {
cwd: root
});
return root;
}
});
var load2 = __swcpack_require__.bind(void 0, function(module, exports) {
"use strict";
Object.defineProperty(exports, "__esModule", {
value: true
});
exports.resolveVersion = resolveVersion;
var _exec = require("@actions/exec");
async function resolveVersion(name, range) {
let stdout = '';
try {
await (0, _exec).exec('npm', [
'info',
`${name}@${range}`,
'version',
'--json'
], {
silent: true,
listeners: {
stdout (data) {
stdout += data.toString();
}
}
});
} catch (error) {
throw new Error(`Could not resolve version "${range}" of "${name}", reason:\n${error.message || error}`);
}
// thanks npm, for returning a "x.x.x" json value...
if (stdout.startsWith('"')) stdout = `[${stdout}]`;
return JSON.parse(stdout).at(-1);
}
});
var load3 = __swcpack_require__.bind(void 0, function(module, exports) {
"use strict";
Object.defineProperty(exports, "__esModule", {
value: true
});
exports.getBinaryName = getBinaryName;
exports.maybeAuthenticate = maybeAuthenticate;
exports.maybePatchWatchers = maybePatchWatchers;
exports.maybeWarnForUpdate = maybeWarnForUpdate;
exports.handleError = handleError;
exports.performAction = performAction;
var core = _interopRequireWildcard(require("@actions/core"));
var cli = _interopRequireWildcard(require("@actions/exec"));
var _semver = _interopRequireDefault(require("semver"));
var _packager1 = load2();
function getBinaryName(name, forWindows = false) {
const bin = name.toLowerCase().replace('-cli', '');
return forWindows ? `${bin}.cmd` : bin;
}
async function maybeAuthenticate(options = {}) {
if (options.token) {
if (options.cli) {
const bin = getBinaryName(options.cli, process.platform === 'win32');
await cli.exec(bin, [
'whoami'
], {
env: {
...process.env,
EXPO_TOKEN: options.token
}
});
} else core.info("Skipping token validation: no CLI installed, can't run `whoami`.");
return core.exportVariable('EXPO_TOKEN', options.token);
}
if (options.username || options.password) {
if (options.cli !== 'expo-cli') return core.warning('Skipping authentication: only Expo CLI supports programmatic credentials, use `token` instead.');
if (!options.username || !options.password) return core.info('Skipping authentication: `username` and/or `password` not set...');
const bin = getBinaryName(options.cli, process.platform === 'win32');
await cli.exec(bin, [
'login',
`--username=${options.username}`
], {
env: {
...process.env,
EXPO_CLI_PASSWORD: options.password
}
});
}
core.info('Skipping authentication: `token`, `username`, and/or `password` not set...');
}
async function maybePatchWatchers() {
if (process.platform !== 'linux') return core.info('Skipping patch for watchers, not running on Linux...');
core.info('Patching system watchers for the `ENOSPC` error...');
try {
// see https://github.com/expo/expo-cli/issues/277#issuecomment-452685177
await cli.exec('sudo sysctl fs.inotify.max_user_instances=524288');
await cli.exec('sudo sysctl fs.inotify.max_user_watches=524288');
await cli.exec('sudo sysctl fs.inotify.max_queued_events=524288');
await cli.exec('sudo sysctl -p');
} catch {
core.warning("Looks like we can't patch watchers/inotify limits, you might encouter the `ENOSPC` error.");
core.warning('For more info, https://github.com/expo/expo-github-action/issues/20');
}
}
async function maybeWarnForUpdate(name) {
const binaryName = getBinaryName(name);
const latest = await (0, _packager1).resolveVersion(name, 'latest');
const current = await (0, _packager1).resolveVersion(name, core.getInput(`${getBinaryName(name)}-version`) || 'latest');
if (_semver.default.diff(latest, current) === 'major') {
core.warning(`There is a new major version available of the Expo CLI (${latest})`);
core.warning(`If you run into issues, try upgrading your workflow to "${binaryName}-version: ${_semver.default.major(latest)}.x"`);
}
}
async function handleError(name, error) {
try {
await maybeWarnForUpdate(name);
} catch {
// If this fails, ignore it
}
core.setFailed(error);
}
function performAction(action) {
if (process.env.JEST_WORKER_ID) return Promise.resolve(null);
return action();
}
});
"use strict";
Object.defineProperty(exports, "__esModule", {
value: true
});
exports.setupAction = setupAction;
var _core = require("@actions/core");
var _install = load1();
var _packager = load2();
var tools = _interopRequireWildcard(load3());
// Auto-execute in GitHub actions
tools.performAction(setupAction);
async function setupAction() {
const expoVersion = await installCli('expo-cli');
const easVersion = await installCli('eas-cli');
await (0, _core).group('Checking current authenticated account', ()=>tools.maybeAuthenticate({
cli: expoVersion ? 'expo-cli' : easVersion ? 'eas-cli' : undefined,
token: (0, _core).getInput('token') || undefined,
username: (0, _core).getInput('username') || undefined,
password: (0, _core).getInput('password') || undefined
})
);
if (!(0, _core).getInput('patch-watchers') || (0, _core).getBooleanInput('patch-watchers') !== false) await (0, _core).group('Patching system watchers for the `ENOSPC` error', ()=>tools.maybePatchWatchers()
);
}
async function installCli(name) {
const shortName = tools.getBinaryName(name);
const inputVersion = (0, _core).getInput(`${shortName}-version`);
const packager = (0, _core).getInput('packager') || 'yarn';
if (!inputVersion) return (0, _core).info(`Skipping installation of ${name}, \`${shortName}-version\` not provided.`);
const version = await (0, _packager).resolveVersion(name, inputVersion);
const cache = (0, _core).getBooleanInput(`${shortName}-cache`);
try {
const path = await (0, _core).group(cache ? `Installing ${name} (${version}) from cache or with ${packager}` : `Installing ${name} (${version}) with ${packager}`, ()=>(0, _install).install({
packager,
version,
cache,
package: name,
cacheKey: (0, _core).getInput(`${shortName}-cache-key`) || undefined
})
);
(0, _core).addPath(path);
} catch (error) {
tools.handleError(name, error);
}
return version;
}
+68391
View File
File diff suppressed because it is too large. Load diff
File diff suppressed because it is too large. Load diff
+52
View File
@@ -0,0 +1,52 @@
const fs = require('fs');
const path = require('path');
const ncc = require('@vercel/ncc');
build();
async function build() {
const actionsDir = path.resolve(__dirname, 'src/actions');
const buildDir = path.resolve(__dirname, 'build');
const actions = fs
.readdirSync(actionsDir, { withFileTypes: true })
.filter(entity => entity.isFile())
.map(entity => ({
name: path.basename(entity.name, path.extname(entity.name)),
file: path.resolve(actionsDir, entity.name),
}));
for (const action of actions) {
const files = await compile(action.file);
write(files, path.resolve(buildDir, action.name));
console.log(`✓ ${path.relative(__dirname, action.file)}`);
}
}
async function compile(entry) {
const { code, map, assets } = await ncc(entry, {
cache: false,
license: 'license.txt',
quiet: true,
});
return {
...assets,
'index.js': { source: code },
'index.js.map': { source: map },
};
}
function write(files, dir) {
for (const fileName in files) {
if (!files[fileName].source) {
continue;
}
const filePath = path.resolve(dir, fileName);
fs.mkdirSync(path.dirname(filePath), { recursive: true });
fs.writeFileSync(filePath, files[fileName].source, { encoding: 'utf-8' });
}
}
+3 -4
View File
@@ -17,8 +17,8 @@
"scripts": {
"test": "jest",
"lint": "tsc --noEmit && eslint .",
"build": "spack && rimraf build/*.map",
"clean": "rimraf build .swc"
"build": "node ncc.js",
"clean": "rimraf build"
},
"dependencies": {
"@actions/cache": "^1.0.7",
@@ -31,14 +31,13 @@
"devDependencies": {
"@semantic-release/changelog": "^5.0.1",
"@semantic-release/git": "^9.0.0",
"@swc/cli": "^0.1.55",
"@swc/core": "^1.2.128",
"@tsconfig/node16": "^1.0.2",
"@types/jest": "^27.0.2",
"@types/node": "^16.11.19",
"@types/semver": "^7.3.6",
"@typescript-eslint/eslint-plugin": "^5.4.0",
"@typescript-eslint/parser": "^5.4.0",
"@vercel/ncc": "^0.33.1",
"conventional-changelog-conventionalcommits": "^4.6.0",
"eslint": "^8.2.0",
"eslint-plugin-jest": "^25.2.4",
-41
View File
@@ -1,41 +0,0 @@
const { config } = require('@swc/core/spack');
const { readdirSync } = require('fs');
const { resolve, basename, extname } = require('path');
module.exports = config({
target: 'node',
entry: actions(resolve(__dirname, 'src/actions')),
output: {
path: resolve(__dirname, 'build'),
},
externalModules: externals(),
});
/**
* Get all action entry points, in src/actions.
* This returns them as `{ [name]: absolutePath }`.
*/
function actions(dir) {
return Object.fromEntries(
readdirSync(dir, { withFileTypes: true })
.filter(entity => entity.isFile())
.map(entity => {
const actionName = basename(entity.name, extname(entity.name));
const actionFile = resolve(dir, entity.name);
return [actionName, actionFile];
})
);
}
/**
* Get all external modules that should not be bundled.
* Ignoring the packages in the `dependencies` list should keep them up to date.
*
* Note, currently `@actions/cache` can't be bundled by SWC due to modules issues in `@azure/core-http`:
* > internal error: entered unreachable code: module item found but is_es6 is false
*
* @see https://github.com/expo/expo-github-action/pull/62
*/
function externals() {
return Object.keys(require('./package.json').dependencies);
}
+5
View File
@@ -1408,6 +1408,11 @@
"@typescript-eslint/types" "5.4.0"
eslint-visitor-keys "^3.0.0"
"@vercel/ncc@^0.33.1":
version "0.33.1"
resolved "https://registry.yarnpkg.com/@vercel/ncc/-/ncc-0.33.1.tgz#b240080a3c1ded9446a30955a06a79851bb38f71"
integrity sha512-Mlsps/P0PLZwsCFtSol23FGqT3FhBGb4B1AuGQ52JTAtXhak+b0Fh/4T55r0/SVQPeRiX9pNItOEHwakGPmZYA==
JSONStream@^1.0.4:
version "1.3.5"
resolved "https://registry.yarnpkg.com/JSONStream/-/JSONStream-1.3.5.tgz#3208c1f08d3a4d99261ab64f92302bc15e111ca0"