Summary: It makes sense to wait until we have more pressing breaking changes to release a major version.
Reviewed By: KylinChang
Differential Revision: D26796073
fbshipit-source-id: f01d622bb7f8451a67309d8c3f62284ceda9a678
Summary: Updating major version to match Graph API release.
Reviewed By: linmx0130
Differential Revision: D26711406
fbshipit-source-id: 2ba166ff86b0d97aececa630e6ee4585ff520aae
Summary:
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1367
Bumping version to 7.0
Bumping Graph API version to 7.0
Reviewed By: jingping2015
Differential Revision: D21405159
fbshipit-source-id: 7ee479aff3ed663210ae0adb13840280d373d9da
Summary:
Thanks for proposing a pull request!
To help us review the request, please complete the following:
- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)
## Pull Request Details
CocoaPods need to be released in three stages
Stage 1:
FBSDKCoreKit
Stage 2:
FBSDKLoginKit - depends on FBSDKCoreKit
FBSDKShareKit - depends on FBSDKCoreKit
Stage 3:
FBSDKGamingServicesKit - depends on FBSDKShareKit
FBSDKTVOSKit - depends on FBSDKCoreKit,FBSDKShareKit,FBSDKLoginKit
If you try to push these as part of the same release job they fail even with a somewhat significant timeout. If you let it fail and try to retrigger it will fail because some pods are already pushed.
The other approach would be to allow the individual pushes to fail silently - we had this before but then there was no clear signal when we needed to rerun the job.
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1351
Test Plan:
Should print the correct commands in [this CI job](https://travis-ci.org/github/facebook/facebook-ios-sdk/builds/677772000):
Stage 1:
pod trunk push --allow-warnings FBSDKCoreKit.podspec
Stage 2:
pod trunk push --allow-warnings FBSDKLoginKit.podspec
pod trunk push --allow-warnings FBSDKShareKit.podspec
Stage 3:
pod trunk push --allow-warnings FBSDKGamingServicesKit.podspec
pod trunk push --allow-warnings FBSDKTVOSKit.podspec
Reviewed By: Nathaaaalie
Differential Revision: D21158325
Pulled By: joesus
fbshipit-source-id: 1a390b75f059657184dc5b116aa88bb3b7bb37b1
Summary:
Thanks for proposing a pull request!
To help us review the request, please complete the following:
- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)
## Pull Request Details
Podspec dependencies were hardcoded to ~> 5.0. This fixes that.
Swift targets require headers to be declared public in Xcode. I removed some files and added them back without updating their visibility. This fixes that.
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1222
Test Plan: CI
Reviewed By: jingping2015
Differential Revision: D19737835
Pulled By: joesus
fbshipit-source-id: 13ec65f70c788ab78c535484aa5db96872fd5cc8
Summary:
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1220
Bumps sdk version to 6.0.0
Bumps api version to v6.0
Reviewed By: jingping2015, ZebingZong, KylinChang
Differential Revision: D19698716
fbshipit-source-id: 165ad3f3ac0f5c686e965f521e9d807f9f21d523
Summary:
Thanks for proposing a pull request!
To help us review the request, please complete the following:
- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)
## Pull Request Details
Should be able to declare `FBSDKCOCOAPODS` more granularly.
See: https://github.com/CocoaPods/CocoaPods/issues/3309
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1180
Test Plan: N/A
Reviewed By: ZebingZong
Differential Revision: D19386668
Pulled By: joesus
fbshipit-source-id: 043bd715aadf466ac8403543ca6fea43827fda45
Summary:
Thanks for proposing a pull request!
To help us review the request, please complete the following:
- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)
## Pull Request Details
Fix for using TVOSKit via CocoaPods as a static library
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1179
Test Plan:
Create a new tvOS project. Add this to the podfile:
`pod 'FBSDKTVOSKit', :path => 'your checkout path'`
Make sure `use_frameworks!` is commented out.
Should build successfully.
Also should successfully lint as a static lib with:
`bundle exec pod lib lint FBSDKTVOSKit.podspec --include-podspecs=FBSDKShareKit.podspec --allow-warnings --use-libraries`
Reviewed By: Mxiim
Differential Revision: D19376023
Pulled By: joesus
fbshipit-source-id: 87b20e082eac0942a0b94d520f444527c022bafe
Summary: The GitHub repo has been renamed from facebook-ios-sdk to facebook-objc-sdk
Reviewed By: jingping2015
Differential Revision: D17630050
fbshipit-source-id: 4fa7a3c4859af7fead71c4700a1151903d4734cc