Commit Graph
9 Commits
Author SHA1 Message Date
Joe Susnick fd86ddce8a Back out "Make Basics an actual dependency 2/n"
Summary: Original commit changeset: 32a9332a2d03

Reviewed By: dreamolight

Differential Revision: D24542238

fbshipit-source-id: bb55b9eeb9fba7e73080fb2cdfa33d16594acb0c
2020-10-26 12:15:30 -07:00
Joe Susnick 1a8aa34081 Make Basics an actual dependency 2/n (#1526)
Summary:
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1526

## Context:

In terms of BUCK, CocoaPods and Swift Package Manager, CoreKitBasics is its own module.

Even in terms of xcodeproj it's its own target. This formalizes that dependency relationship.

## Why do this?

This allows us to avoid a lot of the messiness where we have something like:

```
#if defined FBSDKCOCOAPODS
 #import <FBSDKCoreKit/FBSDKCoreKit_Basics.h>
#elif defined BUCK
 #import <FBSDKCoreKit_Basics/FBSDKCoreKit_Basics.h>
#else
 #import "FBSDKCoreKit_Basics.h"
#endif
```
Now we can just do:
```
#import <FBSDKCoreKit_Basics/FBSDKCoreKit_Basics.h>
```
and it will "just work"

**Correction**: CocoaPods considers anything in a podspec to be part of the same module. Either future work will be needed to publish basics as its own module or we'll have to live with fragmented header imports.

So really the why do this comes down to having the correct code boundaries. In CocoaPods this is a subspec but in other areas it's on the module/product/target level.

## This diff

Adds FBSDKCoreKit basics as a linked dependency to the other kits. This relationship is not new but it was previously hidden by having Basics source files added to the other CoreKit targets. This also fixes the CoreKit+Internal dependency to depend on the library instead of just importing the header.

Reviewed By: dreamolight

Differential Revision: D24179749

fbshipit-source-id: 32a9332a2d0319c1d7579a28895d9d102dec0505
2020-10-16 08:47:31 -07:00
Joe Susnick 6dedbbd5b3 Fix Rsync Step (#1525)
Summary:
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1525

I made some faulty assumptions about why I was getting an rsync warning so I gated it behind a file check. This led to a false positive where it appeared that the files were being synced when they were not.

This updated code ignores the output of the step when it fails since it will fail for GamingServicesKit (because it contains no Swift files at the moment).

Reviewed By: tianqibt, dreamolight

Differential Revision: D24339344

fbshipit-source-id: fe5eccaf4e6bf379eb8b2f2ceffbf3d11fd0e65f
2020-10-15 13:18:32 -07:00
Joe Susnick 44694182e5 Fix Carthage for Xcode 12 (#1517)
Summary:
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1517

Fixes Carthage build for Xcode 12 by following script proposed in
https://github.com/Carthage/Carthage/blob/master/Documentation/Xcode12Workaround.md

Reviewed By: d16r

Differential Revision: D24227997

fbshipit-source-id: 475b6dcff7347e895b0ae40a90169580310dad40
2020-10-14 11:22:52 -07:00
Joe Susnick 7620ff537f Fix release binaries
Summary:
Outlined in this issue:
https://github.com/facebook/facebook-ios-sdk/issues/1380

tldr;  we are missing a build flag that lets xcode know it should include the `.swiftinterface` files.
We are also not copying it to the universal framework.

Reviewed By: dreamolight

Differential Revision: D21848386

fbshipit-source-id: 40c35bee648d9e58938af32975552e8480df0bbe
2020-06-04 14:06:10 -07:00
Joe Susnick 657c7bb907 Formatting for build script
Summary: Simple cleanup

Reviewed By: jingping2015

Differential Revision: D21887439

fbshipit-source-id: bfdb146fb9b8396f3626e4a953165bb63e2a9d05
2020-06-04 13:05:16 -07:00
Stan Wu 6594c9e527 Add schema for building universal FBSDKCoreKit_Basics module
Summary: As title

Reviewed By: codytwinton

Differential Revision: D15385711

fbshipit-source-id: e715c950e52bc46220ccc83800b3f41982353ab2
2019-05-25 21:09:30 -07:00
Ahmed Shehata 1f072634af Added WhatsApp Button Translations
Summary: Added generated translations for WhatsApp

Reviewed By: codytwinton

Differential Revision: D14530711

fbshipit-source-id: 773fa94f12c904b023beb8b93da08ede7f96cb4f
2019-04-15 06:06:43 -07:00
Cody Winton 28dfc3e16f Conversion to Continuous Release (#949)
Summary:
Thanks for proposing a pull request.

To help us review the request, please complete the following:

- [X] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [X] describe the change (for example, what happens before the change, and after the change)

Converted project to structure that best supports continuous release process:

- Updated scripts accordingly
- Added `RELEASING.md` file for documentation
Pull Request resolved: https://github.com/facebook/facebook-objc-sdk/pull/949

Reviewed By: jingping2015

Differential Revision: D14112836

Pulled By: codytwinton

fbshipit-source-id: 740ce8956f2af5a45f7a8ad32e4496cce5046606
2019-02-15 16:39:54 -08:00