Commit Graph
3 Commits
Author SHA1 Message Date
Fred Emmott 3bcf37810a replace markTestFailed() with fail()
Summary:
markTestFailed() is deprecated, and not in external HHI

refs facebook/fbshipit#13

Reviewed By: paulbiss

Differential Revision: D3394293

fbshipit-source-id: a1bc550b6a59997a95f642e27cf08d628daaa97f
2016-06-07 09:36:39 -07:00
Fred Emmott 02c3029883 inherit environment variables in ShipItShellCommand
Summary: Needed for SSH/KRB tokens.

Reviewed By: ebetica

Differential Revision: D3192600

fb-gh-sync-id: d1b03ee899f76fa9659e568ad284f657246c5708
fbshipit-source-id: d1b03ee899f76fa9659e568ad284f657246c5708
2016-04-18 13:45:34 -07:00
Fred Emmott f0c3dbd404 refactor shell command handling
Summary:Needed to extend it to support environment variables. Fix some
annoyances with the existing API:

 - only able to get exit code if the exception is thrown (`git diff` often exits with 1 in non-error situations)
 - almost always specifying null stdin
 - almost always specifying DONT_VERBOSE
 - output was only printed at the end of a command (eg the slow git submodule command in HHVM looked like a hang)

Existing API is now a wrapper around the new one.

refs #12
refs #9
refs #5

Reviewed By: JoelMarcey

Differential Revision: D3186167

fb-gh-sync-id: d64a852facbc6e8ed167fe462ff51cd1e4bde621
fbshipit-source-id: d64a852facbc6e8ed167fe462ff51cd1e4bde621
2016-04-18 10:25:29 -07:00