Commit Graph
10 Commits
Author SHA1 Message Date
Antón MolledaandMichał Pierzchała 5819a17d14 chore: make cleanup async (#1156)
* chore: make `cleanup` async

Using `rimraf.sync` can cause `ENOTEMPTY` and `EBUSY` errors on Windows.
This can make the Windows CI to fail randomly. Changing to the async
method defaults to autoretry 3 times and thus avoiding this issues.

* chore: jest config

* chore: e2e tests use sync cleanup

* chore: pr feedback

* chore: revert timeout

* Update __e2e__/default.test.ts

* Update __e2e__/default.test.ts

Co-authored-by: Michał Pierzchała <[email protected]>
2020-05-12 15:53:04 +02:00
TMaszkoandMichał Pierzchała 9e44835025 fix: invalid output from config command (#1131)
* Moved disabling logger at the top when user used config command

* Added e2e tests for config command

* Added config command output snapshot

* Updated config test snapshot

* Added project root replacement helper

* Removed default terminal program from snapshots

* Moved tests to jest folder and removed additional snapshot

* less snapshots; use raw serializer

* strip unnecessary parts of the snapshot

* Added tmp directory to regex which replaces project root before snapshot

* Added slash before passing testFolder for project root replacing helper

* Fixed problem with windows paths replacing

* CR fixes

Co-authored-by: Michał Pierzchała <[email protected]>
2020-04-29 10:26:30 +02:00
Mike GrabowskiandMichał Pierzchała 21f1b03c01 fix: custom root or calling Gradle outside of project directory (#1057)
* fix: custom root

* chore: dont re-create file

* chore: refactor Jest helpers to allow arbitrary scripts to run

* chore: rename

* chore: add e2e test

* chore: no snapshot testing for Gradle output

* chore: final tweaks and uncomment cleanup

* fix: use proper env for e2e

* chore: move everything to beforeAll

* Update jest/helpers.ts

Co-Authored-By: Michał Pierzchała <[email protected]>

* chore: naming updates

* chore: address comments

Co-authored-by: Michał Pierzchała <[email protected]>
2020-03-18 16:48:49 +01:00
Michał Pierzchała 9560d0d530 chore: upgrade chalk to v3 (#1003) 2020-02-23 21:17:55 +01:00
Mike Grabowski 78bfbfbdd6 chore: finish migration to TypeScript (#788)
* Remove remaining pieces of Flow

* Update CircleCI configuration

* I lied, fix config one more time

* Remove flow-typed and console-log
2019-10-14 21:47:24 +02:00
Charles Assunção fde227d886 chore: convert e2e init test and helpers to TS (#705)
* chore: Convert e2e/init.test and jest/helpers to Typescript

* chore: remove readable stream types temporary

* chore: convert e2e tests to TypeScript

* chore: Adding temporary $FlowFixMe

* chore: Update Jest Config

* chore: Update Snaps

* Revert "chore: Update Snaps"

This reverts commit af5ae56d01d709e00b1ae23da9007e92a4f92ca4.

* chore: Update Snaps

* update snapshots
2019-09-11 10:33:06 +02:00
Kacper Wiszczuk 948776ee9c chore: standardise network requests layer (#463) 2019-07-16 20:53:15 +02:00
Michał Pierzchała 0fcf6d3ddf feat: filter out non-native deps from config output; fix missing hooks (#436) 2019-06-24 16:00:54 +02:00
Michał Pierzchała 116281fb53 fix: allow upgrading with binary files in the diff (#432)
* feat: allow upgrading with binary files in the diff

* fix tests
2019-06-17 16:07:30 +02:00
Mike Grabowski 5f7dba3d6e feat: extract iOS and Android specific linking files out of the core (#290)
Summary:
---------

Historically, Android and iOS platform were hardcoded inside CLI and provided by default. Then, other packages could export additional platforms on top of it.

React Native as a platform was hardcoded in Metro configuration (default platforms, default extensions) and inside link. That means all new features were always developed with these platforms in mind, leaving others behind. We often used private APIs, which made things more complicated for 3rd party platform developers.

From this PR on, there's no longer concept of an out-of-tree platform inside of the CLI. In a follow up PR to React Native, I am going to configure iOS and Android platforms inside React Native, just like React Native Windows exposes Windows platform.

This will open room for improvements and should make it even easier for the CLI to welcome other platforms.
2019-04-05 22:02:26 +02:00