Commit Graph
6 Commits
Author SHA1 Message Date
Michał Pierzchała 27d4924a58 feat: refactor install to use link directly instead of spawning it (#180)
Summary:
---------

Attempt No. 2 after https://github.com/react-native-community/react-native-cli/pull/178. Turned out I passed empty array as `platforms` argument to link, while I should pass `undefined`. We could actually add `--platforms` support to `install`/`uninstall` now, what do you think?

Test Plan:
----------

Uninstalling:

<img width="677" alt="screenshot 2019-02-19 at 13 42 54" src="https://user-images.githubusercontent.com/5106466/53015940-8ed51980-344c-11e9-9f22-0406c468a10d.png">

Installing: 

<img width="668" alt="screenshot 2019-02-19 at 13 43 02" src="https://user-images.githubusercontent.com/5106466/53015941-8ed51980-344c-11e9-8556-a6350f05536f.png">
2019-02-19 13:54:36 +01:00
Mike Grabowski cf99cd1b2c Revert "feat: better logging for install/uninstall; less spawning; fix unlinking (#174)"
This reverts commit 32cc3a2d75.
2019-02-18 17:53:33 +01:00
Michał Pierzchała 32cc3a2d75 feat: better logging for install/uninstall; less spawning; fix unlinking (#174)
Summary:
---------

- [x] use link/unlink directly from source instead of spawning
- [x] fix unlinking failing to get dependencies
- [x] improve logging

Test Plan:
----------

<img width="684" alt="screenshot 2019-02-15 at 23 40 29" src="https://user-images.githubusercontent.com/5106466/52888210-2996d500-317b-11e9-9a37-402de8f50167.png">
<img width="692" alt="screenshot 2019-02-15 at 23 40 50" src="https://user-images.githubusercontent.com/5106466/52888211-2996d500-317b-11e9-8b7e-2cdc4a4f6a94.png">
2019-02-16 16:11:12 +01:00
Michał Pierzchała cdfd2b4bc8 docs: update repository README (#172)
Summary:
---------

Adding some more information to the main README. 
`packages/cli` still needs a proper README with all commands listed, but that's not in scope of this PR
2019-02-15 12:36:46 +01:00
Mike Grabowski 1ced430e73 Add status badge to the repository 2018-11-09 11:32:55 +01:00
Mike Grabowski 49da3b2c5a Set up Yarn workspaces and basic repo structure 2018-09-28 15:30:01 +02:00