expo/react-native-community-cli
1
0 Fork 0
mirror of https://github.com/expo/react-native-community-cli.git synced 2026-11-14 19:11:48 -10:00
Code Issues Packages Projects Releases Wiki Activity
1,238 Commits 11 Branches 51 Tags
@react-native-community/[email protected]
Commit Graph
83 Commits
Author SHA1 Message Date
Mike Grabowski ad65130e76 Publish 
- @react-native-community/[email protected]
 2019-03-14 22:42:20 +01:00
Mike Grabowski 4d7110d907 chore: export findPlugins for ReactNative 2019-03-14 22:42:00 +01:00
Mike Grabowski 33647ab41c Revert "fix: correct export of findPlugins" 
This reverts commit df17527c68.
 2019-03-14 22:41:36 +01:00
Mike Grabowski 962a59c9f4 Publish 
- @react-native-community/[email protected]
 2019-03-14 22:35:18 +01:00
Mike Grabowski df17527c68 fix: correct export of findPlugins 2019-03-14 22:32:44 +01:00
Michał Pierzchała a20aad7d9a v1.4.2 2019-03-14 13:09:23 +01:00
Michał Pierzchała 07a976127d fix: linking assets on Android (#231) 2019-03-14 10:32:34 +01:00
Michał Pierzchała a79130cd3b fix: refine upgrade error handling; improve the output (#232) 
* fix: refine upgrade error handling

* moar refinements to the output
 2019-03-14 10:20:30 +01:00
Michał Pierzchała b572a9cabc v1.4.1 2019-03-12 21:39:47 +01:00
Michał Pierzchała 52b0007bd9 fix: debugger-ui incorrect path (#226) 
Summary:
---------

Missed this one while moving files around in https://github.com/react-native-community/react-native-cli/pull/201.
Fixes https://github.com/react-native-community/react-native-cli/issues/225


Test Plan:
----------

Verified locally on a clean project.
 2019-03-12 21:38:44 +01:00
Michał Pierzchała 2057a9b3c9 fix: set proper peer dependencies (#227) 2019-03-12 21:31:12 +01:00
Michał Pierzchała e32dbb9978 v1.4.0 2019-03-12 17:43:48 +01:00
Michał Pierzchała 13383b9edb fix: re-export findPlugins under cli/core for backcompat with RN 0.59 (#224) 2019-03-12 16:06:07 +01:00
Matei Radu e4ab21e4eb fix: android unlink regression (#221) 
* Fix Android unlink regression

* Update regex to accept extra whitespaces

* Extract dependency regex string to own function

With this approach we have one source of truth for both the regex and
the dependency types.

* Rename dependency types to dependency configs

The Gradle documentation calls "configurations" what we have been
referring to as "types".
 2019-03-12 11:34:21 +01:00
Michał Pierzchała 069163376f chore: remove some unused files (#217) 2019-03-12 09:14:52 +01:00
Benoit Lemaire d70b10f645 fix: path to InitializeCore module in default metro config (#220) 
Summary:
---------

Fix path to React Native `InitializeCore` module in default metro config.
For some reason, this path was modified when moving the `loadMetroConfig.js` file in new `tools` directory.
In current released version (v1.3.2) of the cli, the path is the correct one, as seen in the [loadMetroConfig.js](https://github.com/react-native-community/react-native-cli/blob/%40react-native-community/cli%401.3.2/packages/cli/src/util/loadMetroConfig.js#L52) of v1.3.2.

Test Plan:
----------

Was trying out `react-native run-ios` / `run-android` commands, after a fresh `react-native init` with current master branch of the cli, and was facing following metro bundler error:

```
error: bundling failed: Error: Cannot find module '/Users/blemair/Code/foo/node_modules/react-native/Libraries/tools/InitializeCore'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:580:15)
    at Function.resolve (internal/modules/cjs/helpers.js:30:19)
    at Object.getModulesRunBeforeMainModule (/Users/blemair/Code/foo/node_modules/@react-native-community/cli/build/tools/loadMetroConfig.js:80:53)
[...]
```

After fixing the path, bundling error was gone.
 2019-03-11 22:37:52 +01:00
Michał Pierzchała 5d0a5d1451 chore: remove unnecessary checks for react peer dep (#216) 2019-03-11 17:07:31 +01:00
Mike Grabowski a56441021f chore: remove unnecessary noHelp option for a command (#215) 
`noHelp` doesn't work because we override `printHelpInformation` and we need to handle `description` (that can be undefined) manually
 2019-03-11 16:47:43 +01:00
Michał Pierzchała 5564634044 chore: simplify commander/minimist usage (#209) 
* chore: simplify commander/minimist usage

* feedback

* remove extra parse

* add options back

* rephrase comment

* remove excess whitespace
 2019-03-11 16:28:05 +01:00
Krzysztof Borowy ccc179737b fix: correct paths for eject command (#208) 
Summary:
---------

`eject` had wrong paths (pointing to old RN directories), so this PR fixes that.

Fixes #207 	

Test Plan:
----------

1. Init new project RN 0.59+
2. Remove `android` and/or `ios`
3. Use the `eject` command to generate ios/android projects
 2019-03-06 12:18:17 +01:00
Michał Pierzchała 82087ef2a9 fix: change diff links for upgrade command (#206) 
* fix: change diff links for upgrade command

* use prettier without @format pragma
 2019-03-05 21:17:34 +01:00
Drapich Piotr 885f2c28d4 chore: use @react-native-community/eslint-config (#205) 
Summary:
---------

I changed @callstack/eslint-config to @react-native-community/eslint-config and fixed all lint issues.


Test Plan:
----------

Green CI
 2019-03-05 20:52:51 +01:00
Michał Pierzchała 8ef2a97c2f chore: simplify cli structure and common tools (#201) 
Summary:
---------

Cleaning up the `packages/cli` structure. This might be pretty disruptive to already open PRs :D.

- Renamed `core` -> `tools`
- Moved `util` to `tools`
- Flatten-out `server/util`
- Create `commands` dir and put all commands there

```
packages/cli/src
├── bin.js
├── cliEntry.js
├── commands
│   ├── bundle
│   ├── dependencies
│   ├── eject
│   ├── index.js
│   ├── info
│   ├── init
│   ├── install
│   ├── library
│   ├── link
│   ├── logAndroid
│   ├── logIOS
│   ├── runAndroid
│   ├── runIOS
│   ├── server
│   └── upgrade
├── index.js
└── tools
    ├── ...
``` 

Fixes https://github.com/react-native-community/react-native-cli/issues/49

Test Plan:
----------

CI green
 2019-03-05 16:58:46 +01:00
Emin Khateeb 75c86c8f45 Update templates.js (#202) 
fixed issue that caused dev dependencies to be installed as regular dependencies
 2019-03-05 15:02:03 +01:00
Michał Pierzchała 041b7d789e chore: bump flow to 0.94 (#200) 
Summary:
---------

It's usually better to be on the latest available :D 

Test Plan:
----------

Green CI
 2019-03-04 18:11:24 +01:00
Christoph Nakazawa 45ade50a13 Merge pull request #198 from react-native-community/feat/remove-global-check 
feat: remove hacky check for faulty global react-native installation
 2019-03-04 11:54:09 +09:00
Héctor Ramos 9cbe1fba56 fix: Update links to issue tracker (#196) 
Summary:
---------

Some error messages direct the user to file a new issue. Update the URL to link to the community repository instead.

Test Plan:
----------

Did not test as it's a string replacement.
 2019-03-03 11:14:50 +01:00
Michał Pierzchała 7213bb8491 feat: remove flaky check for faulty global react-native bin 2019-03-03 10:52:46 +01:00
Mike Grabowski eead4d57d9 Publish 
- @react-native-community/[email protected]
 2019-02-27 23:02:25 +01:00
Mike Grabowski 36e7ace15c fix: let server to communicate with the browser (#194) 
Summary:
---------

Spotted after merging #193 - `localhost` was hardcoded here.

Test Plan:
----------

Turn on Chrome Debugger w/o this PR and see `Unauthorized` error in the console.
 2019-02-27 22:57:09 +01:00
Mike Grabowski 49a5fba760 Publish 
- @react-native-community/[email protected]
 2019-02-27 21:00:22 +01:00
Federico de86d0b586 fix: server should listening for all incoming requests by default (#193) 
* fix: server should listening for all incoming requests by default

* Update server.js
 2019-02-27 20:57:50 +01:00
Kacper Wiszczuk ec87ccb938 fix: fix link all (#188) 
Summary:
---------

Fix `linkAll` to link root assets.

@sijad can you test link with those changes?
 2019-02-22 22:50:42 +01:00
Michał Pierzchała 762c1fdf0c Publish 
- @react-native-community/[email protected]
 2019-02-22 17:23:39 +01:00
Michał Pierzchała 06036f5473 feat: improve upgrade to use rn-diff-purge (#176) 
Summary:
---------

Upgrading experience is a bit harsh for React Native. We either need to install global `react-native-git-upgrade` and try that, or patch projects manually using tools like [`rn-diff-purge`](https://github.com/pvinis/rn-diff-purge).

Since `rn-diff-purge` gets some recognition in RN core and website and it has an automated path of applying patches, I thought that it would be nice to use it in our `upgrade` command.

What the command does now:

1. Determine version to upgrade and run some validation checks
1. Fetch patch between current version and specified from [`rn-diff-purge`](https://github.com/pvinis/rn-diff-purge#version-changes) and rename diff app to current project name
	1. If the patch is empty, install RN and its peer deps
	1. Exit with success
1. Prepare for 3-way merge by creating temporary patch file and adding new git remote
1. Apply patch with a fallback to 3-way merge, exclude `package.json` because it will always be failing
1. Install RN and its peer deps
1. Cleanup temporary files and git remote
1. Exit with success

This PR is technically breaking change, so I'm cool with introducing a temporary new command or put old one behind a different name.

Test Plan:
----------

Added tests with various scenarios. 

Successfully upgrading to specified version:

<img width="648" alt="screenshot 2019-02-16 at 22 22 24" src="https://user-images.githubusercontent.com/5106466/52905364-75a84f00-3239-11e9-9c3a-d3612d194cbf.png">

Failed to fetch a non-existent diff:

<img width="680" alt="screenshot 2019-02-16 at 22 22 49" src="https://user-images.githubusercontent.com/5106466/52905365-75a84f00-3239-11e9-9e92-6fd410271151.png">

No upgrade needed:

<img width="904" alt="screenshot 2019-02-16 at 22 33 27" src="https://user-images.githubusercontent.com/5106466/52905501-4abefa80-323b-11e9-9fec-2e6a44ff09a4.png">

Dependency mismatch:

<img width="988" alt="screenshot 2019-02-16 at 22 36 04" src="https://user-images.githubusercontent.com/5106466/52905502-4abefa80-323b-11e9-92db-ed0d661e493c.png">

Upgrading to older version:

<img width="556" alt="screenshot 2019-02-16 at 22 39 50" src="https://user-images.githubusercontent.com/5106466/52905533-cfaa1400-323b-11e9-9685-d45e24cf0d97.png">
 2019-02-22 16:30:24 +01:00
Michał Pierzchała bd332b3add fix: setup_env script failure (#182) 
* fix: setup_env script failure

* chore: adjust the message and remove unused windows script

* fix: adjust platform check and wording

* chore: remove dot for continuity with error
 2019-02-22 09:16:19 +01:00
Eric Lewis 489ab232c0 allow absolute path for templates 2019-02-20 17:26:15 -05:00
Michał Pierzchała 27d4924a58 feat: refactor install to use link directly instead of spawning it (#180) 
Summary:
---------

Attempt No. 2 after https://github.com/react-native-community/react-native-cli/pull/178. Turned out I passed empty array as `platforms` argument to link, while I should pass `undefined`. We could actually add `--platforms` support to `install`/`uninstall` now, what do you think?

Test Plan:
----------

Uninstalling:

<img width="677" alt="screenshot 2019-02-19 at 13 42 54" src="https://user-images.githubusercontent.com/5106466/53015940-8ed51980-344c-11e9-9f22-0406c468a10d.png">

Installing: 

<img width="668" alt="screenshot 2019-02-19 at 13 43 02" src="https://user-images.githubusercontent.com/5106466/53015941-8ed51980-344c-11e9-8556-a6350f05536f.png">
 2019-02-19 13:54:36 +01:00
Mike Grabowski 760d384ae1 Publish 
- @react-native-community/[email protected]
 2019-02-18 17:57:33 +01:00
Mike Grabowski ce12f21ce1 fix: unlink not working (#177) 2019-02-18 17:54:14 +01:00
Mike Grabowski cf99cd1b2c Revert "feat: better logging for install/uninstall; less spawning; fix unlinking (#174)" 
This reverts commit 32cc3a2d75.
 2019-02-18 17:53:33 +01:00
Michał Pierzchała 32cc3a2d75 feat: better logging for install/uninstall; less spawning; fix unlinking (#174) 
Summary:
---------

- [x] use link/unlink directly from source instead of spawning
- [x] fix unlinking failing to get dependencies
- [x] improve logging

Test Plan:
----------

<img width="684" alt="screenshot 2019-02-15 at 23 40 29" src="https://user-images.githubusercontent.com/5106466/52888210-2996d500-317b-11e9-9a37-402de8f50167.png">
<img width="692" alt="screenshot 2019-02-15 at 23 40 50" src="https://user-images.githubusercontent.com/5106466/52888211-2996d500-317b-11e9-8b7e-2cdc4a4f6a94.png">
 2019-02-16 16:11:12 +01:00
Michał Pierzchała b119dd2ae6 Update cli README subheadings 2019-02-16 10:00:23 +01:00
Mehdi A 9bc53ff8ca docs: document the run-ios command (#175) 
document the --simulator argument for the react-native run-ios command to allow user to launch their app on a specific iOS simulator based by its official name

Regarding the #169 issue

cc @thymikee
 2019-02-16 09:58:52 +01:00
Mike Grabowski 74a5cb6ea2 Publish 
- @react-native-community/[email protected]
 - [email protected]
 2019-02-15 10:53:06 +01:00
Mike Grabowski 17b73b3e32 fix: printing error and unknown command messages when unnecessary (#171) 
Summary:
---------

The logic for printing an unknown command was always a hack and the one for printing a help when no command provided never worked.

I did a research and found out there's a recommended (Commander way) of doing this.

It also fixes a regression I've noticed in https://github.com/react-native-community/react-native-releases/issues/79#issuecomment-463933483

![](https://user-images.githubusercontent.com/5376380/52840468-f711bb80-312b-11e9-9bb3-65b9676e3132.png)

Test Plan:
----------

Run w/o command, run with wrong command.
 2019-02-15 10:46:47 +01:00
Dulmandakh 9390ad889f fix: exclude debug folder from findManifest command (#170) 
* exclude debug folder from findManifest command

* fix formatting

* fix lint
 2019-02-15 10:14:32 +01:00
Michał Pierzchała 3a3028d4f3 Publish 
- @react-native-community/[email protected]
 2019-02-14 08:40:13 +01:00
Michał Pierzchała 251e34a7b3 v1.2.1 2019-02-14 08:32:22 +01:00
Michael Diarmid 28d4de9733 fear: export getDefaultConfig (#167) 2019-02-14 06:55:15 +01:00