Commit Graph
7 Commits
Author SHA1 Message Date
Max BuckleyandClaude Opus 4.6 b3a2914982 fix: resolve compiler warnings in test files (#4944)
Summary:
- Fix compiler warnings in all 20 FAISS C++ test files
- Fixes include `-Wshadow`, `-Wunused-parameter`, and signed/unsigned comparisons

All changes are mechanical. No functional changes.

Part 13/13 of the compiler warnings cleanup (split from https://github.com/facebookresearch/faiss/issues/4810 per maintainer request).

Pull Request resolved: https://github.com/facebookresearch/faiss/pull/4944

Test Plan:
- [x] No functional changes — all fixes are mechanical renames and annotations

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Reviewed By: mnorris11

Differential Revision: D96996609

Pulled By: alibeklfc

fbshipit-source-id: 72555246a4ccf540eb5422e64018c8d5e2660dce
2026-03-20 10:21:55 -07:00
Michael Norris eff0898a13 Enable linting: lint config changes plus arc lint command (#3966)
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/3966

This actually enables the linting.

Manual changes:
- tools/arcanist/lint/fbsource-licenselint-config.toml
- tools/arcanist/lint/fbsource-lint-engine.toml

Automated changes:
`arc lint --apply-patches --take LICENSELINT --paths-cmd 'hg files faiss'`

Reviewed By: asadoughi

Differential Revision: D64484165

fbshipit-source-id: 4f2f6e953c94ef6ebfea8a5ae035ccfbea65ed04
2024-10-22 09:46:48 -07:00
Xiao Fu bf8bd6b689 Delete all remaining print (#3452)
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/3452

Delete all remaining print within the Tests to improve the readability and effectiveness of the codebase.

Reviewed By: junjieqi

Differential Revision: D57466393

fbshipit-source-id: 6ebd66ae2e769894d810d4ba7a5f69fc865b797d
2024-05-16 19:51:07 -07:00
Fernando Gasperi e3deb71cdb Enable for faiss tests (#3002)
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/3002

title

Reviewed By: jbardini

Differential Revision: D48266242

fbshipit-source-id: b53e186f1954916a90dc8dbba67963f40d0aead7
2023-08-14 08:03:40 -07:00
Matthijs Douze 371d9c2f3b Fix decoding of large fast_scan blocks (#2746)
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/2746

There was a bug in the decoding code for large blocks, see
https://github.com/facebookresearch/faiss/issues/2739

this diff adds a test that exposes the bug, and fixes it.

Reviewed By: alexanderguzhva

Differential Revision: D43872441

fbshipit-source-id: 2fb64bf850ab76acc2af0fec3179858cc7d4cac8
2023-03-10 03:51:46 -08:00
Alexandr Guzhva e7d5577dd0 Fix CircleCI format warnings (#2699)
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/2699

Remove a couple of blank lines

Reviewed By: algoriddle

Differential Revision: D43092258

fbshipit-source-id: 97a0e0a359562e93052d121ce4b5128b4f73524a
2023-02-07 12:17:42 -08:00
Matthijs Douze ab058456df Crop a ResidualCoarseQuantizer (#2683)
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/2683

Adds a small function and a test to demonstrate how to crop a RCQ to its first quantizers.
Also adds a SearchParameters to set the beam_factor of a RCQ.

Reviewed By: alexanderguzhva

Differential Revision: D42842378

fbshipit-source-id: b522269ce983cddc50c3d0e18b541954c5d7001d
2023-02-06 12:52:28 -08:00