mirror of
https://github.com/facebookresearch/faiss.git
synced 2026-10-12 02:13:36 +00:00
Justin Gibbs
66853ee41d
Summary: Pull Request resolved: https://github.com/facebookresearch/faiss/pull/4804 Valid neighbor indexes are in the range of [0, ntotal). Fix range check in NSG::search_on_graph() that accepted an index value of ntotal. NOTE: This data structure uses -1 as a termninal sentinal. The call to nsg::Graph::get_neighgbors() above the for loop that includes the upper bound check stops when encountering a negative index. This means the check for negative values has already occurred and does not need to be repeated inside the loop. Reviewed By: junjieqi, sh00s Differential Revision: D93040548 fbshipit-source-id: e1bde990a459c86dfaebdd2f780375b7922fc5f5
65 lines
1.8 KiB
C++
65 lines
1.8 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <cstring>
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
#include <faiss/Index.h>
|
|
#include <faiss/IndexFlat.h>
|
|
#include <faiss/IndexNSG.h>
|
|
|
|
#include <faiss/utils/random.h>
|
|
|
|
using namespace faiss;
|
|
|
|
TEST(IoCorrupted, NSGNeighborIdEqualsNtotal) {
|
|
// Build an NSG index
|
|
int d = 8, nb = 500;
|
|
std::vector<float> xb(nb * d);
|
|
faiss::rand_smooth_vectors(nb, d, xb.data(), 1234);
|
|
|
|
IndexNSGFlat index(d, 16);
|
|
index.add(nb, xb.data());
|
|
|
|
// Verify that NSG::search_on_graph() skips corrupt neighbor entries
|
|
// that would trigger access outside/above the bounds of the index by
|
|
// setting the LAST valid neighbor of every node to ntotal.
|
|
// get_neighbors returns neighbors until it hits a -1 sentinel,
|
|
// so setting the last non-sentinel entry preserves graph connectivity
|
|
// while ensuring the inner search loop encounters id == ntotal.
|
|
auto* graph = index.nsg.final_graph.get();
|
|
for (int i = 0; i < nb; i++) {
|
|
// Find the last valid (non-sentinel) neighbor slot
|
|
int last = -1;
|
|
for (int j = 0; j < graph->K; j++) {
|
|
if (graph->at(i, j) >= 0) {
|
|
last = j;
|
|
} else {
|
|
break;
|
|
}
|
|
}
|
|
if (last >= 0) {
|
|
graph->at(i, last) = nb; // inject ntotal
|
|
}
|
|
}
|
|
|
|
std::vector<float> xq(d);
|
|
faiss::rand_smooth_vectors(1, d, xq.data(), 5678);
|
|
std::vector<idx_t> I(1);
|
|
std::vector<float> D(1);
|
|
|
|
// Safely skipped without an exception or ASAN failure.
|
|
EXPECT_NO_THROW(index.search(1, xq.data(), 1, D.data(), I.data()));
|
|
|
|
// Result must be a valid node ID
|
|
EXPECT_GE(I[0], 0);
|
|
EXPECT_LT(I[0], nb);
|
|
}
|