A comment is a last resort, and these were not one: section banners,
doc headers naming what the declaration below already names, and
notes saying in prose what the next line says in code.
What is left is what the code cannot show -- an ordering that matters,
a platform quirk, why the obvious way fails.
Conform CompileFailure to LocalizedError so the underlying
message and collected diagnostics reach the user instead of
the opaque "LumaCore.CompileFailure error 1" default.
If document state has no manifests but the workspace still
holds package.json / node_modules from a prior process that
got killed before auto-save, the document is authoritative —
wipe the orphans so disk and document agree. Runs both at
ensureReady time and at install time, since install doesn't
go through ensureReady. Without the install-side check, Frida
reads the leftover manifest, sees the dep already satisfied,
and returns an empty install result.
Introduce CompilerDiagnostic and CompileFailure so callers
can pretty-print TypeScript errors in the frida-tools format
(path:line:character - category TS<code>: text). Tracer
hooks and custom-instrument compiles rewrite the on-disk
path to the user-facing display name.
Also fix a race in withCompilerDiagnostics: the events
subscriber was racing with esbuild's signals and could miss
.finished on fast failures, hanging the caller. Pre-create
the stream and await the events task.
No longer needed now that frida-core keeps the compiler backend
module resident for the process lifetime. Go back to creating a
fresh Compiler() per withCompilerDiagnostics call.
Fresh Compiler() per compile triggers frida_compiler_backend_init's
g_module_close, which can dlclose a module whose threads are still
executing — observed crashing on tracer instrument add / re-attach.
Cache one instance in CompilerWorkspace so the backend init runs
once and the runtime threads survive.
Also silence "result of 'try?' is unused" warnings on the
disposeInstrument calls by explicitly discarding the optional.
All model structs now conform to FetchableRecord +
PersistableRecord with snake_case table/column names.
GRDB handles Codable encoding/decoding automatically.
ProjectStore rewritten to use the type-safe query builder:
model.save(db), Model.fetchAll(db), Model.filter(...),
Model.deleteOne(db, key:) — no raw SQL remaining.
Move the core business logic for both subsystems:
Package management (CompilerWorkspace):
- PackageOperationQueue: serial async operation queue
- ESMBundleParser: Frida ESM bundle format parsing
- CompilerWorkspace: package install/remove/upgrade,
bundle building via Frida Compiler, workspace lifecycle
- CompilerWorkspacePaths: URL helpers
Collaboration (CollaborationSession):
- Portal bus state machine (connect, create/join room)
- Participant tracking, chat messaging
- Notebook sync protocol (add/update/delete/reorder)
- Uses AsyncEventSource for status change notifications
Both use ProjectStore for persistence instead of SwiftData.
Ole André Vadla Ravnås