go-gitea/git
1
0
Fork 0
mirror of https://github.com/go-gitea/git.git synced 2026-07-18 20:44:38 -04:00
Code Issues 12 Packages Projects Releases Wiki Activity

[GH-ISSUE #10] Make the linter happy #1

New Issue
Closed
opened 2026-02-16 10:23:43 -05:00 by yindo · 2 comments
yindo commented 2026-02-16 10:23:43 -05:00
Owner
Copy Link
Copy Source

Originally created by @tboerger on GitHub (Nov 12, 2016).
Original GitHub issue: https://github.com/go-gitea/git/issues/10

Currently we get a lot of issues with the linter, we should fix that.

# make lint
for PKG in code.gitea.io/git; do golint -set_exit_status $PKG || exit 1; done;
/Users/thomas/.golang/src/code.gitea.io/git/blob.go:28:1: exported method Blob.DataPipeline should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/command.go:43:7: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/command.go:43:7: exported const DEFAULT_TIMEOUT should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/command.go:109:1: comment on exported method Command.RunInDirBytes should be of the form "RunInDirBytes ..."
/Users/thomas/.golang/src/code.gitea.io/git/commit.go:42:35: exported method ParentID returns unexported type git.sha1, which can be annoying to use
/Users/thomas/.golang/src/code.gitea.io/git/commit.go:76:1: exported method Commit.IsImageFile should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/commit.go:98:1: comment on exported function AddChanges should be of the form "AddChanges ..."
/Users/thomas/.golang/src/code.gitea.io/git/commit.go:108:6: exported type CommitChangesOptions should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/commit.go:169:1: exported method Commit.CommitsCount should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/commit.go:173:1: exported method Commit.CommitsByRange should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/commit.go:177:1: exported method Commit.CommitsBefore should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/commit.go:181:1: exported method Commit.CommitsBeforeLimit should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/commit.go:185:1: exported method Commit.CommitsBeforeUntil should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/commit.go:193:1: exported method Commit.SearchCommits should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/commit.go:197:1: exported method Commit.GetFilesChangedSinceCommit should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/commit.go:201:1: exported method Commit.GetSubModules should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/commit.go:201:35: exported method GetSubModules returns unexported type *git.objectCache, which can be annoying to use
/Users/thomas/.golang/src/code.gitea.io/git/commit.go:239:1: exported method Commit.GetSubModule should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/commit_archive.go:13:6: exported type ArchiveType should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/commit_archive.go:16:2: exported const ZIP should have comment (or a comment on this block) or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/commit_archive.go:20:1: exported method Commit.CreateArchive should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/error.go:12:6: exported type ErrExecTimeout should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/error.go:16:1: exported function IsErrExecTimeout should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/error.go:25:6: exported type ErrNotExist should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/error.go:30:1: exported function IsErrNotExist should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/error.go:39:6: exported type ErrUnsupportedVersion should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/error.go:43:1: exported function IsErrUnsupportedVersion should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/git.go:13:7: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/git.go:15:1: exported function Version should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/git.go:23:2: exported var Prefix should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/git.go:41:1: comment on exported function BinVersion should be of the form "BinVersion ..."
/Users/thomas/.golang/src/code.gitea.io/git/hook.go:25:2: exported var ErrNotValidHook should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/hook.go:73:1: exported method Hook.Name should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/hook.go:105:2: exported const HookPathUpdate should have comment (or a comment on this block) or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo.go:25:7: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/repo.go:35:9: range var commitId should be commitID
/Users/thomas/.golang/src/code.gitea.io/git/repo.go:83:6: exported type CloneRepoOptions should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo.go:121:6: exported type PullRemoteOptions should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo.go:156:6: exported type CheckoutOptions should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_branch.go:14:7: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/repo_branch.go:14:7: exported const BRANCH_PREFIX should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_branch.go:27:1: exported method Repository.IsBranchExist should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_branch.go:84:1: comment on exported type DeleteBranchOptions should be of the form "DeleteBranchOptions ..." (with optional leading article)
/Users/thomas/.golang/src/code.gitea.io/git/repo_commit.go:145:1: exported method Repository.GetTagCommit should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_commit.go:186:5: exported var CommitsRangeSize should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_commit.go:213:1: exported method Repository.FileCommitsCount should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_commit.go:217:1: exported method Repository.CommitsByFileAndRange should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_commit.go:226:1: exported method Repository.FilesCountBetween should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_commit.go:269:1: exported method Repository.CommitsBetweenIDs should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_commit.go:281:1: exported method Repository.CommitsCountBetween should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_hook.go:7:1: exported method Repository.GetHook should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_hook.go:11:1: exported method Repository.Hooks should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_object.go:7:6: exported type ObjectType should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_object.go:10:2: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/repo_object.go:10:2: exported const OBJECT_COMMIT should have comment (or a comment on this block) or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_object.go:11:2: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/repo_object.go:12:2: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/repo_object.go:13:2: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/repo_tag.go:13:7: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/repo_tag.go:13:7: exported const TAG_PREFIX should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_tag.go:20:1: exported method Repository.IsTagExist should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_tag.go:24:1: exported method Repository.CreateTag should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/repo_tree.go:19:1: comment on exported method Repository.GetTree should be of the form "GetTree ..."
/Users/thomas/.golang/src/code.gitea.io/git/sha1.go:13:7: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/sha1.go:13:7: exported const EMPTY_SHA should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/sha1.go:48:1: receiver name s should be consistent with previous receiver name id for sha1
/Users/thomas/.golang/src/code.gitea.io/git/sha1.go:59:23: exported func MustID returns unexported type git.sha1, which can be annoying to use
/Users/thomas/.golang/src/code.gitea.io/git/sha1.go:68:23: exported func NewID returns unexported type git.sha1, which can be annoying to use
/Users/thomas/.golang/src/code.gitea.io/git/sha1.go:76:33: exported func MustIDFromString returns unexported type git.sha1, which can be annoying to use
/Users/thomas/.golang/src/code.gitea.io/git/sha1.go:82:33: exported func NewIDFromString returns unexported type git.sha1, which can be annoying to use
/Users/thomas/.golang/src/code.gitea.io/git/submodule.go:9:6: exported type SubModule should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/submodule.go:22:1: exported function NewSubModuleFile should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/submodule.go:67:10: if block ends with a return statement, so drop this else and outdent its block
/Users/thomas/.golang/src/code.gitea.io/git/tag.go:20:1: exported method Tag.Commit should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/tree.go:25:1: exported function NewTree should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/tree.go:110:1: exported method Tree.SubTree should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/tree_blob.go:12:1: exported method Tree.GetTreeEntryByPath should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/tree_blob.go:46:1: exported method Tree.GetBlobByPath should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:17:6: exported type EntryMode should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:22:2: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:23:2: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:24:2: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:25:2: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:26:2: don't use ALL_CAPS in Go names; use CamelCase
/Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:29:6: exported type TreeEntry should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:44:1: exported method TreeEntry.Name should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:48:1: exported method TreeEntry.Size should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:65:1: exported method TreeEntry.IsSubModule should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:69:1: exported method TreeEntry.IsDir should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:73:1: exported method TreeEntry.Blob should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:80:6: exported type Entries should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:108:1: exported method Entries.Sort should have comment or be unexported
/Users/thomas/.golang/src/code.gitea.io/git/utlis.go:83:1: exported function RefEndName should have comment or be unexported
Found 93 lint suggestions; failing.
make: *** [lint] Error 1
Originally created by @tboerger on GitHub (Nov 12, 2016). Original GitHub issue: https://github.com/go-gitea/git/issues/10 Currently we get a lot of issues with the linter, we should fix that. ``` # make lint for PKG in code.gitea.io/git; do golint -set_exit_status $PKG || exit 1; done; /Users/thomas/.golang/src/code.gitea.io/git/blob.go:28:1: exported method Blob.DataPipeline should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/command.go:43:7: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/command.go:43:7: exported const DEFAULT_TIMEOUT should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/command.go:109:1: comment on exported method Command.RunInDirBytes should be of the form "RunInDirBytes ..." /Users/thomas/.golang/src/code.gitea.io/git/commit.go:42:35: exported method ParentID returns unexported type git.sha1, which can be annoying to use /Users/thomas/.golang/src/code.gitea.io/git/commit.go:76:1: exported method Commit.IsImageFile should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/commit.go:98:1: comment on exported function AddChanges should be of the form "AddChanges ..." /Users/thomas/.golang/src/code.gitea.io/git/commit.go:108:6: exported type CommitChangesOptions should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/commit.go:169:1: exported method Commit.CommitsCount should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/commit.go:173:1: exported method Commit.CommitsByRange should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/commit.go:177:1: exported method Commit.CommitsBefore should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/commit.go:181:1: exported method Commit.CommitsBeforeLimit should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/commit.go:185:1: exported method Commit.CommitsBeforeUntil should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/commit.go:193:1: exported method Commit.SearchCommits should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/commit.go:197:1: exported method Commit.GetFilesChangedSinceCommit should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/commit.go:201:1: exported method Commit.GetSubModules should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/commit.go:201:35: exported method GetSubModules returns unexported type *git.objectCache, which can be annoying to use /Users/thomas/.golang/src/code.gitea.io/git/commit.go:239:1: exported method Commit.GetSubModule should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/commit_archive.go:13:6: exported type ArchiveType should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/commit_archive.go:16:2: exported const ZIP should have comment (or a comment on this block) or be unexported /Users/thomas/.golang/src/code.gitea.io/git/commit_archive.go:20:1: exported method Commit.CreateArchive should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/error.go:12:6: exported type ErrExecTimeout should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/error.go:16:1: exported function IsErrExecTimeout should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/error.go:25:6: exported type ErrNotExist should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/error.go:30:1: exported function IsErrNotExist should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/error.go:39:6: exported type ErrUnsupportedVersion should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/error.go:43:1: exported function IsErrUnsupportedVersion should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/git.go:13:7: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/git.go:15:1: exported function Version should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/git.go:23:2: exported var Prefix should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/git.go:41:1: comment on exported function BinVersion should be of the form "BinVersion ..." /Users/thomas/.golang/src/code.gitea.io/git/hook.go:25:2: exported var ErrNotValidHook should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/hook.go:73:1: exported method Hook.Name should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/hook.go:105:2: exported const HookPathUpdate should have comment (or a comment on this block) or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo.go:25:7: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/repo.go:35:9: range var commitId should be commitID /Users/thomas/.golang/src/code.gitea.io/git/repo.go:83:6: exported type CloneRepoOptions should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo.go:121:6: exported type PullRemoteOptions should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo.go:156:6: exported type CheckoutOptions should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_branch.go:14:7: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/repo_branch.go:14:7: exported const BRANCH_PREFIX should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_branch.go:27:1: exported method Repository.IsBranchExist should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_branch.go:84:1: comment on exported type DeleteBranchOptions should be of the form "DeleteBranchOptions ..." (with optional leading article) /Users/thomas/.golang/src/code.gitea.io/git/repo_commit.go:145:1: exported method Repository.GetTagCommit should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_commit.go:186:5: exported var CommitsRangeSize should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_commit.go:213:1: exported method Repository.FileCommitsCount should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_commit.go:217:1: exported method Repository.CommitsByFileAndRange should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_commit.go:226:1: exported method Repository.FilesCountBetween should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_commit.go:269:1: exported method Repository.CommitsBetweenIDs should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_commit.go:281:1: exported method Repository.CommitsCountBetween should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_hook.go:7:1: exported method Repository.GetHook should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_hook.go:11:1: exported method Repository.Hooks should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_object.go:7:6: exported type ObjectType should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_object.go:10:2: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/repo_object.go:10:2: exported const OBJECT_COMMIT should have comment (or a comment on this block) or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_object.go:11:2: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/repo_object.go:12:2: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/repo_object.go:13:2: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/repo_tag.go:13:7: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/repo_tag.go:13:7: exported const TAG_PREFIX should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_tag.go:20:1: exported method Repository.IsTagExist should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_tag.go:24:1: exported method Repository.CreateTag should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/repo_tree.go:19:1: comment on exported method Repository.GetTree should be of the form "GetTree ..." /Users/thomas/.golang/src/code.gitea.io/git/sha1.go:13:7: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/sha1.go:13:7: exported const EMPTY_SHA should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/sha1.go:48:1: receiver name s should be consistent with previous receiver name id for sha1 /Users/thomas/.golang/src/code.gitea.io/git/sha1.go:59:23: exported func MustID returns unexported type git.sha1, which can be annoying to use /Users/thomas/.golang/src/code.gitea.io/git/sha1.go:68:23: exported func NewID returns unexported type git.sha1, which can be annoying to use /Users/thomas/.golang/src/code.gitea.io/git/sha1.go:76:33: exported func MustIDFromString returns unexported type git.sha1, which can be annoying to use /Users/thomas/.golang/src/code.gitea.io/git/sha1.go:82:33: exported func NewIDFromString returns unexported type git.sha1, which can be annoying to use /Users/thomas/.golang/src/code.gitea.io/git/submodule.go:9:6: exported type SubModule should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/submodule.go:22:1: exported function NewSubModuleFile should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/submodule.go:67:10: if block ends with a return statement, so drop this else and outdent its block /Users/thomas/.golang/src/code.gitea.io/git/tag.go:20:1: exported method Tag.Commit should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/tree.go:25:1: exported function NewTree should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/tree.go:110:1: exported method Tree.SubTree should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/tree_blob.go:12:1: exported method Tree.GetTreeEntryByPath should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/tree_blob.go:46:1: exported method Tree.GetBlobByPath should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:17:6: exported type EntryMode should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:22:2: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:23:2: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:24:2: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:25:2: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:26:2: don't use ALL_CAPS in Go names; use CamelCase /Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:29:6: exported type TreeEntry should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:44:1: exported method TreeEntry.Name should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:48:1: exported method TreeEntry.Size should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:65:1: exported method TreeEntry.IsSubModule should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:69:1: exported method TreeEntry.IsDir should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:73:1: exported method TreeEntry.Blob should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:80:6: exported type Entries should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/tree_entry.go:108:1: exported method Entries.Sort should have comment or be unexported /Users/thomas/.golang/src/code.gitea.io/git/utlis.go:83:1: exported function RefEndName should have comment or be unexported Found 93 lint suggestions; failing. make: *** [lint] Error 1 ```
yindo added the kind/enhancement label 2026-02-16 10:23:43 -05:00
yindo closed this issue 2026-02-16 10:23:43 -05:00
yindo commented 2026-02-16 10:23:44 -05:00
Author
Owner
Copy Link
Copy Source

@lunny commented on GitHub (Nov 12, 2016):

I'm working on this

@lunny commented on GitHub (Nov 12, 2016): I'm working on this
yindo commented 2026-02-16 10:23:44 -05:00
Author
Owner
Copy Link
Copy Source

@lunny commented on GitHub (Nov 16, 2016):

This could be closed and I also change the protected branch setting to ask all the PR must pass drone check.

@lunny commented on GitHub (Nov 16, 2016): This could be closed and I also change the protected branch setting to ask all the PR must pass drone check.
yindo changed title from Make the linter happy to [GH-ISSUE #10] Make the linter happy 2026-06-05 16:30:40 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
kind/bug
kind/enhancement
kind/question
kind/testing
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
No Label kind/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: go-gitea/git#1
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?