go-gitea/git
1
0
Fork 0
mirror of https://github.com/go-gitea/git.git synced 2026-07-19 22:44:05 -04:00
Code Issues 12 Packages Projects Releases Wiki Activity

[GH-ISSUE #129] 'tagger' value should be assigned to both Author and Committer probably #12

New Issue
Open
opened 2026-02-16 10:23:46 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 10:23:46 -05:00
Owner
Copy Link
Copy Source

Originally created by @SagePtr on GitHub (Sep 19, 2018).
Original GitHub issue: https://github.com/go-gitea/git/issues/129

In cat-file output, regular commits have following keys:

author (one who wrote code and sent diff content)
committer (one who commited that code to repo or merged PR)

Tag commits have one key: tagger (which corresponds to user who made new tag)

Now, in repo_commit.go, function parseCommitData, tagger is assigned to commit.Author, and commit.Committer stays nil.

I think, for better compatibility, tagger should be assigned to both commit.Author and commit.Committer, because in this case tagger is both author of tag and committer of this tag.

This would also solve go-gitea/gitea#4961 issue when signatures are verified against Committer field, but Committer field is just nil for tag commit.

Originally created by @SagePtr on GitHub (Sep 19, 2018). Original GitHub issue: https://github.com/go-gitea/git/issues/129 In cat-file output, regular commits have following keys: author (one who wrote code and sent diff content) committer (one who commited that code to repo or merged PR) Tag commits have one key: tagger (which corresponds to user who made new tag) Now, in repo_commit.go, function parseCommitData, tagger is assigned to commit.Author, and commit.Committer stays nil. I think, for better compatibility, tagger should be assigned to both commit.Author and commit.Committer, because in this case tagger is both author of tag and committer of this tag. This would also solve go-gitea/gitea#4961 issue when signatures are verified against Committer field, but Committer field is just nil for tag commit.
yindo changed title from 'tagger' value should be assigned to both Author and Committer probably to [GH-ISSUE #129] 'tagger' value should be assigned to both Author and Committer probably 2026-06-05 16:30:43 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
kind/bug
kind/enhancement
kind/question
kind/testing
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: go-gitea/git#12
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?