mirror of
https://github.com/go-gitea/git.git
synced 2026-07-21 18:05:25 -04:00
[PR #124] [MERGED] Add parsing support for tag GPG signatures #128
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/go-gitea/git/pull/124
Author: @christopherjmedlin
Created: 6/16/2018
Status: ✅ Merged
Merged: 7/8/2018
Merged by: @jonasfranz
Base:
master← Head:master📝 Commits (3)
c8cc089Add parsing support for tag GPG signaturesd80a3b6Test that signature is not left in commit message071459aFix object not found error in test📊 Changes
5 files changed (+34 additions, -4 deletions)
View changed files
📝
commit.go(+6 -2)📝
repo_commit.go(+15 -2)📝
repo_commit_test.go(+12 -0)➕
tests/repos/repo1_bare/objects/3a/d28a9149a2864384548f3d17ed7f38014c9e8a(+0 -0)➕
tests/repos/repo1_bare/refs/tags/test(+1 -0)📄 Description
In trying to solve https://github.com/go-gitea/gitea/issues/4137, I realized that tag signatures lack the "gpgsig" prefix that commit signatures have. Instead it is put after the commit message. So I attempted to add support for this in the "parseCommitData" function.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.