[PR #124] [MERGED] Add parsing support for tag GPG signatures #128

Closed
opened 2026-02-16 10:24:12 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/git/pull/124
Author: @christopherjmedlin
Created: 6/16/2018
Status: Merged
Merged: 7/8/2018
Merged by: @jonasfranz

Base: masterHead: master


📝 Commits (3)

  • c8cc089 Add parsing support for tag GPG signatures
  • d80a3b6 Test that signature is not left in commit message
  • 071459a Fix object not found error in test

📊 Changes

5 files changed (+34 additions, -4 deletions)

View changed files

📝 commit.go (+6 -2)
📝 repo_commit.go (+15 -2)
📝 repo_commit_test.go (+12 -0)
tests/repos/repo1_bare/objects/3a/d28a9149a2864384548f3d17ed7f38014c9e8a (+0 -0)
tests/repos/repo1_bare/refs/tags/test (+1 -0)

📄 Description

In trying to solve https://github.com/go-gitea/gitea/issues/4137, I realized that tag signatures lack the "gpgsig" prefix that commit signatures have. Instead it is put after the commit message. So I attempted to add support for this in the "parseCommitData" function.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/git/pull/124 **Author:** [@christopherjmedlin](https://github.com/christopherjmedlin) **Created:** 6/16/2018 **Status:** ✅ Merged **Merged:** 7/8/2018 **Merged by:** [@jonasfranz](https://github.com/jonasfranz) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`c8cc089`](https://github.com/go-gitea/git/commit/c8cc08956d47fc538a9052d4acaa048eb62309da) Add parsing support for tag GPG signatures - [`d80a3b6`](https://github.com/go-gitea/git/commit/d80a3b64b6ef1cf8c9b123cadec3d1ba92a32810) Test that signature is not left in commit message - [`071459a`](https://github.com/go-gitea/git/commit/071459a79934a1436e270dc6a09d6e57da4e6b59) Fix object not found error in test ### 📊 Changes **5 files changed** (+34 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `commit.go` (+6 -2) 📝 `repo_commit.go` (+15 -2) 📝 `repo_commit_test.go` (+12 -0) ➕ `tests/repos/repo1_bare/objects/3a/d28a9149a2864384548f3d17ed7f38014c9e8a` (+0 -0) ➕ `tests/repos/repo1_bare/refs/tags/test` (+1 -0) </details> ### 📄 Description In trying to solve https://github.com/go-gitea/gitea/issues/4137, I realized that tag signatures lack the "gpgsig" prefix that commit signatures have. Instead it is put after the commit message. So I attempted to add support for this in the "parseCommitData" function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 10:24:12 -05:00
yindo closed this issue 2026-02-16 10:24:12 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: go-gitea/git#128