[PR #36] [MERGED] Add GPG payload to commit information if present #45

New Issue

2026-02-16T10:23:56-05:00

yindo commented

2026-02-16 10:23:56 -05:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/git/pull/36
Author: @sapk
Created: 3/8/2017
Status: ✅ Merged
Merged: 3/13/2017
Merged by: @lunny

Base: master ← Head: add-gpg-signature

📝 Commits (2)

1395a17 Add GPG payload to commit information if present
335d1be Fix missing data in payload + leading space in Signature

📊 Changes

2 files changed (+26 additions, -0 deletions)

View changed files

📝 commit.go (+20 -0)
📝 repo_commit.go (+6 -0)

📄 Description

based on : https://github.com/git/git/blob/3bc53220cb2dcf709f7a027a3f526befd021d858/commit.c#L1128
I have to do further testing to determine if the struct CommitGPGSignature could not be replace by a simple string representing directly CommitGPGSignature.Signature. Since payload can maybe re-created from the rest of data in Commit struct.

If we don't care about duplicate of data at this stage it will simplify treatment after since payload and signature (+ public key from keystore in gitea) is only needed to verify the signed commit. https://github.com/git/git/blob/2cc2e70264e0fcba04f9ef791d144bbc8b501206/gpg-interface.c#L204

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/git/pull/36 **Author:** [@sapk](https://github.com/sapk) **Created:** 3/8/2017 **Status:** ✅ Merged **Merged:** 3/13/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `add-gpg-signature` --- ### 📝 Commits (2) - [`1395a17`](https://github.com/go-gitea/git/commit/1395a17c1a5a05a465032519932794c486e43559) Add GPG payload to commit information if present - [`335d1be`](https://github.com/go-gitea/git/commit/335d1be33a8b2845aca44af909f55c880914e912) Fix missing data in payload + leading space in Signature ### 📊 Changes **2 files changed** (+26 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `commit.go` (+20 -0) 📝 `repo_commit.go` (+6 -0) </details> ### 📄 Description based on : https://github.com/git/git/blob/3bc53220cb2dcf709f7a027a3f526befd021d858/commit.c#L1128 I have to do further testing to determine if the struct CommitGPGSignature could not be replace by a simple string representing directly CommitGPGSignature.Signature. Since payload can maybe re-created from the rest of data in Commit struct. If we don't care about duplicate of data at this stage it will simplify treatment after since payload and signature (+ public key from keystore in gitea) is only needed to verify the signed commit. https://github.com/git/git/blob/2cc2e70264e0fcba04f9ef791d144bbc8b501206/gpg-interface.c#L204 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 10:23:56 -05:00

yindo closed this issue

2026-02-16 10:23:56 -05:00

yindo referenced this issue

2026-02-16 10:23:58 -05:00

[PR #45] [MERGED] Add GetLatestCommitTime #53

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: go-gitea/git#45