[PR #42] [MERGED] Add tests for RunInDirTimeoutPipeline #50

New Issue

2026-02-16T10:23:57-05:00

yindo commented

2026-02-16 10:23:57 -05:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/git/pull/42
Author: @typeless
Created: 4/8/2017
Status: ✅ Merged
Merged: 4/8/2017
Merged by: @appleboy

Base: master ← Head: test-command-timeout

📝 Commits (1)

f453b38 Add tests for RunInDirTimeoutPipeline

📊 Changes

1 file changed (+43 additions, -0 deletions)

View changed files

➕ command_test.go (+43 -0)

📄 Description

For #41

Caveats:

The tests are only run when -race enabled
The test for 'no timeout happening scenario' takes long time to run, about 13 seconds for 1000 repetitions on my laptop.
The testing loops might not be necessary. Under the -race enabled, the race get positive in the first round for TestRunInDirTimeoutPipelineAlwaysTimeout.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/git/pull/42 **Author:** [@typeless](https://github.com/typeless) **Created:** 4/8/2017 **Status:** ✅ Merged **Merged:** 4/8/2017 **Merged by:** [@appleboy](https://github.com/appleboy) **Base:** `master` ← **Head:** `test-command-timeout` --- ### 📝 Commits (1) - [`f453b38`](https://github.com/go-gitea/git/commit/f453b381b002d52959d35723abcd700707fecf2c) Add tests for RunInDirTimeoutPipeline ### 📊 Changes **1 file changed** (+43 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `command_test.go` (+43 -0) </details> ### 📄 Description For #41 Caveats: 1. The tests are only run when -race enabled 2. The test for 'no timeout happening scenario' takes long time to run, about 13 seconds for 1000 repetitions on my laptop. 3. The testing loops might not be necessary. Under the -race enabled, the race get positive in the first round for TestRunInDirTimeoutPipelineAlwaysTimeout. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 10:23:57 -05:00

yindo closed this issue

2026-02-16 10:23:57 -05:00

yindo referenced this issue

2026-02-16 10:23:59 -05:00

[PR #50] [MERGED] Update MAINTAINERS #58

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: go-gitea/git#50