mirror of
https://github.com/gravitational/teleport.git
synced 2026-10-12 02:15:01 +00:00
Chris Thach
69cbcafd0e
* Fix feature watcher panic on nil cluster features. Signed-off-by: Chris Thach <[email protected]> * Pass ctx explicitly to startFeatureWatcher. Signed-off-by: Chris Thach <[email protected]> --------- Signed-off-by: Chris Thach <[email protected]>
76 lines
2.5 KiB
Go
76 lines
2.5 KiB
Go
/*
|
|
* Teleport
|
|
* Copyright (C) 2024 Gravitational, Inc.
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
package web
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/gravitational/teleport/api/client/proto"
|
|
)
|
|
|
|
// SetClusterFeatures sets the flags for supported and unsupported features.
|
|
// TODO(mcbattirola): make method unexported, fix tests using it to set
|
|
// test modules instead.
|
|
func (h *Handler) SetClusterFeatures(features proto.Features) {
|
|
h.Mutex.Lock()
|
|
defer h.Mutex.Unlock()
|
|
|
|
h.clusterFeatures = features
|
|
}
|
|
|
|
// GetClusterFeatures returns flags for supported and unsupported features.
|
|
func (h *Handler) GetClusterFeatures() proto.Features {
|
|
h.Mutex.Lock()
|
|
defer h.Mutex.Unlock()
|
|
|
|
return h.clusterFeatures
|
|
}
|
|
|
|
// startFeatureWatcher periodically pings the auth server and updates `clusterFeatures`.
|
|
// Must be called only once per `handler`, otherwise it may close an already closed channel
|
|
// which will cause a panic.
|
|
// The watcher doesn't ping the auth server immediately upon start because features are
|
|
// already set by the config object in `NewHandler`.
|
|
func (h *Handler) startFeatureWatcher(ctx context.Context) {
|
|
ticker := h.clock.NewTicker(h.cfg.FeatureWatchInterval)
|
|
h.logger.InfoContext(ctx, "Proxy handler features watcher has started", "interval", h.cfg.FeatureWatchInterval)
|
|
|
|
defer ticker.Stop()
|
|
for {
|
|
select {
|
|
case <-ticker.Chan():
|
|
h.logger.InfoContext(ctx, "Pinging auth server for features")
|
|
pingResponse, err := h.GetProxyClient().Ping(ctx)
|
|
if err != nil {
|
|
h.logger.ErrorContext(ctx, "Auth server ping failed", "error", err)
|
|
continue
|
|
}
|
|
|
|
if pingResponse.ServerFeatures != nil {
|
|
h.SetClusterFeatures(*pingResponse.ServerFeatures)
|
|
h.logger.InfoContext(ctx, "Done updating proxy features", "features", pingResponse.ServerFeatures)
|
|
}
|
|
|
|
case <-ctx.Done():
|
|
h.logger.InfoContext(ctx, "Feature service has stopped")
|
|
return
|
|
}
|
|
}
|
|
}
|