mirror of
https://github.com/gravitational/teleport.git
synced 2026-10-12 02:15:01 +00:00
Tiago Scolari
c929a85c76
* join: initial tests to support Github scoped join method
* proto: add Github to ScopedTokenSpec proto
* proto: generate joining.v1.Github
* join: normalize GitHub method behind the provision.Token interface
This captures that the change adds the getter across the interface
layers (types.ProvisionToken, provision.Token, scoped adapter), the
validation, and the round-trip/ equivalence tests
* join: use interface in lib/join/githubactions instead of literal token type
This allows `CheckGithubIDToken` to work with both scoped and non-scoped
tokens.
* join: add test for Bot with Github scoped token
* join: refactor Bot test for bound_keypair to use new helper
* join: explicitly disallow single_use tokens on scoped github join method
Because delegated OIDC joins do not consume them, allowing unintended
unlimited reuse. Proper enforcement requires a separate common Join service change.
* lint: exclude lib/join/jointest from "testing/testify" linter rules
This is a helper-test package: It can't be `_test` because it needs to
be imported by other tests, and it needs the testing/testify package to
fulfill its purpose.
* tests: add negative bot join test case
* Remove testing packages from jointest
This removes any testing packages reference from the jointest package,
which will instead return errors for the caller to verify.
This ensures that no test symbol is leaked into this package.
* Revert "Remove testing packages from jointest"
This reverts commit ca29de6a61.
* Move new helpers from jointest down to the `join` pkg
This moves the new helpers added to `joingtest` to the same package
where they are being called (`join`).
There's the potential for these helpers to be reused, but we can move
them around when/if we get there.
* Fix tests the diverged in master and remove jointest exceptions
from the golangci.yaml