mirror of
https://github.com/horizon-rust/horizon.git
synced 2026-11-07 17:21:49 -10:00
port map: client2-014 rows the narrator and the fixer screens have moved on
Twenty-three rows were stale. Fifteen said a screen's narration needed no port because the narrator was missing: crates/horizon-narrator and screen_narrator.rs exist now, so they cite the function that does each job (screen_info.rs::confirm and ::level_loading, Title::narration, Screen::narration, the five Screen narration functions in horizon-narrator/src/screen.rs and screen_narrator.rs), and the two that belong to screens Horizon does not have are missing rather than skipped. The other eight: the pause menu's report bugs, feedback and player reporting icons are live and its now-playing song is drawn by draw_music_toast; the backup's waiting screen does hold input; Horizon installs data packs, so the datapack failure screen is missing because it does not exist, not because packs are never loaded; and the upgrade progress screen and its Cancel do exist, with no aborted screen after them.
This commit is contained in:
1 parent
0c027235cf
commit
54a006d4ef
1 file changed
+23
-23
@@ -3,7 +3,7 @@ ConfirmLinkScreen.addAdditionalText port crates/horizon-client/src/game/server_l
|
||||
ConfirmLinkScreen.addButtons port crates/horizon-client/src/game/server_links.rs::Game::confirm_link_click Yes opens the browser, Copy Link copies, No goes back; 100 wide
|
||||
ConfirmLinkScreen.confirmLinkNow port crates/horizon-client/src/game/server_links.rs::Game::click_link opens the prompt when Prompt on Links is on; gap: minor: the trusted flag is not passed
|
||||
ConfirmLinkScreen.confirmLink inline crates/horizon-client/src/game/server_links.rs::Game::click_link the button's action, folded into click_link
|
||||
ConfirmScreen.getNarrationMessage skip:other screen-reader narration; Horizon has no narrator
|
||||
ConfirmScreen.getNarrationMessage port crates/horizon-client/src/game/screen_info.rs::confirm the title and the message joined for the narrator (PackConfirmScreen, ConfirmLinkScreen, DialogScreen.WarningScreen); the confirm screens the menus build narrate themselves in title.rs::Title::narration and multiplayer.rs::Screen::narration
|
||||
ConfirmScreen.addMessage port crates/horizon-client/src/confirm_screen.rs::Confirm::new message wrapped to width - 50, 15 rows at most, centred
|
||||
ConfirmScreen.addButtons port crates/horizon-client/src/confirm_screen.rs::Confirm::answer_at Yes and No buttons; the answer comes from the click position
|
||||
ConfirmScreen.tick inline crates/horizon-client/src/confirm_screen.rs::Confirm::draw_active the 20-tick delay is a 1000 ms timer kept by the caller; buttons are greyed while it runs
|
||||
@@ -25,14 +25,14 @@ CreateFlatWorldScreen.DetailsList.populateList inline crates/horizon-client/src/
|
||||
CreateFlatWorldScreen.DetailsList.resetRows inline crates/horizon-client/src/title/flat.rs::draw_layers nothing to rebuild; rows are drawn from the settings each frame
|
||||
CreateFlatWorldScreen.DetailsList.deleteLayer port crates/horizon-client/src/title/flat.rs::State::remove_selected removes the selected layer; gap: minor: the next selection after a delete is not checked
|
||||
CreateFlatWorldScreen.DetailsList.HeaderEntry.extractContent port crates/horizon-client/src/title/flat.rs::draw_layers Layer and Height column titles
|
||||
CreateFlatWorldScreen.DetailsList.HeaderEntry.getNarration skip:other narration text; Horizon has no narrator
|
||||
CreateFlatWorldScreen.DetailsList.HeaderEntry.getNarration port crates/horizon-client/src/title/flat.rs::draw_layers the list's first row narrates the header, "Layer Material. Height"; the layer rows below it are narrator.select plus the height
|
||||
CreateFlatWorldScreen.DetailsList.LayerEntry.extractContent port crates/horizon-client/src/title/flat.rs::draw_layers slot, block name and the Top, Bottom or height label
|
||||
CreateFlatWorldScreen.DetailsList.LayerEntry.getDisplayItem port crates/horizon-client/src/title/flat.rs::layer_icon water and lava use the bucket sprites
|
||||
CreateFlatWorldScreen.DetailsList.LayerEntry.blitSlot port crates/horizon-client/src/title/flat.rs::slot slot frame and icon
|
||||
CreditsAndAttributionScreen.init port crates/horizon-client-render/src/options_ui.rs::OptionsUi::layout Credits page: Credits, Attribution and Licenses buttons; gap: unsure whether Attribution and Licenses open links here
|
||||
CreditsAndAttributionScreen.openCreditsScreen port crates/horizon-client/src/game/win.rs::Game::open_win_screen rolls the credits without the poem, then returns here
|
||||
DatapackLoadFailureScreen.init missing minor: Horizon loads no data packs, so there is no datapack failure screen
|
||||
DatapackLoadFailureScreen.extractRenderState missing minor: same as init, no datapack failure screen
|
||||
DatapackLoadFailureScreen.init missing gap: minor: no datapack failure screen; a pack that fails to install is logged (game.rs:12109-12111) and the world opens with the packs it has
|
||||
DatapackLoadFailureScreen.extractRenderState missing gap: minor: same as init, there is no failure screen to draw; a failed pack install only reaches the log
|
||||
DeathScreen.exitToTitleScreen port crates/horizon-client/src/game/screens.rs::Game::death_confirm_answer Yes leaves the world; gap: minor: the leave and title hand-off is one close_world call
|
||||
DeathScreen.extractRenderState port crates/horizon-client/src/game/screens.rs::Game::draw_death_screen gap: minor: no draft-report badge on the title button (reporting service)
|
||||
DeathScreen.visitText port crates/horizon-client/src/game/screens.rs::Game::draw_death_screen title at double size, cause and score lines
|
||||
@@ -46,31 +46,31 @@ DirectJoinServerScreen.onSelect port crates/horizon-client/src/multiplayer.rs::S
|
||||
DirectJoinServerScreen.removed port crates/horizon-client/src/title.rs::Title::remember_direct_address saves the address to last_server; gap: minor: the options file write is not in this fn
|
||||
DirectJoinServerScreen.extractRenderState port crates/horizon-client/src/multiplayer.rs::Screen::draw title, label and address field (Screen::Direct arm)
|
||||
DisconnectedScreen.init port crates/horizon-client/src/multiplayer.rs::Screen::buttons reason text and the disconnected buttons; gap: minor: no Report to Server or open-report-folder button
|
||||
DisconnectedScreen.getNarrationMessage skip:other narration text; Horizon has no narrator
|
||||
DisconnectedScreen.getNarrationMessage port crates/horizon-client/src/multiplayer.rs::Screen::narration disconnect.lost and the reason, joined
|
||||
ErrorScreen.init port crates/horizon-client/src/title.rs::Title::buttons Cancel button of the error mode (Mode::Error arm)
|
||||
ErrorScreen.extractRenderState port crates/horizon-client/src/title.rs::Title::draw the error title and message (Mode::Error arm)
|
||||
ErrorScreen.extractBackground port crates/horizon-client/src/title.rs::Title::draw gap: minor: the flat gradient is replaced by the title background
|
||||
FaviconTexture.forWorld port crates/horizon-client/src/title.rs::Title::icon the world row's icon texture
|
||||
FaviconTexture.forServer port crates/horizon-client/src/multiplayer.rs::ping_all server icon keyed by address, from the ping
|
||||
FaviconTexture.clear inline crates/horizon-client/src/multiplayer.rs::ping_all icon dropped when the ping has no favicon
|
||||
FileFixerAbortedScreen.getNarrationMessage skip:other narration text; Horizon has no narrator
|
||||
FileFixerAbortedScreen.init missing minor: no upgrade-aborted screen; Horizon has no world-fixer cancel flow
|
||||
FileFixerAbortedScreen.addButtons missing minor: Back and Report Bug buttons of the aborted-upgrade screen
|
||||
FileFixerAbortedScreen.keyPressed missing minor: Escape on the aborted-upgrade screen
|
||||
FileFixerAbortedScreen.getNarrationMessage missing the aborted-upgrade screen does not exist (see init), so nothing narrates it
|
||||
FileFixerAbortedScreen.init missing gap: minor: FileFixerProgressScreen exists with its Cancel button (level_loading.rs::draw_file_fixer), but a cancelled upgrade goes straight back to the title (game.rs:19411-19416); no aborted screen
|
||||
FileFixerAbortedScreen.addButtons missing gap: minor: Back and Report Bug have no aborted screen to sit on (see init)
|
||||
FileFixerAbortedScreen.keyPressed missing gap: minor: Escape on the aborted screen; the screen does not exist (see init)
|
||||
GenericMessageScreen.init port crates/horizon-client-render/src/level_loading.rs::draw_progress centred message line while a world opens; gap: minor: no progress bar, the text is the loader's stage line
|
||||
GenericMessageScreen.repositionElements skip:ui layout only
|
||||
GenericMessageScreen.extractBackground port crates/horizon-client-render/src/ui.rs::menu_background the menu background behind the message
|
||||
GenericWaitingScreen.createWaitingWithoutButton port crates/horizon-client/src/title.rs::Title::start_backup backup runs in the background; gap: minor: no waiting screen blocks input while it runs
|
||||
GenericWaitingScreen.createWaitingWithoutButton port crates/horizon-client/src/title.rs::Title::start_backup the backup runs on its own thread while Mode::Backup draws the waiting screen with no buttons, so input goes nowhere until it finishes
|
||||
GenericWaitingScreen.createWaiting skip:service waiting screen while a report is sent (reporting)
|
||||
GenericWaitingScreen.createCompleted skip:service result screen after a report (reporting)
|
||||
GenericWaitingScreen.init skip:service layout of the report waiting screen (reporting)
|
||||
GenericWaitingScreen.tick skip:service the report button's delay (reporting)
|
||||
GenericWaitingScreen.extractRenderState port crates/horizon-client/src/title.rs::Title::draw_with_items Mode::Backup draws the waiting title, the message and the animated dots while the backup runs; the Created/Failed toast follows when it finishes
|
||||
GenericWaitingScreen.shouldCloseOnEsc skip:service Escape on the report waiting screen (reporting)
|
||||
GenericWaitingScreen.getNarrationMessage skip:other narration text; Horizon has no narrator
|
||||
GenericWaitingScreen.getNarrationMessage port crates/horizon-client/src/title.rs::Title::narration Mode::Backup: selectWorld.waitingForBackup.title and its message, joined
|
||||
InBedChatScreen.init port crates/horizon-client/src/game/chat.rs::Game::draw_chat_screen Leave Bed button over the chat; its click is in chat_click
|
||||
InBedChatScreen.onPlayerWokeUp port crates/horizon-client/src/game/chat.rs::Game::tick_in_bed_chat closes the chat, or turns it into the plain chat if text was typed; gap: minor: polled each tick, not on the wake event
|
||||
LevelLoadingScreen.updateNarratedWidget skip:other narration text; Horizon has no narrator
|
||||
LevelLoadingScreen.updateNarratedWidget port crates/horizon-client/src/game/screen_info.rs::level_loading loading.progress with the server progress floored to a percent, in the title's place, said again every 2 s
|
||||
LevelLoadingScreen.extractChunksForRendering port crates/horizon-client-render/src/level_loading.rs::draw chunk status colours; gap: minor: the debug red centre square is not drawn
|
||||
LevelLoadingScreen.getNetherPortalSprite port crates/horizon-client-render/src/hud_overlays.rs::portal_overlay draws the block/nether_portal sprite
|
||||
LoadingOverlay.extractRenderState port crates/horizon-client/src/game.rs::Game::render the reload screen's progress bar; gap: player: no Mojang logo and no fade in or out
|
||||
@@ -87,14 +87,14 @@ MenuScreens.register skip:data registry of menu types; Horizon reads them from
|
||||
MenuScreens.selfTest skip:debug startup check that every menu has a screen
|
||||
MenuScreens.ScreenConstructor.fromPacket port crates/horizon-client/src/game/remote.rs::Game::remote_open_screen builds the screen from the open-screen packet and sets the container menu
|
||||
NoticeWithLinkScreen.init missing minor: no symlink warning when a world or pack folder is a symlink
|
||||
NoticeWithLinkScreen.getNarrationMessage skip:other narration text; Horizon has no narrator
|
||||
NoticeWithLinkScreen.getNarrationMessage missing the symlink warning screen does not exist (see init), so nothing narrates it
|
||||
OutOfMemoryScreen.init missing minor: unsure: no out-of-memory screen; Horizon does not handle allocation failures this way
|
||||
PauseScreen.added skip:service friend list listener on the pause screen (social)
|
||||
PauseScreen.init port crates/horizon-client/src/game/screens.rs::pause_buttons button layout; the title is drawn in draw_pause_menu
|
||||
PauseScreen.createPauseMenu port crates/horizon-client/src/game/screens.rs::pause_buttons gap: player: Report Bugs, Feedback and Player Reporting icons are inactive, and no Mods button
|
||||
PauseScreen.createPauseMenu port crates/horizon-client/src/game/screens.rs::pause_buttons gap: minor: no Mods button; the report bugs, feedback, friends and player reporting icons are all live (icon_active, screens.rs:144-151)
|
||||
PauseScreen.getCustomAdditions port crates/horizon-client/src/game/screens.rs::Game::pause_screen_additions the pause_screen_additions tag: one dialog, else minecraft:custom_options, else the server links row
|
||||
PauseScreen.addCustomDialogButtons port crates/horizon-client/src/game/screens.rs::Game::pause_click one full-width button in row 3 (id 14), labelled by computeExternalTitle; the server links fallback opens the links screen (id 11)
|
||||
PauseScreen.extractRenderState port crates/horizon-client/src/game/screens.rs::Game::draw_pause_menu gap: minor: no now-playing toast and no draft-report badge
|
||||
PauseScreen.extractRenderState port crates/horizon-client/src/game/screens.rs::Game::draw_pause_menu gap: minor: no draft-report badge; the now-playing song on the pause menu is drawn by music.rs::Game::draw_music_toast, not here
|
||||
PauseScreen.rendersNowPlayingToast port crates/horizon-client/src/game/music.rs::Game::draw_music_toast on the pause menu the song name is drawn under the Pause and Pause and Toast settings while music is audible, instead of the toast; the Music Toast option still decides whether the toast exists
|
||||
PauseScreen.openScreenButton inline crates/horizon-client/src/game/screens.rs::Game::pause_click the Advancements, Stats, Options and World Options actions
|
||||
PresetFlatWorldScreen.getLayerInfoFromString inline crates/horizon-client/src/title/flat.rs::FlatSettings::parse one layer of the share text, parsed in the same loop
|
||||
@@ -118,7 +118,7 @@ RecoverWorldDataScreen.attemptRestore port crates/horizon-client/src/title.rs::T
|
||||
RecoverWorldDataScreen.buildInfo port crates/horizon-client/src/title.rs::recover_info "State from <date>: " and the issue, green No issues / red Missing file or the read error; nothing for a level.dat_old that is just missing
|
||||
RecoverWorldDataScreen.collectIssue port crates/horizon-client/src/title.rs::recover_issues the level.dat and level.dat_old issues the screen and the restore both read (save::level_dat_issue)
|
||||
RecoverWorldDataScreen.repositionElements port crates/horizon-client/src/title.rs::recover_buttons_top the column of title, message, issues, the restore row and Back, 8 apart, centred; the widgets themselves are built in Title::buttons
|
||||
RecoverWorldDataScreen.getNarrationMessage skip:other narration text; Horizon has no narrator
|
||||
RecoverWorldDataScreen.getNarrationMessage port crates/horizon-client/src/title.rs::Title::narration Mode::Recover: recover_world.title then recover_world.message with the folder name
|
||||
Screen.extractRenderStateWithTooltipAndSubtitles port crates/horizon-client/src/game.rs::Game::hud_layers draws the current screen's layer and tooltips; unsure about subtitles
|
||||
Screen.setInitialFocus skip:ui keyboard focus starts on the first widget; Horizon draws its own focus
|
||||
Screen.isInputCaptured port crates/horizon-client/src/title.rs::Title::has_caret_field gap: minor: only the title screen's text fields
|
||||
@@ -131,13 +131,13 @@ Screen.extractPanorama port crates/horizon-client-render/src/gfx/panorama.rs::Pa
|
||||
Screen.extractMenuBackground port crates/horizon-client-render/src/ui.rs::menu_background the dirt background with blur
|
||||
Screen.extractMenuBackgroundTexture port crates/horizon-client-render/src/ui.rs::menu_background gap: minor: only the standard background texture
|
||||
Screen.isValidCharacterForName port crates/horizon-client/src/game/block_editor.rs::valid_character_for_name structure and command block editors' name field: one `:` before any `/`, `/` only after it
|
||||
Screen.scheduleNarration skip:other narration timing; Horizon has no narrator
|
||||
Screen.shouldRunNarration skip:other narration gate; Horizon has no narrator
|
||||
Screen.handleDelayedNarration skip:other narration timing; Horizon has no narrator
|
||||
Screen.runNarration skip:other narration output; Horizon has no narrator
|
||||
Screen.updateNarratedWidget skip:other narration of widgets; Horizon has no narrator
|
||||
Screen.findNarratableWidget skip:other narration focus search; Horizon has no narrator
|
||||
Screen.updateNarratorStatus skip:other narrator option toggle only; Horizon has no narrator output
|
||||
Screen.scheduleNarration port crates/horizon-narrator/src/screen.rs::ScreenNarration::schedule the delay, the suppression and the trigger of one narration; schedule_now, after_mouse_move, after_mouse_action, after_keyboard_action and after_status_change are the vanilla entry points
|
||||
Screen.shouldRunNarration port crates/horizon-client/src/screen_narrator.rs::ScreenNarrator::frame_with GameNarrator.isActive decides it: while the narrator cannot speak the screens still record and the narration is marked said, so turning it on says only what changed
|
||||
Screen.handleDelayedNarration port crates/horizon-narrator/src/screen.rs::ScreenNarration::due the trigger of a narration due now, once the delay and the suppression have passed; the frame says it
|
||||
Screen.runNarration port crates/horizon-narrator/src/screen.rs::ScreenNarration::run rebuilds the narration and returns what to say now, empty for nothing
|
||||
Screen.updateNarratedWidget port crates/horizon-client/src/screen_narrator.rs::update_narrated_widget the active narratables in tab order, the one findNarratableWidget picks, with its position or how to navigate
|
||||
Screen.findNarratableWidget port crates/horizon-narrator/src/screen.rs::find_narratable the first focused narratable that is not the last said, else the highest priority one, else the last said focused one
|
||||
Screen.updateNarratorStatus port crates/horizon-client/src/screen_narrator.rs::ScreenNarrator::status_changed once the narrator is turned on the open screen is narrated two seconds later (after_status_change)
|
||||
TitleScreen.tick skip:service Realms notifications and the friend request count (social)
|
||||
TitleScreen.init port crates/horizon-client/src/title.rs::Title::buttons main menu buttons; the splash text is chosen at load (choose_splash)
|
||||
TitleScreen.getHorizontalPosition skip:ui layout of the icon row only
|
||||
|
||||
|
Can't render this file because it contains an unexpected character in line 28 and column 160.
|
Reference in new issue
Block a user