port_map: ChunkBiomeData's extract and size are from_biomes

ChunkBiomeData::from_biomes writes the column's biome containers in section
order into the packet's buffer and documents itself as extractChunkData, and
the buffer grows as it writes, so no size is computed the way
calculateChunkSize computes it. Cite the writer for both rows.
This commit is contained in:
MSedgeMC committed 2026-11-02 14:18:25 +00:00
1 parent 897fbb415e
commit 68044bf45a
1 file changed
+2 -2
+2 -2
View File
@@ -33,8 +33,8 @@ ClientboundBossEventPacket.createUpdateStylePacket inline crates/horizon-client/
ClientboundBossEventPacket.createUpdatePropertiesPacket inline crates/horizon-client/src/game/bossbars.rs::Game::diff_boss_events UpdateProperties when darken, boss music or fog differ
ClientboundBossEventPacket.encodeProperties port crates/horizon-protocol/src/packets/play.rs::boss_flags the three flag bits (darken, music, fog)
ClientboundBossEventPacket.AddOperation.dispatch port crates/horizon-client/src/boss_overlay.rs::BossOverlay::apply
ClientboundChunksBiomesPacket.ChunkBiomeData.calculateChunkSize missing minor: biome-only chunk updates are never sent; no ChunksBiomes packet in ids.rs
ClientboundChunksBiomesPacket.ChunkBiomeData.extractChunkData missing minor: biome-only chunk updates are never sent; no ChunksBiomes packet in ids.rs
ClientboundChunksBiomesPacket.ChunkBiomeData.calculateChunkSize inline crates/horizon-protocol/src/packets/play.rs::ChunkBiomeData::from_biomes the buffer grows as each section's container is written, so no size is computed or prefixed on the wire
ClientboundChunksBiomesPacket.ChunkBiomeData.extractChunkData port crates/horizon-protocol/src/packets/play.rs::ChunkBiomeData::from_biomes the column's sections' biome containers written one after another into the buffer
ClientboundCommandSuggestionsPacket.toSuggestions port crates/horizon-client/src/game/remote.rs::Game::handle_command_suggestions start, length and tooltip become the suggestion range
ClientboundCommandsPacket.validateEntries missing minor: an impossible command tree is not rejected; from_packet skips bad child indexes
ClientboundCommandsPacket.enumerateNodes port crates/horizon-client/src/lan/commands.rs::CommandTree::packet_with breadth-first node ids on the LAN host
1 IdDispatchCodec.decode skip:java codec dispatch; packet_enum! matches the id in packets/mod.rs
33 ClientboundBossEventPacket.createUpdatePropertiesPacket inline crates/horizon-client/src/game/bossbars.rs::Game::diff_boss_events UpdateProperties when darken, boss music or fog differ
34 ClientboundBossEventPacket.encodeProperties port crates/horizon-protocol/src/packets/play.rs::boss_flags the three flag bits (darken, music, fog)
35 ClientboundBossEventPacket.AddOperation.dispatch port crates/horizon-client/src/boss_overlay.rs::BossOverlay::apply
36 ClientboundChunksBiomesPacket.ChunkBiomeData.calculateChunkSize missing inline crates/horizon-protocol/src/packets/play.rs::ChunkBiomeData::from_biomes minor: biome-only chunk updates are never sent; no ChunksBiomes packet in ids.rs the buffer grows as each section's container is written, so no size is computed or prefixed on the wire
37 ClientboundChunksBiomesPacket.ChunkBiomeData.extractChunkData missing port crates/horizon-protocol/src/packets/play.rs::ChunkBiomeData::from_biomes minor: biome-only chunk updates are never sent; no ChunksBiomes packet in ids.rs the column's sections' biome containers written one after another into the buffer
38 ClientboundCommandSuggestionsPacket.toSuggestions port crates/horizon-client/src/game/remote.rs::Game::handle_command_suggestions start, length and tooltip become the suggestion range
39 ClientboundCommandsPacket.validateEntries missing minor: an impossible command tree is not rejected; from_packet skips bad child indexes
40 ClientboundCommandsPacket.enumerateNodes port crates/horizon-client/src/lan/commands.rs::CommandTree::packet_with breadth-first node ids on the LAN host