mirror of
https://github.com/horizon-rust/horizon.git
synced 2026-11-07 11:06:11 -10:00
MSedgeMC
e524b6a114
tools/test_enchanting_parity.py always built a fresh ItemStack for its offer corpus, so EnchantmentMenu.slotsChanged's ItemStack.isEnchantable gate (the enchantable component and an empty minecraft:enchantments) was never exercised, and the oracle skipped the gate entirely. Fixture lines now carry damage and a pre-existing enchantments entry; the oracle applies the gate and the probe builds the same stack. The default corpus is unchanged and --no-components reproduces it. 68992/68992 enchanting cases match.
98 lines
5.5 KiB
Python
98 lines
5.5 KiB
Python
#!/usr/bin/env python3
|
|
"""Compare enchanting-table offers (costs, clues, applied enchantments) with vanilla.
|
|
|
|
Java loads the vanilla data pack's enchantment registry and runs
|
|
EnchantmentHelper as EnchantmentMenu does; Rust runs horizon_client::stations
|
|
on the prepared resources. Every enchantable item and the book are tested
|
|
across seeds and bookshelf counts.
|
|
"""
|
|
import argparse
|
|
import json
|
|
import os
|
|
from pathlib import Path
|
|
import platform
|
|
import random
|
|
import subprocess
|
|
try:
|
|
from . import lab, test_rust_parity as base
|
|
except ImportError:
|
|
import lab
|
|
import test_rust_parity as base
|
|
|
|
|
|
def corpus(items, components=True):
|
|
rng = random.Random(0x454E4348414E54)
|
|
seeds = [-2147483648, -1, 0, 1, 2147483647, *[rng.randrange(-2**31, 2**31) for _ in range(27)]]
|
|
for item, max_damage in items:
|
|
for seed in seeds:
|
|
for bookcases in [0, 1, 4, 8, 12, 15, 30]:
|
|
# `EnchantmentMenu.slotsChanged` only reaches the cost draws for an
|
|
# item `ItemStack.isEnchantable` accepts: the enchantable component
|
|
# and an empty `minecraft:enchantments`. A damaged stack is still
|
|
# enchantable; a stack with one enchantment already on it is not.
|
|
if not components:
|
|
yield f"{seed} {bookcases} {item} 0 -"
|
|
else:
|
|
damage = max(1, max_damage // 2) if max_damage else 0
|
|
yield f"{seed} {bookcases} {item} 0 -"
|
|
yield f"{seed} {bookcases} {item} {damage} -"
|
|
yield f"{seed} {bookcases} {item} 0 minecraft:unbreaking=1"
|
|
yield f"{seed} {bookcases} {item} {damage} minecraft:unbreaking=1"
|
|
|
|
|
|
def main():
|
|
parser = argparse.ArgumentParser(description=__doc__)
|
|
parser.add_argument('--prepare', action='store_true')
|
|
parser.add_argument('--no-components', action='store_true',
|
|
help='only undamaged stacks with no enchantments, as the corpus did before them')
|
|
args = parser.parse_args()
|
|
build = lab.LOCAL / 'agents/stations/enchanting-parity'
|
|
build.mkdir(parents=True, exist_ok=True)
|
|
if args.prepare:
|
|
lab.prepare()
|
|
lock, jars, libraries = base.verify_artifacts()
|
|
resources = lab.RESOURCES
|
|
catalog = json.loads((resources / 'items.json').read_text())
|
|
items = sorted((k, v.get('minecraft:max_damage', 0)) for k, v in catalog.items()
|
|
if 'minecraft:enchantable' in v)
|
|
oracle = lab.ROOT / 'mods/horizon/src/test/java/dev/horizonlab/parity/VanillaEnchantingOracle.java'
|
|
sources = [oracle, Path(__file__), lab.ROOT / 'crates/horizon-client/examples/probe/enchanting_fixture.rs',
|
|
*sorted((lab.ROOT / 'crates/horizon-client/src').glob('*.rs')),
|
|
*sorted((lab.ROOT / 'crates/horizon-client-render/src').glob('*.rs'))]
|
|
tested = base.source_hashes(sources)
|
|
inputs = build / 'inputs.txt'
|
|
fixtures = list(corpus(items, not args.no_components))
|
|
inputs.write_text(''.join(line + '\n' for line in fixtures), encoding='utf-8')
|
|
classes = build / 'classes'
|
|
classes.mkdir(exist_ok=True)
|
|
deps = os.pathsep.join(map(str, libraries))
|
|
|
|
def run(command, name):
|
|
with (build / (name + '.log')).open('w', encoding='utf-8') as log:
|
|
base.run(list(map(str, command)), stdout=log, stderr=subprocess.STDOUT)
|
|
run(['javac', '--release', lock['minecraft']['java_major'], '-proc:none','-sourcepath',str(lab.ROOT/'mods/horizon/src/test/java'), '-cp', str(jars['server']) + os.pathsep + deps, '-d', classes, oracle], 'compile-java')
|
|
run(['cargo', 'build', '--profile', 'fast', '-p', 'horizon-client-lib', '--example', 'client_probe'], 'compile-rust')
|
|
metadata = json.loads(subprocess.check_output(['cargo', 'metadata', '--no-deps', '--format-version', '1'], cwd=lab.ROOT, text=True))
|
|
binary = Path(metadata['target_directory']) / 'fast/examples' / ('client_probe.exe' if os.name=='nt' else 'client_probe')
|
|
run([binary, 'enchanting_fixture',resources, inputs, build / 'rust.txt'], 'rust')
|
|
references = []
|
|
for side in ['server']:
|
|
run(['java', '-Xmx1G', '-cp', os.pathsep.join([str(classes), str(jars[side]), deps]), 'dev.horizonlab.parity.VanillaEnchantingOracle', inputs, build / f'{side}.txt'], side)
|
|
matched = base.compare(build / f'{side}.txt', build / 'rust.txt')
|
|
references.append({'side': side, 'jar_sha256': lab.digest(jars[side], 'sha256'), 'matched_output_lines': matched})
|
|
print(f'{side}: {matched:,} enchanting offer lines match Rust', flush=True)
|
|
print(f'{len(fixtures)}/{len(fixtures)} enchanting cases match', flush=True)
|
|
base.ensure_sources_unchanged(sources, tested)
|
|
report = {'schema': 1, 'minecraft': lock['minecraft']['version'], 'platform': platform.platform(), 'fixtures': len(fixtures),
|
|
'items': len(items), 'references': references, 'sources_sha256': tested,
|
|
'scope': 'EnchantmentHelper.getEnchantmentCost / selectEnchantment on the data-driven enchantment registry and '
|
|
'#in_enchanting_table, EnchantmentMenu clue draws and book removal, for every enchantable item and the book. '
|
|
'Stacks vary damage and a pre-existing minecraft:enchantments entry, so ItemStack.isEnchantable\'s '
|
|
'empty-enchantments gate is compared; other component overrides (an enchantable value) are not.'}
|
|
lab.write_json(build / 'report.json', report)
|
|
print(f'Enchanting parity passed: {build / "report.json"}')
|
|
|
|
|
|
if __name__ == '__main__':
|
|
main()
|