mirror of
https://github.com/icsharpcode/ILSpy.git
synced 2026-10-12 02:15:58 +00:00
Christoph Wille
9125b196d4
SplitTypeParameterCountFromReflectionName allocated the digits after the backtick only to feed int.TryParse and discard them, and the TopLevelTypeName constructor cut the name part twice for generic types (once at the dot, again at the backtick), dropping the first cut. Both run for every generic reflection name parsed, e.g. for typeof-valued attribute arguments and string-switch metadata. The arity is now parsed in place with a digit loop (netstandard2.0 has no span int.TryParse) and each final string is cut exactly once. The digit loop only accepts plain ASCII digits, so suffixes like `+1 that int.TryParse tolerated are now rejected; such names are not legal reflection names. New unit tests pin the parse edge cases. Assisted-by: Claude:claude-fable-5:Claude Code
376 lines
14 KiB
C#
376 lines
14 KiB
C#
// Copyright (c) 2010-2013 AlphaSierraPapa for the SharpDevelop Team
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy of this
|
|
// software and associated documentation files (the "Software"), to deal in the Software
|
|
// without restriction, including without limitation the rights to use, copy, modify, merge,
|
|
// publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons
|
|
// to whom the Software is furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in all copies or
|
|
// substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED,
|
|
// INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR
|
|
// PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE
|
|
// FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
// DEALINGS IN THE SOFTWARE.
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
|
|
using ICSharpCode.Decompiler.TypeSystem;
|
|
using ICSharpCode.Decompiler.TypeSystem.Implementation;
|
|
|
|
using NUnit.Framework;
|
|
|
|
namespace ICSharpCode.Decompiler.Tests.TypeSystem
|
|
{
|
|
[TestFixture]
|
|
public unsafe class ReflectionHelperTests
|
|
{
|
|
ICompilation compilation = new SimpleCompilation(TypeSystemLoaderTests.Mscorlib);
|
|
|
|
void TestFindType(Type type)
|
|
{
|
|
IType t = compilation.FindType(type);
|
|
Assert.That(t, Is.Not.Null, type.FullName);
|
|
Assert.That(t.ReflectionName, Is.EqualTo(type.FullName));
|
|
}
|
|
|
|
[Test]
|
|
public void TestGetInnerClass()
|
|
{
|
|
TestFindType(typeof(Environment.SpecialFolder));
|
|
}
|
|
|
|
[Test]
|
|
public void TestGetGenericClass1()
|
|
{
|
|
TestFindType(typeof(Action<>));
|
|
}
|
|
|
|
[Test]
|
|
public void TestGetGenericClass2()
|
|
{
|
|
TestFindType(typeof(Action<,>));
|
|
}
|
|
|
|
[Test]
|
|
public void TestGetInnerClassInGenericClass1()
|
|
{
|
|
TestFindType(typeof(Dictionary<,>.ValueCollection));
|
|
}
|
|
|
|
[Test]
|
|
public void TestGetInnerClassInGenericClass2()
|
|
{
|
|
TestFindType(typeof(Dictionary<,>.ValueCollection.Enumerator));
|
|
}
|
|
|
|
[Test]
|
|
public void TestFindTypeReflectionNameInnerClass()
|
|
{
|
|
Assert.That(compilation.FindType(typeof(Environment.SpecialFolder)).ReflectionName, Is.EqualTo("System.Environment+SpecialFolder"));
|
|
}
|
|
|
|
[Test]
|
|
public void TestFindTypeReflectionNameUnboundGenericClass()
|
|
{
|
|
Assert.That(compilation.FindType(typeof(Action<>)).ReflectionName, Is.EqualTo("System.Action`1"));
|
|
Assert.That(compilation.FindType(typeof(Action<,>)).ReflectionName, Is.EqualTo("System.Action`2"));
|
|
}
|
|
|
|
[Test]
|
|
public void TestFindTypeReflectionNameBoundGenericClass()
|
|
{
|
|
Assert.That(compilation.FindType(typeof(Action<string>)).ReflectionName, Is.EqualTo("System.Action`1[[System.String]]"));
|
|
Assert.That(compilation.FindType(typeof(Action<int, short>)).ReflectionName, Is.EqualTo("System.Action`2[[System.Int32],[System.Int16]]"));
|
|
}
|
|
|
|
[Test]
|
|
public void TestFindTypeReflectionNameNullableType()
|
|
{
|
|
Assert.That(compilation.FindType(typeof(int?)).ReflectionName, Is.EqualTo("System.Nullable`1[[System.Int32]]"));
|
|
}
|
|
|
|
[Test]
|
|
public void TestFindTypeReflectionNameInnerClassInUnboundGenericType()
|
|
{
|
|
Assert.That(compilation.FindType(typeof(Dictionary<,>.ValueCollection)).ReflectionName, Is.EqualTo("System.Collections.Generic.Dictionary`2+ValueCollection"));
|
|
}
|
|
|
|
[Test]
|
|
public void TestFindTypeReflectionNameInnerClassInBoundGenericType()
|
|
{
|
|
Assert.That(compilation.FindType(typeof(Dictionary<string, int>.KeyCollection)).ReflectionName, Is.EqualTo("System.Collections.Generic.Dictionary`2+KeyCollection[[System.String],[System.Int32]]"));
|
|
}
|
|
|
|
[Test]
|
|
public void TestFindTypeReflectionNameArrayType()
|
|
{
|
|
Assert.That(compilation.FindType(typeof(int[])).ReflectionName, Is.EqualTo(typeof(int[]).FullName));
|
|
}
|
|
|
|
[Test]
|
|
public void TestFindTypeReflectionNameMultidimensionalArrayType()
|
|
{
|
|
Assert.That(compilation.FindType(typeof(int[,])).ReflectionName, Is.EqualTo(typeof(int[,]).FullName));
|
|
}
|
|
|
|
[Test]
|
|
public void TestFindTypeReflectionNameJaggedMultidimensionalArrayType()
|
|
{
|
|
Assert.That(compilation.FindType(typeof(int[,][,,])).ReflectionName, Is.EqualTo(typeof(int[,][,,]).FullName));
|
|
}
|
|
|
|
[Test]
|
|
public void TestFindTypeReflectionNamePointerType()
|
|
{
|
|
Assert.That(compilation.FindType(typeof(int*)).ReflectionName, Is.EqualTo(typeof(int*).FullName));
|
|
}
|
|
|
|
[Test]
|
|
public void TestFindTypeReflectionNameByReferenceType()
|
|
{
|
|
Assert.That(compilation.FindType(typeof(int).MakeByRefType()).ReflectionName, Is.EqualTo(typeof(int).MakeByRefType().FullName));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseReflectionName()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.That(ReflectionHelper.ParseReflectionName("System.Int32", context).ReflectionName, Is.EqualTo("System.Int32"));
|
|
Assert.That(ReflectionHelper.ParseReflectionName("System.Int32&", context).ReflectionName, Is.EqualTo("System.Int32&"));
|
|
Assert.That(ReflectionHelper.ParseReflectionName("System.Int32*&", context).ReflectionName, Is.EqualTo("System.Int32*&"));
|
|
Assert.That(ReflectionHelper.ParseReflectionName(typeof(int).AssemblyQualifiedName, context).ReflectionName, Is.EqualTo("System.Int32"));
|
|
Assert.That(ReflectionHelper.ParseReflectionName("System.Action`1[[System.String]]", context).ReflectionName, Is.EqualTo("System.Action`1[[System.String]]"));
|
|
Assert.That(ReflectionHelper.ParseReflectionName("System.Action`1[[System.String, mscorlib]]", context).ReflectionName, Is.EqualTo("System.Action`1[[System.String]]"));
|
|
Assert.That(ReflectionHelper.ParseReflectionName(typeof(int[,][,,]).AssemblyQualifiedName, context).ReflectionName, Is.EqualTo("System.Int32[,,][,]"));
|
|
Assert.That(ReflectionHelper.ParseReflectionName("System.Environment+SpecialFolder", context).ReflectionName, Is.EqualTo("System.Environment+SpecialFolder"));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseOpenGenericReflectionName()
|
|
{
|
|
IType converter = ReflectionHelper.ParseReflectionName("System.Converter`2[[`0],[``0]]", new SimpleTypeResolveContext(compilation.MainModule));
|
|
Assert.That(converter.ReflectionName, Is.EqualTo("System.Converter`2[[`0],[``0]]"));
|
|
IMethod convertAll = compilation.FindType(typeof(List<>)).GetMethods(m => m.Name == "ConvertAll").Single();
|
|
IType converter2 = ReflectionHelper.ParseReflectionName("System.Converter`2[[`0],[``0]]", new SimpleTypeResolveContext(convertAll));
|
|
Assert.That(converter2.ReflectionName, Is.EqualTo("System.Converter`2[[`0],[``0]]"));
|
|
}
|
|
|
|
[Test]
|
|
public void ArrayOfTypeParameter()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.That(ReflectionHelper.ParseReflectionName("`0[,]", context).ReflectionName, Is.EqualTo("`0[,]"));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseNullReflectionName()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.Throws<ArgumentNullException>(() => ReflectionHelper.ParseReflectionName(null, context));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName1()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.Throws<ReflectionNameParseException>(() => ReflectionHelper.ParseReflectionName(string.Empty, context));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName2()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.That(ReflectionHelper.ParseReflectionName("`", context).ReflectionName, Is.EqualTo("`"));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName3()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.That(ReflectionHelper.ParseReflectionName("``", context).ReflectionName, Is.EqualTo("``"));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName4()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.That(ReflectionHelper.ParseReflectionName("System.Action`A", context).ReflectionName, Is.EqualTo("System.Action`A"));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName5()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.Throws<ReflectionNameParseException>(() => ReflectionHelper.ParseReflectionName("System.Environment+", context));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName5b()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.That(ReflectionHelper.ParseReflectionName("System.Environment+`", context).ReflectionName, Is.EqualTo("System.Environment+`"));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName6()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.Throws<ReflectionNameParseException>(() => ReflectionHelper.ParseReflectionName("System.Int32[", context));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName7()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.That(ReflectionHelper.ParseReflectionName("System.Int32[`]", context).ReflectionName, Is.EqualTo("System.Int32"));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName8()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.Throws<ReflectionNameParseException>(() => ReflectionHelper.ParseReflectionName("System.Int32[,", context));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName9()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.Throws<ReflectionNameParseException>(() => ReflectionHelper.ParseReflectionName("System.Int32]", context));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName10()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.Throws<ReflectionNameParseException>(() => ReflectionHelper.ParseReflectionName("System.Int32*a", context));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName11()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.Throws<ReflectionNameParseException>(() => ReflectionHelper.ParseReflectionName("System.Action`1[[]]", context));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName12()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.Throws<ReflectionNameParseException>(() => ReflectionHelper.ParseReflectionName("System.Action`1[[System.Int32]a]", context));
|
|
}
|
|
|
|
[Test]
|
|
public void SplitTypeParameterCountFromName()
|
|
{
|
|
Assert.That(ReflectionHelper.SplitTypeParameterCountFromReflectionName("List`1", out int tpc), Is.EqualTo("List"));
|
|
Assert.That(tpc, Is.EqualTo(1));
|
|
Assert.That(ReflectionHelper.SplitTypeParameterCountFromReflectionName("Dictionary`2", out tpc), Is.EqualTo("Dictionary"));
|
|
Assert.That(tpc, Is.EqualTo(2));
|
|
Assert.That(ReflectionHelper.SplitTypeParameterCountFromReflectionName("Foo`12", out tpc), Is.EqualTo("Foo"));
|
|
Assert.That(tpc, Is.EqualTo(12));
|
|
}
|
|
|
|
[Test]
|
|
public void SplitTypeParameterCountWithoutBacktick()
|
|
{
|
|
Assert.That(ReflectionHelper.SplitTypeParameterCountFromReflectionName("String", out int tpc), Is.EqualTo("String"));
|
|
Assert.That(tpc, Is.EqualTo(0));
|
|
}
|
|
|
|
[Test]
|
|
public void SplitTypeParameterCountUsesTheLastBacktick()
|
|
{
|
|
Assert.That(ReflectionHelper.SplitTypeParameterCountFromReflectionName("Outer`1+Inner`2", out int tpc), Is.EqualTo("Outer`1+Inner"));
|
|
Assert.That(tpc, Is.EqualTo(2));
|
|
}
|
|
|
|
[Test]
|
|
public void SplitTypeParameterCountKeepsNameWhenSuffixIsNotAPlainNumber()
|
|
{
|
|
Assert.That(ReflectionHelper.SplitTypeParameterCountFromReflectionName("Foo`", out int tpc), Is.EqualTo("Foo`"));
|
|
Assert.That(tpc, Is.EqualTo(0));
|
|
Assert.That(ReflectionHelper.SplitTypeParameterCountFromReflectionName("Foo`x", out tpc), Is.EqualTo("Foo`x"));
|
|
Assert.That(tpc, Is.EqualTo(0));
|
|
// Only plain digits form an arity: a signed suffix is not a legal reflection name.
|
|
Assert.That(ReflectionHelper.SplitTypeParameterCountFromReflectionName("Foo`+1", out tpc), Is.EqualTo("Foo`+1"));
|
|
Assert.That(tpc, Is.EqualTo(0));
|
|
// An arity beyond int.MaxValue is rejected, not truncated.
|
|
Assert.That(ReflectionHelper.SplitTypeParameterCountFromReflectionName("Foo`2147483648", out tpc), Is.EqualTo("Foo`2147483648"));
|
|
Assert.That(tpc, Is.EqualTo(0));
|
|
Assert.That(ReflectionHelper.SplitTypeParameterCountFromReflectionName("Foo`99999999999999999999", out tpc), Is.EqualTo("Foo`99999999999999999999"));
|
|
Assert.That(tpc, Is.EqualTo(0));
|
|
}
|
|
|
|
[Test]
|
|
public void TopLevelTypeNameParsesNamespaceNameAndArity()
|
|
{
|
|
var t = new TopLevelTypeName("System.Collections.Generic.List`1");
|
|
Assert.That(t.Namespace, Is.EqualTo("System.Collections.Generic"));
|
|
Assert.That(t.Name, Is.EqualTo("List"));
|
|
Assert.That(t.TypeParameterCount, Is.EqualTo(1));
|
|
}
|
|
|
|
[Test]
|
|
public void TopLevelTypeNameWithoutNamespace()
|
|
{
|
|
var t = new TopLevelTypeName("List`1");
|
|
Assert.That(t.Namespace, Is.EqualTo(string.Empty));
|
|
Assert.That(t.Name, Is.EqualTo("List"));
|
|
Assert.That(t.TypeParameterCount, Is.EqualTo(1));
|
|
}
|
|
|
|
[Test]
|
|
public void TopLevelTypeNameWithoutArity()
|
|
{
|
|
var t = new TopLevelTypeName("System.String");
|
|
Assert.That(t.Namespace, Is.EqualTo("System"));
|
|
Assert.That(t.Name, Is.EqualTo("String"));
|
|
Assert.That(t.TypeParameterCount, Is.EqualTo(0));
|
|
}
|
|
|
|
[Test]
|
|
public void TopLevelTypeNameIgnoresBacktickInsideTheNamespace()
|
|
{
|
|
var t = new TopLevelTypeName("A`1.B");
|
|
Assert.That(t.Namespace, Is.EqualTo("A`1"));
|
|
Assert.That(t.Name, Is.EqualTo("B"));
|
|
Assert.That(t.TypeParameterCount, Is.EqualTo(0));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName13()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.Throws<ReflectionNameParseException>(() => ReflectionHelper.ParseReflectionName("System.Action`1[[System.Int32],]", context));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName14()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.Throws<ReflectionNameParseException>(() => ReflectionHelper.ParseReflectionName("System.Action`1[[System.Int32]", context));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName15()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.Throws<ReflectionNameParseException>(() => ReflectionHelper.ParseReflectionName("System.Action`1[[System.Int32", context));
|
|
}
|
|
|
|
[Test]
|
|
public void ParseInvalidReflectionName16()
|
|
{
|
|
var context = new SimpleTypeResolveContext(compilation.MainModule);
|
|
Assert.Throws<ReflectionNameParseException>(() => ReflectionHelper.ParseReflectionName("System.Action`1[[System.Int32],[System.String", context));
|
|
}
|
|
}
|
|
}
|