iv-org/videojs-quality-selector
1
0
Fork 0
mirror of https://github.com/iv-org/videojs-quality-selector.git synced 2024-11-26 23:20:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #48 from yokuze/fix_empty_selector_menu_47

Browse Source 
fix: Update menu when sources are set after player is ready (#47)
This commit is contained in:
Jeremy Thomerson 2019-11-20 13:23:34 -05:00 committed by GitHub
commit 303d85532a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/js/components/QualitySelector.js
View File

@ -34,6 +34,11 @@ module.exports = function(videojs) {
});
}.bind(this));
// Update the list of menu items only when the list of sources change
player.on(events.PLAYER_SOURCES_CHANGED, function() {
this.update();
}.bind(this));
player.on(events.QUALITY_SELECTED, function(event, newSource) {
// Update the selected source with the source that was actually selected
this.setSelectedSource(newSource);

1
src/js/events.js
View File

@ -4,5 +4,6 @@ module.exports = {
QUALITY_REQUESTED: 'qualityRequested',
QUALITY_SELECTED: 'qualitySelected',
PLAYER_SOURCES_CHANGED: 'playerSourcesChanged',
};

5
src/js/middleware/SourceInterceptor.js
View File

@ -17,6 +17,11 @@ module.exports = function(videojs) {
player._qualitySelectorSafeSeek.onPlayerSourcesChange();
}
if (!_.isEqual(sources, player._qualitySelectorPreviousSources)) {
player.trigger(events.PLAYER_SOURCES_CHANGED, sources);
player._qualitySelectorPreviousSources = sources;
}
// There are generally two source options, the one that videojs
// auto-selects and the one that a "user" of this plugin has
// supplied via the `selected` property. `selected` can come from