jellyfin/jellyfin-plugin-reports
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-plugin-reports.git synced 2024-11-26 23:20:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Apply suggestions from @crobibero code review

Browse Source 
Co-authored-by: Cody Robibero <cody@robibe.ro>
This commit is contained in:
mwildgoose 2022-08-19 17:38:31 +01:00 committed by GitHub
parent 582c301597
commit d72eda9c3f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Jellyfin.Plugin.Reports/Api/Data/ReportExport.cs
View File

@ -153,7 +153,7 @@ namespace Jellyfin.Plugin.Reports.Api.Data
nextRow += rows.Count();
}
IXLWorkbook workbook = new XLWorkbook(XLEventTracking.Disabled);
using IXLWorkbook workbook = new XLWorkbook(XLEventTracking.Disabled);
IXLWorksheet worksheet = workbook.Worksheets.Add("ReportExport");
// Add report rows
@ -198,7 +198,6 @@ namespace Jellyfin.Plugin.Reports.Api.Data
// Save workbook to stream and return
MemoryStream memoryStream = new MemoryStream();
workbook.SaveAs(memoryStream);
workbook.Dispose();
memoryStream.Position = 0;
return memoryStream;
}

5
build.yaml
View File

@ -14,12 +14,7 @@ artifacts:
- "ClosedXML.dll"
- "DocumentFormat.OpenXml.dll"
- "ExcelNumberFormat.dll"
- "Microsoft.Win32.SystemEvents.dll"
- "System.Drawing.Common.dll"
- "System.IO.Packaging.dll"
- "runtimes/unix/lib/netcoreapp2.0/System.Drawing.Common.dll"
- "runtimes/win/lib/netcoreapp2.0/Microsoft.Win32.SystemEvents.dll"
- "runtimes/win/lib/netcoreapp2.0/System.Drawing.Common.dll"
changelog: |2-
### Bug Fixes ###
- Fix CSV Export Format (#73) @mwildgoose