mirror of
https://github.com/jellyfin/jellyfin-plugin-webhook.git
synced 2024-12-03 11:41:25 +00:00
Update ruleset, fix new warnings
This commit is contained in:
Cody Robibero
parent
4faecb9219
commit
472b13d7c4
@ -80,7 +80,7 @@ namespace Jellyfin.Plugin.Webhook.Destinations.Discord
|
|||||||
|
|
||||||
private static int FormatColorCode(string hexCode)
|
private static int FormatColorCode(string hexCode)
|
||||||
{
|
{
|
||||||
return int.Parse(hexCode.Substring(1, 6), NumberStyles.HexNumber, CultureInfo.InvariantCulture);
|
return int.Parse(hexCode[1..6], NumberStyles.HexNumber, CultureInfo.InvariantCulture);
|
||||||
}
|
}
|
||||||
|
|
||||||
private static string GetMentionType(DiscordMentionType mentionType)
|
private static string GetMentionType(DiscordMentionType mentionType)
|
||||||
|
|||||||
@ -1,4 +1,5 @@
|
|||||||
using System;
|
using System;
|
||||||
|
using System.Globalization;
|
||||||
using HandlebarsDotNet;
|
using HandlebarsDotNet;
|
||||||
|
|
||||||
namespace Jellyfin.Plugin.Webhook.Helpers
|
namespace Jellyfin.Plugin.Webhook.Helpers
|
||||||
@ -82,7 +83,7 @@ namespace Jellyfin.Plugin.Webhook.Helpers
|
|||||||
// UndefinedBindingResult means the parameter was a part of the provided dataset.
|
// UndefinedBindingResult means the parameter was a part of the provided dataset.
|
||||||
return input is UndefinedBindingResult or null
|
return input is UndefinedBindingResult or null
|
||||||
? null
|
? null
|
||||||
: Convert.ToString(input);
|
: Convert.ToString(input, CultureInfo.InvariantCulture);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
180
jellyfin.ruleset
180
jellyfin.ruleset
@ -1,82 +1,108 @@
|
|||||||
<?xml version="1.0" encoding="utf-8"?>
|
<?xml version="1.0" encoding="utf-8"?>
|
||||||
<RuleSet Name="Rules for Jellyfin" Description="Code analysis rules for Jellyfin" ToolsVersion="14.0">
|
<RuleSet Name="Rules for Jellyfin.Server" Description="Code analysis rules for Jellyfin.Server.csproj" ToolsVersion="14.0">
|
||||||
<Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
|
<Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
|
||||||
<!-- disable warning SA1202: 'public' members must come before 'private' members -->
|
<!-- disable warning SA1009: Closing parenthesis should be followed by a space. -->
|
||||||
<Rule Id="SA1202" Action="Info" />
|
<Rule Id="SA1009" Action="None" />
|
||||||
<!-- disable warning SA1204: Static members must appear before non-static members -->
|
<!-- disable warning SA1011: Closing square bracket should be followed by a space. -->
|
||||||
<Rule Id="SA1204" Action="Info" />
|
<Rule Id="SA1011" Action="None" />
|
||||||
<!-- disable warning SA1404: Code analysis suppression should have justification -->
|
<!-- disable warning SA1101: Prefix local calls with 'this.' -->
|
||||||
<Rule Id="SA1404" Action="Info" />
|
<Rule Id="SA1101" Action="None" />
|
||||||
|
<!-- disable warning SA1108: Block statements should not contain embedded comments -->
|
||||||
|
<Rule Id="SA1108" Action="None" />
|
||||||
|
<!-- disable warning SA1118: Parameter must not span multiple lines. -->
|
||||||
|
<Rule Id="SA1118" Action="None" />
|
||||||
|
<!-- disable warning SA1128:: Put constructor initializers on their own line -->
|
||||||
|
<Rule Id="SA1128" Action="None" />
|
||||||
|
<!-- disable warning SA1130: Use lambda syntax -->
|
||||||
|
<Rule Id="SA1130" Action="None" />
|
||||||
|
<!-- disable warning SA1200: 'using' directive must appear within a namespace declaration -->
|
||||||
|
<Rule Id="SA1200" Action="None" />
|
||||||
|
<!-- disable warning SA1202: 'public' members must come before 'private' members -->
|
||||||
|
<Rule Id="SA1202" Action="None" />
|
||||||
|
<!-- disable warning SA1204: Static members must appear before non-static members -->
|
||||||
|
<Rule Id="SA1204" Action="None" />
|
||||||
|
<!-- disable warning SA1309: Fields must not begin with an underscore -->
|
||||||
|
<Rule Id="SA1309" Action="None" />
|
||||||
|
<!-- disable warning SA1413: Use trailing comma in multi-line initializers -->
|
||||||
|
<Rule Id="SA1413" Action="None" />
|
||||||
|
<!-- disable warning SA1512: Single-line comments must not be followed by blank line -->
|
||||||
|
<Rule Id="SA1512" Action="None" />
|
||||||
|
<!-- disable warning SA1515: Single-line comment should be preceded by blank line -->
|
||||||
|
<Rule Id="SA1515" Action="None" />
|
||||||
|
<!-- disable warning SA1600: Elements should be documented -->
|
||||||
|
<Rule Id="SA1600" Action="None" />
|
||||||
|
<!-- disable warning SA1602: Enumeration items should be documented -->
|
||||||
|
<Rule Id="SA1602" Action="None" />
|
||||||
|
<!-- disable warning SA1633: The file header is missing or not located at the top of the file -->
|
||||||
|
<Rule Id="SA1633" Action="None" />
|
||||||
|
</Rules>
|
||||||
|
|
||||||
<!-- disable warning SA1009: Closing parenthesis should be followed by a space. -->
|
<Rules AnalyzerId="Microsoft.CodeAnalysis.NetAnalyzers" RuleNamespace="Microsoft.Design">
|
||||||
<Rule Id="SA1009" Action="None" />
|
<!-- error on CA1305: Specify IFormatProvider -->
|
||||||
<!-- disable warning SA1011: Closing square bracket should be followed by a space. -->
|
<Rule Id="CA1305" Action="Error" />
|
||||||
<Rule Id="SA1011" Action="None" />
|
<!-- error on CA1725: Parameter names should match base declaration -->
|
||||||
<!-- disable warning SA1101: Prefix local calls with 'this.' -->
|
<Rule Id="CA1725" Action="Error" />
|
||||||
<Rule Id="SA1101" Action="None" />
|
<!-- error on CA1725: Call async methods when in an async method -->
|
||||||
<!-- disable warning SA1108: Block statements should not contain embedded comments -->
|
<Rule Id="CA1727" Action="Error" />
|
||||||
<Rule Id="SA1108" Action="None" />
|
<!-- error on CA1843: Do not use 'WaitAll' with a single task -->
|
||||||
<!-- disable warning SA1128:: Put constructor initializers on their own line -->
|
<Rule Id="CA1843" Action="Error" />
|
||||||
<Rule Id="SA1128" Action="None" />
|
<!-- error on CA2016: Forward the CancellationToken parameter to methods that take one
|
||||||
<!-- disable warning SA1130: Use lambda syntax -->
|
or pass in 'CancellationToken.None' explicitly to indicate intentionally not propagating the token -->
|
||||||
<Rule Id="SA1130" Action="None" />
|
<Rule Id="CA2016" Action="Error" />
|
||||||
<!-- disable warning SA1200: 'using' directive must appear within a namespace declaration -->
|
<!-- error on CA2254: Template should be a static expression -->
|
||||||
<Rule Id="SA1200" Action="None" />
|
<Rule Id="CA2254" Action="Error" />
|
||||||
<!-- disable warning SA1309: Fields must not begin with an underscore -->
|
|
||||||
<Rule Id="SA1309" Action="None" />
|
|
||||||
<!-- disable warning SA1413: Use trailing comma in multi-line initializers -->
|
|
||||||
<Rule Id="SA1413" Action="None" />
|
|
||||||
<!-- disable warning SA1512: Single-line comments must not be followed by blank line -->
|
|
||||||
<Rule Id="SA1512" Action="None" />
|
|
||||||
<!-- disable warning SA1515: Single-line comment should be preceded by blank line -->
|
|
||||||
<Rule Id="SA1515" Action="None" />
|
|
||||||
<!-- disable warning SA1600: Elements should be documented -->
|
|
||||||
<Rule Id="SA1600" Action="None" />
|
|
||||||
<!-- disable warning SA1602: Enumeration items should be documented -->
|
|
||||||
<Rule Id="SA1602" Action="None" />
|
|
||||||
<!-- disable warning SA1633: The file header is missing or not located at the top of the file -->
|
|
||||||
<Rule Id="SA1633" Action="None" />
|
|
||||||
</Rules>
|
|
||||||
|
|
||||||
<Rules AnalyzerId="Microsoft.CodeAnalysis.NetAnalyzers" RuleNamespace="Microsoft.Design">
|
<!-- disable warning CA1014: Mark assemblies with CLSCompliantAttribute -->
|
||||||
<!-- error on CA2016: Forward the CancellationToken parameter to methods that take one
|
<Rule Id="CA1014" Action="Info" />
|
||||||
or pass in 'CancellationToken.None' explicitly to indicate intentionally not propagating the token -->
|
<!-- disable warning CA1024: Use properties where appropriate -->
|
||||||
<Rule Id="CA2016" Action="Error" />
|
<Rule Id="CA1024" Action="Info" />
|
||||||
|
<!-- disable warning CA1031: Do not catch general exception types -->
|
||||||
|
<Rule Id="CA1031" Action="Info" />
|
||||||
|
<!-- disable warning CA1032: Implement standard exception constructors -->
|
||||||
|
<Rule Id="CA1032" Action="Info" />
|
||||||
|
<!-- disable warning CA1040: Avoid empty interfaces -->
|
||||||
|
<Rule Id="CA1040" Action="Info" />
|
||||||
|
<!-- disable warning CA1062: Validate arguments of public methods -->
|
||||||
|
<Rule Id="CA1062" Action="Info" />
|
||||||
|
<!-- TODO: enable when false positives are fixed -->
|
||||||
|
<!-- disable warning CA1508: Avoid dead conditional code -->
|
||||||
|
<Rule Id="CA1508" Action="Info" />
|
||||||
|
<!-- disable warning CA1716: Identifiers should not match keywords -->
|
||||||
|
<Rule Id="CA1716" Action="Info" />
|
||||||
|
<!-- disable warning CA1720: Identifiers should not contain type names -->
|
||||||
|
<Rule Id="CA1720" Action="Info" />
|
||||||
|
<!-- disable warning CA1724: Type names should not match namespaces -->
|
||||||
|
<Rule Id="CA1724" Action="Info" />
|
||||||
|
<!-- disable warning CA1805: Do not initialize unnecessarily -->
|
||||||
|
<Rule Id="CA1805" Action="Info" />
|
||||||
|
<!-- disable warning CA1812: internal class that is apparently never instantiated.
|
||||||
|
If so, remove the code from the assembly.
|
||||||
|
If this class is intended to contain only static members, make it static -->
|
||||||
|
<Rule Id="CA1812" Action="Info" />
|
||||||
|
<!-- disable warning CA1822: Member does not access instance data and can be marked as static -->
|
||||||
|
<Rule Id="CA1822" Action="Info" />
|
||||||
|
<!-- disable warning CA2000: Dispose objects before losing scope -->
|
||||||
|
<Rule Id="CA2000" Action="Info" />
|
||||||
|
<!-- disable warning CA2253: Named placeholders should not be numeric values -->
|
||||||
|
<Rule Id="CA2253" Action="Info" />
|
||||||
|
<!-- disable warning CA5394: Do not use insecure randomness -->
|
||||||
|
<Rule Id="CA5394" Action="Info" />
|
||||||
|
|
||||||
<!-- disable warning CA1031: Do not catch general exception types -->
|
<!-- disable warning CA1054: Change the type of parameter url from string to System.Uri -->
|
||||||
<Rule Id="CA1031" Action="Info" />
|
<Rule Id="CA1054" Action="None" />
|
||||||
<!-- disable warning CA1032: Implement standard exception constructors -->
|
<!-- disable warning CA1055: URI return values should not be strings -->
|
||||||
<Rule Id="CA1032" Action="Info" />
|
<Rule Id="CA1055" Action="None" />
|
||||||
<!-- disable warning CA1062: Validate arguments of public methods -->
|
<!-- disable warning CA1056: URI properties should not be strings -->
|
||||||
<Rule Id="CA1062" Action="Info" />
|
<Rule Id="CA1056" Action="None" />
|
||||||
<!-- disable warning CA1716: Identifiers should not match keywords -->
|
<!-- disable warning CA1303: Do not pass literals as localized parameters -->
|
||||||
<Rule Id="CA1716" Action="Info" />
|
<Rule Id="CA1303" Action="None" />
|
||||||
<!-- disable warning CA1720: Identifiers should not contain type names -->
|
<!-- disable warning CA1308: Normalize strings to uppercase -->
|
||||||
<Rule Id="CA1720" Action="Info" />
|
<Rule Id="CA1308" Action="None" />
|
||||||
<!-- disable warning CA1805: Do not initialize unnecessarily -->
|
<!-- disable warning CA1848: Use the LoggerMessage delegates -->
|
||||||
<Rule Id="CA1805" Action="Info" />
|
<Rule Id="CA1848" Action="None" />
|
||||||
<!-- disable warning CA1812: internal class that is apparently never instantiated.
|
<!-- disable warning CA2101: Specify marshaling for P/Invoke string arguments -->
|
||||||
If so, remove the code from the assembly.
|
<Rule Id="CA2101" Action="None" />
|
||||||
If this class is intended to contain only static members, make it static -->
|
<!-- disable warning CA2234: Pass System.Uri objects instead of strings -->
|
||||||
<Rule Id="CA1812" Action="Info" />
|
<Rule Id="CA2234" Action="None" />
|
||||||
<!-- disable warning CA1822: Member does not access instance data and can be marked as static -->
|
</Rules>
|
||||||
<Rule Id="CA1822" Action="Info" />
|
|
||||||
<!-- disable warning CA2000: Dispose objects before losing scope -->
|
|
||||||
<Rule Id="CA2000" Action="Info" />
|
|
||||||
<!-- disable warning CA5394: Do not use insecure randomness -->
|
|
||||||
<Rule Id="CA5394" Action="Info" />
|
|
||||||
|
|
||||||
<!-- disable warning CA1014: Mark assemblies with CLSCompliantAttribute -->
|
|
||||||
<Rule Id="CA1014" Action="Info" />
|
|
||||||
<!-- disable warning CA1054: Change the type of parameter url from string to System.Uri -->
|
|
||||||
<Rule Id="CA1054" Action="None" />
|
|
||||||
<!-- disable warning CA1055: URI return values should not be strings -->
|
|
||||||
<Rule Id="CA1055" Action="None" />
|
|
||||||
<!-- disable warning CA1056: URI properties should not be strings -->
|
|
||||||
<Rule Id="CA1056" Action="None" />
|
|
||||||
<!-- disable warning CA1303: Do not pass literals as localized parameters -->
|
|
||||||
<Rule Id="CA1303" Action="None" />
|
|
||||||
<!-- disable warning CA1308: Normalize strings to uppercase -->
|
|
||||||
<Rule Id="CA1308" Action="None" />
|
|
||||||
</Rules>
|
|
||||||
</RuleSet>
|
</RuleSet>
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user